[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

efriedma added a comment. The patch is currently impossible to read; please don't clang-format the whole file. There's a script clang-format-diff.py that can format just the parts of a file you change, if you need it. As noted in the discussion on the bug report, needs a testcase. Repository

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added a comment. Actually, while you're here, can you please remove all calls to `SemaFeatureCheck()` that test builtins which are only available on a specific CPU? The Sema checking happens too early before the target info is populated, which does not allow for a very common idiom whe

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/76177/step_9.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/ https://reviews.llvm.org/D146

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

majnemer created this revision. majnemer added a reviewer: reedwm. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagains

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:143 +namespace llvm { +void RISCVMarchHelp() { + errs() << "All available -march extensions for RISC-V\n\n"; `void llvm::RISCVMarchHelp` and remove the `namespace llvm {` Reposit

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/print-supported-marchs.c:17 +// CHECK-RISCV:i 2.0 +// CHECK-RISCV:e 1.9 +//

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:141 + }; + S foo(); + )cc"; ymandel wrote: > gribozavr2 wrote: > > Is `foo()` used for anything in this test? > not that I can see. looks le

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:197 + if (TargetStr.find("riscv") == std::string::npos) { +llvm::errs() << "The -march=help only supports for RISCV target.\n"; +return 1; MaskRay wrote: > The check should b

[clang] cd11f55 - [clang][dataflow] Fix indentation in a test

Author: Dmitri Gribenko Date: 2023-03-20T18:34:16+01:00 New Revision: cd11f55a0c6d8524f9ac494d26514d4d72d83435 URL: https://github.com/llvm/llvm-project/commit/cd11f55a0c6d8524f9ac494d26514d4d72d83435 DIFF: https://github.com/llvm/llvm-project/commit/cd11f55a0c6d8524f9ac494d26514d4d72d83435.dif

[clang] 72073fc - [Serialization] Place command line defines in the correct file

Author: John Brawn Date: 2023-03-20T17:36:01Z New Revision: 72073fc95cd4793a853925ddc8cc3fb2118808a5 URL: https://github.com/llvm/llvm-project/commit/72073fc95cd4793a853925ddc8cc3fb2118808a5 DIFF: https://github.com/llvm/llvm-project/commit/72073fc95cd4793a853925ddc8cc3fb2118808a5.diff LOG: [S

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was automatically updated to reflect the committed changes. Closed by commit rG72073fc95cd4: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D144651?vs=502977&id=506642#toc Repository: rG

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:720 +const CXXRecordDecl *RD, const ValueDecl *VD) { + MSInheritanceModel IM = RD->getMSInheritanceModel(); + // ::= It's not obvious to me why the inheritance model is relevant

[PATCH] D146376: Update static_assert message for redundant cases

cjdb added a comment. Thanks for working on this, it's much appreciated! :4:1: error: static assertion failed due to requirement 'is_gitlab' static_assert(is_gitlab and is_weekend); ^ ~ The arrow seems a bit off here. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 60b117a - [PowerPC] Adding test coverage for vector compatibility warning

Author: Maryam Moghadas Date: 2023-03-20T12:48:45-05:00 New Revision: 60b117aa81493e4f91df11ec2322957ec7800f55 URL: https://github.com/llvm/llvm-project/commit/60b117aa81493e4f91df11ec2322957ec7800f55 DIFF: https://github.com/llvm/llvm-project/commit/60b117aa81493e4f91df11ec2322957ec7800f55.dif

[PATCH] D144611: [PowerPC] Adding test coverage for vector compatibility warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG60b117aa8149: [PowerPC] Adding test coverage for vector compatibility warning (authored by maryammo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144611/ne

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. as discussed offline, this feels a little fishy and we should probably try and not put nulls into the parameter lists at all (and mark the functiontype as invalid instead), but since i don

[clang] 5259da7 - [AIX][Clang] Respect -r when invoking the linker

Author: Michael Francis Date: 2023-03-20T17:56:39Z New Revision: 5259da75b9352592cd12fc2c6b6b875567989867 URL: https://github.com/llvm/llvm-project/commit/5259da75b9352592cd12fc2c6b6b875567989867 DIFF: https://github.com/llvm/llvm-project/commit/5259da75b9352592cd12fc2c6b6b875567989867.diff LO

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG5259da75b935: [AIX][Clang] Respect -r when invoking the linker (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://revi

[clang-tools-extra] fb3f6a9 - Revert "[clangd] Fix AddUsing in the face of typo-correction"

Author: Kadir Cetinkaya Date: 2023-03-20T18:57:53+01:00 New Revision: fb3f6a95393f33bc8d8550a5ac62c18e488a9b6f URL: https://github.com/llvm/llvm-project/commit/fb3f6a95393f33bc8d8550a5ac62c18e488a9b6f DIFF: https://github.com/llvm/llvm-project/commit/fb3f6a95393f33bc8d8550a5ac62c18e488a9b6f.dif

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. when certain flags are specified, the Crt0 object files are not linked. However, the logic for determining which fil

[clang] d1e00b6 - [clang][deps] Only cache files with specific extension

Author: Jan Svoboda Date: 2023-03-20T11:12:00-07:00 New Revision: d1e00b6f136ec71a4c95a7eb4fd81ec0ab547962 URL: https://github.com/llvm/llvm-project/commit/d1e00b6f136ec71a4c95a7eb4fd81ec0ab547962 DIFF: https://github.com/llvm/llvm-project/commit/d1e00b6f136ec71a4c95a7eb4fd81ec0ab547962.diff L

[PATCH] D146328: [clang][deps] Only cache files with specific extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e00b6f136e: [clang][deps] Only cache files with specific extension (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

jdoerfert added a comment. Herald added subscribers: jplehr, sunshaoce. can we update some tests to see the results? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

tra created this revision. Herald added subscribers: mattd, bixia, yaxunl. Herald added a project: All. tra edited the summary of this revision. tra published this revision for review. tra added reviewers: yaxunl, dcastagna. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fi

[PATCH] D146371: [Clang][OpenMP]Solved the the always truth condition in Arm64

jdoerfert added a comment. Can you please upload a patch that does not reformat the entire file? Also, add a commit message explaining what this does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146371/new/ https://reviews.llvm.org/D146371 _

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

craig.topper updated this revision to Diff 506669. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update a few more files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146449/new/ https://revie

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:179 by prioritizing ``-Wunreachable-code-fallthrough``. +- Clang now correctly diagnoses statement attributes ``[[clang::always_inine]]` and + ``[[clang::noinline]]`` when used on a statement with d

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

craig.topper updated this revision to Diff 506670. craig.topper added a comment. Herald added subscribers: Sanitizers, Enna1, emaste. Herald added a reviewer: MaskRay. Herald added a project: Sanitizers. More files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 2d373e4 - [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives

Author: Akash Banerjee Date: 2023-03-20T18:48:21Z New Revision: 2d373e4dc7e97b0b2d7022d8d04e64834204187c URL: https://github.com/llvm/llvm-project/commit/2d373e4dc7e97b0b2d7022d8d04e64834204187c DIFF: https://github.com/llvm/llvm-project/commit/2d373e4dc7e97b0b2d7022d8d04e64834204187c.diff LOG

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d373e4dc7e9: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14291

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

nridge added a comment. My understanding is that a more elaborate configuration scheme has been proposed in https://github.com/clangd/clangd/issues/1367, and the feedback there was (quoting Sam from this comment ): > I think

[clang-tools-extra] 57bfe25 - [clangd] Remove reundant use of getSpellingLoc()

Author: Nathan Ridge Date: 2023-03-20T14:52:10-04:00 New Revision: 57bfe25574a0bfa9b6701e645d1f1ec966f838d9 URL: https://github.com/llvm/llvm-project/commit/57bfe25574a0bfa9b6701e645d1f1ec966f838d9 DIFF: https://github.com/llvm/llvm-project/commit/57bfe25574a0bfa9b6701e645d1f1ec966f838d9.diff

[PATCH] D146377: [clangd] Remove reundant use of getSpellingLoc()

This revision was automatically updated to reflect the committed changes. Closed by commit rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146377/new/ https://revie

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

aaron.ballman added reviewers: erichkeane, aaron.ballman. aaron.ballman added a comment. This feels like it's heading in the wrong direction -- the AST should not have holes in it. An invalid type should be replaced by a valid type (after diagnosing the invalid type, of course) so that we can ke

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + The template definition isn't available within the header file, so this is

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

erichkeane added a comment. In D146426#4207118 , @aaron.ballman wrote: > This feels like it's heading in the wrong direction -- the AST should not > have holes in it. An invalid type should be replaced by a valid type (after > diagnosing the invalid ty

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane updated this revision to Diff 506680. erichkeane marked 5 inline comments as done. erichkeane added a comment. Changes aaron suggested. Chose zip_longest instead of enumerate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146323/new/ https://reviews.llvm.org/D146323 Files:

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

ilya-biryukov added a comment. In D146426#4207118 , @aaron.ballman wrote: > This feels like it's heading in the wrong direction -- the AST should not > have holes in it. An invalid type should be replaced by a valid type (after > diagnosing the invalid

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/floats.cpp:110-111 + + static_assert(~2.0f == 3, ""); // ref-error {{invalid argument type 'float' to unary expression}} \ + // expected-error {{invalid argument type 'float'

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

craig.topper created this revision. craig.topper added reviewers: reames, asb, jrtc27, kito-cheng, luismarques. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflictin

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

francii updated this revision to Diff 506684. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146443/new/ https://reviews.llvm.org/D146443 Files: clang/lib/Driver/ToolChains/AIX.cpp Index: clang/lib/Driver/ToolCha

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflicting a

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

asb added a comment. The logic I saw with the pass names is that the backend for the RISC-V architecture is called "RISCV". But I've got no objection to changing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146451/new/ https://reviews.llvm.org/D

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431 std::string val_; }; MarcoFalke wrote: > PiotrZSL wrote: > > MarcoFalke wrote: > > > PiotrZSL wrote: > > > > Missing tests: > > > > - Test

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall LGTM, give it few days, maybe something will pop up. I will try to run this change on my project and check if it finds any false-positives or real-issues. CHANGES SINCE LAST ACTIO

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

dcastagna added a comment. Thank you Artem! Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1201 + return Loc->second; +// non-HIP compilation may end up with a different F and need to have +// handles and stubs updated. The different F is because somet

[PATCH] D146441: [APFloat] Add E4M3B11FNUZ

majnemer updated this revision to Diff 506694. majnemer added a comment. Fix a small typo in PyFloat8E4M3B11FNUZType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146441/new/ https://reviews.llvm.org/D146441 Files: clang/lib/AST/MicrosoftMangle.

[PATCH] D146422: Fix typo

1lyasm added a comment. I do not know why builds fail, only comment is changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146422/new/ https://reviews.llvm.org/D146422 ___ cfe-commits mailing list cfe

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

tbaeder updated this revision to Diff 506701. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 Files: clang/test/AST/Interp/floats.cpp Index: clang/test/AST/Interp/floats.cpp ===

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

tbaeder added inline comments. Comment at: clang/test/AST/Interp/floats.cpp:110-111 + + static_assert(~2.0f == 3, ""); // ref-error {{invalid argument type 'float' to unary expression}} \ + // expected-error {{invalid argument type 'float' to un

[PATCH] D146426: [Sema] Fix crash on __fp16 parameters in template instantiations

shafik added a comment. As I noted in the bug report not doing `D.setInvalidType();` does fix this bug and seems harmless since the error diagnostic should prevent us from getting to codegen but it is not clear to me if this has other negative impacts. Reading your replies it is not obvious you

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

kadircet added a subscriber: sammccall. kadircet added a comment. In D145843#4207101 , @nridge wrote: > My understanding is that a more elaborate configuration scheme has been > proposed in https://github.com/clangd/clangd/issues/1367, and the feedback

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

eandrews added a comment. Herald added a subscriber: jplehr. This patch causes an assertion when the attribute argument is an integer constant expression - https://godbolt.org/z/osKx5ejMb and has resulted in test fails downstream since any attribute which uses `VerifyIntegerConstantExpression`

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1201 + return Loc->second; +// non-HIP compilation may end up with a different F and need to have +// handles and stubs updated. dcastagna wrote: > The different F is because somet

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

tra updated this revision to Diff 506719. tra added a comment. Fixed a typo in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/test/CodeGenCUDA/bu

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

royjacobson added a comment. In D146329#4203174 , @shafik wrote: > I would have loved to test the case from > https://github.com/llvm/llvm-project/issues/61335 directly but I think in > order to do it nicely I need `__builtin_memset` to be usable in a c

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

kadircet updated this revision to Diff 506723. kadircet added a comment. Disable msvc compatibility to enable typo-correction on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/ https://reviews.llvm.org/D146417 Files: clang-too

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

yaxunl added a comment. Do you know whether the issue happens to HIP too? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146448/new/ https://reviews.llvm.org/D146448 ___ cfe-commits mailing list c

[PATCH] D144064: [-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

ziqingluo-90 updated this revision to Diff 506733. ziqingluo-90 marked 2 inline comments as done. ziqingluo-90 added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144064/new/ https://reviews.llvm.org/D144064 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

craig.topper added a comment. In D146451#4207261 , @asb wrote: > The logic I saw with the pass names is that the backend for the RISC-V > architecture is called "RISCV". But I've got no objection to changing. Yeah. I also wasn't sure which is best. Re

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth created this revision. paulkirth added reviewers: asb, phosek, hiraditya, jrtc27, mcgrathr. Herald added subscribers: jobnoorman, luke, Enna1, VincentWu, abrachet, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruce

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

tra added a comment. Would it make sense to also introduce a `ClangTargetBuiltin` for the cases where we use TARGET_BUILTIN on LLVM side now? A lot of the builtins we have in clang are TARGET_BUILTIN() with constrained availability (~5K, if my grep-foo works correctly). Right now we attempt t

[libunwind] 1187d8a - [libunwind][Modules] Add unwind_arm_ehabi.h and unwind_itanium.h to the unwind module)

Author: Ian Anderson Date: 2023-03-20T15:13:14-07:00 New Revision: 1187d8a62ba288e2221731f1795fa184571cd854 URL: https://github.com/llvm/llvm-project/commit/1187d8a62ba288e2221731f1795fa184571cd854 DIFF: https://github.com/llvm/llvm-project/commit/1187d8a62ba288e2221731f1795fa184571cd854.diff

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { Can you add a FIXME here? Using x27 should hopefully remove this restriction ===

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Fix an issue where temporaries initialized via parenthesized aggregate initialization don't get destroyed. - Fix an issue w

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 506754. ayzhao added a comment. clean up test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaInit.cpp c

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

tra added a comment. In D146448#4207591 , @yaxunl wrote: > Do you know whether the issue happens to HIP too? Thanks. Possibly, but I'm unable to reproduce the crash: https://godbolt.org/z/Gsx9sWG4v The value cached by KernelHandles in HIP is the the man

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao updated this revision to Diff 506755. ayzhao added a comment. remove extra semicolon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146465/new/ https://reviews.llvm.org/D146465 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaIni

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly converted to a type T...if T is an +//

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Debugging functions that have fallen through to the

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22178 "});"); - verifyFormat("Block b = ^int *(A *a, B *b) {}"); + verifyFormat("Block b = ^int *(A *a, B *b) {\n" + "};"); I don’t like us cha

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers updated this revision to Diff 506760. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146466/new/ https://reviews.llvm.org/D146466 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/AArch64/function-fallthrough.ll:7 +entry: + unreachable +} TODO: add test that the final MBB is a call to a noreturn function followed by unreachable Repository: rG LLVM Github Monorepo C

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506762. paulkirth added a comment. Fix comment and add `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp compile

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > Can you add a FIXME her

[PATCH] D146448: [CUDA] Update cached kernel handle when the function instance changes.

tra added a comment. In D146448#4207800 , @tra wrote: > However, `KernelStubs` would still point to the original `F`, and that may > potentially be left dangling. Perhaps I should always update both handles and > stubs if `F` changes. Yes, HIP is susce

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { paulkirth wrote: > craig.topper wrote: > > Can you add a FIXME here? Using x27 should

[PATCH] D146466: [clang] diagnose function fallthrough

efriedma added a comment. I'm concerned about the potential for false positives: - If a user doesn't mark a function noreturn, but it doesn't actually ever return. - A function is conditionally broken, but the condition is never actually true (for example, jump threading creates a dead codepath

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > paulkirth wrote: > > cr

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd marked an inline comment as not done. compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. + hans wrote: > Optionall

[clang] 6a0f2e5 - [-Wunsafe-buffer-usage] Add Fixable for dereference of simple ptr arithmetic

Author: ziqingluo-90 Date: 2023-03-20T17:07:03-07:00 New Revision: 6a0f2e539b8ef1f510f62aceb36430b95e40f0d3 URL: https://github.com/llvm/llvm-project/commit/6a0f2e539b8ef1f510f62aceb36430b95e40f0d3 DIFF: https://github.com/llvm/llvm-project/commit/6a0f2e539b8ef1f510f62aceb36430b95e40f0d3.diff

[PATCH] D142795: [-Wunsafe-buffer-usage] Add Fixable for dereference of simple ptr arithmetic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0f2e539b8e: [-Wunsafe-buffer-usage] Add Fixable for dereference of simple ptr arithmetic (authored by ziqingluo-90). Herald added a project: clang.

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506790. paulkirth added a comment. Remove outdated diagnostics and add tests for SCS + save/restore. I'm not 100% on if this is the right approach for save/restore testing, so I'm hapy to back this bit out or add more cases. Repository: rG LLVM Github

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

vabridgers added a comment. Hi @balazske . Can we go back to the original proposed fix and treat the new issue separately? We have an internal crash open that is corrected by the original patch I proposed, and passes all LITs and unit tests. I think it would be better to separate these concerns

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

rjmccall added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:720 +const CXXRecordDecl *RD, const ValueDecl *VD) { + MSInheritanceModel IM = RD->getMSInheritanceModel(); + // ::= efriedma wrote: > It's not obvious to me why the inheritance

[PATCH] D146466: [clang] diagnose function fallthrough

dblaikie added a comment. Yeah, we already have the return type warning and UBSan for the dynamic version of this check - seems OK? That a function lowers to unreachable isn't a bug - there's a ton of them in LLVM, quite intentionally as unimplemented functions that should never be called. If

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rG0fae851824bc1b64a727aeb331b7a0787599bd1f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D13737

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Thanks for putting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D137373: [Test][[AIX][p] Add 64-bit linker invocation tests

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rGdc9846ce988b9ddfcbc42cd462d5d94b634b3161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137373/new/ https://reviews.llvm.org/D1373

[PATCH] D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests

francii closed this revision. francii added a comment. Closing as this revision has landed https://reviews.llvm.org/rGe07a7040d9c6dbdd71e55d1153bfe1357079e511 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D1373

[clang] 4c483a0 - [AIX] Consolidate Crt0Basename logic

Author: Michael Francis Date: 2023-03-21T00:47:05Z New Revision: 4c483a046d2ff29ec2fd5bad6305f97424a2b880 URL: https://github.com/llvm/llvm-project/commit/4c483a046d2ff29ec2fd5bad6305f97424a2b880 DIFF: https://github.com/llvm/llvm-project/commit/4c483a046d2ff29ec2fd5bad6305f97424a2b880.diff LO

[PATCH] D146443: [AIX] Consolidate Crt0Basename logic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4c483a046d2f: [AIX] Consolidate Crt0Basename logic (authored by francii). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dblaikie added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:712-714 + assert(!getAbstractScopeDIEs().count(DS) && + "Abstract DIE for this scope exists!"); + getAbstractScopeDIEs()[DS] = ScopeDIE; jmmartinez

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:184 + +; RUN: llc -mtriple=riscv32 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV32I +; RUN: llc -mtriple=riscv64 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV64I ---

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 506813. aeubanks added a comment. Herald added subscribers: cfe-commits, ormris, wenlei, steven_wu. Herald added a project: clang. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https:/

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks added a comment. In D145403#4175178 , @tejohnson wrote: > In D145403#4172268 , @aeubanks > wrote: > >> still need to update tests and make sure this doesn't regress anything, but >> sending out to make

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added a subscriber: usama54321. NoQ added a comment. Thank you for a detailed summary, it's very helpful! > Can we move everything in AnalysisBasedWarnings.cpp to Sema? So far > AnalysisBasedWarnings is used to bridge Sema and UnsafeBufferAnalysis so that > the changes are minimal. Current

[PATCH] D146465: [clang] Fix 2 bugs with parenthesized aggregate initialization

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1582-1596 + MultiExprArg ExprsToPass; + if (Exprs.size() == 1 && isa(Exprs[0])) { +// C++20 [expr.static.cast]p4: +// An expression E can be explicitly converted to a type T...if T is an +//

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa updated this revision to Diff 506814. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 Files: clang/lib/Basic/Targets/Mips.cpp clang/test/Driver/mips-abi

<    1   2   3   >