tra added a comment.

In D146448#4207591 <https://reviews.llvm.org/D146448#4207591>, @yaxunl wrote:

> Do you know whether the issue happens to HIP too? Thanks.

Possibly, but I'm unable to reproduce the crash: https://godbolt.org/z/Gsx9sWG4v

The value cached by KernelHandles in HIP is the the manually created 'Var' and 
not the function itself.  I don't think it ever changes outside of this 
function.

However, `KernelStubs` would still point to the original `F`, and that may 
potentially be left dangling. Perhaps I should always update both handles and 
stubs if `F` changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146448/new/

https://reviews.llvm.org/D146448

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to