[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a comment. Patch seems to be missing all the context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:2 +! Test -emit-obj (RISC-V 64) + +! RUN: rm -f %t.o Missing `REQUIRES: ` - this test won't work unless the RISC-V backend is available. Comment at: flang/test/

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 504673. Endill added a comment. - Diagnose dependent expressions - Move AST dumping from parser to sema - Add documentation - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.l

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. Sorry! It's my first time using Phabricator. Maybe, the problem occurs because I've solved the issue with Arcanist just by means of copy-pasting patches into "Update Diff" Web GUI form. Maybe, I should reopen the PR? CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web G

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

hazohelet updated this revision to Diff 504678. hazohelet added a comment. Added a release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145793/new/ https://reviews.llvm.org/D145793 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/

[PATCH] D145947: [clang][sema][NFC] Make a few functions const

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC but I thought I'd at least better ask. Repository: rG LLVM Github Monorepo

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224 for (auto *D : DS->decls()) { -if (isa(D)) +if (isa(D)) continue; aaron.ballman wrote: > What about other kinds of declarations, such as typedefs or function

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. This needs a release note. Also, the patch message doesn't do a good job explaining what is going on here. Also, I'm not sure this is the right answer. The purpose of `CorrectDelayedTyposInExpr` is, in part, to make sure we emit the diagnostics of all child expres

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Endill added a comment. In D140996#4189452 , @bolshakov-a wrote: > Sorry! It's my first time using Phabricator. Maybe, the problem occurs > because I've solved the issue with Arcanist just by means of copy-pasting > patches into "Update Diff" Web GUI f

[PATCH] D145834: typo statment to statement

HerrCai0907 added a comment. Thanks, you can use my name HerrCai0907 (congcongcai0...@163.com) as patch attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145834/new/ https://reviews.llvm.org/D145834 __

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504681. bolshakov-a added a comment. Update patch with more context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. It works, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

awarzynski added inline comments. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + Given that you use `-###`, I think that this can be skipped (please double check). Comment at: flang/test/Dri

[clang] 383cfee - [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

Author: Anders Waldenborg Date: 2023-03-13T16:47:51+01:00 New Revision: 383cfeee09d1f345d08f396f2b7295b36830c88e URL: https://github.com/llvm/llvm-project/commit/383cfeee09d1f345d08f396f2b7295b36830c88e DIFF: https://github.com/llvm/llvm-project/commit/383cfeee09d1f345d08f396f2b7295b36830c88e.d

[clang] f5f1813 - [clang] Extract attribute plugin instantiation to function (NFC)

Author: Anders Waldenborg Date: 2023-03-13T16:47:51+01:00 New Revision: f5f1813defb5810223de8f916380808a8ed34584 URL: https://github.com/llvm/llvm-project/commit/f5f1813defb5810223de8f916380808a8ed34584 DIFF: https://github.com/llvm/llvm-project/commit/f5f1813defb5810223de8f916380808a8ed34584.d

[clang] 8629343 - [clang] Extract function for generated part of clang::hasAttribute (NFC)

Author: Anders Waldenborg Date: 2023-03-13T16:47:51+01:00 New Revision: 8629343a8b6c26f15f02de2fdd8db440eba71937 URL: https://github.com/llvm/llvm-project/commit/8629343a8b6c26f15f02de2fdd8db440eba71937 DIFF: https://github.com/llvm/llvm-project/commit/8629343a8b6c26f15f02de2fdd8db440eba71937.d

[clang] 1285a49 - [clang][pp] Handle attributes defined by plugin in __has_attribute

Author: Anders Waldenborg Date: 2023-03-13T16:47:51+01:00 New Revision: 1285a495d5886b99f8d193c90b258a56f89c8937 URL: https://github.com/llvm/llvm-project/commit/1285a495d5886b99f8d193c90b258a56f89c8937 DIFF: https://github.com/llvm/llvm-project/commit/1285a495d5886b99f8d193c90b258a56f89c8937.d

[clang] 446f780 - [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

Author: Anders Waldenborg Date: 2023-03-13T16:47:51+01:00 New Revision: 446f78092ffa75274866ec40411a1c0dbec2f13d URL: https://github.com/llvm/llvm-project/commit/446f78092ffa75274866ec40411a1c0dbec2f13d DIFF: https://github.com/llvm/llvm-project/commit/446f78092ffa75274866ec40411a1c0dbec2f13d.d

[PATCH] D144402: [clang] Move ParsedAttrInfo from Sema to Basic (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG383cfeee09d1: [clang] Move ParsedAttrInfo from Sema to Basic (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145769: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG446f78092ffa: [clang] Extract ParsedAttrInfo::hasSpelling method (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D144403: [clang] Extract attribute plugin instantiation to function (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5f1813defb5: [clang] Extract attribute plugin instantiation to function (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8629343a8b6c: [clang] Extract function for generated part of clang::hasAttribute (NFC) (authored by wanders). Repository: rG LLVM Github Monorepo

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285a495d588: [clang][pp] Handle attributes defined by plugin in __has_attribute (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144405/

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

hazohelet added a comment. In D145793#4189252 , @aaron.ballman wrote: > LGTM, though please add a release note for the fix. If you need someone to > land on your behalf, let us know what name and email address you'd like used > for patch attribution.

[clang] 73f9a0c - Fix typo: statment to statement; NFC

Author: HerrCai0907 Date: 2023-03-13T11:51:28-04:00 New Revision: 73f9a0c92377196b4a671d763175ac090e6a4cc2 URL: https://github.com/llvm/llvm-project/commit/73f9a0c92377196b4a671d763175ac090e6a4cc2 DIFF: https://github.com/llvm/llvm-project/commit/73f9a0c92377196b4a671d763175ac090e6a4cc2.diff L

[PATCH] D145834: typo statment to statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG73f9a0c92377: Fix typo: statment to statement; NFC (authored by HerrCai0907, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14583

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

vabridgers added a comment. Hi @balazske , all LIT and unittests pass with this change. By your logic, then we are missing some LIT or unittest cases that support your statement. Can you think of a case that demonstrates this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144981/new/ https://reviews.llvm.org/D144981 ___

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce updated this revision to Diff 504695. sunshaoce added a comment. Add `REQUIRES` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp flang/te

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:12 + +! CHECK: Flags: 0x5, RVC, double-float ABI +end program awarzynski wrote: > awarzynski wrote: > > For those of us less familiar with RISC-V - could you explain what's > > sign

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. The idea is that: 1. If function return an invalid ExprResult, this error should be handled in the callee 2. If function return valid Expr, the potential error should be handled in the caller, in this case, is ActOnExprStmt. If callee handles error, when caller fin

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Herald added a subscriber: sunshaoce. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderB

[PATCH] D145781: [AArch64] Don't #define __ARM_FP when there's no FPU.

tmatheson accepted this revision. tmatheson added a comment. LGTM Comment at: clang/lib/Basic/Targets/AArch64.h:29 - enum FPUModeEnum { FPUMode, NeonMode = (1 << 0), SveMode = (1 << 1) }; + enum FPUModeEnum { FPUMode = (1 << 0), NeonMode = (1 << 1), SveMode = (1 << 2) };

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4187872 , @dexonsmith wrote: > In D83906#4186887 , @hoy wrote: > >> In D83906#4184916 , @dexonsmith >> wrote: >> >>> In D83906#4183453

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

hazohelet updated this revision to Diff 504697. hazohelet added a comment. Address comments from @aaron.ballman - Dropped `const` qualifier from value objects for style consistency - Passed boolean `HasFallThroughAttr` to callback and handled warning suppression in `HandleUnreachable` in order t

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

vzakhari added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:1 -! REQUIRES: aarch64-registered-target, x86-registered-target +! REQUIRES: aarch64-registered-target, x86-registered-target, riscv-registered-target Can we split this test

[PATCH] D142905: [Driver] Change multilib selection algorithm

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. I've left a suggestion for a comment, bu

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

erichkeane added a comment. In D145892#4189603 , @HerrCai0907 wrote: > The idea is that: > > 1. If function return an invalid ExprResult, this error should be handled in > the callee > 2. If function return valid Expr, the potential error should be hand

[PATCH] D145567: [Driver] Rename multilib flags to tags

peter.smith added a comment. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. From looking at the source code alone - assuming that most people would not track down the commit message/review for extra c

[PATCH] D145567: [Driver] Rename multilib flags to tags

peter.smith accepted this revision. peter.smith added a comment. Actually click the button this time to set approval, see previous comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567

[PATCH] D142932: Multilib YAML parsing

peter.smith added a comment. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. I've left some comments that can be applied prior to commit if you want to take them up. Comment at: clan

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. Repository: rG LLVM Github Monorepo

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. Repository: rG LLVM Github Monorepo

[PATCH] D145951: [docs] Add more complete documentation for -f[no]split-lto-unit

tejohnson created this revision. tejohnson added reviewers: nikic, hans. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Option was added in D53891

[PATCH] D145517: MSVC: support version preference with search

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5f46822847: MSVC: support version preference with search (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. Repository: rG LLVM Github Monorepo

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:1 -! REQUIRES: aarch64-registered-target, x86-registered-target +! REQUIRES: aarch64-registered-target, x86-registered-target, riscv-registered-target vzakhari wrote: > Can

[PATCH] D143075: BareMetal ToolChain multilib layering

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. Repository: rG LLVM Github Monorepo

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

tejohnson added a comment. In D53891#4186894 , @tejohnson wrote: > In D53891#4186892 , @nikic wrote: > >> In D53891#2116541 , @hans wrote: >> >>> Would be possible to add som

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma added a comment. There appear to be 8 different places that call `isTypeConstant(Ty, true)`; I'd like to see testcases for all of them if it's relevant. (I agree with your assessment for global variables, but not sure about the other places.) Repository: rG LLVM Github Monorepo CH

[PATCH] D143587: [Docs] Multilib design

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. I've left a suggestion that can be appli

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &b

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 504717. VitaNuo marked 14 inline comments as done. VitaNuo added a comment. Implement the most recent version from the design document: always show a single provider, whether directly included or not (as long as there is a provider). Address review comments.

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thank you for the comments! I've implemented the new version as per the design doc, as well as did my best to address the review comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1093 +std::vector +collectMacroReferences(ParsedAST &AST) { + con

[clang] 5fba4c4 - [AArch64] Don't #define __ARM_FP when there's no FPU.

Author: Simon Tatham Date: 2023-03-13T16:43:25Z New Revision: 5fba4c4d08bdb38d0df2fd43afa4bec4f3809b66 URL: https://github.com/llvm/llvm-project/commit/5fba4c4d08bdb38d0df2fd43afa4bec4f3809b66 DIFF: https://github.com/llvm/llvm-project/commit/5fba4c4d08bdb38d0df2fd43afa4bec4f3809b66.diff LOG:

[PATCH] D145781: [AArch64] Don't #define __ARM_FP when there's no FPU.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fba4c4d08bd: [AArch64] Don't #define __ARM_FP when there's no FPU. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D145643: [clang][driver] Add option to manually control -disable-free in cc1

aaron.ballman added a comment. Hmmm, can you explain a bit more about why you need this? By default, Clang (the application) leaks memory on shutdown (why free a whole bunch of memory only to terminate, which frees the memory for you?). So it surprises me that we'd need a *driver* option for th

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 504720. VitaNuo added a comment. Rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clang

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce marked 5 inline comments as done. sunshaoce added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:33 ! RUN: -o /dev/null -S %s 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-CPU ! RUN: %flang_fc1 -triple aarch64-linux-gnu -target-feature +sup

[clang] 6b48d20 - [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

Author: Takuya Shimizu Date: 2023-03-13T12:53:12-04:00 New Revision: 6b48d202ef497f4d512c382fe0db8c5ad3a72faa URL: https://github.com/llvm/llvm-project/commit/6b48d202ef497f4d512c382fe0db8c5ad3a72faa DIFF: https://github.com/llvm/llvm-project/commit/6b48d202ef497f4d512c382fe0db8c5ad3a72faa.diff

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b48d202ef49: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call (authored by hazohelet, committed by aaron.ballman). Ch

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &b

[PATCH] D145947: [clang][sema][NFC] Make a few functions const

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145947/new/ https://reviews.llvm.org/D145947 _

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 504724. royjacobson added a comment. Add more tests, small nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/ReleaseNotes.rst clang/lib/S

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson marked 2 inline comments as done. royjacobson added a comment. In D145851#4189158 , @erichkeane wrote: > Generally looks good to me. Do we do anything special if there are multiple > initializers? Also, can we have a codegen test that vali

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTra

[clang] eae70cc - [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Author: Ayal Zaks Date: 2023-03-13T18:59:26+02:00 New Revision: eae70ccbf9756e1e5b2c32f08558cb11e0f05dbf URL: https://github.com/llvm/llvm-project/commit/eae70ccbf9756e1e5b2c32f08558cb11e0f05dbf DIFF: https://github.com/llvm/llvm-project/commit/eae70ccbf9756e1e5b2c32f08558cb11e0f05dbf.diff LOG

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeae70ccbf975: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0 (authored by Ayal). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Correct issue when inco

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

erichkeane added a comment. In D145851#4189916 , @royjacobson wrote: > In D145851#4189158 , @erichkeane > wrote: > >> Generally looks good to me. Do we do anything special if there are multiple >> initializers

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504736. royjacobson added a comment. Add a test case, slightly simpler modeling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.

[PATCH] D145951: [docs] Add more complete documentation for -f[no]split-lto-unit

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145951/new/ https://reviews.llvm.org/D145951 ___

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

tra added a subscriber: nikic. tra added a comment. I'm in the same boat as @nikic -- the patch looks reasonable in principle, but I'm not familiar with the nuanaces of FP codegen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 _

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

cjdb added a comment. Would you be able to update the commit message to include a description that explains why this commit is necessary please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145856/new/ https://reviews.llvm.org/D145856 __

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2817 +// unique representation. +if (Field->isUnnamedBitfield() && BitfieldSize > 0) + return std::nullopt; aaron.ballman wrote:

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia added a comment. testcase? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:236 + if (Args.hasArg(options::OPT_r)) { +const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); +C.addCommand(std::make_unique( nit: can we avoid the code du

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added a comment. First, we've been dealing with the 16.0 release process/regressions, which unfortunately got us pretty far behind on reviews. Sorry about that! I have only 1 concern here, otherwise, this LGTM. I'll leave it to Aaron to make the final 'value judgement' of if we wan

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii added a comment. In D145899#4190055 , @w2yehia wrote: > testcase? This patch is still WIP while I verify the libraries that we intend not to add. But I will add a test case once I've done so :) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExprSequence.cpp:67 +llvm::SmallVector +allInitListExprForms(const InitListExpr *InitList) { + llvm::SmallVector result = {InitList}; maybe some other name instead of allInitListExprF

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

awarzynski added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:12 + +! CHECK: Flags: 0x5, RVC, double-float ABI +end program sunshaoce wrote: > awarzynski wrote: > > awarzynski wrote: > > > For those of us less familiar with RISC-V - could you

[clang] a26aabe - [Clang] Add --version and --help messages to amdgpu/nvptx-arch

Author: Joseph Huber Date: 2023-03-13T12:32:42-05:00 New Revision: a26aabefe535d323c416d7d57be8c669f3741f15 URL: https://github.com/llvm/llvm-project/commit/a26aabefe535d323c416d7d57be8c669f3741f15 DIFF: https://github.com/llvm/llvm-project/commit/a26aabefe535d323c416d7d57be8c669f3741f15.diff

[PATCH] D145944: [Clang] Add --version and --help messages to amdgpu/nvptx-arch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa26aabefe535: [Clang] Add --version and --help messages to amdgpu/nvptx-arch (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES S

[clang] c2aabcf - [LinkerWrapper] Switch to add_clang_tool() macro

Author: Evangelos Foutras Date: 2023-03-13T12:43:12-05:00 New Revision: c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d URL: https://github.com/llvm/llvm-project/commit/c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d DIFF: https://github.com/llvm/llvm-project/commit/c2aabcfc8395ba30884dd3c1ecc2b192ae85a78d.d

[clang] 1b40df1 - [Clang] Fix not including clangBasic in the dynamic build

Author: Joseph Huber Date: 2023-03-13T12:41:16-05:00 New Revision: 1b40df1de7a4b3664a55becd776c250f20db0041 URL: https://github.com/llvm/llvm-project/commit/1b40df1de7a4b3664a55becd776c250f20db0041 DIFF: https://github.com/llvm/llvm-project/commit/1b40df1de7a4b3664a55becd776c250f20db0041.diff

[PATCH] D145862: [LinkerWrapper] Switch to add_clang_tool() macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2aabcfc8395: [LinkerWrapper] Switch to add_clang_tool() macro (authored by foutrelis, committed by jhuber6). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM G

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && +!(getLangOpts().ObjC && isObjCProtectedMacro(II))) + Diag(MacroNameTok, di

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @peter.smith. I've opted to leave the comment as-is. If we can expect a tag_set to actually contain flags then I've continued to use that terminology. Comment at: clang/lib/Driver/ToolCha

[PATCH] D145838: [clang][deps] Handle response files in dep scanner

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145838/new/ https://reviews.llvm.org/D145838

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce updated this revision to Diff 504756. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Add `target-cpu-features-invalid.f90` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e901cda725b: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions… (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 4e901cd - [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

Author: Mike Crowe Date: 2023-03-13T18:03:09Z New Revision: 4e901cda725b5adbdfeb495607fda9a2f84128c8 URL: https://github.com/llvm/llvm-project/commit/4e901cda725b5adbdfeb495607fda9a2f84128c8 DIFF: https://github.com/llvm/llvm-project/commit/4e901cda725b5adbdfeb495607fda9a2f84128c8.diff LOG: [c

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114 + case llvm::Triple::riscv64: +getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false); +break; kiranchandramohan wrote: > jrtc27 wrote: > > mnadeem wrote: > > >

[PATCH] D145970: [MSVC][PS][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclasses

wolfgangp created this revision. wolfgangp added reviewers: probinson, bd1976llvm, hans, mstorsjo. Herald added a project: All. wolfgangp requested review of this revision. For the Playstation platform, mimic MSVC in propagating dllexport/dllimport attributes to an instantiated template base clas

[clang] bcad161 - [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Author: Joshua Cranmer Date: 2023-03-13T14:20:24-04:00 New Revision: bcad161db3e69e27736c975ef5eeac60c96dcc97 URL: https://github.com/llvm/llvm-project/commit/bcad161db3e69e27736c975ef5eeac60c96dcc97 DIFF: https://github.com/llvm/llvm-project/commit/bcad161db3e69e27736c975ef5eeac60c96dcc97.diff

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcad161db3e6: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V. (authored by jcranmer-intel). Changed prior to commit: https

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added subscribers: eli.friedman, gribozavr2, akyrtzi, gribozavr. erichkeane added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:88 +/// so cannot be dependent. +UncommonValue, + bolshakov-a wrote: > shafik wrote: > > erich

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1067 + Reference type template arguments referring to instantiation-dependent objects and subobjects + (i.e. delcared inside a template but neither type- nor value-dependent) aren't fully

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 504771. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. parse -> parseYaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932

[PATCH] D142932: Multilib YAML parsing

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:66 + /// options and look similar to them, and others can be defined by a + /// particular multilib.yaml. A multilib is considered compatible if its tags + /// are a subset of the tags der

<    1   2   3   4   >