w2yehia added a comment.

testcase?



================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:236
+  if (Args.hasArg(options::OPT_r)) {
+    const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
+    C.addCommand(std::make_unique<Command>(
----------------
nit: can we avoid the code duplication here? We can use a `goto` or add 
`options::OPT_r` checking below. 
`./lib/Driver/ToolChains/Gnu.cpp` can be used as a reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145899/new/

https://reviews.llvm.org/D145899

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to