[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 503644. jchlanda added a comment. `append` -> `+` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Co

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda marked 5 inline comments as done. jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.seco

[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.

hokein updated this revision to Diff 503653. hokein marked an inline comment as done. hokein added a comment. address comment: add more _N symbol up to _29. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145553/new/ https://reviews.llvm.org/D145553

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm

[clang] 1c33c41 - [doc] Deprecate the '-fmodule-file==' for named modules in the document

Author: Chuanqi Xu Date: 2023-03-09T16:20:01+08:00 New Revision: 1c33c419e41e412a1b2476e9979034a42b8dda56 URL: https://github.com/llvm/llvm-project/commit/1c33c419e41e412a1b2476e9979034a42b8dda56 DIFF: https://github.com/llvm/llvm-project/commit/1c33c419e41e412a1b2476e9979034a42b8dda56.diff LO

[clang] 404b1b2 - [Tooling/Inclusion] Add missing placerholder _1 symbols.

Author: Haojian Wu Date: 2023-03-09T09:20:42+01:00 New Revision: 404b1b2ed42f6138a0e91b337150a90108c1b155 URL: https://github.com/llvm/llvm-project/commit/404b1b2ed42f6138a0e91b337150a90108c1b155 DIFF: https://github.com/llvm/llvm-project/commit/404b1b2ed42f6138a0e91b337150a90108c1b155.diff LO

[PATCH] D145553: [Tooling/Inclusion] Add missing placerholder _1 symbols.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG404b1b2ed42f: [Tooling/Inclusion] Add missing placerholder _1 symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 22c0ce9 - [Tooling/Inclusion] Add atomic family symbols

Author: Haojian Wu Date: 2023-03-09T09:21:18+01:00 New Revision: 22c0ce96912f55f48ba4535800bacc0c48fe9832 URL: https://github.com/llvm/llvm-project/commit/22c0ce96912f55f48ba4535800bacc0c48fe9832 DIFF: https://github.com/llvm/llvm-project/commit/22c0ce96912f55f48ba4535800bacc0c48fe9832.diff LO

[PATCH] D145557: [Tooling/Inclusion] Add atomic family symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG22c0ce96912f: [Tooling/Inclusion] Add atomic family symbols (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145557/new/ https://reviews.

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added a comment. Please update the commit message (there is no `clang_isFieldDeclBitWidthDependent` anymore) and update the revision with `arc diff --verbatim @~`. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaratio

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 503672. domada added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/T

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, foad, kzhuravl, rampitec. Herald added subscribers: kosarev, StephenFan, kerbowa, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added

[PATCH] D145519: [SanitizerBinaryMetadata] Do not add to GPU code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG61ed64954b97: [SanitizerBinaryMetadata] Do not add to GPU code (authored by melver). Repository: rG LLVM Github Monorep

[clang] 61ed649 - [SanitizerBinaryMetadata] Do not add to GPU code

Author: Marco Elver Date: 2023-03-09T10:15:28+01:00 New Revision: 61ed64954b979df0d5bfdfbe54a7c27e20be9001 URL: https://github.com/llvm/llvm-project/commit/61ed64954b979df0d5bfdfbe54a7c27e20be9001 DIFF: https://github.com/llvm/llvm-project/commit/61ed64954b979df0d5bfdfbe54a7c27e20be9001.diff L

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

shchenz added a comment. I think this is a good direction. For example we can avoid the crash in https://github.com/llvm/llvm-project/issues/60959 and give a clear diagnostic message. However, manually adding the required target feature seems a little mistakable, like the one below. I guess we

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. > However, manually adding the required target feature seems a little > mistakable, like the one below. I guess we can not get the required feature > in the LLVM instruction TDs(if the builtin is mapped to a IR intrinsic and > the intrinsic is selected inside the instruct

[clang] db987b9 - [Modules] Remove unnecessary check when generating name lookup table in ASTWriter

Author: Chuanqi Xu Date: 2023-03-09T17:29:36+08:00 New Revision: db987b9589be1eb604fcb74c85b410469e31485f URL: https://github.com/llvm/llvm-project/commit/db987b9589be1eb604fcb74c85b410469e31485f DIFF: https://github.com/llvm/llvm-project/commit/db987b9589be1eb604fcb74c85b410469e31485f.diff LO

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. This is basically a reverting of https://reviews.llvm.org/D117087. So it should be good according to our previous talk. Comment at: clang/include/clang/AST/StmtCXX.h:4

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 _

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 503696. karapsinie added a comment. Removed the spurious whitespace changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKind

[PATCH] D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:475 const CoroutineBodyStmt &S; + bool DirectEmit = false; nit. Rewords it if you like. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:483-499 +// The call

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added a comment. In D145591#4179144 , @tra wrote: > How is this different from compiling a C++ file with opemnp directives in it? > AFAICT neither clang nor gcc issue anywarnings: > https://godbolt.org/z/5Me3dnTdr > > What makes the warnings neces

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** Assigning `true` to `int : 1` bit-fields in C++ code produces a GCC warning: ``` warning: overflow in conversion from ‘int’ to ‘signed

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith added inline comments. Comment at: clang/tools/libclang/CXType.cpp:13 +#include "CXType.h" #include "CIndexer.h" vedgy wrote: > collinbaker wrote: > > vedgy wrote: > > > I guess //clang-format// did this include reordering. But it certainly > > > l

[clang] 4cb843d - [OpenCL] Add builtin header TableGen emitter

Author: Sven van Haastregt Date: 2023-03-09T10:20:04Z New Revision: 4cb843d099422e5d77d0f7e16cbb18ee64d457a5 URL: https://github.com/llvm/llvm-project/commit/4cb843d099422e5d77d0f7e16cbb18ee64d457a5 DIFF: https://github.com/llvm/llvm-project/commit/4cb843d099422e5d77d0f7e16cbb18ee64d457a5.diff

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb843d09942: [OpenCL] Add builtin header TableGen emitter (authored by svenvh). Herald added a subscriber: mgrang. Changed prior to commit: https://reviews.llvm.org/D104040?vs=417678&id=503704#toc Rep

[PATCH] D145517: MSVC: support version preference with search

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm I wish the way clang-cl finds system libraries was better documented though. Since you've been digging through this code, would you be up for writing something in the https://clang.llvm.org/

[PATCH] D129951: adds `__disable_adl` attribute

cor3ntin added a subscriber: lewissbaker. cor3ntin added a comment. In D129951#4179596 , @cjdb wrote: > In D129951#4179481 , @ldionne wrote: > >> In D129951#4179467 , @cjd

[PATCH] D145567: [Driver] Rename multilib flags to tags

simon_tatham added a comment. But it was useful to have it separate at least for review purposes, since it made it much easier when Michael asked me to proofread the change from 'flags' to 'tags'! Comment at: clang/docs/Multilib.rst:66 ``--target=armv7m-none-eabi`` are eq

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 // RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -

[clang] 353155a - [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2023-03-09T11:54:52+01:00 New Revision: 353155a1a507e2d04edf227b8665a6360b354762 URL: https://github.com/llvm/llvm-project/commit/353155a1a507e2d04edf227b8665a6360b354762 DIFF: https://github.com/llvm/llvm-project/commit/353155a1a507e2d04edf227b8665a6360b354762.diff L

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG353155a1a507: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14375

[PATCH] D145567: [Driver] Rename multilib flags to tags

simon_tatham added inline comments. Comment at: clang/docs/Multilib.rst:71 + arguments into a standard set of simpler "tags". In many cases these tags will look like a command line argument with the leading ``-`` stripped off, + but where a suitable form for the tag doesn

[clang] e281793 - [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Author: ManuelJBrito Date: 2023-03-09T11:01:09Z New Revision: e2817933fdd4417673eb7f96a2842ae2dca8fc59 URL: https://github.com/llvm/llvm-project/commit/e2817933fdd4417673eb7f96a2842ae2dca8fc59 DIFF: https://github.com/llvm/llvm-project/commit/e2817933fdd4417673eb7f96a2842ae2dca8fc59.diff LOG:

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2817933fdd4: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS (authored by ManuelJBrito). Changed prior to commit: https:/

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 _

[clang] 6836714 - Revert "[clang-format] Add -j to clang-format-diff to speed up formatting"

Author: Nikita Popov Date: 2023-03-09T12:32:10+01:00 New Revision: 68367141dd91ee71f50418f28ea358519cd6613d URL: https://github.com/llvm/llvm-project/commit/68367141dd91ee71f50418f28ea358519cd6613d DIFF: https://github.com/llvm/llvm-project/commit/68367141dd91ee71f50418f28ea358519cd6613d.diff

[clang] 85e6617 - Revert "[X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS"

Author: ManuelJBrito Date: 2023-03-09T11:56:08Z New Revision: 85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7 URL: https://github.com/llvm/llvm-project/commit/85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7 DIFF: https://github.com/llvm/llvm-project/commit/85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7.diff LOG:

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder marked an inline comment as done. tbaeder added a comment. The tests you proposed need https://reviews.llvm.org/D143480 first so we can cast up more than one level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393 +break; + } else { +return; don't need `else` afte

[PATCH] D145435: Choose style (file) from within code for use in IDEs

HazardyKnusperkeks added a comment. In D145435#4179662 , @owenpan wrote: > In D145435#4179308 , @bersbersbers > wrote: > >> In D145435#4173875 , @owenpan >> wrote: >> >>

[clang] 9aa54db - Revert "Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot"

Author: Aaron Ballman Date: 2023-03-09T08:01:55-05:00 New Revision: 9aa54db44c5b057669d507c0cd4689062750487e URL: https://github.com/llvm/llvm-project/commit/9aa54db44c5b057669d507c0cd4689062750487e DIFF: https://github.com/llvm/llvm-project/commit/9aa54db44c5b057669d507c0cd4689062750487e.diff

[clang] feec067 - Revert "Add __builtin_set_flt_rounds"

Author: Aaron Ballman Date: 2023-03-09T08:02:31-05:00 New Revision: feec067982abd806c2cf444956446b604bf7cf4c URL: https://github.com/llvm/llvm-project/commit/feec067982abd806c2cf444956446b604bf7cf4c DIFF: https://github.com/llvm/llvm-project/commit/feec067982abd806c2cf444956446b604bf7cf4c.diff

Re: [clang] d4fcc69 - Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

On Wed, Mar 8, 2023 at 11:57 PM via cfe-commits wrote: > > > Author: jinge90 > Date: 2023-03-09T13:14:36+08:00 > New Revision: d4fcc692ee15b2c6d249daabe31208d6a5afa025 > > URL: > https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025 > DIFF: > https://github.com/llv

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &b

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. Found some minor cleanups but otherwise LGTM (feel free to fix when landing if you'd like). Comment at: clang/tools/libclang/CXType.cpp:380-384 if (const FieldDecl *FD = dyn_cast_or_null(D)) { if

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503741. TIFitis added a comment. Added names for offload mapper variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

ilya-biryukov added a comment. I don't have a lot of experience in codegen, so will let Aaron and Richard do the review. However, still wanted to share one observation. The actual check that avoids emitting the destructors for variables seems more involved than just checking if the destructor

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked an inline comment as not done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > Assigning `true` to `int : 1` bit-fields in C++ code produces a GCC warning:

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4175887 , @vedgy wrote: > In D143418#4175628 , @aaron.ballman > wrote: > >> Hmmm, don't relaxed loads and stores still have the potential to be racey? I >> thought you n

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked an inline comment as not done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > aaron.ballman wrote: > > vedgy wrote: > > > Assigning `true` to `int : 1` bi

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTra

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans added a comment. In D145369#4181296 , @ilya-biryukov wrote: > I don't have a lot of experience in codegen, so will let Aaron and Richard do > the review. Thanks for checking! I don't have a lot of experience here either, so any review is much app

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

alexander-shaposhnikov updated this revision to Diff 503750. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145034/new/ https://reviews.llvm.org/D145034 Files: clang/include/clang/Parse/Par

[clang] dbde7cc - Switch from int to unsigned int; NFC

Author: Aaron Ballman Date: 2023-03-09T09:29:00-05:00 New Revision: dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b URL: https://github.com/llvm/llvm-project/commit/dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b DIFF: https://github.com/llvm/llvm-project/commit/dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b.diff

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > vedgy wrote: > > aaron.ballman wrote: > > > vedgy wrote: > > > > Assigning `true` to `int : 1` bit-fields in C++

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 503753. rymiel added a comment. Improve code flow in parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineP

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141 + ClassTemplate->getInjectedClassNameSpecialization(); + if (Context.hasSameType(Injected, ContextType)) +return ClassTemplate->getTemplatedDecl();

[clang] 1a4d0eb - [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Author: ManuelJBrito Date: 2023-03-09T14:32:30Z New Revision: 1a4d0eb866be909fe16da5ebffe4122aa0693d8c URL: https://github.com/llvm/llvm-project/commit/1a4d0eb866be909fe16da5ebffe4122aa0693d8c DIFF: https://github.com/llvm/llvm-project/commit/1a4d0eb866be909fe16da5ebffe4122aa0693d8c.diff LOG:

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393 +break; + } else { +return; HazardyKnusperkeks wrote: > don't need `else` after `break`. > In fact I would negate

[PATCH] D145605: Revert two patches to fix GH58452 regression

erichkeane updated this revision to Diff 503756. erichkeane added a comment. clang-format fixes, going to make sure this passes CI, then commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 Files: clang/include/clang/Sema/Sema.h clang/in

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation &C, StringRef Prefix, StringRef Suffix, t

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

artem.tamazov accepted this revision as: artem.tamazov. artem.tamazov added a comment. This revision is now accepted and ready to land. No objections from MIOpen side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.o

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

kadircet added a comment. > @kadircet it is obvious that there is something in this diff that causes this > hesitancy in accepting it. I'm ready to keep iterating on the solution but I > need a clue what needs the improvement. Please comment. sorry for the late reply, i was on vacation and just

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

ahatanak added a comment. clang marks the called function `foo` in p1.cpp as nounwind here: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L1284 clang can also mark a function declaration as nounwind based on the information in the source code, for example,

[clang] 0041f08 - [clang][Interp][NFC] Take a const Descriptor* in dtor,move,ctorFns

Author: Timm Bäder Date: 2023-03-09T16:08:59+01:00 New Revision: 0041f081962c60a96d45d9a3a964c2d00216c16d URL: https://github.com/llvm/llvm-project/commit/0041f081962c60a96d45d9a3a964c2d00216c16d DIFF: https://github.com/llvm/llvm-project/commit/0041f081962c60a96d45d9a3a964c2d00216c16d.diff LO

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings added a comment. Thanks @MaskRay for taking a look and thanks @simon_tatham for the review of the change. This change affects existing code so I think it deserves its own commit, but I'll move it down the stack to before D142932 so that later c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

jmmartinez added a comment. Just a few minor comments. Everything else seems good to me. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:698 + // an inlined function: if a local variable has a templated type with + // a function-local type as a template parameter

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D145691 should fix the libc++ CI failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can deprecate

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4175942 , @giulianobelinassi wrote: > Hi, Aron. > > Just to make myself clear: What I need to do is that the clang dumps for C > files are also accepted by GCC as input. FWIW, that's not a supported use for `-a

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && +!(getLangOpts().ObjC && isObjCProtectedMacro(II))) + Diag(MacroNameTok,

[PATCH] D122677: [prototype] include-cleaner library

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:62 "misc-unused-alias-decls"); +CheckFactories.registerCheck("misc-unused-includes"); CheckFactories.registerCheck( Missing tests & documentation fo

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1949 + // Pointer of derived type is already on the stack. + const CXXRecordDecl *FinalDecl = cast(BaseType->getDecl()); + const RecordDecl *CurDecl = DerivedType->getDecl();

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman added a comment. In D143466#4181191 , @tbaeder wrote: > The tests you proposed need https://reviews.llvm.org/D143480 first so we can > cast up more than one level. Okay, how about we land that one first then come back to this one? I left s

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503796. qiongsiwu1 added a comment. Rename the `ReadOnlyPointers` option in the source to `XCOFFReadOnlyPointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. There are *some* properties we can still assume about `linkonce_odr` functions despite them being replaceable at link time. The high-level language guarantee we're starting from is that the source semantics of all versions of the function are identical. The version o

[clang] acecf68 - Revert two patches to fix GH58452 regression

Author: Erich Keane Date: 2023-03-09T09:16:53-08:00 New Revision: acecf68c8b7c3c625cfa00f00f8ddc8f15baae44 URL: https://github.com/llvm/llvm-project/commit/acecf68c8b7c3c625cfa00f00f8ddc8f15baae44 DIFF: https://github.com/llvm/llvm-project/commit/acecf68c8b7c3c625cfa00f00f8ddc8f15baae44.diff L

[PATCH] D145605: Revert two patches to fix GH58452 regression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGacecf68c8b7c: Revert two patches to fix GH58452 regression (authored by erichkeane). Herald added a project: clang. Repos

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

kzhuravl added a comment. In D145671#4181568 , @yaxunl wrote: > Did you go through the deprecation process for this option? We need to send a > documentation team first so that it is announced to the users. Then in the > next release we can deprecate it

[clang] 9dcf6b1 - [PS4/PS5] Remove C_INCLUDE_DIRS handling

Author: Paul Robinson Date: 2023-03-09T09:26:50-08:00 New Revision: 9dcf6b19daf8980a02a5b9206126b3eff7a37e01 URL: https://github.com/llvm/llvm-project/commit/9dcf6b19daf8980a02a5b9206126b3eff7a37e01 DIFF: https://github.com/llvm/llvm-project/commit/9dcf6b19daf8980a02a5b9206126b3eff7a37e01.diff

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.org/D145671 __

[PATCH] D145517: MSVC: support version preference with search

compnerd added a comment. Sure thing, I can try to write up some details about that @hans! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145517/new/ https://reviews.llvm.org/D145517 ___ cfe-commits maili

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase &builder, LLVM::ModuleTranslation

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4180435 , @dexonsmith wrote: > Oh, de-refining is pretty nifty / evil. This patch has background: > https://reviews.llvm.org/D18634 > > Since 2016, the optimizer is not allowed to do IPA on functions that can be > de-refin

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 503819. ManuelJBrito added a comment. Rebase `avx-cast-builtins.c` was moved to D144903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/ https://reviews.llvm.or

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503826. yaxunl marked an inline comment as done. yaxunl added a comment. fix comments and tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h clang/lib/Drive

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a subscriber: jhuber6. tra added a comment. In D145591#4180908 , @mhalk wrote: > For example: when using `-x hip -fopenmp --offload-arch=...` (+ other > reasonable parameters) a HIP program with OpenMP target directives will > compile without

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting __FLT_EVAL_METHOD__ to -1 with fast-math will set __GLIBC_F

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added subscribers: Wilco1, kito-cheng, bjope. zahiraam added a comment. Tagging @davemgreen, @kito-cheng, @bjope and @Wilco1 for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182016 , @tra wrote: > It sounds like what we want is to make `-x hip` and `-fopenmp` mutually > exclusive, with a hard error when both are used. If you look at the problem > as "-fopenmp completely breaks HIP compila

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish updated this revision to Diff 503850. snehasish added a comment. Update the script for Transforms/PGOProfile/memprof.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 Files: clang/test/CodeG

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish added inline comments. Comment at: llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh:63 + delete[] f; + + // Loop ensures the two calls to recurse have stack contexts that only differ @tejohnson Turns out the LLVM IR matching issue was d

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

tejohnson added a comment. Generally lgtm, but why did the raw profiles change size from what is currently committed? Comment at: llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh:63 + delete[] f; + + // Loop ensures the two calls to recurse have stack contexts

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a subscriber: tstellar. aaron.ballman added a comment. Thank you for working on this! Because this is fixing an ABI break, if we can land this in time for the release candidate I think we should try to add this to 16.0 to limit damage. CC @tstellar for his opinion. This does

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4181981 , @hoy wrote: > That said, the LLVM optimizer does not strictly subsume the front-end because > of how it fails to handle `linkonce_odr` functions as in > https://reviews.llvm.org/D18634. I'm wondering how co

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish updated this revision to Diff 503859. snehasish added a comment. Update the script in test/tool/llvm-profdata/Inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 Files: clang/test/CodeGen/

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit

yln created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. yln requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the `-lower-global-dtors-via-cxa-atexit` escape hatch introduc

[clang] 8da99b4 - Revert "Revert "Add map info for dereference pointer.""

Author: Jennifer Yu Date: 2023-03-09T10:59:59-08:00 New Revision: 8da99b44b6a5a2c9033e38828858cbadad425204 URL: https://github.com/llvm/llvm-project/commit/8da99b44b6a5a2c9033e38828858cbadad425204 DIFF: https://github.com/llvm/llvm-project/commit/8da99b44b6a5a2c9033e38828858cbadad425204.diff L

  1   2   3   >