[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. Hi, @rjmccall and @sepavloff I updated built name to "__builtin_set_flt_rounds" as suggested and restrict the built to be used on x86, arm, aarch64 target. I did my local test on x86 and x86_64 and found arm and aarch64 code gen have already supported "llvm.set.round

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

This revision was automatically updated to reflect the committed changes. Closed by commit rG29a4ed80bb4c: [clang][ASTImporter] Add VaList declaration to lookup table. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D144273?vs=502089&id=502542#toc Repository: rG LLV

[clang] 29a4ed8 - [clang][ASTImporter] Add VaList declaration to lookup table.

Author: Balázs Kéri Date: 2023-03-06T09:32:02+01:00 New Revision: 29a4ed80bb4c8aadc76718924f80a5f532b1ffce URL: https://github.com/llvm/llvm-project/commit/29a4ed80bb4c8aadc76718924f80a5f532b1ffce DIFF: https://github.com/llvm/llvm-project/commit/29a4ed80bb4c8aadc76718924f80a5f532b1ffce.diff L

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 502545. AlexanderHederstaf added a comment. Add extra tests based on https://github.com/llvm/llvm-project/issues/56111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.o

[clang] 2fbf18b - [clang] Fix aggregate initialization inside lambda constexpr

Author: Mariya Podchishchaeva Date: 2023-03-06T03:38:49-05:00 New Revision: 2fbf18b40026b46bd380fae58575cebbd9801ff4 URL: https://github.com/llvm/llvm-project/commit/2fbf18b40026b46bd380fae58575cebbd9801ff4 DIFF: https://github.com/llvm/llvm-project/commit/2fbf18b40026b46bd380fae58575cebbd9801f

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbf18b40026: [clang] Fix aggregate initialization inside lambda constexpr (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.

[PATCH] D144454: Add builtin for llvm set rounding

rjmccall accepted this revision. rjmccall added a comment. I have no objection to doing the documentation in a separate patch. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454/new/ https://reviews.llvm.org/D144454 __

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf planned changes to this revision. AlexanderHederstaf added a comment. Missed right->left in the fix. Also looking a bit at comments, e.g. ns::/*ns2::*/vector v; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https:/

[clang-tools-extra] aa3e85a - [include-fixer] Add the missing optional header to the STL header list.

Author: Haojian Wu Date: 2023-03-06T10:34:53+01:00 New Revision: aa3e85a812a0d448ec8afd960ed4f17a4806261e URL: https://github.com/llvm/llvm-project/commit/aa3e85a812a0d448ec8afd960ed4f17a4806261e DIFF: https://github.com/llvm/llvm-project/commit/aa3e85a812a0d448ec8afd960ed4f17a4806261e.diff LO

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. > The install target for clang distributes the clangd static libs I don't think this was ever intended, looks like an accidental side-effect of using LLVM's many cmake macros. Can we fix this instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145302: [clangd] Add library for clangd main function

sammccall added a comment. IIUC we want to link some extra targets into the `clangd` binary in order to provide extra clang-tidy checks, but *don't* want to customize the binary further. (The latter can be useful, but this interface isn't sufficient for it). Can this be solved at the build-syst

[PATCH] D145346: [NFC] Format printstmt

zkkxu updated this revision to Diff 502557. zkkxu added a comment. 1. Updating D145346 : [NFC] Format printstmt # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intend

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://wg21.link/p1937 proposes that in unevaluated contexts, consteval functions should not be immediately evaluated.

[PATCH] D145228: [clangd] Add clangd headers to install targets

DmitryPolukhin added a comment. In D145228#4170792 , @sammccall wrote: >> The install target for clang distributes the clangd static libs > > I don't think this was ever intended, looks like an accidental side-effect of > using LLVM's many cmake macros.

[PATCH] D145346: [NFC] Format printstmt

zkkxu updated this revision to Diff 502559. zkkxu added a comment. 1. Updating D145346 : [NFC] Format printstmt # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intend

[PATCH] D145244: [clang-format] Add ability to trace tokens.

sammccall added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:289 Current.closesBlockOrBlockTypeList(Style))) { +DEBUG_FORMAT_TRACE_TOKEN(Current, "!canBreak"); return false; annotating all ex

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet and @nridge friendly ping could you please accept this diff or let me know if you would like to change anything here? I moved `addTargetAndModeForProgramName` after `SystemIncludeExtractor` as was suggested. Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] fa491fe - clang-tidy: Count template constructors in modernize-use-default-member-init

Author: MarcoFalke Date: 2023-03-06T11:04:38+01:00 New Revision: fa491fefb0f862b653b196eb61f0e690b0b71460 URL: https://github.com/llvm/llvm-project/commit/fa491fefb0f862b653b196eb61f0e690b0b71460 DIFF: https://github.com/llvm/llvm-project/commit/fa491fefb0f862b653b196eb61f0e690b0b71460.diff LO

[PATCH] D143375: clang-tidy: Count template constructors in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa491fefb0f8: clang-tidy: Count template constructors in modernize-use-default-member-init (authored by MarcoFalke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D145228: [clangd] Add clangd headers to install targets

sammccall added a comment. In D145228#4170826 , @DmitryPolukhin wrote: > In D145228#4170792 , @sammccall > wrote: > >>> The install target for clang distributes the clangd static libs >> >> I don't think this wa

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 502563. AlexanderHederstaf added a comment. This revision is now accepted and ready to land. Handle /*c*/ comments inside types. Add >> test to right->left. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145364 Files: clang-tools-extra/include-cleaner/lib

[PATCH] D145244: [clang-format] Add ability to trace tokens.

klimek added a comment. Answering the fundamental design question first. Comment at: clang/lib/Format/ContinuationIndenter.cpp:289 Current.closesBlockOrBlockTypeList(Style))) { +DEBUG_FORMAT_TRACE_TOKEN(Current, "!canBreak"); return

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/test/nocrash.cpp:1 +// RUN: clang-include-cleaner %s -- + I have considered to add a unittest in `FindHeadersTest`, but that is not trivial to do, the unittest is written based on the as

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added subscribers: aaron.ballman, vedgy. vedgy added a comment. I just verified that this patch fixes a KDevelop crash reported by several users. Thank you! @aaron.ballman, could you please review this fix? Comment at: clan

[PATCH] D145244: [clang-format] Add ability to trace tokens.

sammccall added a comment. Oops, sorry for the noise. I'd forgotten that we're really interested in *why* we reach the conclusion, not the conclusion itself - and that file/line are our proxy for "why" as writing/maintaining descriptions is a burden. Comment at: clang/lib/Fo

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3560 + * If a cursor that is not a bit field declaration is passed in, or if the bit + * field's width expression cannot be evaluated, -1 is returned. */ Append the following line to the com

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/61026 Repository: rG LLVM Github Monorep

[clang] 665e32e - [Sanitizers] Error out for -static-libsan on darwin

Author: usama hameed Date: 2023-03-06T16:08:26+05:00 New Revision: 665e32ee0ffd2b70c9066bebaaa6140dc0ca93f8 URL: https://github.com/llvm/llvm-project/commit/665e32ee0ffd2b70c9066bebaaa6140dc0ca93f8 DIFF: https://github.com/llvm/llvm-project/commit/665e32ee0ffd2b70c9066bebaaa6140dc0ca93f8.diff

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:251 +// cppreference symbol index page was missing these symbols. +// Remove them when the cppreference offline archive catches up. +SYMBOL(index_sequence, std::, ) -

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG665e32ee0ffd: [Sanitizers] Error out for -static-libsan on darwin (authored by usama54321). Changed prior to commit: https://reviews.llvm.org/D144672?vs=502474&id=502569#toc Repository: rG LLVM Githu

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { carlo.bertolli wrote: > What if you have something like this: > > v

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

labath added a comment. In D144181#4142295 , @Michael137 wrote: > We thought a bit about what it would take to link a constructor declaration > DIE to the various definitions (e.g., via a > `DW_AT_LLVM_complete_ctor_linkage_name` or `DW_AT_LLVM_complet

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. I have some more comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1556 + /// Generator for '#omp target data' + ///

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/include-cleaner/test/nocrash.cpp:1 +// RUN: clang-include-cleaner %s -- + hokein wrote: > I have considered t

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I might have been tempted to handle the comments in a separate commit, I don't like to do too much in one go or the review gets hard to manage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D145346: [NFC] Format printstmt

jrtc27 added a comment. This isn't NFC, the output changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145346/new/ https://reviews.llvm.org/D145346 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf requested review of this revision. AlexanderHederstaf added a comment. Refactored using the NonComment() functions and added some tests to verify that it works correctly. In D144709#4171029 , @MyDeveloperDay wrote: > I might have bee

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:252 +// Remove them when the cppreference offline archive catches up. +SYMBOL(index_sequence, std::, ) +SYMBOL(index_sequence_for, std::, ) there's also `integ

[clang-tools-extra] b2897ad - [include-cleaner] Fix a crash on non-identifier-name symbols.

Author: Haojian Wu Date: 2023-03-06T13:18:43+01:00 New Revision: b2897ad70301ae669328795eebc894d383d787c1 URL: https://github.com/llvm/llvm-project/commit/b2897ad70301ae669328795eebc894d383d787c1 DIFF: https://github.com/llvm/llvm-project/commit/b2897ad70301ae669328795eebc894d383d787c1.diff LO

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2897ad70301: [include-cleaner] Fix a crash on non-identifier-name symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145364/new/

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for this, LGTM (maybe we can cherry pick this to 16.0) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145344/new/ https://

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:252 +// Remove them when the cppreference offline archive catches up. +SYMBOL(index_sequence, std::, ) +SYMBOL(index_sequence_for, std::, ) kadircet wrote: > the

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:252 +// Remove them when the cppreference offline archive catches up. +SYMBOL(index_sequence,

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans created this revision. hans added reviewers: rsmith, ilya-biryukov. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. This follows 2b4fa53 which made Clang not emit destructor calls for such objects. However, they would still not get emitted

[PATCH] D145362: [clang] Update test according to P1937

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for cleaning that test up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145362/new/ https://reviews.llvm.org/D145

[clang] 7eb36f5 - [Tooling/Inclusion] Add missing index_sequence symbols.

Author: Haojian Wu Date: 2023-03-06T14:09:49+01:00 New Revision: 7eb36f5d87a67d1ab6df6085b7c5b35ed67cf766 URL: https://github.com/llvm/llvm-project/commit/7eb36f5d87a67d1ab6df6085b7c5b35ed67cf766 DIFF: https://github.com/llvm/llvm-project/commit/7eb36f5d87a67d1ab6df6085b7c5b35ed67cf766.diff LO

[PATCH] D145365: [Tooling/Inclusion] Add missing index_sequence symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb36f5d87a6: [Tooling/Inclusion] Add missing index_sequence symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145365/new/ https:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie added a comment. PTAL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added a comment. In D144903#4169623 , @ManuelJBrito wrote: > It seems the build failure was caused by a known crash > https://github.com/llvm/llvm-project/issues/55263. I tried to find some > workaround but unsuccessfully. @pengfei Do you kno

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

ymandel added a comment. In D144546#4167161 , @steakhal wrote: > By looking at the title, I get the impression that this fixes an assertion > violation. > I also observed that this commit is part of `main` but not part of > `release/16.x`, hence the `cl

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ I just thought how the new API cou

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added a comment. thanks, looks great! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:451 + tooling::HeaderIncludes HeaderIncludes(AST.tuPath(), Code, + tooling::IncludeStyle{}); + const SourceManager &SM = AST.getSourc

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

hans added a comment. Interesting! Do you have an example where this (local dllexport/import classes) comes up in practice? MSVC will also allow the following: namespace { struct __declspec(dllexport) T { void foo(); }; } whereas Clang will not, and I think Clang is making the ri

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 502607. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > > agozill

[PATCH] D145164: [clang][RISCV] Enable -fasynchronous-unwind-tables by default on Linux

asb added a subscriber: jobnoorman. asb added a comment. Funnily enough, @jobnoorman and I were just discussion something related to this, how `-fexceptions` doesn't seem to enable unwind tables as you'd expect. This change hides that issue in the common case you're targeting Linux, but I've fi

[PATCH] D142384: [C++20] Fix a crash with modules.

hans added a comment. I have no opinion about merging this, but I second the worry about not having a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 ___

[clang] 748a820 - [NFC] Disable test temporarily to investigate why it's failing on AIX

Author: Jake Egan Date: 2023-03-06T09:27:54-05:00 New Revision: 748a820d97dd6aecce9fc1416182dd22258cc489 URL: https://github.com/llvm/llvm-project/commit/748a820d97dd6aecce9fc1416182dd22258cc489 DIFF: https://github.com/llvm/llvm-project/commit/748a820d97dd6aecce9fc1416182dd22258cc489.diff LOG

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

erichkeane added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:46 + for (auto &AttrPlugin : getAttributePluginInstances()) { +for (auto &S : AttrPlugin->Spellings) + if (S.Syntax == Syntax && S.NormalizedFullName == Name) wanders wrote: >

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { koops wrote: > carlo.bertolli wrote: > > What if you have s

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. The changes look correct to me, but precommit CI isn't able to apply the patch cleanly to test. Can you rebase the patch so it applies so we can smoke test it before acceptance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy updated this revision to Diff 502632. vedgy edited the summary of this revision. vedgy added a comment. Clean rebase on main branch where the base revision D143415 has already landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 502646. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Basic/TokenKinds.def clang/include/clang/Interp

[PATCH] D145141: [Driver] Reject -march= for ppc

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. I am perfectly fine with this. That option is quite problematic. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145141/new/ https://rev

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen updated this revision to Diff 502649. sdesmalen added a comment. - Added assert to check that NumVectors=1 for svcount_t. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136864/new/ https://reviews.llvm.org/D136864 Files: clang/include/c

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 updated this revision to Diff 502660. 0xdc03 added a comment. - Reword the diagnostic messages - Refactor tests to match updated diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 Files:

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Not thrilled about 'mangled name' still, but I can't think of anything better after all this time, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I'm happy with this but agree that "what might be a system path?" is a tricky heuristic. What we want is to exclude the places that the application will search anyway, but th

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. Okay, I have now modified the diagnostic to look like this: ../bug/ifunc-#59164.cpp:17:16: error: ifunc must point to a defined function __attribute__((ifunc("resolver"))) ^ ../bug/ifunc-#59164.cpp:17:16: note: the function specified in an ifunc must

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. In D143803#4171728 , @erichkeane wrote: > Not thrilled about 'mangled name' still, but I can't think of anything better > after all this time, so LGTM. Oh wow your reply was much faster than I expected 😅. If you can, please land

[PATCH] D145391: [HIP] Supports env var HIP_PATH

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Currently HIP toolchain recognize env var ROCM_PATH and option --rocm-path but

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

steakhal added a comment. In D144546#4171238 , @ymandel wrote: > In D144546#4167161 , @steakhal > wrote: > >> By looking at the title, I get the impression that this fixes an assertion >> violation. >> I also ob

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

steakhal added a comment. FYI the release schedule is here: https://llvm.org/docs/HowToReleaseLLVM.html#annual-release-schedule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144546/new/ https://reviews.llvm.org/D144546 ___

[PATCH] D145362: [clang] Update test according to P1937

shafik accepted this revision. shafik added a comment. Besides the nitpick, LGTM Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14 -// bad_assert_copyable is not needed for constant evaluation -// (and thus not instantiated) +// consteval assert is not instantiated as w

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502670. TIFitis marked 9 inline comments as done. TIFitis added a comment. Adrresed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > Can't the presence/

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. yaxunl requested review of this revision. HIP runtime is the language runtime of HIP. When users need to specify rpath, they usually need to specify rpath

[clang] 9306ef9 - [clang][alias|ifunc]: Add a diagnostic for mangled names

Author: Dhruv Chawla Date: 2023-03-06T08:59:02-08:00 New Revision: 9306ef9750b7a319d59f6d3e4977e01e39b8f161 URL: https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161 DIFF: https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161.diff

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9306ef9750b7: [clang][alias|ifunc]: Add a diagnostic for mangled names (authored by 0xdc03, committed by erichkeane). Changed prior to commit: htt

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU line marker directives are not recognis

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502683. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Herald added a project: clang-tools-extra. Fixed a couple of things causing failures in clangd tests (path being

[clang] 7370b9c - [Driver] Reject -march= for ppc

Author: Fangrui Song Date: 2023-03-06T09:16:57-08:00 New Revision: 7370b9c8ea0049f103daae0126861ba4f6ff6f4a URL: https://github.com/llvm/llvm-project/commit/7370b9c8ea0049f103daae0126861ba4f6ff6f4a DIFF: https://github.com/llvm/llvm-project/commit/7370b9c8ea0049f103daae0126861ba4f6ff6f4a.diff

[PATCH] D145141: [Driver] Reject -march= for ppc

This revision was automatically updated to reflect the committed changes. Closed by commit rG7370b9c8ea00: [Driver] Reject -march= for ppc (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D145141?vs=501759&id=502686#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. This does not seem to be a pressing issue as there are no other reported module/cpp20 related crashes which were fixed by this. Also since it has no tests, it should be fine to postpone it to the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. In D144654#4156430 , @aaron.ballman wrote: > This seems to cause precommit CI failures that should be addressed, and it > should also have a release note about the fix. Failures in CI should be fixed by D145397

[PATCH] D143704: [flang] Part one of Feature List action

elmcdonough updated this revision to Diff 502691. elmcdonough retitled this revision from "[Flang] Part one of Feature List action" to "[flang] Part one of Feature List action". elmcdonough added a comment. Allow for plugin to parse semantically incorrect files. Repository: rG LLVM Github Mon

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502693. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/Cla

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah added a comment. Please could you add tests for the flag forwarding logic in flang/tests/Driver/frontend-forwarding.f90. For example see https://reviews.llvm.org/rGd0d4b635786d510cd919cadbeb7e5e19983242cf Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg *loop

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > > agozil

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { carlo.bertolli wrote: > koops wrote: > > carlo.bertolli wro

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

cor3ntin added a comment. I think this make sense. Maybe we should add a comment quoting [expr.const] p15.1 in both places though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/ https://reviews.llvm.org/D145251 _

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `(DRE.data() + any)`

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1079 +dyn_cast(ArraySub->getBase()->IgnoreImpCasts())) { + // FIXME: this `getASTContext` call is costy, we should pass the + // ASTContext in: Nit: "costly

[clang] c4de9b9 - [clang][deps] Un-XFAIL test on AIX

Author: Jan Svoboda Date: 2023-03-06T10:57:43-08:00 New Revision: c4de9b9c021d14972157096514d17692f15fbb15 URL: https://github.com/llvm/llvm-project/commit/c4de9b9c021d14972157096514d17692f15fbb15 DIFF: https://github.com/llvm/llvm-project/commit/c4de9b9c021d14972157096514d17692f15fbb15.diff L

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM, Comment at: clang/include/clang/Driver/Options.td:4257 + HelpText<"Add -rpath with architecture-specific resource directory to the linker flags. " + "When --hip-link is sp

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

kubamracek added a comment. @kcc Any takes from you on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

MaskRay added a comment. Seems fine. Should we eventually remove `--offload-add-rpath` and `-fopenmp-implicit-rpath`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145393/new/ https://reviews.llvm.org/D145393 ___ cfe-commits mailing list cfe

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, shafik, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This addresses an issue found by WG21 and tracked by CWG2699 (which is not yet pu

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 + `#61177 `_ in anticipation + of `CWG2699 _` being accepted by WG21. This link seems broken? I get 40

  1   2   >