tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM, ================ Comment at: clang/include/clang/Driver/Options.td:4257 + HelpText<"Add -rpath with architecture-specific resource directory to the linker flags. " + "When --hip-link is specified, also add -rpath with HIP runtime library directory to the linker flags">; def fno_rtlib_add_rpath: Flag<["-"], "fno-rtlib-add-rpath">, Flags<[NoArgumentUnused]>, ---------------- I'm not sure these HIP-specific details are needed here. It may be better to generalize the generic description along the lines of "adds required architecture-specific directories to RPATH". ================ Comment at: clang/test/Driver/hip-runtime-libs-linux.hip:16 // RUN: %clang -### --hip-link --target=x86_64-linux-gnu \ -// RUN: --rocm-path=%S/Inputs/rocm %t.o --offload-add-rpath 2>&1 \ +// RUN: --rocm-path=%S/Inputs/rocm %t.o -frtlib-add-rpath 2>&1 \ // RUN: | FileCheck -check-prefixes=ROCM-RPATH %s ---------------- I think you may still want to test with `--offload-add-rpath`, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145393/new/ https://reviews.llvm.org/D145393 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
