[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6a8d52d645: [clang-tidy] improve readability-identifier-naming hungarian options test (authored by amurzeau, committed by PiotrZSL). Repository:

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a subscriber: reames. leonardchan added a comment. @reames let's continue the discussion here. What specific bits with the optimizer does this break? I'm not too familiar with SVEC. Prior to this, one thing I tried was instead just doing `Ops.push_back(GA)` and `getSCEV(GA)` bu

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

erichkeane added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; This patch seems to cause a self-build Werror regression. The

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500264. mysterymath marked an inline comment as done. mysterymath added a comment. Update condition; move release note to AVR section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://revie

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43-45 +- The definition of ``USHRT_MAX`` in the freestanding no longer + overflows on AVR (where ``sizeof(unsigned int) == sizeof(unsigned short)``). + The type of ``USHRT_MAX`` on AVR is now ``unsi

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. I'm not sure if I can run clang targetting AArch64 on an X86 machine but I tried it regardless and I get compiler errors on startup, so I can't debug this issue at the moment. Besided that I don't know why it times out on that buildbot. The build job that is performe

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

aganea added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; erichkeane wrote: > This patch seems to cause a self-build Werror

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

erichkeane added a comment. In D135495#4151238 , @isuckatcs wrote: > I'm not sure if I can run clang targetting AArch64 on an X86 machine but I > tried it regardless and I get compiler errors on startup, so I can't debug > this issue at the moment. > B

[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

erichkeane added inline comments. Comment at: llvm/lib/Support/Windows/Signals.inc:834 + int RetCode = (int)EP->ExceptionRecord->ExceptionCode; + if (RetCode == (0xE000 | EX_IOERR)) +return; aganea wrote: > erichkeane wrote: > > This patch seems to caus

[PATCH] D143560: clang-format.el: fix warnings

HazardyKnusperkeks added a comment. In D143560#4149733 , @phst wrote: > I'm not super familiar with the process either, but IIRC @sammccall or > @djasper have to merge this. Anyone with commit access can do that. In D143560#4147918

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:77 +void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) { + + auto AllowedNamedExceptionDecl = Excessive newline. Comment at:

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

thetruestblue added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} Can you explain the motivation here? RTAsan_static o

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169 +should be provided. If an exception type name in the list is caught in an +empty catch statement, no warning will be raised. Default value: `` (empty). ---

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169 +should be provided. If an exception type name in the list is caught in an +empty catch statement, no warning will be raised. Default value: `` (empty

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5251 + if (Args.hasFlag(options::OPT_mroptr, options::OPT_mno_roptr, false)

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan abandoned this revision. leonardchan added a comment. This was landed in https://reviews.llvm.org/rG4308166403b4c28b6db7094a4e202e42da6e28a8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589 __

[PATCH] D144748: [clang-tidy] Add bugprone-empty-catch check

PiotrZSL updated this revision to Diff 500274. PiotrZSL added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144748/new/ https://reviews.llvm.org/D144748 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModu

[clang] 44b391f - LanguageExtensions.rst: fix a typo in the `#pragma clang deprecated` example

Author: Fangrui Song Date: 2023-02-24T12:41:49-08:00 New Revision: 44b391fc473c3ea8ce5d6cefeac6c781060b398f URL: https://github.com/llvm/llvm-project/commit/44b391fc473c3ea8ce5d6cefeac6c781060b398f DIFF: https://github.com/llvm/llvm-project/commit/44b391fc473c3ea8ce5d6cefeac6c781060b398f.diff

[PATCH] D144709: [clang-format] Improve west to east const

HazardyKnusperkeks added a comment. In D144709#4149737 , @AlexanderHederstaf wrote: > I tried to refactor QualifierAlignmentFixer to handle more types, notably > removing the *,&,&& requirement as e.g. const Foo did not work. To avoid > moving qualifie

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { jhuber6 wrote: > Why does this handling need to be d

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { doru1004 wrote: > jhuber6 wrote: > > Why does this ha

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { jhuber6 wrote: > doru1004 wrote: > > jhuber6 wrote:

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 500298. qiongsiwu1 added a comment. > This accepts -mno-roptr for other platforms despite having no semantic > functionality (e.g., it does not move variables to a different section for > ELF codegen). Thanks for catching this @hubert.reinterpretcast !!

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

jhuber6 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2274 + if (!IsByRef) { +if ((Ctx.getTargetInfo().getTriple().isAMDGCN()) || +(Ctx.getTargetInfo().getTriple().isNVPTX())) { doru1004 wrote: > jhuber6 wrote: > > doru1004 wrote:

[PATCH] D140925: [CMake] Use Clang to infer the target triple

smeenai added a comment. Ping @ldionne, would you be able to take a look at this soon (or are you okay waiving the libc++ blocking requirement for it)? This is really useful for Android armv7, where the triple is traditionally spelled armv7-none-linux-androideabi but normalized to arvm7-none-li

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 500299. isuckatcs added a comment. Fixed the timed out test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tid

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. > As long as you don't need the library (which, if you have a preprocessed file > or a test, should absolutely not be necessary), you can just do the -cc1 > option of -triple , or the non- -cc1 option of -target . > > Both use basically the same options list, and that

[PATCH] D140925: [CMake] Use Clang to infer the target triple

MaskRay added a comment. In D140925#4151524 , @smeenai wrote: > Ping @ldionne, would you be able to take a look at this soon (or are you okay > waiving the libc++ blocking requirement for it)? This is really useful for > Android armv7, where the triple

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a comment. > Highlight by me. That is not acceptable, running the output of `clang-format` > through `clang-format` shall not result in any change. In that case it's > better to not touch it in any way. That is no longer an issue in the latest patch. Repository: rG

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1.cpp:204 +#if __cplusplus == 201703L + // cxx17-error@-3 {{non-type template argument refers to subobject '(int *)1'}} +#endif Shouldn't this be an error b/c it is a tempo

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CodeGenCXX/template-arguments.cpp:4 + +template CONSTEXPR T id(T v) { return v; } +template auto value = id(V); I don't see any tests covering unions or enums. Comment at: clang/test/SemaTemp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:88 +/// so cannot be dependent. +UncommonValue, + erichkeane wrote: > I definitely hate the name here... Just `Value` makes a bit more sense, but > isn't perfectly accurate.

[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

galapoz1996 added a comment. Herald added a subscriber: mgehre. Herald added a project: All. Indeed, I recognize that completely. I had a small business nearby as well, and within a year, several of my neighbors started doing the same. Hence, our town has grown considerably. Nevertheless, since

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

kstoimenov added inline comments. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} thetruestblue wrote: > Can you explain the motivation here? > > RTAsan_static object

[clang] 8709bca - clang: Add __builtin_elementwise_fma

Author: Matt Arsenault Date: 2023-02-24T21:55:08-04:00 New Revision: 8709bcacfb3a06847b47bb6b47e8556db43f3a43 URL: https://github.com/llvm/llvm-project/commit/8709bcacfb3a06847b47bb6b47e8556db43f3a43 DIFF: https://github.com/llvm/llvm-project/commit/8709bcacfb3a06847b47bb6b47e8556db43f3a43.diff

[PATCH] D140992: clang: Add __builtin_elementwise_fma

arsenm closed this revision. arsenm added a comment. 8709bcacfb3a06847b47bb6b47e8556db43f3a43 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140992/new/ https://reviews.llvm.org/D140992 __

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

galapoz1996 added a comment. Herald added subscribers: steakhal, MaskRay. Herald added a reviewer: NoQ. Herald added a project: All. I used to think that therapy was only for people with "real" problems, but I couldn't have been more wrong. Seeking help for my anxiety and depression has been one

[PATCH] D144772: [Sema] Use isSVESizelessBuiltinType instead of isSizelessBuiltinType to prevent crashing on RISC-V.

craig.topper created this revision. craig.topper added reviewers: reames, asb, kito-cheng, eopXD, c-rhodes, frasercrmck, rogfer01. Herald added subscribers: luke, VincentWu, ctetreau, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edwa

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

brad created this revision. brad added reviewers: dim, emaste. brad added a project: clang. Herald added subscribers: krytarowski, arichardson. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. With the last diff as I was simplifying some bits

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

nridge updated this revision to Diff 500087. nridge added a comment. use Constant rather than Variable for object-like macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 Files: clang-tools-extra/cla

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149516 , @craig.topper wrote: > Can you outline your full plan and why you want to do this. We need to see > the bigger picture. In D144696#4149545 , @ym1813382441 w

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. In D144696#4149545 , @ym1813382441 wrote: > F26630797: Screenshot from 2023-02-24 15-54-21.png > I meant what extensions are you planning to support multiple versions for and why? How

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

uabelho added a comment. Hello, I noticed that if I compile the compiler with ubsan, then lots of Clangd tests start failing with this patch: Failed Tests (165): Clangd :: ast-no-range.test Clangd :: ast.test Clangd :: call-hierarchy.test Clangd :: check-lines.test Clangd

[PATCH] D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144646/new/ https://reviews.llvm.org/D144646

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149560 , @craig.topper wrote: > In D144696#4149545 , @ym1813382441 > wrote: > >> F26630797: Screenshot from 2023-02-24 15-54-21.png >>

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske added a comment. Probably we can add a new function `ASTContext::getVaListTagDeclIfExists` that does not create declarations if these do not exist. These new mentioned test cases would probably fail, but with a new non-modifying get function it can work. Repository: rG LLVM Github

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

pcwang-thead added a comment. > My intention is to support RVV0.71, since specific cpu's exist for the > XuanTie C900 series. In LLVM use Feature to distinguish between different > versions of extensions. I am considering how to solve this problem, using > multiple `.td` files in the worst case

[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, dblaikie, Bigcheese. ChuanqiXu added a project: clang-modules. Herald added a subscriber: jvesely. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D144708: [clangd] Fix UB in scanPreamble

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. getMemBufferCop

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added a comment. In D142890#4149181 , @vitalybuka wrote: > One of your patches likely introduced UB > https://lab.llvm.org/buildbot/#/builders/85/builds/14558 > Can you please take a look? Thanks a lot Vitaly and sorry for not noticing this my

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added a comment. thanks for the ping! see the discussion in https://reviews.llvm.org/D142890#4149679 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ https://reviews.llvm.org/D143096 _

[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

ChuanqiXu added a comment. For example, the issue (https://github.com/llvm/llvm-project/issues/60085) disappears after we change the eagerly loading to lazily loading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144707/new/ https://reviews.llvm.

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. How much of the existing vector code in the backend including tablegen can be reused for 0.71? How much of the intrinsic interface can be used? If we’re talking about completely duplicating everything it is very unlikely we can accept it. RISCVGenDAGISel.inc, for e

[PATCH] D144708: [clangd] Fix UB in scanPreamble

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:351 auto PreambleContents = - llvm::MemoryBuffer::getMemBufferCopy(Contents.substr(0, Bounds.Size)); + llvm

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf created this revision. Herald added a project: All. AlexanderHederstaf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Qualifiers were not moved for non-pointer non-simple types. Remove the requirement for *,&,&& and

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks an improvement to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 ___

[PATCH] D143560: clang-format.el: fix warnings

phst added a comment. I'm not super familiar with the process either, but IIRC @sammccall or @djasper have to merge this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a reviewer: MyDeveloperDay. AlexanderHederstaf added a comment. I tried to refactor QualifierAlignmentFixer to handle more types, notably removing the *,&,&& requirement as e.g. const Foo did not work. To avoid moving qualifiers too far, a test for "already east const" i

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

asb added a comment. @ym1813382441 thanks for the contribution. In many cases, this kind of incremental and tightly focused patch is a good way to start things. But in this case, there's a few bigger issues. - As has been pointed out, the discussion about supporting multiple ISA versions has b

[PATCH] D144708: [clangd] Fix UB in scanPreamble

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:351 auto PreambleContents = - llvm::MemoryBuffer::getMemBufferCopy(Contents.substr(0, Bounds.Size)); + llvm::MemoryBuffer::getMemBufferCopy(PI

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149706 , @craig.topper wrote: > How much of the existing vector code in the backend including tablegen can be > reused for 0.71? How much of the intrinsic interface can be used? If we’re > talking about complet

[clang-tools-extra] c4972d3 - [clangd] Avoid using CompletionItemKind.Text for macro completions

Author: Nathan Ridge Date: 2023-02-24T04:41:27-05:00 New Revision: c4972d37290ff5ab1228ecfc7280bc07a9280f92 URL: https://github.com/llvm/llvm-project/commit/c4972d37290ff5ab1228ecfc7280bc07a9280f92 DIFF: https://github.com/llvm/llvm-project/commit/c4972d37290ff5ab1228ecfc7280bc07a9280f92.diff

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4972d37290f: [clangd] Avoid using CompletionItemKind.Text for macro completions (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/n

[clang-tools-extra] f393e1f - [clangd] Fix UB in scanPreamble

Author: Kadir Cetinkaya Date: 2023-02-24T10:43:12+01:00 New Revision: f393e1f6b3b42e8f355e64e2fb479c571ab939bc URL: https://github.com/llvm/llvm-project/commit/f393e1f6b3b42e8f355e64e2fb479c571ab939bc DIFF: https://github.com/llvm/llvm-project/commit/f393e1f6b3b42e8f355e64e2fb479c571ab939bc.dif

[PATCH] D144708: [clangd] Fix UB in scanPreamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGf393e1f6b3b4: [clangd] Fix UB in scanPreamble (authored by kadircet). Changed prior to commit: https://

[clang] 385c8cd - [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

Author: Kadir Cetinkaya Date: 2023-02-24T10:44:33+01:00 New Revision: 385c8cd3cd66052dee2dff01bfdbeb258191f2ff URL: https://github.com/llvm/llvm-project/commit/385c8cd3cd66052dee2dff01bfdbeb258191f2ff DIFF: https://github.com/llvm/llvm-project/commit/385c8cd3cd66052dee2dff01bfdbeb258191f2ff.dif

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

pcwang-thead added a comment. In D144696#4149706 , @craig.topper wrote: > How much of the existing vector code in the backend including tablegen can be > reused for 0.71? How much of the intrinsic interface can be used? If we’re > talking about complet

[PATCH] D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG385c8cd3cd66: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t (authored by kadircet). Repository: rG LLVM Github M

[clang] e6e753d - [clang][dataflow] Fix wrong assert for CXXConstructExpr

Author: Paul Semel Date: 2023-02-24T09:51:10Z New Revision: e6e753d173db14bb1273db65387dec696b7d7a48 URL: https://github.com/llvm/llvm-project/commit/e6e753d173db14bb1273db65387dec696b7d7a48 DIFF: https://github.com/llvm/llvm-project/commit/e6e753d173db14bb1273db65387dec696b7d7a48.diff LOG: [c

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6e753d173db: [clang][dataflow] Fix wrong assert for CXXConstructExpr (authored by paulsemel). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 500117. cor3ntin marked 18 inline comments as done. cor3ntin added a comment. Address Shafik's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clan

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500121. klimek marked 6 inline comments as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/includ

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22584 + Style.Macros.push_back("CALL(x)=f([] { x })"); + Style.Macros.push_back("ASSIGN_OR_RETURN(a, b, c)=a = (b) || (c)"); + sammccall wrote: > klimek wrote: > > sammccall wrote:

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:242 +// Macros +SYMBOL(NULL, , ) +SYMBOL(NULL, , ) we use `None` for global namespace rather than leaving empty. let's keep it that way? Repository: rG LL

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

hokein updated this revision to Diff 500126. hokein added a comment. oops, fix the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.in

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. @balazske Thanks for clarifying the side effects of the current solution and I support creating that side-effect-free getter function -- it sounds to be a good solution for this problem. One minor doubt: I can theoretically imagine the case when the TU object doesn't

[PATCH] D144709: [clang-format] Improve west to east const

MyDeveloperDay added a comment. Can you please add unit tests for the cases you added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 ___ cfe-commits mailing li

[clang] c86f05d - [Tooling/Inclusion] Add the missing NULL symbol to the table.

Author: Haojian Wu Date: 2023-02-24T12:59:52+01:00 New Revision: c86f05dd48d2efc5d1bb7c9962ba331653311795 URL: https://github.com/llvm/llvm-project/commit/c86f05dd48d2efc5d1bb7c9962ba331653311795 DIFF: https://github.com/llvm/llvm-project/commit/c86f05dd48d2efc5d1bb7c9962ba331653311795.diff LO

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table. (authored by hokein). Repositor

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added subscribers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. MyDeveloperDay added a comment. I'm one of the code owners for clang-format, but I'm not an emacs user (don't hate me..), honestly I don't think you'll get a response from anyone others than the clang-format

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added a comment. please mark the comments as done when you've addressed them CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! The overloading impl is a little surprising to me. I was assuming that object would always win over function (or that it would be disallowed to combine the two). I think that is s

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/60964 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144721

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a comment. I will add new tests / examples as well as look into the volatile/const ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 _

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added a comment. thanks! looks amazing, we're missing a little bit of test coverage though Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:280 +bool isFilteredByConfig(const Config &Cfg, llvm::StringRef HeaderSpelling) { + // Convert the path to Unix slashes

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

kadircet added a comment. this fixes the `abs` in the mentioned issue, but leaves the friends out :( those are specifically `std::labs, std::llabs, std::imaxabs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144721/new/ https://reviews.llvm.org/D1

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

hokein added a comment. In D144721#4150122 , @kadircet wrote: > this fixes the `abs` in the mentioned issue, but leaves the friends out :( > those are specifically `std::labs, std::llabs, std::imaxabs` These symbols are already covered in the generated

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oh right, i thought these were also provided by multiple headers, but looks like they're only provided by `cstdlib`, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] 6b0cf1e - [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

Author: isuckatcs Date: 2023-02-24T13:46:47+01:00 New Revision: 6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf URL: https://github.com/llvm/llvm-project/commit/6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf DIFF: https://github.com/llvm/llvm-project/commit/6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf.diff LOG

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0cf1e15f8f: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer` (authored by isuckatcs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/ne

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @rupprecht Great to hear! Sorry again for the disruption @shafik Thanks for the review! Comment at: clang/lib/Sema/SemaLambda.cpp:1010 + + // C++11 [expr.prim.lambda]p5: + // The closure type for a lambda-expression has a public inline function --

[clang] 4416e4a - [Tooling/Inclusion] Add the generic abs symbol to the table.

Author: Haojian Wu Date: 2023-02-24T13:56:00+01:00 New Revision: 4416e4a9ed0666cbeb3d34f43337d7205c09521a URL: https://github.com/llvm/llvm-project/commit/4416e4a9ed0666cbeb3d34f43337d7205c09521a DIFF: https://github.com/llvm/llvm-project/commit/4416e4a9ed0666cbeb3d34f43337d7205c09521a.diff LO

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4416e4a9ed06: [Tooling/Inclusion] Add the generic abs symbol to the table. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144684/new/ https://reviews.llvm.org/D144684 ___ cfe

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman added reviewers: jyknight, clang-language-wg. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43-45 +- The definition of ``USHRT_MAX`` in the freestanding no longer + overflows on AVR (where ``sizeof(unsigned int) == sizeof(unsigne

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 500149. ManuelJBrito added a comment. Update tests after D143593 . There are some performance regressions with casts from 128 to 512. The backend inserts vinsertf instructions. So that as to be fixed. In D130339

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a comment. In D143524#4148024 , @v.g.vassilev wrote: > Indeed the warning is noisy but it will potentially fix broken code which > were unable to diagnose before. Especially that in some cases where static > templates in header file

  1   2   >