[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

thesamesam created this revision. thesamesam added a reviewer: aaron.ballman. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is for 16.x. Bug: https://github.com/llvm/llvm-project/issues/59792

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. @jmmartinez thank you for looking at this! Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, Alig

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. Hi Petr, In LLVM Embedded Toolchain for Arm we put libclang_rt in the regular library directory, not the resource dir. Therefore `-resource-dir` has no effect for us. Instead of this change, I could have added a `--sysroot` argument to each test, but this change

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. I'm happy to revert this and add `--sysroot` if you prefer. That would fit with keeping the tests hermetic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 __

[clang] 8498ba6 - [clang] Add the check of membership for the issue #58674 and improve the lookup process

Author: Liming Liu Date: 2023-02-22T16:43:50+08:00 New Revision: 8498ba6c2860c838183f9951b63df26ab5f02265 URL: https://github.com/llvm/llvm-project/commit/8498ba6c2860c838183f9951b63df26ab5f02265 DIFF: https://github.com/llvm/llvm-project/commit/8498ba6c2860c838183f9951b63df26ab5f02265.diff LO

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8498ba6c2860: [clang] Add the check of membership for the issue #58674 and improve the lookup… (authored by lime). Repository: rG LLVM Github Mono

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/TokenLexer.cpp:1029 + // Including Limit will not mischeck for across-file-id tokens + // because SourceManager allocates FileSi

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

phosek added a comment. In D143666#4143702 , @michaelplatings wrote: > I'm happy to revert this and add `--sysroot` if you prefer. That would fit > with keeping the tests hermetic. That would be my preference and it would match what we do in other Clan

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifying --sysroot prevents libclang_rt from being located in st

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

michaelplatings added a comment. https://reviews.llvm.org/D144542 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:101 + IgnoreComparisonForTypesRegexp( + Options.get("IgnoreComparisonForTypesRegexp", "^::std::array")) {} + carlosgalvezp wrote: > I a

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144542/new/ https://reviews.llvm.org/D144542

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein updated this revision to Diff 499405. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144054/new/ https://reviews.llvm.org/D144054 Files: clang/lib/Lex/Token

[clang] 341dd60 - [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

Author: Haojian Wu Date: 2023-02-22T10:16:02+01:00 New Revision: 341dd6076b123946f79a3148b660d6579f9683a7 URL: https://github.com/llvm/llvm-project/commit/341dd6076b123946f79a3148b660d6579f9683a7 DIFF: https://github.com/llvm/llvm-project/commit/341dd6076b123946f79a3148b660d6579f9683a7.diff LO

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG341dd6076b12: [Lex] Fix a crash in updateConsecutiveMacroArgTokens. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 67e28a3 - [Clang] Improve hermeticity of clang_rt tests

Author: Michael Platings Date: 2023-02-22T09:23:10Z New Revision: 67e28a3010e1852ec670cf5346fd171bf2a16774 URL: https://github.com/llvm/llvm-project/commit/67e28a3010e1852ec670cf5346fd171bf2a16774 DIFF: https://github.com/llvm/llvm-project/commit/67e28a3010e1852ec670cf5346fd171bf2a16774.diff L

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e28a3010e1: [Clang] Improve hermeticity of clang_rt tests (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 850dab0 - [NFC] Class for building MultilibSet

Author: Michael Platings Date: 2023-02-22T09:24:48Z New Revision: 850dab0f2537bb31103578fc35caef2f1ad98f04 URL: https://github.com/llvm/llvm-project/commit/850dab0f2537bb31103578fc35caef2f1ad98f04 DIFF: https://github.com/llvm/llvm-project/commit/850dab0f2537bb31103578fc35caef2f1ad98f04.diff L

[PATCH] D142893: [NFC] Class for building MultilibSet

This revision was automatically updated to reflect the committed changes. michaelplatings marked 4 inline comments as done. Closed by commit rG850dab0f2537: [NFC] Class for building MultilibSet (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield added a comment. I don't know how this configuration file works. Running clang from the build directory is useful when developing, but to avoid user facing regression we'd need it to run from the install directory. The use case is someone builds trunk or a release on a HPC machi

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 499416. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://review

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 499417. zyounan added a comment. Move parsing logic to Record.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. Overall not bad, except reported things, I don't have any complains. Number of options is not an issue. 90% of users wont use them, 10% will be happy to find them instead of dealing with NOLINT. Comment at: clang-tools-extra/clang-tidy/cppcoreguideli

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin updated this revision to Diff 499433. DmitryPolukhin added a comment. Move call addTargetAndModeForProgramName after SystemIncludeExtractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 F

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 499436. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) kadircet wrote: > nit: >

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. Note that the Debian x64 test failure is from the unit test TEST(ClangdServer, MemoryUsageTest) { MockFS FS; MockCompilationDatabase CDB; ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); auto FooCpp = testPath("foo.cpp"); Server.addDo

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 499443. michaelplatings added a subscriber: peter.smith. michaelplatings added a comment. - Squash D143763 into this change as suggested by @MaskRay - Use PascalCase field names as requested by @phosek - Applied impr

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

michaelplatings abandoned this revision. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Squashed into D142932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143763/new/ https://r

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 499450. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces and blank lines as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but we should add a release note for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143891/new/ https://reviews.ll

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) VitaNuo wrote: > kadircet wrote: > > nit: >

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144540/new/ https://reviews.llvm.org/D144540

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 499453. isuckatcs added a comment. Added tests for function pointers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs added a comment. @xazax.hun can we merge this or should we wait for someone else's approval too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 499456. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) kad

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks (both for the patch and for bearing with me)! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143

[PATCH] D144484: [Tooling/Inclusion] Handle std::get symbol.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144484/new/ https://reviews.llvm.org/D144484

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield added a comment. So what is this configuration file? Joseph found a Gentoo blog post https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config-file/ and I don't have a clang.cfg file in my install dir Repository: rG LLVM Github Monorepo

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499479. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply changes requested by @peter.smith and @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:14 +// RUN: | FileCheck %s +// CHECK: "{{.*}}clang{{.*}}" "-cc1" "-triple" "thumbv8m.main-none-unknown-eabihf" +// CHECK-SAME: "-internal-isystem" "{{.*}}/baremetal_multilib/bin/../lib

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:4218-4223 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", LangOpts<"OpenMP">, - DefaultTrue, + DefaultFalse, PosFlag, NegFlag, BothFlags<[NoArgumentUnused]>>;

[clang-tools-extra] 7177a23 - [clangd] Add config option for fast diagnostics mode

Author: Kadir Cetinkaya Date: 2023-02-22T15:54:14+01:00 New Revision: 7177a237b68f32befcecedba78a875f1bbc4a609 URL: https://github.com/llvm/llvm-project/commit/7177a237b68f32befcecedba78a875f1bbc4a609 DIFF: https://github.com/llvm/llvm-project/commit/7177a237b68f32befcecedba78a875f1bbc4a609.dif

[clang-tools-extra] 75ae784 - [clangd] #undef macros inside preamble patch

Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 75ae784e8f49cf2425f3bf702a1bbf6c581e721a URL: https://github.com/llvm/llvm-project/commit/75ae784e8f49cf2425f3bf702a1bbf6c581e721a DIFF: https://github.com/llvm/llvm-project/commit/75ae784e8f49cf2425f3bf702a1bbf6c581e721a.dif

[clang-tools-extra] 909cd1f - [clangd] Respect preamble-patch when handling diags

Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 909cd1f9a8934033a803659da8c54c87013941ef URL: https://github.com/llvm/llvm-project/commit/909cd1f9a8934033a803659da8c54c87013941ef DIFF: https://github.com/llvm/llvm-project/commit/909cd1f9a8934033a803659da8c54c87013941ef.dif

[clang-tools-extra] 8c2a12f - [clangd] Provide patched diagnostics with preamble patch

Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 8c2a12f7f9b6dc078bfb18df979fdf27c6a3 URL: https://github.com/llvm/llvm-project/commit/8c2a12f7f9b6dc078bfb18df979fdf27c6a3 DIFF: https://github.com/llvm/llvm-project/commit/8c2a12f7f9b6dc078bfb18df979fdf27c6a3.dif

[clang-tools-extra] 465ee9b - [clangd] Publish diagnostics with stale preambles

Author: Kadir Cetinkaya Date: 2023-02-22T15:54:16+01:00 New Revision: 465ee9bfb26d46f2732d8b238dcbadc38373dbb3 URL: https://github.com/llvm/llvm-project/commit/465ee9bfb26d46f2732d8b238dcbadc38373dbb3 DIFF: https://github.com/llvm/llvm-project/commit/465ee9bfb26d46f2732d8b238dcbadc38373dbb3.dif

[PATCH] D143093: [clangd] #undef macros inside preamble patch

This revision was automatically updated to reflect the committed changes. Closed by commit rG75ae784e8f49: [clangd] #undef macros inside preamble patch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143093/new/ https://reviews

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG7177a237b68f: [clangd] Add config option for fast diagnostics mode (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D142890?vs=495889&

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

This revision was automatically updated to reflect the committed changes. Closed by commit rG909cd1f9a893: [clangd] Respect preamble-patch when handling diags (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143095/new/ https://

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2a12f7f9b6: [clangd] Provide patched diagnostics with preamble patch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ htt

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG465ee9bfb26d: [clangd] Publish diagnostics with stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan @clementval can you please take a look and let me know if any more changes are required for this patch? Thanks, Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Please add tests for the MLIR portion. Could you also post the full LLVM IR for a construct with the map clause? Comment at: llvm/lib/Fronten

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499491. michaelplatings added a comment. Rebase and remove some braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/Ba

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. Marking this as "no" because as far as I can tell it'll stop anyone running openmp built from source which constitutes a severe regression and I am struggling to fi

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 499500. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ ht

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

jdoerfert added a comment. I'm worried this makes use of LLVM on HPC machines even harder. That said, I'm open to suggestions and I am not well versed in all the ways we can make it work. Our problem is that there are N `libomptarget.so` files and N `libomptarget.nvptx.so` files on a system, in

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

jolanta.jensen updated this revision to Diff 499502. jolanta.jensen added a comment. Adjusting the test for Windows OS again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files: clang/include/clang/C

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499503. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I guess this is fine. We should try to run V&V tests, this is really just checking if we generate (some) code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

Szelethus added a comment. Ugh, I admit, its a little hard to follow what happened here. You moved a lot of code around (I agree with that!), but also changed code as well. Can you just summarize what is NOT just moved code and needs a more thorough look? Comment at: clang/l

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

cor3ntin added a comment. In D143891#4144161 , @aaron.ballman wrote: > LGTM but we should add a release note for the change. This fixes P0848R3, which is a clang 16 feature. If we backport this we don't need a changelog entry. Repository: rG LLVM Gi

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd13ad6c537: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on… (authored by shangwuyao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 8bd13ad - [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

Author: ShangwuYao Date: 2023-02-22T15:44:46Z New Revision: 8bd13ad6c5374f39408be4a34989007999a57ee9 URL: https://github.com/llvm/llvm-project/commit/8bd13ad6c5374f39408be4a34989007999a57ee9 DIFF: https://github.com/llvm/llvm-project/commit/8bd13ad6c5374f39408be4a34989007999a57ee9.diff LOG: [C

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499511. michaelplatings marked 8 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @MaskRay and @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D143587: [Docs] Multilib design

michaelplatings added inline comments. Comment at: clang/docs/Multilib.rst:237 + +Stable API +-- MaskRay wrote: > What does "API" refer to? A function defined in llvm-project/clang/lib? Changed "API" to "interface" and reworded to hopefully make it cleare

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

animeshk-amd updated this revision to Diff 499513. animeshk-amd added a comment. Removed a pragma line which was not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144544/new/ https://reviews.llvm.org/D144544 Files: clang/test/OpenMP/ta

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545 +addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0], + C.getDriver().getLTOMode() == LTOK_Thin); CmdArgs.push_back("-shared"); What's

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. NVM the above, all the other call sites to addLTOOptions have that test in them so it must be fine Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545 +addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0], + C.getDriver().getLTOMode() == LTOK_Thin); CmdArgs.push_back("-shared"); JonChesterfiel

[clang] c45d2df - [Clang] Add options in LTO mode when cross compiling for AMDGPU

Author: Joseph Huber Date: 2023-02-22T10:14:05-06:00 New Revision: c45d2df05e0e7b6f2517aa2933a24928b4942a3f URL: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f DIFF: https://github.com/llvm/llvm-project/commit/c45d2df05e0e7b6f2517aa2933a24928b4942a3f.diff

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45d2df05e0e: [Clang] Add options in LTO mode when cross compiling for AMDGPU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144505/new

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

aqjune abandoned this revision. aqjune added a comment. Closing this as D142388 added a function that can be used instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136737/new/ https://reviews.llvm.org/D136737

[clang] a7b6978 - [clang][doc] Removes obsolete comment.

Author: Mark de Wever Date: 2023-02-22T17:17:36+01:00 New Revision: a7b6978285c1c07600d1762b206c1dcec35fe6c8 URL: https://github.com/llvm/llvm-project/commit/a7b6978285c1c07600d1762b206c1dcec35fe6c8 DIFF: https://github.com/llvm/llvm-project/commit/a7b6978285c1c07600d1762b206c1dcec35fe6c8.diff

[PATCH] D144497: [clang][doc] Removes obsolete comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b6978285c1: [clang][doc] Removes obsolete comment. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144497/new/ https://reviews.llvm.

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:83 + } + // The universal integral type to use in value range descriptions. This enum is moved here from other location, and `negateKind` is added.

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

kamaub added a comment. We may also need an associated test case for the changed behaviour for using `areCompatibleVectorTypes()` instead of `areSameVectorElemTypes()`. The test coverage should display when warnings are emitted now that we account for vector bool, vector pixel and type qualifier

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

xazax.hun added a comment. I think at this point it is ok to merge. Any other comments can be addressed in follow-up commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:583 + if (!KernelEnvOrError) +return KernelEnvOrError.takeError(); + tianshilei1992 wrote: > jdoerfert wrote: > > We used to default

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 created this revision. doru1004 added reviewers: jdoerfert, jhuber6, ronl, carlo.bertolli, arsenm, gregrodgers, ABataev. doru1004 added a project: OpenMP. Herald added subscribers: kosarev, kerbowa, guansong, yaxunl, jvesely. Herald added a project: All. doru1004 requested review of this

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

thesamesam closed this revision. thesamesam added a comment. Thanks! Merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144540/new/ https://reviews.llvm.org/D144540 ___ cfe-commits mailing list cfe-co

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499553. VitaNuo marked 24 inline comments as done. VitaNuo added a comment. Address review comments (apart from testing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D1434

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! I should have addressed everything apart from testing. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:523 +TransformedInc.Angled = WrittenRef.starts_with("<"); +if (auto FE = SM.getFileManager().getFile(Inc.Reso

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 499555. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D143052: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

phosek updated this revision to Diff 499561. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm.org/D143052 Files: clang/tools/driver/CMakeLists.txt

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, royjacobson, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. During Clang 15, 3d2629dd3aab17098813c68b5b76bb864bc5e285

[PATCH] D144149: [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144149/new/ https://reviews.llvm.org/D144149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D144157: Add 128-bit integer support to enum element

aaron.ballman added a comment. I think this needs additional test coverage around `_BitInt` as those can be arbitrarily large depending on the target. Also, C2x made changes in this area to how we calculate what type to represent the enumerations in; we don't have to implement that support as p

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMake

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

arsenm added inline comments. Comment at: clang/test/Driver/amdgpu-toolchain.c:7 // RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s // AS_LINK: "-cc1as" should add a test for thinlto? Repository:

[PATCH] D144505: [Clang] Add options in LTO mode when cross compiling for AMDGPU

jhuber6 added inline comments. Comment at: clang/test/Driver/amdgpu-toolchain.c:7 // RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=DWARF_VER %s // AS_LINK: "-cc1as" arsenm wrote: > should add a test for thinlt

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19113 +// parameter appertaining to the same declaration as that attribute. +if(auto* Parm = dyn_cast(Var); Parm && Parm->getDeclContext() == DC) + return true; Formatting

[PATCH] D144572: [C++20] Stop claiming full support for consteval (for the moment!)

erichkeane added a comment. We've discussed this offline, and I think this is the right thing to do, but I'll let others comment before approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144572/new/ https://reviews.llvm.org/D144572

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 4 inline comments as done. TIFitis added a comment. In D142914#4144475 , @kiranchandramohan wrote: > Please add tests for the MLIR portion. Can you please tell me where to add these? > Could you also post the full LLVM IR for a construct

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 499583. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments, fixed error in MLIR translation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews

[PATCH] D144149: [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2893d55f8f61: [Serialization] Don't warn when a deserialized category is equivalent to an… (authored by vsapsai). Repository: rG LLVM Github Monor

[clang] 2893d55 - [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

Author: Volodymyr Sapsai Date: 2023-02-22T11:01:40-08:00 New Revision: 2893d55f8f61edb2c253b960cab1107ea6c163c2 URL: https://github.com/llvm/llvm-project/commit/2893d55f8f61edb2c253b960cab1107ea6c163c2 DIFF: https://github.com/llvm/llvm-project/commit/2893d55f8f61edb2c253b960cab1107ea6c163c2.di

  1   2   >