JonChesterfield requested changes to this revision.
JonChesterfield added a comment.
This revision now requires changes to proceed.

Marking this as "no" because as far as I can tell it'll stop anyone running 
openmp built from source which constitutes a severe regression and I am 
struggling to find information on what Fedora are doing here. This link 
https://fedoraproject.org/wiki/Changes/Broken_RPATH_will_fail_rpmbuild suggests 
changing clang to not set rpath when it would be aiming at a "system 
directory", which is unfortunately platform specific magic strings, would be 
fine. That is, maybe Fedora is OK with setting RPATH as long as it isn't set to 
/usr/lib64 or possibly other unspecified strings.

The use case I want to preserve is people running clang -fopenmp from a local 
install and without setting environment variables. That means the binary needs 
to find the shared libraries from that local install and not unrelated files 
with the same name that happen to be under /usr somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143306/new/

https://reviews.llvm.org/D143306

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to