[PATCH] D143148: [clang-repl] Add basic multiline input support

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:260 + std::error_code()); +Token Tok; +do { I think we can simplify the heuristics here by asking if the end source

[clang] ddc5d40 - [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

Author: Balázs Kéri Date: 2023-02-15T09:22:48+01:00 New Revision: ddc5d40dd285d6422dc66b9aa25064502af3218b URL: https://github.com/llvm/llvm-project/commit/ddc5d40dd285d6422dc66b9aa25064502af3218b DIFF: https://github.com/llvm/llvm-project/commit/ddc5d40dd285d6422dc66b9aa25064502af3218b.diff L

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddc5d40dd285: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly (authored by balazske). Repository: rG LLVM Github Mono

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1023 Partition = All.take_while([&](const Token &T) { - return T.getLocation() >= BeginLoc && T.getLocation() < Limit && - NearLast(T.getLocation()); + // NOTE: the Limit is included

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. The pre-commit check is still failing with these tests: Flang :: Fir/alloc.fir Flang :: Fir/embox.fir Flang :: Fir/optional.fir Flang :: Fir/rebox.fir Flang :: Lower/common-block.f90 Flang :: Lower/forall/character-1.f90 CHANGES SINCE LAST ACTION https:/

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

carlosgalvezp added a comment. > That's not so simple. At work we use clang-tidy for few big projects. I had > to explicitly add to some checks `unless(isExpansionInSystemHeader())` to > gain some performance improvement of clang-tidy. This check is one of them. > Problem is that some matchers o

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497596. xen0n added a comment. Rebase and change to lower the op in LoongArchAsmPrinter so as to make people's lives easier when they come to rebase D141785 on top of this. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497598. xen0n added a comment. Document the change in Clang release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 497602. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Headers.cpp:76 +Out->MainFileIncludesBySpelling.try_emplace(Inc.Written) +.first->second.push_back(static_cast(*Inc.HeaderID)); } kadircet wrote: > r

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/FormatTokenSource.h:74 public: - IndexedTokenSource(ArrayRef Tokens) + IndexedTokenSource(SmallVectorImpl &Tokens) : Tokens(T

[clang-tools-extra] 45ddc15 - [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

Author: Carlos Galvez Date: 2023-02-15T10:38:36Z New Revision: 45ddc157ca7c464ebbea627da0f682b1554e2390 URL: https://github.com/llvm/llvm-project/commit/45ddc157ca7c464ebbea627da0f682b1554e2390 DIFF: https://github.com/llvm/llvm-project/commit/45ddc157ca7c464ebbea627da0f682b1554e2390.diff LOG:

[PATCH] D143843: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ddc157ca7c: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14384

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 497609. sepavloff added a comment. Changed the way to copy strictfp attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Sema/Sema

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4123922 , @rjmccall wrote: > In D143919#4123712 , @sepavloff > wrote: > >> In D143919#4123616 , @efriedma >> wrote: >> >>> We have

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 497620. eklepilkina added a comment. - [RISCV] Prepare work to be ready for adding separate Zicsr and Zifencei extensions - [RISCV] Proper support of extensions Zicsr and Zifencei - Updated I extension verson - Fixing after updating Repository: rG LLV

[clang] 5bb8ead - [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

Author: Caroline Concatto Date: 2023-02-15T11:39:00Z New Revision: 5bb8ead4e9dc4a03bddae1f7d3419e97eac37426 URL: https://github.com/llvm/llvm-project/commit/5bb8ead4e9dc4a03bddae1f7d3419e97eac37426 DIFF: https://github.com/llvm/llvm-project/commit/5bb8ead4e9dc4a03bddae1f7d3419e97eac37426.diff

[PATCH] D143989: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb8ead4e9dc: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? Sorry for checking in so late, I noticed the notifications only n

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 497630. pmatos added a comment. Rebased against HEAD. Waiting for @vitalybuka go ahead to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497632. pmatos added a comment. Rebased on current HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/include/cl

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 497633. pmatos added a comment. Rebased on current HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/include/clang/

Re: [clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

Addressed in ddb704247b16002d916bba67e3aa9f54fd4bbace - thanks again. Best, Alex On 2023-02-14 20:58, Craig Topper wrote: > I don't have a better idea. > > ~Craig > > On Tue, Feb 14, 2023 at 12:32 PM Alex Bradbury wrote: > >> On 2023-02-14 19:56, Craig Topper wrote: >>> How does this interac

[clang] 7cbbbc0 - clang: Rename misleading test name

Author: Matt Arsenault Date: 2023-02-15T08:32:57-04:00 New Revision: 7cbbbc0a045bf1597972dabd2e071786157c87bf URL: https://github.com/llvm/llvm-project/commit/7cbbbc0a045bf1597972dabd2e071786157c87bf DIFF: https://github.com/llvm/llvm-project/commit/7cbbbc0a045bf1597972dabd2e071786157c87bf.diff

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek updated this revision to Diff 497637. klimek marked an inline comment as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143070/new/ https://reviews.llvm.org/D143070 Files: clang/lib/Fo

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:287 // owned outside of and handed into the UnwrappedLineParser. + // FIXME: The above fixme doesn't work if we need to create tokens while + // parsing. sammccall wrote: > I'm

[clang] 1995d44 - [clang-format] Enable FormatTokenSource to insert tokens.

Author: Manuel Klimek Date: 2023-02-15T12:39:24Z New Revision: 1995d4424505cb5a1c3f0e5f851a660ec32d7af1 URL: https://github.com/llvm/llvm-project/commit/1995d4424505cb5a1c3f0e5f851a660ec32d7af1 DIFF: https://github.com/llvm/llvm-project/commit/1995d4424505cb5a1c3f0e5f851a660ec32d7af1.diff LOG:

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1995d4424505: [clang-format] Enable FormatTokenSource to insert tokens. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added a comment. Thanks! Details mostly looks good, but i think we had different ideas about how the final diagnostics should look like. Let's try to clear that up a bit. My suggested proposal is: - Having a main diagnostic for each symbol that doesn't have a satisfying include in the

[clang] 1f818f6 - [clang-format] assert(false) -> llvm_unreachable

Author: Benjamin Kramer Date: 2023-02-15T14:10:09+01:00 New Revision: 1f818f63b829f3038a9fd605bf90348ba58cd981 URL: https://github.com/llvm/llvm-project/commit/1f818f63b829f3038a9fd605bf90348ba58cd981 DIFF: https://github.com/llvm/llvm-project/commit/1f818f63b829f3038a9fd605bf90348ba58cd981.dif

[clang] 861764b - [NVPTX] Fix NVPTX output name in the driver with `-save-temps`

Author: Joseph Huber Date: 2023-02-15T07:39:59-06:00 New Revision: 861764b1c5f7fc31601655f01d84407d42013c30 URL: https://github.com/llvm/llvm-project/commit/861764b1c5f7fc31601655f01d84407d42013c30 DIFF: https://github.com/llvm/llvm-project/commit/861764b1c5f7fc31601655f01d84407d42013c30.diff

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: kadircet, nridge. zyounan added a comment. zyounan retitled this revision from "[clangd] Hide extra inlay hints for macro as argument" to "[clangd] Hide inlay hints wh

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske updated this revision to Diff 497654. balazske added a comment. make check available in all C++ versions, add compound operator related test and code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138777/new/ https://reviews.llvm.org/D1387

[PATCH] D144100: [clang] Fix a bug that allowed some overflowing octal escape sequences

barannikov88 created this revision. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144100 Files: clang/lib/Lex/LiteralSupport.cpp

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

davrec added a comment. Only had a chance to give it a once over, I will look through more closely later, def by this weekend. Main thing is I think we shouldn't be exposing the buffer pointers after this change, i.e. no public function should return `const char *`, unless I'm missing somethin

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:108 +__STDC_VERSION__ >= 202000L +#define unreachable() __builtin_unreachable() +#endif /* defined(__need_STDDEF_H_misc) && >= C23 */ erichkeane wrote: > Is this REALLY required to be

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/stddef.h:108 +__STDC_VERSION__ >= 202000L +#define unreachable() __builtin_unreachable() +#endif /* defined(__need_STDDEF_H_misc

[PATCH] D143210: PowerPC] Include vector bool and pixel when emitting lax warning

amyk added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9845 if (anyAltivecTypes(RHSType, LHSType) && -!areSameVectorElemTypes(RHSType, LHSType)) +!Context.areCompatibleVectorTypes(RHSType, LHSType)) Diag(RHS.get()->getExprL

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

donat.nagy added a comment. In D142822#4102795 , @balazske wrote: > I looked at some of the failing tests but can not decide how to fix the > problems. The problem seems to be with the extra `namespace std` that was not > there before. I do not know wha

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

ldionne added a comment. I suspect the libc++ failure is because the patch is not rebased onto `main`. I remember seeing those issues a while back. I think it's unlikely to be this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 _

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:111 if not any( -[arg.startswith('-config=') for arg in self.clang_tidy_extra_args]): +[arg.startswith('-config=') or arg.startswith('-config-file=') for a

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

whisperity added subscribers: rsmith, whisperity. whisperity added a comment. In D142822#4095896 , @DavidSpickett wrote: > > /home/david.spickett/llvm-project/clang/test/CodeGenCXX/cxx20-module-std-subst-2b.cpp:14:18: > error: reference to 'std' is a

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. LGTM except the comments left by other reviewers! Marking it as "Request Changes" for visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

yaxunl added a comment. Making the builtin types consistent is necessary to keep struct layout consistent across host and device, but why do we need to make __GCC_ATOMIC_XXX_LOCK_FREE macros the same between the host and device? Is there any concrete issue if they are not the same? Repositor

[PATCH] D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144041/new/ https://reviews.llvm.org/D144041

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. But there should be a way to make the namespace "invisible" like it is done with `std::bad_alloc`, the linked commit seems to contain the code to "hide" the first std definition and this may not work any more. Another question is why this architecture has a probably no

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

xazax.hun added a comment. I am ok with committing this to unblock people hitting this assert, but at the same time I wonder if we want to open a ticket on GitHub that we might want to rethink how some of this works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 6b991ba - [clang][dataflow] Change `transfer` API to take a reference.

Author: Yitzhak Mandelbaum Date: 2023-02-15T15:37:21Z New Revision: 6b991ba486b64f09e7d90ebc1fc2118ab48c8bff URL: https://github.com/llvm/llvm-project/commit/6b991ba486b64f09e7d90ebc1fc2118ab48c8bff DIFF: https://github.com/llvm/llvm-project/commit/6b991ba486b64f09e7d90ebc1fc2118ab48c8bff.diff

[PATCH] D143920: [clang][dataflow] Change `transfer` API to take a reference.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b991ba486b6: [clang][dataflow] Change `transfer` API to take a reference. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. In D144047#4129154 , @yaxunl wrote: > Making the builtin types consistent is necessary to keep struct layout > consistent across host and device, but why do we need to make > __GCC_ATOMIC_XXX_LOCK_FREE macros the same betwee

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

hubert.reinterpretcast added a comment. In D143891#4122660 , @aaron.ballman wrote: > This is an ABI breaking change, isn't it? (The type trait now returns > something different than it did before, which could change instantiations or > object layout.)

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

yaxunl added a comment. In D144047#4129182 , @shangwuyao wrote: > In D144047#4129154 , @yaxunl wrote: > >> Making the builtin types consistent is necessary to keep struct layout >> consistent across host and dev

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe updated this revision to Diff 497687. Febbe marked 3 inline comments as done. Febbe added a comment. - Removed some, not required changes. - Reverted mapOptional -> mapRequired change, since it might break existing configs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

njames93 added a comment. Just a few more points then it should be good to land Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:181-190 + + // Detect redundant 'c_str()' calls in parameters passed to std::print and + // std::format. + Finde

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

erichkeane added a subscriber: rsmith. erichkeane added a comment. In D143891#4129214 , @hubert.reinterpretcast wrote: > In D143891#4122660 , @aaron.ballman > wrote: > >> This is an ABI breaking change, isn't it

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

ClockMan created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 497408. ClockMan added a comment. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. ClockMan updated

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. Thanks for the review and further suggestions. Mike. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:181-190 + + // Detect redundant 'c_str()' calls in parameters passed to std::print and + // std::format. + Find

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao updated this revision to Diff 497700. shangwuyao added a comment. Amend with comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144047/new/ https://reviews.llvm.org/D144047 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGe

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added a comment. It's an interesting discussion, I just want to remind that this change is for triviality rules from P0848 (conditionally trivial member functions) which is only going to ship in Clang 16 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe updated this revision to Diff 497701. Febbe added a comment. Added requested tests: - since we now support priorities, equal to 0 (the main include priority) sorting should work now for those. - multiple files can be main-includes now, the tests expects that now. - negative priorities do n

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao added a comment. In D144047#4129247 , @yaxunl wrote: > In D144047#4129182 , @shangwuyao > wrote: > >> In D144047#4129154 , @yaxunl wrote: >> >>> Making the bui

[PATCH] D144011: [clang]Fix warning for signed conversion

yaxunl added a comment. In D144011#4126853 , @MaskRay wrote: > I think it makes sense for `-Wsign-conversion` to not warn for this LP64 > case, like we don't emit a warning for `-m32`. I do not know whether we need > another diagnostic like `-Wshorten-6

[PATCH] D144011: [clang]Fix warning for signed conversion

yaxunl updated this revision to Diff 497703. yaxunl added a comment. revised by Fanrui's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144011/new/ https://reviews.llvm.org/D144011 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/sign-conversion.c Index: clang/test/

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

Febbe marked 2 inline comments as done. Febbe added inline comments. Comment at: clang/lib/Format/Format.cpp:1379 LLVMStyle.IncludeStyle.IncludeCategories = { - {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false}, - {"^(<|\"(gtest|gmock|isl|json)/)", 3, 0, false}, -

[clang] 97ba3c2 - [Clang][AMDGPU] Set LTO CG opt level based on Clang option

Author: Scott Linder Date: 2023-02-15T17:34:35Z New Revision: 97ba3c2bec48ca55cc842c6499b19b0b8a271951 URL: https://github.com/llvm/llvm-project/commit/97ba3c2bec48ca55cc842c6499b19b0b8a271951 DIFF: https://github.com/llvm/llvm-project/commit/97ba3c2bec48ca55cc842c6499b19b0b8a271951.diff LOG:

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba3c2bec48: [Clang][AMDGPU] Set LTO CG opt level based on Clang option (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak added a comment. @tahonermann @cor3ntin have you had a chance to take a look at the updated patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143109/new/ https://reviews.llvm.org/D143109 ___

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve updated this revision to Diff 497713. fdeazeve added a comment. Fixed clang format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/docs/Lan

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill created this revision. Endill added reviewers: clang-language-wg, aaron.ballman. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend `#pragma clang __debug dump` to support not only single ident

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9494 + // of SVM. + if (S.getLangOpts().getOpenCLCompatibleVersion() > 120 && + (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam)) Anastasia wrote: > Ayal wr

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak updated this revision to Diff 497719. ahatanak added a comment. Fix type and add comment. Remove unnecessary cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 Files: clang/lib/CodeGen/Addre

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

ClockMan updated this revision to Diff 497727. ClockMan marked 3 inline comments as done. ClockMan added a comment. Corrected issues mentioned in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 Fil

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

ClockMan added a comment. Fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 57865bc - [CodeGen] Add a flag to `Address` and `Lvalue` that is used to keep

Author: Akira Hatanaka Date: 2023-02-15T10:15:13-08:00 New Revision: 57865bc5ad277166507d9e9fbb5205be86caa73a URL: https://github.com/llvm/llvm-project/commit/57865bc5ad277166507d9e9fbb5205be86caa73a DIFF: https://github.com/llvm/llvm-project/commit/57865bc5ad277166507d9e9fbb5205be86caa73a.diff

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57865bc5ad27: [CodeGen] Add a flag to `Address` and `Lvalue` that is used to keep (authored by ahatanak). Repository: rG LLVM Github Monorepo CHA

[PATCH] D144120: [HLSL] add log library functions This change exposes the log library functions for HLSL, excluding long, int, and long long doubles. The log functions are supported for all scalar, ve

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...missing in this patch because those types don't exist in HLSL. Int is missing bec

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

dmgreen added a comment. Hi. I created this issue about the use of Ofast and -1: https://github.com/llvm/llvm-project/issues/60781 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mail

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#4129733 , @dmgreen wrote: > Hi. I created this issue about the use of Ofast and -1: > https://github.com/llvm/llvm-project/issues/60781 Thanks. Will take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127505 , @b-sumner wrote: >> My current understanding is the c-p will go into already forked clang-16, >> but not to rocm 5.4. So rocm device-libs will be accompanied by the older >> clang-16 w/o this and stay compa

[clang] a9797d7 - [C2x] Implement the `unreachable` macro for WG14 N2826

Author: Aaron Ballman Date: 2023-02-15T14:43:01-05:00 New Revision: a9797d7d2d7878464868312e0c147b4e747a31c6 URL: https://github.com/llvm/llvm-project/commit/a9797d7d2d7878464868312e0c147b4e747a31c6 DIFF: https://github.com/llvm/llvm-project/commit/a9797d7d2d7878464868312e0c147b4e747a31c6.diff

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9797d7d2d78: [C2x] Implement the `unreachable` macro for WG14 N2826 (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143430/new/

[PATCH] D143691: Fix clang-formats IncludeCategory to match the documentation

HazardyKnusperkeks added a comment. Looks good to me, apart from that one issue. Comment at: clang/lib/Tooling/Inclusions/IncludeStyle.cpp:23 + +constexpr int DefaultPriority = std::numeric_limits::max(); + Please move this into the `mapping` function. ==

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4128729 , @diseraluca wrote: > In D140756#4100387 , @aaron.ballman > wrote: > >> @diseraluca -- do you need this cherry picked into Clang 16 or are you fine >> if this

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4126266 , @vedgy wrote: > `size_t` indeed makes logical sense for this member as that's the return type > of `sizeof`. `size_t` is two times larger than `unsigned` on x86_64, but I > don't think the size of this

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

aaron.ballman added a comment. Precommit CI found an issue on Windows that should be addressed: FAIL: Clang :: CodeGenCXX/cxx1z-constexpr-if.cpp (7014 of 17903) TEST 'Clang :: CodeGenCXX/cxx1z-constexpr-if.cpp' FAILED Script: -- : 'RUN: at line

[PATCH] D143210: [PowerPC] Include vector bool and pixel when emitting lax warning

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9845 if (anyAltivecTypes(RHSType, LHSType) && -!areSameVectorElemTypes(RHSType, LHSType)) +!Context.areCompatibleVectorTypes(RHSType, LHSType)) Diag(RHS.get()->getE

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

jansvoboda11 accepted this revision. jansvoboda11 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:64-66 +/// Dependency scanner callbacks that are used during scanning t

[PATCH] D144037: [clang-tidy] allow tests to use --config-file instead of --config

amurzeau updated this revision to Diff 497773. amurzeau retitled this revision from "[clang-tidy] allow tests to use -config-file instead of -config" to "[clang-tidy] allow tests to use --config-file instead of --config". amurzeau added a comment. Allow use of --config and --config-file (with do

[clang] 8c1f77a - [clang-format] Fix windows build.

Author: Manuel Klimek Date: 2023-02-15T20:59:43Z New Revision: 8c1f77af7fd14d5a611246aa16b9693d3ebcee22 URL: https://github.com/llvm/llvm-project/commit/8c1f77af7fd14d5a611246aa16b9693d3ebcee22 DIFF: https://github.com/llvm/llvm-project/commit/8c1f77af7fd14d5a611246aa16b9693d3ebcee22.diff LOG:

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

ahatanak updated this revision to Diff 497776. ahatanak added a comment. Add triple to the test and add release note for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144016/new/ https://reviews.llvm.org/D144016 Files: clang/docs/Releas

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

tahonermann requested changes to this revision. tahonermann added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaExpr.cpp:19085-19092 + // If the variable is used in a default argument expression of a lambda call + // operator, sw

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added a comment. If the "strictfp" attribute is based on the contents of the function body, should we recompute it when the function is instantiated, as opposed to copying it? For example, say you have a pragma inside an "if constexpr"; should that set the strictfp attribute if it's d

[clang] f5aa8d1 - [Clang][docs] Update the release notes page to the new skeleton

Author: Roy Jacobson Date: 2023-02-15T23:53:38+02:00 New Revision: f5aa8d191a5b5ea118281bfa410bdb2ee961c704 URL: https://github.com/llvm/llvm-project/commit/f5aa8d191a5b5ea118281bfa410bdb2ee961c704 DIFF: https://github.com/llvm/llvm-project/commit/f5aa8d191a5b5ea118281bfa410bdb2ee961c704.diff

[PATCH] D144136: Add a "remark" to report on array accesses

void created this revision. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This will report a ton of information. It's basically only good for piping to a file and using Perl to gather any useful informati

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9494 + // of SVM. + if (S.getLangOpts().getOpenCLCompatibleVersion() > 120 && + (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam)) Anastasia wrote: > Anastasia wr

[clang] a851d46 - [Clang][Driver] Fix integer normalization with KCFI

Author: Sami Tolvanen Date: 2023-02-16T00:21:31Z New Revision: a851d46e07c1234a0763b4630c8475c73208e776 URL: https://github.com/llvm/llvm-project/commit/a851d46e07c1234a0763b4630c8475c73208e776 DIFF: https://github.com/llvm/llvm-project/commit/a851d46e07c1234a0763b4630c8475c73208e776.diff LOG:

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

hubert.reinterpretcast added a comment. In D142867#4108079 , @eaeltsin wrote: > The warning now fires even if overflow is prevented with `if constexpr`: > > if constexpr (width <= 64) { > if constexpr (width == 64) { > return 1; > } >

[PATCH] D144147: [Clang][RISCV] Sort test cases into its mnemonics

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 497847. dzhidzhoev added a comment. Simplified condition in lowerUnion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h c

[PATCH] D144149: [Serialization] Don't warn when a deserialized category is equivalent to an existing one.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A single class allows multiple catego

  1   2   >