[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

kadircet added a comment. All this complexity for handling only 4 symbols feels wrong. is this the whole set? are there any other symbols that fall under this class? can we disambiguate all of them solely based on number of parameters? Downsides: - We are relying heavily on number of parameters

[clang-tools-extra] 19659b5 - [clangd] Drop includes from disabled PP regions in preamble patch

Author: Kadir Cetinkaya Date: 2023-02-13T09:49:13+01:00 New Revision: 19659b5f0dd1a1dcf745cf058d042ada2d4ff061 URL: https://github.com/llvm/llvm-project/commit/19659b5f0dd1a1dcf745cf058d042ada2d4ff061 DIFF: https://github.com/llvm/llvm-project/commit/19659b5f0dd1a1dcf745cf058d042ada2d4ff061.dif

[clang-tools-extra] fae01d1 - [clangd] Fix bugs in main-file include patching for stale preambles

Author: Kadir Cetinkaya Date: 2023-02-13T09:49:13+01:00 New Revision: fae01d175a29270ec01211d3988c7ae57ddabfd3 URL: https://github.com/llvm/llvm-project/commit/fae01d175a29270ec01211d3988c7ae57ddabfd3 DIFF: https://github.com/llvm/llvm-project/commit/fae01d175a29270ec01211d3988c7ae57ddabfd3.dif

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae01d175a29: [clangd] Fix bugs in main-file include patching for stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14319

[PATCH] D143597: [clangd] Drop includes from disabled PP regions in preamble patch

This revision was automatically updated to reflect the committed changes. Closed by commit rG19659b5f0dd1: [clangd] Drop includes from disabled PP regions in preamble patch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143597/

[clang] 24ecd99 - [NFC] Set C++20 Named Modules for CodeGen in ASTContext in the early place

Author: Chuanqi Xu Date: 2023-02-13T17:14:58+08:00 New Revision: 24ecd99842352ed1e6d7877e76e93c2f83ebf3f3 URL: https://github.com/llvm/llvm-project/commit/24ecd99842352ed1e6d7877e76e93c2f83ebf3f3 DIFF: https://github.com/llvm/llvm-project/commit/24ecd99842352ed1e6d7877e76e93c2f83ebf3f3.diff LO

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

svenvh accepted this revision. svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + Anastasia

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496875. zyounan added a comment. Revise symbols from N4100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/unittests/CanonicalInclud

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 496882. balazske added a comment. small problem fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChe

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson created this revision. royjacobson added reviewers: erichkeane, cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Up to C++20, hasDefaultConstructor and !hasNonTrivialDefaultConst

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9494 + // of SVM. + if (S.getLangOpts().getOpenCLCompatibleVersion() > 120 && + (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam)) Ayal wrote: > Anastasia wr

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 496900. kadircet marked 12 inline comments as done. kadircet added a comment. - Change patching logic to iterate over diags instead of preamble lines - Change translation logic to: - Preserve a diagnostic if its range can be translated. - Preserve all the

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 496905. kadircet added a comment. - Reflow comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ https://reviews.llvm.org/D143096 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-ext

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta updated this revision to Diff 496906. thieta marked 2 inline comments as done. thieta added a comment. - Expand on tests - Fix crash when Attrs was null - Added release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143632/new/ https://r

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 496907. kadircet edited the summary of this revision. kadircet added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ https://reviews.llvm.org/D143096 Files: clan

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta marked an inline comment as done. thieta added a comment. Thanks for your comments - feel free to comment on the release note, I was struggling with describing the fix well for a short release note paragraph. Comment at: clang/lib/Parse/ParseDecl.cpp:61-63 + for (Parse

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet added a comment. Thanks for updating this, as I mentioned in https://reviews.llvm.org/D143319#4115186, we should put these symbols into their own symbol map. ATM `StdSymbolMap.inc` is still generated by an automated tool and shouldn't be modified by hand. So can you rather put these sy

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Sorry for the late update, I'm rebasing my branch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 ___ cfe-commits mailing list cfe

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin added a comment. In D143436#4120899 , @nridge wrote: > Note that D138546 is removing the call to > `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds > equivalent logic too `Comma

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 496923. balazske added a comment. removed "IsLast" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143751/new/ https://reviews.llvm.org/D143751 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChec

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 496924. carlosgalvezp added a comment. - Rebase. - Fix code directly for the newly introduce check in llvmlibc. We do not need the deprecation process here since the check is brand new. - Rebase the getter functions from ClangTidyCheck.h, they don't see

[PATCH] D143260: [clangd] Add semantic token for labels

kadircet added a comment. thanks for the patch, but could you elaborate a little bit on "why this is useful for clients". in theory semantic highlighting tries to provide annotations for tokens that are hard to disambiguate by a syntax highlighter due to need for context. at hindsight i can't se

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

kadircet added a comment. > There is a discrepancy between how clangd processes CDB loaded from JSON file > on disk and pushed via LSP. That's actually because we model compile commands pushed via LSP as a "fixed compilation database" rather than a json compilation database (you can check the

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

hokein added a comment. Thanks for the comment, putting more thoughts. In D143640#4121998 , @kadircet wrote: > All this complexity for handling only 4 symbols feels wrong. is this the > whole set? are there any other symbols that fall under this class?

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496934. zyounan added a comment. Rebase to main && Move tests to clang/Tooling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/Tooling/Inclusions/S

[PATCH] D143640: [Tooling/Inclusion] Support overload symbols in the stdlib.

kadircet added a comment. In D143640#4122603 , @hokein wrote: > Thanks for the comment, putting more thoughts. > > In D143640#4121998 , @kadircet > wrote: > >> All this complexity for handling only 4 symbols feel

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 6 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6552-6555 + // The call we get looks like + // CallExpr + // `- ImplicitCastExpr + // `- DeclRefExpr tlively wrote: > How do these parts corre

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 496937. pmatos marked 5 inline comments as done. pmatos added a comment. Addressed a few comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/inclu

[PATCH] D141950: Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

kuganv updated this revision to Diff 496936. kuganv added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141950/new/ https://reviews.llvm.org/D141950 Files: clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTContext.cpp

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this, the new layout is a big improvement! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142578/new/ https://r

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet added a comment. thanks a lot! mostly LG couple more nits Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:1 +// These symbols are exported from N4100[fs.filesystem.synopsis], the final +// draft for experimental filesystem. Note that not all of these

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

aaron.ballman added a comment. This is an ABI breaking change, isn't it? (The type trait now returns something different than it did before, which could change instantiations or object layout.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143891/

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should add a release note for the changes. The precommit CI failures appear to be unrelated to the changes in this patch. Repository: rG LLVM Github Monorepo

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added a comment. In D143891#4122660 , @aaron.ballman wrote: > This is an ABI breaking change, isn't it? (The type trait now returns > something different than it did before, which could change instantiations or > object layout.) Technicall

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. By special-casing them at the moment. The tooling stdlib lib doesn't support these symbols (most important one is std::

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

aaron.ballman added a comment. In D143891#4122668 , @royjacobson wrote: > In D143891#4122660 , @aaron.ballman > wrote: > >> This is an ABI breaking change, isn't it? (The type trait now returns >> something dif

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > can you strip clang-format pragmas to be similar to other

[PATCH] D143112: [clang] Support parsing comments without ASTContext

kadircet added a comment. Thanks, this looks like a good start. I left some comments about the details of implementation, as for placing and APIs in general, i think it's useful to see how things will be built on top inside clangd to make the right call here. Comment at: clan

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) zyounan wrote: > kadircet wrote: > > can you strip clang-format pragmas to

[PATCH] D143632: [clang] Handle __declspec() attributes in using

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits that you can fix when landing, thank you for the fix! Comment at: clang/docs/ReleaseNotes.rst:112-114 +__declspec attributes ca

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4120058 , @vedgy wrote: > In D143418#4118905 , @aaron.ballman > wrote: > >> I don't think "tries hard" is a good enough guarantee for where files are >> placed. I'm not

[clang] 877859a - [clang] Handle __declspec() attributes in using

Author: Tobias Hieta Date: 2023-02-13T15:43:08+01:00 New Revision: 877859a09bda29fe9a7f1a9016b06cf80661a032 URL: https://github.com/llvm/llvm-project/commit/877859a09bda29fe9a7f1a9016b06cf80661a032 DIFF: https://github.com/llvm/llvm-project/commit/877859a09bda29fe9a7f1a9016b06cf80661a032.diff

[PATCH] D143632: [clang] Handle __declspec() attributes in using

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG877859a09bda: [clang] Handle __declspec() attributes in using (authored by thieta). Changed prior to commit: https://reviews.llvm.org/D143632?vs=4

[PATCH] D143632: [clang] Handle __declspec() attributes in using

thieta added a comment. Thanks for the review and the explanations! I fixed your nits and landed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143632/new/ https://reviews.llvm.org/D143632 ___ cfe-c

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496963. zyounan marked 4 inline comments as done. zyounan added a comment. Revise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/Tooling/Inclusion

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:1 +// These symbols are exported from N4100[fs.filesystem.synopsis], the final +// draft for experimental filesystem. Note that not all of these symbols were kadirce

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:104 + } + if (FName == "remove") { +if (FD->getNumParams() == 1) nit: `else if` Comment at: clang-tools-extra/include-cleaner/lib/FindHeader

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) kadircet wrote: > zyounan wrote: > > kadircet wrote: > > > can you strip cl

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 496964. bryanpkc edited the summary of this revision. bryanpkc added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: c

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc marked 5 inline comments as done. bryanpkc added inline comments. Comment at: clang/include/clang/Basic/arm_sme.td:22 +let TargetGuard = "sme" in { + def SVLD1_HOR_ZA8 : MInst<"svld1_hor_za8", "vimiPQ", "c", [IsLoad, IsOverloadNone, IsStreaming, IsSharedZA], MemEltTyDe

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) -

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

tuliom added a comment. @qiucf Thanks! I still don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Thank you for your detailed explanation and sorry again for my dumb mistake before. :) Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, )

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdTsSymbolMap.inc:6 +// whatever. +// clang-format off +SYMBOL(absolute, std::experimental::filesystem::, ) zyounan wrote: > kadircet wrote: > > zyounan wrote: > > > kadircet wrote: >

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 496971. zyounan added a comment. Apply clang-format to StandardLibrary.cpp to fix pipeline failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang/lib/

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 496976. bryanpkc marked an inline comment as done. bryanpkc added a comment. Fixed minor bugs in the previous upload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 496985. VincentWu added a comment. Herald added a subscriber: luke. add doc & update to v1.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Pre

[PATCH] D143917: [clang-tidy] Clarify branch-clone diagnostic message

donat.nagy created this revision. donat.nagy added reviewers: aaron.ballman, njames93, carlosgalvezp. donat.nagy added a project: clang-tools-extra. Herald added subscribers: gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a project: All. donat.nagy requested review of this revision. This si

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

yaxunl added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D' declared here}} we should not limit the t

[clang] b8c2ba1 - [NFC] Fix using-declspec.cpp test with non-C++17 compilers

Author: Tobias Hieta Date: 2023-02-13T16:58:13+01:00 New Revision: b8c2ba138ef689710efaa6331a618620058057fb URL: https://github.com/llvm/llvm-project/commit/b8c2ba138ef689710efaa6331a618620058057fb DIFF: https://github.com/llvm/llvm-project/commit/b8c2ba138ef689710efaa6331a618620058057fb.diff

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. If a template function contained a pragma that made it strictfp, code generation for such

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

pvellien added a comment. @yaxunl Could you please commit this change on my behalf? I don't have a write access to the trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https://reviews.llvm.org/D143495 __

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

dmgreen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:1477 + + OS << "#if !defined(__ARM_FEATURE_SME)\n"; + OS << "#error \"SME support not enabled\"\n"; bryanpkc wrote: > dmgreen wrote: > > We have been changing how the existing SVE an

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. In D143260#4122523 , @kadircet wrote: > at hindsight i can't see why `goto X;` and `X:` is not enough for clients to > implement this without any need for semantic analysis. are there contexts > where this kind of syntactical

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

peter.smith added a comment. No objections to MaskRay's suggestion to merge with an earlier patch. I've made some suggestions to make the error messages be a bit more specific about what is wrong. Comment at: clang/lib/Driver/Multilib.cpp:185 +if (M.ClangMinimumVersion.em

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson updated this revision to Diff 496998. royjacobson added a comment. Address CR comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143851/new/ https://reviews.llvm.org/D143851 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/

[PATCH] D143920: [clang][dataflow] Change `transfer` API to take a reference.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The provided `CFGElement` is never null,

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. fdeazeve requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The functi

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 4 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6696 +bool Sema::BuiltinWasmRefNullFunc(CallExpr *TheCall) { + if (TheCall->getNumArgs() != 0) +return true; erichkeane wrote: > Does this diag

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497002. pmatos marked 2 inline comments as done. pmatos added a comment. Further refinement of the patch with more diagnostics tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.ll

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497004. pmatos added a comment. Remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/include/cl

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7269 + } + Attrs[NewAttrKind] = true; + aaron.ballman wrote: > aaron.ballman wrote: > > This seems like it's not used. > Still wondering about this Th

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. Any testing suggestions here? I can use what we have on GH (cpp -> codegen test), but I'm not sure if there's a finer grained test we could use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.ll

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

inclyc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { +setOperationAction({ISD::CTLZ}, XLenVT, Legal); + It looks like this line of code will cause compilation warning. ``` [1677/171

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

inclyc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:320 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } inclyc wrote: > And this one Ah, this is my fault :(. Ther

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich marked 4 inline comments as done. philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { +setOperationAction({ISD::CTLZ}, XLenVT, Legal); + inclyc wrote: > It

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

reames added a comment. JFYI, I have a change out which just documents current status while we wait for a resolution. https://reviews.llvm.org/D143924 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497011. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a subscriber: aaron.ballman. aaronmondal added a comment. Ok so I went over https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations#testing-for-the-presence-of-a-header-__has_include (thanks, @aaron.ballman 😊) and through the commit history for the amdg

[clang] d4021ed - [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

Author: Younan Zhang Date: 2023-02-14T01:07:39+08:00 New Revision: d4021ed3d79d8823317d894b55f4e6a30cfc3614 URL: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614 DIFF: https://github.com/llvm/llvm-project/commit/d4021ed3d79d8823317d894b55f4e6a30cfc3614.diff

[PATCH] D142836: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4021ed3d79d: [Tooling/Inclusion] Add symbol mappings for `std::experimental::filesystem` (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

shafik added a comment. In D143891#4122731 , @aaron.ballman wrote: > In D143891#4122668 , @royjacobson > wrote: > >> In D143891#4122660 , >> @aaron.ballman wrote: >> >>

[clang] b6259ec - [Clang] Export CanPassInRegisters as a type trait

Author: Roy Jacobson Date: 2023-02-13T19:16:23+02:00 New Revision: b6259eca16f6c923d87a1ca1d424931e37d6871a URL: https://github.com/llvm/llvm-project/commit/b6259eca16f6c923d87a1ca1d424931e37d6871a DIFF: https://github.com/llvm/llvm-project/commit/b6259eca16f6c923d87a1ca1d424931e37d6871a.diff

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6259eca16f6: [Clang] Export CanPassInRegisters as a type trait (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D1417

[PATCH] D141808: [Driver] Add --vfsoverlay flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5beebc98bb: [Driver] Add --vfsoverlay flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[clang] df5beeb - [Driver] Add --vfsoverlay flag

Author: Alex Brachet Date: 2023-02-13T17:25:45Z New Revision: df5beebc98bbe76312e3a416d5fbc563c037923c URL: https://github.com/llvm/llvm-project/commit/df5beebc98bbe76312e3a416d5fbc563c037923c DIFF: https://github.com/llvm/llvm-project/commit/df5beebc98bbe76312e3a416d5fbc563c037923c.diff LOG:

[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

sunshaoce added a comment. I tend to keep it as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141698/new/ https://reviews.llvm.org/D141698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 756395f - [clang] fix DR status in cxx_status.html

Author: Corentin Jabot Date: 2023-02-13T09:30:57-08:00 New Revision: 756395f61b90e30c9087b5efa8b4809ab03aff6e URL: https://github.com/llvm/llvm-project/commit/756395f61b90e30c9087b5efa8b4809ab03aff6e DIFF: https://github.com/llvm/llvm-project/commit/756395f61b90e30c9087b5efa8b4809ab03aff6e.diff

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4122821 , @aaron.ballman wrote: >> How about including existing options, which //should// be set in >> constructor, in the initial struct version and deprecating the corresponding >> setters? > > I think that makes a l

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

madanial updated this revision to Diff 497024. madanial added a comment. Addressing the review comments relating to the test case. Thanks for the catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 Files: clang/include/clang/Driver/Option

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. FWIW, I agree that switch labels and goto labels are conceptually quite different: the thing before a switch label is an expression, and if it's an identifier it references an already-declared entity with its own kind (e.g. enumerator), whereas a goto label basically dec

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

royjacobson added inline comments. Comment at: clang/lib/AST/Type.cpp:2495 + // FIXME: We should merge this definition of triviality into + // CXXRecordDecl::isTrivial. Currently it computes the wrong thing. + return ClassDecl->hasTrivialDefaultConstructor() && ---

[PATCH] D143260: [clangd] Add semantic token for labels

nridge added a comment. Another potential consideration here is the GNU "labels as values " language extension, which clang seems to support, and which allows referencing a `LabelDecl` from a context other than a goto-statement (and thus

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

hoy added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1169-1171 + // On PowerPC and ARM/Thumb, if the address of a branch is the same as + // the target, it means that it's a function call. Do not mark the label + // for this case. ---

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4123468 , @vedgy wrote: > In D143418#4122821 , @aaron.ballman > wrote: > >>> How about including existing options, which //should// be set in >>> constructor, in the ini

[PATCH] D143781: [Clang][LLVM] Enable __arithmetic_fence and fprotect-parens on AArch64

alexander-shaposhnikov added a comment. sure, will do! thanks for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143781/new/ https://reviews.llvm.org/D143781 ___ cfe-commits mailing list cfe-co

[PATCH] D142316: [clang] Add test for CWG2396

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142316/new/ https://reviews.llvm.org/D142316 ___

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

efriedma added a comment. We have code somewhere to generically copy attributes from function templates to instantiations, right? Why do we need to explicitly copy StrictFPAttr in particular, separate from that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

efriedma added a comment. In D140123#4113536 , @efriedma wrote: > Missing LangRef change? Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140123/new/ https://reviews.llvm.org/D140123

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 497045. TIFitis added a comment. Fixing build errors. Added mlir/lib/Target/LLVMIR/Dialect/Utils.cpp, made it part of the MLIRTargetLLVMIRExport lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ h

  1   2   >