svenvh accepted this revision. svenvh added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:840 + * Fixed conditional definition of the depth image and read_write image3d builtins. + * Added ``nounwind`` attribute to all builtin functions. + ---------------- Anastasia wrote: > svenvh wrote: > > It's slightly more than that: clang adds `nounwind` not only for builtin > > functions, but for any OpenCL function call. > Thanks, this makes sense... stack unwind in OpenCL kernel is meaningless atm. > > However has this change been made in a separate commit? The change of https://reviews.llvm.org/D142033 is not specific to builtins. Please remember to decrease the indent level of this bullet point, so that it is no longer under "Improved builtin functions support". Otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
