[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. @akyrtzi Thank you for your feedback. Can I land the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:678 +if (Preamble) { + auto PDiags = Patch->patchedDiags(); + Diags->insert(Diags->end(), PDiags.begin(), PDiags.end()); llvm::append_range(Diags, Patch->patchedDiag

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

tschuett added a comment. For AArch64 the default alignment is 0? I would have expected 128. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings added a comment. In D142932#4111925 , @phosek wrote: > Do you know if regular expressions are necessary to cover the existing use > cases? Yes. One use case is mapping later architecture versions to the last architecture version support

[clang] 1782e8f - [C++20] [Modules] Allow -fmodule-file== for implementation unit and document the behavior

Author: Chuanqi Xu Date: 2023-02-08T16:45:00+08:00 New Revision: 1782e8f9e882e8f4fb59968ff555c8c93827ea02 URL: https://github.com/llvm/llvm-project/commit/1782e8f9e882e8f4fb59968ff555c8c93827ea02 DIFF: https://github.com/llvm/llvm-project/commit/1782e8f9e882e8f4fb59968ff555c8c93827ea02.diff LO

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:648 + }); + if (NotePointsToOutside) +return true; Oh yeah, one more thing :-) Currently if the note/fix aren't at this line we're bailing out of the diagnostic entirely.

[PATCH] D143559: [Tooling/Inclusion] Use the StdSpecialSymbolMap.inc in the stdlib

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added projects: clang, clang-tools-extra. Remove a special-case in clangd.

[PATCH] D143093: [clangd] #undef macros inside preamble patch

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:216 unsigned Offset; + tok::PPKeywordKind Directive; + // Name of the macro being defined in the case of a #d

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:102 + auto PatchedRange = [&M](CharSourceRange &R) { +// FIXME: Should we handle all presumed locations? +

[PATCH] D143549: [clang][AIX] Remove test for the default OpenMP runtime

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143549/new/ https://reviews.llvm.org/D143549 ___

[PATCH] D143560: clang-format.el: fix warnings

augfab created this revision. augfab added reviewers: sammccall, phst, djasper. augfab added a project: clang-format. Herald added a project: All. augfab requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Emacs trunk complained about: Warni

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

sammccall added a comment. Only serious concern is `getPreviousToken()`. Comment at: clang/lib/Format/FormatTokenSource.h:74 public: - IndexedTokenSource(ArrayRef Tokens) + IndexedTokenSource(SmallVectorImpl &Tokens) : Tokens(Tokens), Position(-1) {}

[PATCH] D143560: clang-format.el: fix warnings

phst requested changes to this revision. phst added inline comments. This revision now requires changes to proceed. Comment at: clang/tools/clang-format/clang-format.el:70 (cl-case (xml-node-name node) -('replacement +((replacement quote)

[clang] 5ae99be - [clang][AIX] Remove test for the default OpenMP runtime

Author: wangpc Date: 2023-02-08T17:47:52+08:00 New Revision: 5ae99be0377248c74346096dc475af254a3fc799 URL: https://github.com/llvm/llvm-project/commit/5ae99be0377248c74346096dc475af254a3fc799 DIFF: https://github.com/llvm/llvm-project/commit/5ae99be0377248c74346096dc475af254a3fc799.diff LOG: [

[PATCH] D143549: [clang][AIX] Remove test for the default OpenMP runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ae99be03772: [clang][AIX] Remove test for the default OpenMP runtime (authored by pcwang-thead). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143549/new/

[PATCH] D143482: [SanitizerBinaryMetadata] Optimize used space for features and UAR stack args

dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143482/new/ https://reviews.llvm.org/D143482

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495771. hokein added a comment. update the standard-library tests, and fix a bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/include/clang/Tooling/

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495776. hokein added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. fix the clangd unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.l

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); This is a behavior change

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske added a comment. Probably it is not always useful to explain why the argument is wrong. In cases when we can find out that the value is exactly between two consecutive valid ranges we can display a note, or when the exact value is known. Otherwise it may end up in something like "the v

[PATCH] D143569: [Tooling/Inclusions] Add more multi-header symbols to StdSpecialSymbolMap.inc

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143569 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder updated this revision to Diff 495786. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141472/new/ https://reviews.llvm.org/D141472 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Funct

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 495789. tbaeder set the repository for this revision to rG LLVM Github Monorepo. tbaeder added a comment. Fixed all the new test cases by adding a new `CallVirt` opcode and only using that if appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

kadircet updated this revision to Diff 495790. kadircet marked 4 inline comments as done. kadircet retitled this revision from "[clangd] Patch includes even without any changes" to "[clangd] Fix bugs in main-file include patching for stale preambles". kadircet edited the summary of this revision.

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:690 +// it's coming from baseline preamble. +if (It->second) { + Inc.Resolved = It->second->Resolved; sammccall wrote: > why the null check? as discussed of

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby added a comment. I think the other suggestion from the warning should be applied, as I don't think it _is_ intended that "quote" is matched by either of these. It would actually be odd if it did as you'd have two matches. Comment at: clang/tools/clang-format/clang-

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings updated this revision to Diff 495798. michaelplatings added a comment. Replace makeMultilibBuilder() with a MultilibBuilder constructor that initializes all suffixes to the same value. In the case of AndroidMipsMultilibs it was apparently intended that only the GCC suffix was se

[PATCH] D142534: [clang][codegen] Fix emission of consteval constructor of derived type

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D142534: [clang][codegen] Fix emission of consteval constructor of derived type

Fznamznon added a comment. I discovered that this patch also helps to fix crash reported in https://github.com/llvm/llvm-project/issues/59223 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 ___

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495800. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143482: [SanitizerBinaryMetadata] Optimize used space for features and UAR stack args

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d53b5273003: [SanitizerBinaryMetadata] Optimize used space for features and UAR stack args (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D143484: [SanitizerBinaryMetadata] Emit constants as ULEB128

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf9814b70560: [SanitizerBinaryMetadata] Emit constants as ULEB128 (authored by melver). Changed prior to commit: https://reviews.llvm.org/D143484?vs=495442&id=495802#toc Repository: rG LLVM Github Mo

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings marked 4 inline comments as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:35-39 std::string GCCSuffix; std::string OSSuffix; std::string IncludeSuffix; flags_list Flags; int Priority;

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); hokein wrote: > This is

[PATCH] D143569: [Tooling/Inclusions] Add more multi-header symbols to StdSpecialSymbolMap.inc

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:37 +SYMBOL(swap, std::, ) // since C++17 +SYMBOL(swap, std::, ) // until C++11 +// C++ [tuple.

[PATCH] D143559: [Tooling/Inclusion] Use the StdSpecialSymbolMap.inc in the stdlib

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/StandardLibraryTest.cpp:65 stdlib::Header::named(""))); + EXPECT_THAT(stdlib::Symbol::named("std::", "

[PATCH] D143560: clang-format.el: fix warnings

augfab added inline comments. Comment at: clang/tools/clang-format/clang-format.el:70 (cl-case (xml-node-name node) -('replacement +((replacement quote) (let* ((offset (xml-get-attribute-or-nil node 'offset)) phst

[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. In D141472#4107008 , @aaron.ballman wrote: > In D141472#4106091 , @tbaeder wrote: > >>> Member pointers (for functions or for data) are weird in that they're not >>> the typical pointer

[PATCH] D143560: clang-format.el: fix warnings

augfab updated this revision to Diff 495815. augfab edited the summary of this revision. augfab added a comment. Applied suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 Files: clang/tools/clang-format/clang-format.el Index: cl

[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

sammccall added a comment. Based on offline discussion, doubling down on checking in generated files to make these easy/possible to consume where they're needed. rebased and addressed high level comments (I think!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz added a comment. In D143414#4110461 , @benlangmuir wrote: >> This should allow the path serialization of input files to use the paths >> used when looking up a file entry, instead of the last reference. > > Isn't this at odds with not having the VF

[PATCH] D142534: [clang][codegen] Fix emission of consteval constructor of derived type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note about the issues this fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https:/

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

sunshaoce abandoned this revision. sunshaoce added a comment. A better implementation is in D143572 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 _

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:146 // CHECK-LABEL: test_mm256_castpd128_pd256 - // CHECK: shufflevector <2 x double> %{{.*}}, <2 x double> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x double> %{{.*}}, <2 x double> %{{.

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:691 +// it's coming from baseline preamble. +if (It->second) + PatchedInc = *It->second;

[PATCH] D143587: [Docs] Multilib design

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, phosek. Herald added a subscriber: arphaman. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D142534: [clang][codegen] Fix emission of consteval constructor of derived type

Fznamznon updated this revision to Diff 495851. Fznamznon added a comment. Rebase and add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 Files: clang/docs/ReleaseNotes.rst clang/lib/Co

[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143507/new/ https://reviews.llvm.org/D143507 ___

[clang] 37eb9d1 - Revert "[Support] change StringMap hash function from djbHash to xxHash"

Author: Erik Desjardins Date: 2023-02-08T10:41:51-05:00 New Revision: 37eb9d13f891f7656f811516e765b929b169afe0 URL: https://github.com/llvm/llvm-project/commit/37eb9d13f891f7656f811516e765b929b169afe0 DIFF: https://github.com/llvm/llvm-project/commit/37eb9d13f891f7656f811516e765b929b169afe0.dif

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. In D141910#4112164 , @tschuett wrote: > For AArch64 the default alignment is 0? I would have expected 128. The refactored function `TargetInfo::getSimdDefaultAlign` is used only for calculation of default alignment for `#pragma o

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4112144 , @domada wrote: > @akyrtzi Thank you for your feedback. Can I land the patch? Fine be me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 495860. rcvalle added a comment. Fixed initialization order warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst cla

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495864. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel updated this revision to Diff 495866. jcranmer-intel marked 2 inline comments as done. jcranmer-intel added a comment. Herald added a subscriber: jdoerfert. This updates code, and rebases tests on top of trunk. Note: test issues still haven't been fixed, will fix that likely in the

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel marked an inline comment as done. jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2260 -return CGF.CGM.getNullPointer(cast(ConvertType(DestTy)), - DestTy); +// The type may be a target exte

[PATCH] D143590: [NFC] Simplify test from change D73904

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This part of the test can break if multilib is enabled, and isn't

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added a comment. In D127855#4048642 , @jyu2 wrote: > In D127855#3956014 , @sandeepkosuri > wrote: > >> As I do not have commit access, can someone commit this patch, now that it >> passes the pre-m

[PATCH] D143590: [NFC] Simplify test from change D73904

amilendra accepted this revision. amilendra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143590/new/ https://reviews.llvm.org/D143590

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional created this revision. everythingfunctional added reviewers: ktras, rouson, awarzynski, CarolineConcatto, rovka, stuartellis, tarunprabhu, mnadeem, PeteSteinfeld, peixin, clementval, jpenix-quic, ekieri, FarisRehman, arnamoy10, DavidTruby, mstorsjo, Ericson2314, klausler, ss

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

aprantl added a comment. Nice! Does `expr -- std::basic_string s` still work after this change? Not that anyone would want to type this over `std::string` ... Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limite

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:624 + + llvm::StringLiteral BaselinePreamble = "#define FOO\n"; + { sammccall wrote: > nit: "preamble" vs "code" is a confusing distinction when we're using both as

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495879. kadircet marked 10 inline comments as done. kadircet added a comment. - Use raw string literals - Make tests more expressive by mentioning diagnostic names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

benlangmuir added a comment. +1 for determinism. Okay I spent some time trying to understand how this code is used and the non-virtual paths make some sense now. I am a bit skeptical about this on-disk-hash-table by filepath but that's separate from this patch. Comment at:

[clang] 5d07e04 - [TLS]: Clamp the alignment of TLS global variables if required by the target

Author: Wolfgang Pieb Date: 2023-02-08T10:34:56-08:00 New Revision: 5d07e0448e38d4be0cc7b1079d72b5e3644e941c URL: https://github.com/llvm/llvm-project/commit/5d07e0448e38d4be0cc7b1079d72b5e3644e941c DIFF: https://github.com/llvm/llvm-project/commit/5d07e0448e38d4be0cc7b1079d72b5e3644e941c.diff

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d07e0448e38: [TLS]: Clamp the alignment of TLS global variables if required by the target (authored by wolfgangp). Herald added a project: clang. He

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - -debugger-tuning=lldb | FileCheck --check-prefixes=COMMON,LLDB %s +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=lim

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. In D143501#4113347 , @aprantl wrote: > Nice! Does `expr -- std::basic_string s` still work after this change? > Not that anyone would want to type this over `std::string` ... Yup that still works. We would still emit it as `b

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

kadircet updated this revision to Diff 495884. kadircet marked 2 inline comments as done. kadircet added a comment. - use rawstrings in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143197/new/ https://reviews.llvm.org/D143197 Files: clang-

[PATCH] D143597: [clangd] Drop includes from disabled PP regions in preamble patch

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In rest of t

[PATCH] D143197: [clangd] Fix bugs in main-file include patching for stale preambles

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:691 +// it's coming from baseline preamble. +if (It->second) + PatchedInc = *It->second; sammccall wrote: > if It->second is null, then all the `#includes`

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet updated this revision to Diff 495889. kadircet added a comment. - Insert missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 Files: clang-tools-extra/clangd/Config.h clang-tools-e

[PATCH] D143093: [clangd] #undef macros inside preamble patch

kadircet updated this revision to Diff 495891. kadircet marked 3 inline comments as done. kadircet added a comment. - Use raw strings - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143093/new/ https://reviews.llvm.org/D143093 Files: clan

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

kadircet updated this revision to Diff 495893. kadircet marked 3 inline comments as done. kadircet added a comment. - Drop FIXME for respecting all presumed locations - Use PatchLoc instead of PLoc - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D140123: [TLS] Clamp the alignment of TLS global variables if required by the target

efriedma added a comment. Missing LangRef change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140123/new/ https://reviews.llvm.org/D140123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 98e7670 - [Tooling/Inclusion] Add more multi-header symbols to StdSpecialSymbolMap.inc

Author: Haojian Wu Date: 2023-02-08T20:15:47+01:00 New Revision: 98e7670b64d8b5bbb12432945b476cc9634b6358 URL: https://github.com/llvm/llvm-project/commit/98e7670b64d8b5bbb12432945b476cc9634b6358 DIFF: https://github.com/llvm/llvm-project/commit/98e7670b64d8b5bbb12432945b476cc9634b6358.diff LO

[PATCH] D143569: [Tooling/Inclusions] Add more multi-header symbols to StdSpecialSymbolMap.inc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG98e7670b64d8: [Tooling/Inclusion] Add more multi-header symbols to StdSpecialSymbolMap.inc (authored by hoke

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

jansvoboda11 added a comment. Having this check is great! Left some nits in-line. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:644-650 // May perform round-trip of command line arguments. By default, the round-trip // is enabled in assert builds. This can be overwrit

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4111890 , @sunho wrote: > I think it makes more sense to use stable version of clang-format for that > purpose but I'm not in a postion to decide as I don't work with format. Can > you change the script to use latest

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495910. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang-tools-extra/cl

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37 EXPECT_THAT(CXX, HasSubstr("#include ")); - EXPECT_THAT(CXX, Not(HasSubstr("#include "))); + EXPECT_THAT(CXX, HasSubstr("#include ")); kadircet wrote: > hokein

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training (WIP)

Amir updated this revision to Diff 495915. Amir added a comment. Fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/utils/perf-trai

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3884 if (Style.isCpp()) { +if (Right.is(tok::period) && Left.is(tok::numeric_constant)) + return true; Add a comment w

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3884 if (Style.isCpp()) { +if (Right.is(tok::period) && Left.is(tok::numeric_constant)) + return true; HazardyKnusperkeks wrote: > Add a comment what that is? Without the b

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir abandoned this revision. Amir added a comment. Abandon in favor of D143553 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 _

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rymiel added a comment. In D143546#4112077 , @owenpan wrote: > As this one is an invalid-code-generation bug, I wanted it fixed ASAP. Do you intend to backport it to the 16 release branch then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143546: [clang-format] Insert a space between a numeric UDL and a dot

rsmith added a comment. I wonder if this can be fixed more generally by using `TokenConcatenation::AvoidConcat` to determine whether `clang-format` should require a space between two tokens. This is the logic that `clang -E` uses when printing preprocessed tokens to avoid token splices. For exa

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 495925. abidmalikwaterloo added a comment. Rebase the patch to origin/main with all updates. Made changes to make it buildable using the new changes. (WIP). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir updated this revision to Diff 495935. benlangmuir added a comment. - Improved doc comment for RoundTrip (mostly followed the suggested text; also converted from // to ///). - Renamed variables - Moved default value for RoundTripArgs CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir marked 3 inline comments as done. benlangmuir added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:658 +#endif + if (RoundTripArgs.getNumOccurrences() ? RoundTripArgs : DoRoundTripDefault) +if (FD.roundTripCommands(llvm::errs())) -

[PATCH] D143592: [flang][driver] Rename `flang-new -flang-experimental-exec` to `flang`

everythingfunctional updated this revision to Diff 495940. everythingfunctional added a comment. Fix the flang program path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143592/new/ https://reviews.llvm.org/D143592 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Drive

[PATCH] D143553: [Clang][CMake] Add BOLT perf-training

Amir updated this revision to Diff 495941. Amir added a comment. Fixed BOLT-PGO build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143553/new/ https://reviews.llvm.org/D143553 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake clang/

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143446/new/ https://reviews.llvm.org/D143446 ___ cfe-commits maili

[clang] 829bcb0 - [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

Author: Ziqing Luo Date: 2023-02-08T14:12:03-08:00 New Revision: 829bcb06ec43ab4b56b95ff040ec9d36feeaf06a URL: https://github.com/llvm/llvm-project/commit/829bcb06ec43ab4b56b95ff040ec9d36feeaf06a DIFF: https://github.com/llvm/llvm-project/commit/829bcb06ec43ab4b56b95ff040ec9d36feeaf06a.diff LO

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D139395: Add CFI integer types normalization

samitolvanen accepted this revision. samitolvanen added a comment. Thanks for fixing the MSan issue, Ramon. There's still a clang-format error that trips the Debian build above, but it's trivial so I can fix it when relanding the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] cf73d3f - [clang][deps] Ensure module invocation can be serialized

Author: Ben Langmuir Date: 2023-02-08T14:23:39-08:00 New Revision: cf73d3f07b5b0ff83a852dfdf8857500e86f9952 URL: https://github.com/llvm/llvm-project/commit/cf73d3f07b5b0ff83a852dfdf8857500e86f9952 DIFF: https://github.com/llvm/llvm-project/commit/cf73d3f07b5b0ff83a852dfdf8857500e86f9952.diff

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. benlangmuir marked an inline comment as done. Closed by commit rGcf73d3f07b5b: [clang][deps] Ensure module invocation can be serialized (authored by benlangmuir). Repo

[clang] 71c7313 - Add CFI integer types normalization

Author: Ramon de C Valle Date: 2023-02-08T22:24:19Z New Revision: 71c7313f42d2b6063fea09854cf4fc46fd0627e1 URL: https://github.com/llvm/llvm-project/commit/71c7313f42d2b6063fea09854cf4fc46fd0627e1 DIFF: https://github.com/llvm/llvm-project/commit/71c7313f42d2b6063fea09854cf4fc46fd0627e1.diff L

[PATCH] D139395: Add CFI integer types normalization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71c7313f42d2: Add CFI integer types normalization (authored by rcvalle, committed by samitolvanen). Changed prior to commit: https://reviews.llvm.

  1   2   >