hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/StdLibTests.cpp:37
EXPECT_THAT(CXX, HasSubstr("#include <cstdio>"));
- EXPECT_THAT(CXX, Not(HasSubstr("#include <stdio.h>")));
+ EXPECT_THAT(CXX, HasSubstr("#include <stdio.h>"));
----------------
kadircet wrote:
> hokein wrote:
> > This is a behavior change, I think it is probably fine. Would be nice to
> > have a second look.
> let's change it to `stdatomic.h` instead.
`stdatomic.h` is still a c-compa header (though we don't have a entry in the
StdSymbolMap.inc now). `<iso646.h>` might be better, it is empty file in C++
per C++ [standard](https://eel.is/c++draft/iso646.h.syn), so we never have a
symbol for this header in C++ symbol map.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143214/new/
https://reviews.llvm.org/D143214
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
