[clang] e685bde - [Clang][RISCV] Bump rvv intrinsics version to v0.11

Author: eopXD Date: 2023-02-02T00:08:29-08:00 New Revision: e685bde1e0b0dcfeb1619b434a5dce3c755b9631 URL: https://github.com/llvm/llvm-project/commit/e685bde1e0b0dcfeb1619b434a5dce3c755b9631 DIFF: https://github.com/llvm/llvm-project/commit/e685bde1e0b0dcfeb1619b434a5dce3c755b9631.diff LOG: [C

[PATCH] D143051: [Clang][RISCV] Bump rvv intrinsics version to v0.11

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe685bde1e0b0: [Clang][RISCV] Bump rvv intrinsics version to v0.11 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. Another disadvantage of using `CINDEX_VERSION_MINOR` instead of the `sizeof` is that an older libclang version won't know about compatibility of newer versions with itself. But this reasoning brought me to a different thought: when a program is compiled against a libclang

[PATCH] D142448: [clang][Interp] Handle TypeTraitExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142448/new/ https://reviews.llvm.org/D142448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/lambda-unevaluated.cpp:127 +auto foo(int t) { + int(*f)(int) = [](auto t) -> decltype([=] { return t; } ()) { return t; }; + return f; I thought unevaluated lambdas could not have captures. that mig

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

phosek added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:17 + + set(oneValueArgs PREFIX SUBDIR) + cmake_parse_arguments(RESOURCE_DIR "" "${oneValueArgs}" "" ${ARGN}) This variable is only used once on the following line, I'd just inline

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1417-1418 + assert(!BD->getHoldingVar()); // FIXME + if (!this->allocateVariable(BD, BD->getBinding())) +return false; +} aaron.ballman wrote: > tbaeder wrot

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

rjmccall added a comment. This seems reasonable to me. Eli, are your questions answered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142584/new/ https://reviews.llvm.org/D142584 ___ cfe-commits mailin

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. LGTM other than test header comment that needs changed. Comment at: clang/test/Driver/riscv-rvv-vector-bits.c:2 +// ---

[PATCH] D142933: Add -print-multi-selection-flags argument

Joe added a comment. >> The main trouble I had was at that point we don't have a reference to the >> ToolChain, so calling `getMultiSelectionFlags` was not possible. [...] I'm >> not sure what the solution here is. > > I see two options: > > 1. Split getMultiSelectionFlags into needs-ToolChain

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494221. Fznamznon added a comment. Apply suggestion and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driv

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 494222. Fznamznon added a comment. Fix incorrect conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/li

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

hans added a comment. In D142826#4098014 , @chapuni wrote: > This discovers a warning in > https://reviews.llvm.org/rGa68d4b11465f5b3326be1dd820f59fac275b7581 > I think its checking is valid if size_t is uint32_t (eg. -m32) > > Could you guys teach me wh

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/test/Driver/x-args.c:12 +// RUN: not %clang_cl /TC /WX /clang:-xc /clang:-E /clang:-dM %s 2>&1 | FileCheck -check-prefix=CL %s +// CL-NOT: '-x c' after last input file has no effect +// CL: error: unsupported option '-x c'; did

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 494223. paperchalice added a comment. - Use `clang::driver::Driver::GetResourcesPath` - Use `ARG` as prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + zero9178 wrote: > Any reason this is `mutable`? I don't see it being used a non-const way in a > const method yeah, `T const

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://reviews.llvm.org/D142181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdd44e2c8554: [C++20][Modules] Handle template declarations in header units. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] cdd44e2 - [C++20][Modules] Handle template declarations in header units.

Author: Iain Sandoe Date: 2023-02-02T10:51:08Z New Revision: cdd44e2c85542d152aef19cfd1d2ad451d774935 URL: https://github.com/llvm/llvm-project/commit/cdd44e2c85542d152aef19cfd1d2ad451d774935 DIFF: https://github.com/llvm/llvm-project/commit/cdd44e2c85542d152aef19cfd1d2ad451d774935.diff LOG: [

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder updated this revision to Diff 494235. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[clang] 4a1832a - [Clang] Add builtin_nondeterministic_value

Author: ManuelJBrito Date: 2023-02-02T11:14:17Z New Revision: 4a1832a5c801a61bf4c30891aaebe63993712fd9 URL: https://github.com/llvm/llvm-project/commit/4a1832a5c801a61bf4c30891aaebe63993712fd9 DIFF: https://github.com/llvm/llvm-project/commit/4a1832a5c801a61bf4c30891aaebe63993712fd9.diff LOG:

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a1832a5c801: [Clang] Add builtin_nondeterministic_value (authored by ManuelJBrito). Changed prior to commit: https://reviews.llvm.org/D142388?vs=

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. Thank you all for the reviews and helping me see this patch through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388 ___ cfe-commi

[PATCH] D142384: [C++20] Fix a crash with modules.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In D142384#4098650 , @usaxena95 wrote: > I think this is fine, and we should just use the definition when it is > available without aski

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

hokein added a comment. Thanks! The changes in C++ mapping are good in general. Most removals are reasonable, my only concern is the removal of `std::{begin, end, size, empty, data}` (as they are now provided by multiple headers), IMO these are important symbols (no action needed in this patch

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings added a comment. In D142933#4099043 , @Joe wrote: > I did briefly try to pass a ToolChain to Gnu.cpp functions, but it became > intrusive and had to add it in 5+ places, so unless I'm missing a trick to > get the ToolChain from the Drive

[PATCH] D142277: [clang][Interp] Clear metadata when destroying locals

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:260-261 +// local variable is used after being destroyed. +InlineDescriptor &ID = *reinterpret_cast(B->rawData()); +std::memset(&ID, 0, sizeof(InlineDescriptor)); } aar

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo updated this revision to Diff 494250. VitaNuo added a comment. Remove the C symbol map from commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143054/new/ https://reviews.llvm.org/D143054 Files: clang/include/clang/Tooling/Inclusions/

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

VitaNuo added a comment. Sure, removed the C symbol mapping from this patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143054/new/ https://reviews.llvm.org/D143054 ___ cfe-commits mailing lis

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. Hello Luca and Aaron. I have noticed that you recently implemented/reviewed multiple interesting libclang features, some of which can be used in KDevelop. However, `CINDEX_VERSION_MINOR` was last modified in Clang 13. This constant's documentation states: > `CINDEX_VERSI

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + serge-sans-paille wrote: > zero9178 wrote: > > Any reason this is `mutable`? I don't see it being used a non-const way in > > a const

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

hokein added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:31 + +static llvm::DenseMap LanguageMappings; + VitaNuo wrote: > hokein wrote: > > using a map here seems like an overkill, we have just 2 elements, I'd just > > us

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added a comment. So this is getting some build failures: - https://lab.llvm.org/buildbot#builders/38/builds/9446 - https://lab.llvm.org/buildbot#builders/245/builds/4189 - https://lab.llvm.org/buildbot#builders/65/builds/7949 - https://lab.llvm.org/buildbot#builders/188/builds/25538

[PATCH] D142878: Add testing for Fuchsia multilib

michaelplatings updated this revision to Diff 494258. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142878/new/ https://reviews.llvm.org/D142878 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/D

[PATCH] D142893: Class for building MultilibSet

michaelplatings updated this revision to Diff 494259. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://reviews.llvm.org/D142893 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { tkuchta wrote: > browneee wrote: > > tkuchta wrote: > > > bro

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 494260. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 494262. michaelplatings added a comment. Rebase and change llvm::SmallVector to simply llvm::SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 File

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

Szelethus added a comment. While we were there, we also dug into `std::any`, and learned that the analyzer can model it shockingly well. Hopefully we can submit a few patches that demonstrates it in a form of some test files. In D142354#4079758 , @steak

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099326 , @vedgy wrote: > Hello Luca and Aaron. > I have noticed that you recently implemented/reviewed multiple interesting > libclang features, some of which can be used in KDevelop. However, > `CINDEX_VERSION

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 +/// - Strict +std::optional> Mode; + kadircet wrote: > sammccall wrote: > > I think "Diagnostics.Mode" is too vague a name. > > > > I expect this to be a rollout

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Alright, I've done a full reanalysis after a rebase. Overhead is not meaningfully measurable, even for complex TUs such as LLVM. The check is viable in C++ code as it finds cases (such

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

thakis added a comment. Looks like the test fails on win: http://45.33.8.238/win/74290/step_7.txt And Mac: http://45.33.8.238/macm1/54080/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] f27c8ac - [clang-tidy] Add the `bugprone-unsafe-functions` check

Author: Gergely Fűtő Date: 2023-02-02T14:11:42+01:00 New Revision: f27c8ac83e7cb945c8b3f9bf0092f8cf93278b5c URL: https://github.com/llvm/llvm-project/commit/f27c8ac83e7cb945c8b3f9bf0092f8cf93278b5c DIFF: https://github.com/llvm/llvm-project/commit/f27c8ac83e7cb945c8b3f9bf0092f8cf93278b5c.diff

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf27c8ac83e7c: [clang-tidy] Add the `bugprone-unsafe-functions` check (authored by futogergely, committed by whisperity). Changed prior to commit: https://reviews.llvm.org/D91000?vs=485774&id=494265#toc

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:493-494 /// Returns the pointer that points to the beginning of line that contains /// the given offset, or null if the offset if invalid. +const char *Lexer::findBeginningOfLine(StringRef Buffer, unsi

[clang] 79571aa - Bump CINDEX_VERSION_MINOR due to additional APIs

Author: Aaron Ballman Date: 2023-02-02T08:49:12-05:00 New Revision: 79571aa2103c95760a07e3549d8636379e4948f0 URL: https://github.com/llvm/llvm-project/commit/79571aa2103c95760a07e3549d8636379e4948f0 DIFF: https://github.com/llvm/llvm-project/commit/79571aa2103c95760a07e3549d8636379e4948f0.diff

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099410 , @aaron.ballman wrote: > In D140756#4099326 , @vedgy wrote: > >> Hello Luca and Aaron. >> I have noticed that you recently implemented/reviewed multiple interest

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. Oddly enough, one of the buildbots caught a not matching test that was working locally... on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. > 79571aa2103c95760a07e3549d8636379e4948f0 > is the > commit on main and https://github.com/llvm/llvm-project/issues/60478 is for > the 16.x cherry-pick. Thank you Aaron! But note that this review's co

[clang] adf7ffd - Revert "[Clang] Add builtin_nondeterministic_value"

Author: Nico Weber Date: 2023-02-02T08:59:27-05:00 New Revision: adf7ffd51ee34c3a72d3168f5aed8b946ba3d2cc URL: https://github.com/llvm/llvm-project/commit/adf7ffd51ee34c3a72d3168f5aed8b946ba3d2cc DIFF: https://github.com/llvm/llvm-project/commit/adf7ffd51ee34c3a72d3168f5aed8b946ba3d2cc.diff LO

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

thakis added a comment. Reverted in adf7ffd51ee34c3a72d3168f5aed8b946ba3d2cc for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142388/new/ https://reviews.llvm.org/D142388

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > tkuchta wrote: > > browneee wrote: > > > tku

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman added a comment. In D142826#4098014 , @chapuni wrote: > This discovers a warning in > https://reviews.llvm.org/rGa68d4b11465f5b3326be1dd820f59fac275b7581 > I think its checking is valid if size_t is uint32_t (eg. -m32) > > Could you guys te

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099558 , @vedgy wrote: >> 79571aa2103c95760a07e3549d8636379e4948f0 >> is the >> commit on main and https://github.com/llvm/llvm-project/issu

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

Backl1ght updated this revision to Diff 494281. Backl1ght added a comment. adapt suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

erichkeane added a comment. In D142388#4099374 , @ManuelJBrito wrote: > So this is getting some build failures: > > - https://lab.llvm.org/buildbot#builders/38/builds/9446 > - https://lab.llvm.org/buildbot#builders/245/builds/4189 > - https://lab.llvm.or

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

Backl1ght marked an inline comment as done. Backl1ght added a comment. In D143091#4097534 , @HazardyKnusperkeks wrote: > An entry in the changelog would be nice. It is already added I think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091

[PATCH] D142933: Add -print-multi-selection-flags argument

Joe added a comment. > Thanks for explaining. I found that when I was writing a regex to match flags > it was helpful to have a part of the string I could be sure would be there to > avoid matching the wrong type of flag, and `march=` helped with that. I also > worry that names from different

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. Alright, right now, I have no meaningful idea why this failure appears , locally I'm trying every test command as they appear in the test, and all the tests

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added a comment. I meant that the commit message of https://reviews.llvm.org/rG79571aa2103c95760a07e3549d8636379e4948f0 misleadingly refers to this review's commit. But `CINDEX_VERSION_MINOR == 63` is for previous commits. This commit will require incrementing `CINDEX_VERSION_MINOR` agai

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 494283. tblah marked 8 inline comments as done. tblah added a comment. Changes: fix nits from review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 Files: clang/docs

[PATCH] D140415: [flang] stack arrays pass

tblah added a comment. In D140415#4098170 , @kiranchandramohan wrote: > Looks OK. I have a few questions and some minor comments inline. It might be > good to pull in a bit of info from the RFC into the Summary, particularly > saying why a dataflow ana

[clang-tools-extra] ed740e7 - [clang-tidy] Attempt fixing wrong caching result in `bugprone-unsafe-functions`

Author: Whisperity Date: 2023-02-02T15:24:40+01:00 New Revision: ed740e741ec22f9aaea09bfc0b87d0801a7c492f URL: https://github.com/llvm/llvm-project/commit/ed740e741ec22f9aaea09bfc0b87d0801a7c492f DIFF: https://github.com/llvm/llvm-project/commit/ed740e741ec22f9aaea09bfc0b87d0801a7c492f.diff LO

[PATCH] D143093: [clangd] #undef macros inside preamble patch

sammccall added a comment. I can't understand from the description, code, or testcases what problem this is fixing. Can you clarify, ideally by improving the testcases? It seems to introduce a false negative in the case that the preamble *does* contain a definition of an already-defined macro,

[PATCH] D143178: Add new clang-format alignment option

philbert created this revision. philbert added reviewers: MyDeveloperDay, owenpan. Herald added a project: All. philbert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I work on a code base that aligns all declarations execpt parameters to

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a subscriber: dyung. whisperity added a comment. Ping @dyung, it looks like you're the owner of the relevant build-bot. I can't find any information what `x86_64-sie` is... Meanwhile, it seems my attempt at fix is not actually fixing anything, I'm trying to figure out how to at

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall added a comment. It looks like this fixes up the location only of diagnostics attached to particular directives (`#include`) based on some "deep" idea about the content of the directive (the spelled header name). Some shortcomings: - This misses diagnostics attached to other directiv

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

cor3ntin accepted this revision. cor3ntin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/Parser.cpp:1415 +// +// FIXME: It looks not easy to balance PushExpressionEvaluationContext() +// and PopExpressionEvaluationC

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

aaron.ballman added a comment. In D140756#4099593 , @vedgy wrote: > I meant that the commit message of > https://reviews.llvm.org/rG79571aa2103c95760a07e3549d8636379e4948f0 > misleadingly refers to this review's commit. But `CINDEX_VERSION_MINOR == 63`

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

dyung added a comment. In D91000#4099657 , @whisperity wrote: > Ping @dyung, it looks like you're the owner of the relevant build-bot. I > can't find any information what `x86_64-sie` is... > > Meanwhile, it seems my attempt at fix is not actually fixing

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. In D91000#4099669 , @dyung wrote: > -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 > > Hopefully this can help you to reproduce the problem. Ah, thank you very much. And indeed, giving `--target=x86_64-scei-ps4` to Clang-Tidy

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

dyung added a comment. In D91000#4099744 , @whisperity wrote: > In D91000#4099669 , @dyung wrote: > >> -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 >> >> Hopefully this can help you to reproduce the problem. > > A

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser added a comment. In D143094#4098208 , @LuoYuanke wrote: > LGTM, thanks Thanks for the review. Do I need to wait for another approver before landing this? I mostly work on `libc++`, so not too familiar with expectations on Clang reviews, or whe

[PATCH] D143160: [include-mapping] Extend c-compatibility symbols in StdSymbolMap.inc

hokein updated this revision to Diff 494299. hokein added a comment. update, separate out a new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 Files: clang/include/clang/Tooling/Inclusions/StdSym

[PATCH] D143160: [include-mapping] Extend c-compatibility symbols in StdSymbolMap.inc

hokein updated this revision to Diff 494300. hokein added a comment. upload the missing file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143160/new/ https://reviews.llvm.org/D143160 Files: clang/include/clang/Tooling/Inclusions/CXXSymbolMap.i

[clang] 5e01234 - Add a new modules test to ensure we dont rebreak diagnostic

Author: Erich Keane Date: 2023-02-02T07:16:41-08:00 New Revision: 5e01234df81885fa882c58e062ca0cb87ac4849d URL: https://github.com/llvm/llvm-project/commit/5e01234df81885fa882c58e062ca0cb87ac4849d DIFF: https://github.com/llvm/llvm-project/commit/5e01234df81885fa882c58e062ca0cb87ac4849d.diff L

[PATCH] D140415: [flang] stack arrays pass

tblah added inline comments. Comment at: flang/lib/Optimizer/Transforms/StackArrays.cpp:732 + mlir::applyPartialConversion(func, target, std::move(patterns { +mlir::emitError(func->getLoc(), "error in stack arrays optimization\n"); +signalPassFailure(); -

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw updated this revision to Diff 494303. sstwcw added a comment. - add parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142891/new/ https://reviews.llvm.org/D142891 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/White

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846 return Style.AlignConsecutiveAssignments.AlignCompound ? C.Tok->getPrecedence() == prec::Assignment - :

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings marked an inline comment as done. michaelplatings added a comment. In D142933#4099587 , @Joe wrote: > Would it be weird for one target to have the `march=` but anothers not? Yes I think it would be weird. Potentially you could have a tool

[clang-tools-extra] 9225d08 - [NFC][clang-tidy] Disable test for `bugprone-unsafe-functions` for PlayStation

Author: Whisperity Date: 2023-02-02T16:35:08+01:00 New Revision: 9225d08ccca5be900c07eb89e907c4092bbdd462 URL: https://github.com/llvm/llvm-project/commit/9225d08ccca5be900c07eb89e907c4092bbdd462 DIFF: https://github.com/llvm/llvm-project/commit/9225d08ccca5be900c07eb89e907c4092bbdd462.diff LO

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. In D91000#4099773 , @dyung wrote: > To XFAIL the test, grep for lines with "XFAIL" and "ps4" and you should find > some examples. It was recently changed how it worked lately. Thank you, yes I found an example. I went with `UN

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 494314. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files: clang/li

[clang] b612143 - [C++20] Fix a crash with modules.

Author: Utkarsh Saxena Date: 2023-02-02T17:06:43+01:00 New Revision: b6121432da79c4b3d21f191864ff6c583e2e62eb URL: https://github.com/llvm/llvm-project/commit/b6121432da79c4b3d21f191864ff6c583e2e62eb DIFF: https://github.com/llvm/llvm-project/commit/b6121432da79c4b3d21f191864ff6c583e2e62eb.diff

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

shafik added inline comments. Comment at: clang/test/SemaCXX/lambda-unevaluated.cpp:127 +auto foo(int t) { + int(*f)(int) = [](auto t) -> decltype([=] { return t; } ()) { return t; }; + return f; cor3ntin wrote: > I thought unevaluated lambdas could not have ca

[PATCH] D142384: [C++20] Fix a crash with modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6121432da79: [C++20] Fix a crash with modules. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D141950: Use find_last_of when seraching for code in getRawCommentForDeclNoCacheImpl

kuganv created this revision. Herald added a subscriber: kadircet. Herald added a project: All. kuganv updated this revision to Diff 489882. kuganv edited the summary of this revision. kuganv added a comment. kuganv added subscribers: DmitryPolukhin, 0x1eaf, ivanmurashko. kuganv updated this revisi

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

vedgy added inline comments. Comment at: clang/tools/libclang/libclang.map:419 clang_getSymbolGraphForUSR; +clang_CXXMethod_isExplicit; }; This line should be moved from under the `LLVM_16` tag to under a new `LLVM_17` tag. Alternatively this commit ca

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true; efriedma

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev marked an inline comment as not done. dzhidzhoev added a comment. Existing code creating base subobject layout of classes is reused for unions * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741

[clang] fe08212 - [clang][driver] Emit an error for `/clang:-x`

Author: Mariya Podchishchaeva Date: 2023-02-02T11:48:33-05:00 New Revision: fe082124faa8455cc9a68be5fdf10fc46a4d066c URL: https://github.com/llvm/llvm-project/commit/fe082124faa8455cc9a68be5fdf10fc46a4d066c DIFF: https://github.com/llvm/llvm-project/commit/fe082124faa8455cc9a68be5fdf10fc46a4d06

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe082124faa8: [clang][driver] Emit an error for `/clang:-x` (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://revie

  1   2   3   >