[PATCH] D138713: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG98d55095d851: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location."… (authored by arseniy-sonar, committed by steakhal). Changed prior to commit: https://reviews.llvm.org/D13871

[PATCH] D140891: [analyzer] Fix assertion failure in SMT conversion for unary operator on floats.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3674421c4bc0: [analyzer] Fix assertion failure in SMT conversion for unary operator on floats (authored by tomasz-kaminski-sonarsource, committed by

[clang] 787876b - [unittests] Use GTEST_SKIP() instead of return when appropriate

Author: Paul Robinson Date: 2023-01-26T08:40:38-08:00 New Revision: 787876b0d592a6b4e87d00a0adb89ce87dfc11cd URL: https://github.com/llvm/llvm-project/commit/787876b0d592a6b4e87d00a0adb89ce87dfc11cd DIFF: https://github.com/llvm/llvm-project/commit/787876b0d592a6b4e87d00a0adb89ce87dfc11cd.diff

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

tahonermann added a comment. > You'll need a rebase to get the pre-commit CI to work. Yes, thank you. I'll wait for https://reviews.llvm.org/D142578 to land and then rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142639/new/ https://review

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. @rjmccall @ABataev Thanks for the help. So the basic idea is to build the expressions in Sema for those captured decls and then emit them accordingly in code gen, right? > There are a bunch of places we do that for various language extensions > already, includin

[PATCH] D142085: [WIP][1/N][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax

eopXD updated this revision to Diff 492474. eopXD added a comment. Update test case for vlenb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142085/new/ https://reviews.llvm.org/D142085 Files: clang/include/clang/Basic/riscv_vector.td clang/t

[PATCH] D142644: [WIP][2/N][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

eopXD created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#4083150 , @tianshilei1992 wrote: > @rjmccall @ABataev Thanks for the help. So the basic idea is to build the > expressions in Sema for those captured decls and then emit them accordingly > in code gen, right? Yes.

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added a comment. In D131306#4081864 , @jdoerfert wrote: > Drive by: There should be a lang ref component to this. Thanks for pointing out that we need to update the langref. Offhand, do you recall if there are places other than `BranchWeightM

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. In D131141#4082469 , @VincentWu wrote: > should I update zcb to v1.0 in this patch? > or create a new one Let's go ahead and commit this as is. I'll add Zcb to my version bump patch D142596

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. Can you also add test in `flang/test/Fir/external-mangling.fir`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

cfe-commits@lists.llvm.org

dkt01 marked 11 inline comments as done. dkt01 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1162-1169 + case TT_EnumLBrace: + case TT_ControlStatementLBrace: + case TT_ElseLBrace: + case TT_BracedListLBrace: + case TT_CompoundReq

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/arithmetic-fence-builtin.c clang/test/Sema/arithmetic-fence-builtin.c Index: clang/te

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float nou

cfe-commits@lists.llvm.org

dkt01 updated this revision to Diff 492482. dkt01 marked an inline comment as done. dkt01 added a comment. Changes as suggested in review from owenpan CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D142534: Fix emission of consteval constructor of derived type

Fznamznon updated this revision to Diff 492485. Fznamznon added a comment. Rebase and apply nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142534/new/ https://reviews.llvm.org/D142534 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGe

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#4083185 , @ABataev wrote: > In D129008#4083150 , > @tianshilei1992 wrote: > >>> There are a bunch of places we do that for various language extensions >>> already, incl

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits mailing list cfe-co

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, ye-luo, fhahn. Herald added subscribers: StephenFan, guansong, hiraditya, inglorion, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added a reviewer:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

luismarques added a comment. Possibly we want to add this change to the release notes? Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:304-308 + "'Zcb' (Shortened format for basic bit manipulation instructions)", + [FeatureExtZca

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/TypePrinter.cpp:2018 + + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); -

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

pratlucas updated this revision to Diff 492491. pratlucas added a comment. Renaming `getDefaultExtensions()` to `getImpliedExtensions()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142540/new/ https://reviews.llvm.org/D142540 Files: clang/lib

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492492. paulkirth added a comment. Rebase and update lang ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-bran

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added a comment. In D142583#4083251 , @bader wrote: > LGTM. Thanks! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits mailin

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492493. paulkirth edited the summary of this revision. paulkirth added a comment. Update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492494. craig.topper added a comment. Address @luismarques comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492495. tianshilei1992 added a comment. rebase and fix problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.c

[PATCH] D142637: A slightly more concise AST dump :)

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-attr-type.cpp:12 +// CHECK-NEXT:`-BuiltinType 0x{{[^ ]*}} 'int' +// CHECK-NOT: `-PointerType 0x564c31a07520 'int *

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

jdoerfert accepted this revision. jdoerfert added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

jhuber6 updated this revision to Diff 492498. jhuber6 added a comment. Herald added subscribers: ormris, steven_wu. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142650/new/ https://reviews.llvm.org/D142650 Files: clang/tools/clang-link

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nickdesaulniers added a comment. Thanks for the patch! In D142609#4082259 , @xgupta wrote: > WIP && TODO- Fixed test > > Failed Tests (7): > > Clang :: C/drs/dr4xx.c > Clang :: Modules/explicit-build-extra-files.cpp > Clang :: Parser/cxx2a-concept-

[clang-tools-extra] 9470de6 - [clang-doc] Reduce duplicate code with template

Author: Paul Kirth Date: 2023-01-26T18:05:31Z New Revision: 9470de65bb33a18842d64ab2ab777902613ee014 URL: https://github.com/llvm/llvm-project/commit/9470de65bb33a18842d64ab2ab777902613ee014 DIFF: https://github.com/llvm/llvm-project/commit/9470de65bb33a18842d64ab2ab777902613ee014.diff LOG: [c

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

This revision was automatically updated to reflect the committed changes. Closed by commit rG9470de65bb33: [clang-doc] Reduce duplicate code with template (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://rev

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

Jake-Egan added a comment. Hi, this change causes a failure on AIX. Could you take a look? https://lab.llvm.org/buildbot/#/builders/214/builds/5502/steps/6/logs/FAIL__Clang__annotate-comments-objc_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1425

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492501. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

luismarques accepted this revision. luismarques added a comment. LGTM, with some in-line caveats. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:1 +//===-- RISCVInstrInfoZc.td - RISC-V 'Zc' instructions -*- tablegen -*-===// +// `Zc` -> `Zc*`

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492503. craig.topper added a comment. Update file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c

[clang] 7aa2708 - [CMake] Remove libLTO from Fuchsia toolchain

Author: Alex Brachet Date: 2023-01-26T18:18:21Z New Revision: 7aa27081e43f13d7d55d36ca6ffd83ad7b87976b URL: https://github.com/llvm/llvm-project/commit/7aa27081e43f13d7d55d36ca6ffd83ad7b87976b DIFF: https://github.com/llvm/llvm-project/commit/7aa27081e43f13d7d55d36ca6ffd83ad7b87976b.diff LOG:

[PATCH] D142649: [CMake] Remove libLTO from Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7aa27081e43f: [CMake] Remove libLTO from Fuchsia toolchain (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-comm

[clang] df04883 - [AMDGPU] Split dot7 feature

Author: Stanislav Mekhanoshin Date: 2023-01-26T10:34:36-08:00 New Revision: df0488369d32a8cb1604a85d008e602e4de24d05 URL: https://github.com/llvm/llvm-project/commit/df0488369d32a8cb1604a85d008e602e4de24d05 DIFF: https://github.com/llvm/llvm-project/commit/df0488369d32a8cb1604a85d008e602e4de24d

[PATCH] D142507: [AMDGPU] Split dot7 feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rampitec marked an inline comment as done. Closed by commit rGdf0488369d32: [AMDGPU] Split dot7 feature (authored by rampitec). Herald added a project: clang. Herald ad

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson updated this revision to Diff 492516. royjacobson added a comment. - Address comments from Erich and Emilia - Validate that the rst actually builds an html file - Fix some missing backticks and underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson added a comment. Thanks Erich and Emilia! The html file is attached here, I think it's probably easier to proof read that way. (Took me a bit to figure out the CMake magic...) F26271094: ReleaseNotes.html Repository: rG LLVM Github Monorepo

[clang] f027dd5 - [analyzer] Fix crash exposed by D140059

Author: einvbri Date: 2023-01-26T12:55:42-06:00 New Revision: f027dd55f32a3c1803fc3cbd53029acee849465c URL: https://github.com/llvm/llvm-project/commit/f027dd55f32a3c1803fc3cbd53029acee849465c DIFF: https://github.com/llvm/llvm-project/commit/f027dd55f32a3c1803fc3cbd53029acee849465c.diff LOG:

[PATCH] D142627: [analyzer] Fix crash exposed by D140059

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf027dd55f32a: [analyzer] Fix crash exposed by D140059 (authored by einvbri ). Changed prior to commit: https://revi

[clang] db20228 - [Clang][NFC] Fix out-of-date comments on 'clang-offload-bundler'

Author: Joseph Huber Date: 2023-01-26T13:03:01-06:00 New Revision: db202286eb7b3f6725c82ded4f5c8b31ea648521 URL: https://github.com/llvm/llvm-project/commit/db202286eb7b3f6725c82ded4f5c8b31ea648521 DIFF: https://github.com/llvm/llvm-project/commit/db202286eb7b3f6725c82ded4f5c8b31ea648521.diff

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2031 +if (args_expr->isValueDependent() || !args_expr->isIntegerConstantExpr(Ctx)) + return false; + aprantl wrote: > Just for my own education: what's an example for a value-de

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2019 + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); + if (pattern_expr->isValueDependent() || aprantl wrote: > I assume

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1720 + MPM.addPass(OpenMPOptPass(ThinOrFullLTOPhase::FullLTOPostLink)); + // If we didn't decide t

[PATCH] D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Re-introduce it, now with a

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 492526. carlosgalvezp retitled this revision from "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options" to "[WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options". carlosgalvezp added

[clang] 42e371b - [NFC][Concepts] Change the Source Range of Concepts ParamMatching

Author: Erich Keane Date: 2023-01-26T11:14:40-08:00 New Revision: 42e371b174d4407ec5805010c2ecfef9c086b5c2 URL: https://github.com/llvm/llvm-project/commit/42e371b174d4407ec5805010c2ecfef9c086b5c2 DIFF: https://github.com/llvm/llvm-project/commit/42e371b174d4407ec5805010c2ecfef9c086b5c2.diff L

[clang] b4b06d8 - __arithmetic_fence enforces ordering on expression evaluation when fast-math

Author: Zahira Ammarguellat Date: 2023-01-26T14:18:28-05:00 New Revision: b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 URL: https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2 DIFF: https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam). Repository: rG LLVM Github Mono

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. Here's the relevant part of the test: #define DECLARE_ENUMS(name) \ /** enumFromMacro IS_DOXYGEN_SINGLE */ \ enum enumFromMacro { A }; \ /** namedEnumFromMacro IS_DOXYGEN_SINGLE */ \ enum name { B }; /// IS_DOXYGEN_NOT_ATTACHED DECLARE_ENUMS(namedE

[clang] 6185246 - [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

Author: Joseph Huber Date: 2023-01-26T13:23:45-06:00 New Revision: 6185246f4f62345d0cfdaef62da7e15b01d52557 URL: https://github.com/llvm/llvm-project/commit/6185246f4f62345d0cfdaef62da7e15b01d52557 DIFF: https://github.com/llvm/llvm-project/commit/6185246f4f62345d0cfdaef62da7e15b01d52557.diff

[PATCH] D142650: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6185246f4f62: [OpenMP] Run an extra 'OpenMPOpt' pass in LTO-mode (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D142650?

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. I am not sure how to debug further for AIX, do you have any suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 ___ cfe-commits

[PATCH] D133574: [C2x] reject type definitions in offsetof

asbirlea added a comment. Following this change, the following emits warnings: https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE Can you please fix fwd or revert until resolved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/n

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4083724 , @asbirlea wrote: > Following this change, the following emits warnings: > https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE > > Can you please fix fwd or revert until resolved? What do y

[PATCH] D133574: [C2x] reject type definitions in offsetof

erichkeane added a comment. In D133574#4083724 , @asbirlea wrote: > Following this change, the following emits warnings: > https://godbolt.org/z/cvGdMWqEa, https://godbolt.org/z/GhTP85WzE > > Can you please fix fwd or revert until resolved? Those both a

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. It appears to me this change https://reviews.llvm.org/D116774 is responsible for the unexpected behavior. Question for @jrtc27 : do you think if we could make this change consistent with https://reviews.llvm.org/D116774 that the problem would be addressed? Looks like

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers added a comment. @balazske , could you please share how to repro this problem on an x86 machine? Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 _

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak added inline comments. Comment at: clang/lib/CodeGen/Address.h:97 + llvm::Value * + getPointer(KnownNonNull_t KnownNonNull = KnownNonNull_t::False) const { assert(isValid()); rjmccall wrote: > Apologies if this rehashes a conversation we had earli

[clang] 42c36da - [RISCV] Add MC support of RISCV Zcb Extension

Author: WuXinlong Date: 2023-01-26T12:54:00-08:00 New Revision: 42c36da9c99b84ca7bc843a27ff0da29f5bf8a74 URL: https://github.com/llvm/llvm-project/commit/42c36da9c99b84ca7bc843a27ff0da29f5bf8a74 DIFF: https://github.com/llvm/llvm-project/commit/42c36da9c99b84ca7bc843a27ff0da29f5bf8a74.diff LOG

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c36da9c99b: [RISCV] Add MC support of RISCV Zcb Extension (authored by VincentWu, committed by craig.topper). Repository: rG LLVM Github Monorep

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added a comment. I tried modifying the test to pass an AIX target, running on Linux: // RUN: %clang_cc1 -triple powerpc64-ibm-aix -emit-pch -o %t/out.pch -F %S/Inputs/Frameworks %s // RUN: %clang_cc1 -triple powerpc64-ibm-aix -include-pch %t/out.pch -F %S/Inputs/Frameworks -fsyntax-o

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok I think I'm happy with the patch! Let's give other folks a few days to comment and then land? The commit message will need to be updated to remove mentions of `DiagnosticsEngine`. I'm somewhat

[clang] f983987 - [LinkerWrapper] Fix `-Bsymbolic` being sent to the compiler and not the linker

Author: Joseph Huber Date: 2023-01-26T15:05:10-06:00 New Revision: f9839876574fe97fdcdf104fbb1c9ba7fd4f9433 URL: https://github.com/llvm/llvm-project/commit/f9839876574fe97fdcdf104fbb1c9ba7fd4f9433 DIFF: https://github.com/llvm/llvm-project/commit/f9839876574fe97fdcdf104fbb1c9ba7fd4f9433.diff

[clang] ca44603 - [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-26T15:10:19-06:00 New Revision: ca446037af019d1aa01b1352a30a18df33038359 URL: https://github.com/llvm/llvm-project/commit/ca446037af019d1aa01b1352a30a18df33038359 DIFF: https://github.com/llvm/llvm-project/commit/ca446037af019d1aa01b1352a30a18df33038359.dif

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo CH

[PATCH] D142316: [clang] Add test for CWG2396

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } While gcc accep

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp updated this revision to Diff 492555. carlosgalvezp added a comment. Add functions to ClangTidyCheck so checks can get access to them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142655/new/ https://reviews.llvm.org/D142655 Files:

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:233-234 + utils::FileExtensionsSet HeaderFileExtensions; + utils::FileExtensionsSet ImplementationFileExtensions; + @njames93 Would appreciate feedback

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142639/new/ https://reviews.llvm.org/D142639 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] c10615e - [SYCL] Fix test to conform to SYCL2020

Author: Elizabeth Andrews Date: 2023-01-26T13:52:48-08:00 New Revision: c10615e4a94fc8dec65a48a6eb8f7efccc3fb1fc URL: https://github.com/llvm/llvm-project/commit/c10615e4a94fc8dec65a48a6eb8f7efccc3fb1fc DIFF: https://github.com/llvm/llvm-project/commit/c10615e4a94fc8dec65a48a6eb8f7efccc3fb1fc.d

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492559. python3kgae marked an inline comment as done. python3kgae added a comment. Only create dxv job when 'dxv' exist. Test ccc-print-bindings. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

ClockMan added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:149 + Options.HeaderFileExtensions = {"", "h", "hh", "hpp", "hxx"}; + Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"}; Options.HeaderFilterRegex = ""; -

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492560. shafik added a comment. - Update line ending in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added a comment. In D141705#4082935 , @jhuber6 wrote: > I'm not overly familiar with HLSL or DirectX here. Most of the changes are > purely mechanical, but I don't see anywhere we create the tool.

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492562. shafik added a comment. - I think I correctly updated line endings this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vao

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added inline comments. Comment at: clang/test/Preprocessor/macro_vaopt_p1042r1.cpp:1 - RUN: %clang_cc1 -E %s -pedantic -std=c++2a | FileCheck -strict-whitespace %s - I removed Windows lines ending from this test, I don't think they matter but if someone c

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

rjmccall added inline comments. Comment at: clang/lib/CodeGen/Address.h:97 + llvm::Value * + getPointer(KnownNonNull_t KnownNonNull = KnownNonNull_t::False) const { assert(isValid()); ahatanak wrote: > rjmccall wrote: > > Apologies if this rehashes a conve

[PATCH] D140489: Add builtin_elementwise_log

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only add action when 'dxv' exists. Coul

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 492573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h cl

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. In D142606#4082783 , @serge-sans-paille wrote: > In D142606#4082753 , @tstellar > wrote: > >> Does this mean that clang will no longer search for the ROCM and CUDA >> library paths for

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 492575. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/test/pp-trace/pp-trace-con

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 492576. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallbacks.h clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Pragma.cpp Index: clang/lib/Lex/Pragm

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 492577. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.h clang-tools-extra/test/pp-trace/

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: sscalpone. Herald added a reviewer: njames93. Herald added a project: All. Kyl

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 492579. KyleFromKitware retitled this revision from "[clang-tidy] Add check to suggest use of #pragma once" to "[clang-tidy] Add header guard style to suggest use of #pragma once". KyleFromKitware added a comment. Refactored to use HeaderGuardStyle.

[PATCH] D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

KyleFromKitware abandoned this revision. KyleFromKitware added a comment. Closed in favor of D142673 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142121/new/ https://reviews.llvm.org/D142121 ___

[PATCH] D140489: Add builtin_elementwise_log

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:248 if (const auto *VD = dyn_cast(D)) { -assert(Defs.count(VD) == 0 && "Definition already discovered!"); +// FIXME: Assertion temporarily disabled due to a bug in +// A

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + Any reason this is `mutable`? I don't see it being used a non-const way in a const method Repository: rG LLVM Github Monorepo CH

[PATCH] D140489: Add builtin_elementwise_log

bob80905 updated this revision to Diff 492581. bob80905 added a comment. remove unrelated commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140489/new/ https://reviews.llvm.org/D140489 Files: clang/docs/LanguageExtensions.rst clang/docs/Rel

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 492585. bryanpkc retitled this revision from "[Clang][AArch64] Add SME C intrinsics for load and store" to "[Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics". bryanpkc edited the summary of this revision. bryanpkc added a comment. Updated th

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan added a comment. Per https://llvm.org/docs/Phabricator.html#committing-a-change, I cannot commit the patch myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140730/new/ https://reviews.llvm.org/D140730 __

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 492586. bryanpkc added a comment. Minor clean-up. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsSME

<    1   2   3   >