[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Ping. If this approach is acceptable, I think we could use it for future ACLE features too (rather than the GNU attributes that we've used previously). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139028/new/ https:

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4079669 , @erichkeane wrote: > In D142500#4079135 , @Mordante > wrote: > >> FYI I tested this patch with libc++ and as expected it does not fix the >> libc++ modular build I

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj created this revision. Herald added a subscriber: arphaman. Herald added a project: All. danakj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The key part of getRawCommentForDecl() required to find a comment is determining where to

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. How the multilib system matches user arguments is the main problem I've been struggling with. These are the options I see: 1. Grant the multilib system full access to all cc1 arguments, as demonstrated by the current code. However declare the multilib system un

[PATCH] D140250: Define NULL in its own header

dblaikie added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line:

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492141. danakj added a comment. Adding back a period that was removed from a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files: clang/lib/AST/ASTContext

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a comment. In D142500#4080279 , @Mordante wrote: > In D142500#4079669 , @erichkeane > wrote: > >> In D142500#4079135 , @Mordante >> wrote: >> >>> FYI I

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:121 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE -// CHECK: annotate-comments-objc.m:43:22: EnumDecl=An_NS_ENUM_isdoxy

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

erichkeane added a subscriber: mstorsjo. erichkeane added a comment. In D142500#4080302 , @erichkeane wrote: > In D142500#4080279 , @Mordante > wrote: > >> In D142500#4079669

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. In D142500#4080317 , @erichkeane wrote: > In D142500#4080302 , @erichkeane > wrote: > >> In D142500#4080279 , @Mordante >> wrote: >> >>> In D1

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon updated this revision to Diff 492151. Fznamznon added a comment. Add a case with vector of length 33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142550/new/ https://reviews.llvm.org/D142550 Files: clang/lib/AST/ASTContext.cpp clang

[PATCH] D142550: Fix sizeof of boolean vector

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attribute__((ext_vector_type(28))); static_assert(sizeof(FourBools) == 1); erichke

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

efriedma added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1584 +Outputs may be used along any branches from the ``asm goto`` whether the +branches are taken or not. Maybe put a note about earlier releases, so people don't get confused if the

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142564 Files: clang-tools-extra/clang-do

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138472/new/ https://reviews.llvm.org/D138472 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 492160. VitaNuo added a comment. Refine C parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc cl

[PATCH] D142550: Fix sizeof of boolean vector

erichkeane added a comment. Just a couple more I'm concerned about after thinking about it, otherwise this looks about right. Comment at: clang/test/SemaCXX/vector-bool.cpp:97 + using NineBools = bool __attribute__((ext_vector_type(9))); + using ABunchOfBools = bool __attrib

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGRecordLayoutBuilder.cpp:370 + const auto StorageAlignment = getAlignment(StorageType); + if (LayoutSize % StorageAlignment || Layout.getDataSize() % StorageAlignment) Packed = true; Should thi

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492172. danakj added a comment. Ensure the comment outside the macro is attached to enums defined inside NS_ENUM() and NS_OPTIONS() macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://revie

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj added inline comments. Comment at: clang/test/Index/annotate-comments-objc.m:121 // CHECK: annotate-comments-objc.m:32:9: ObjCInstanceMethodDecl=method1_isdoxy4:{{.*}} method1_isdoxy4 IS_DOXYGEN_SINGLE -// CHECK: annotate-comments-objc.m:43:22: EnumDecl=An_NS_ENUM_isdoxy

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492176. danakj added a comment. Improve the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files: clang/lib/AST/ASTContext.cpp clang/test/Index/annotate-c

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. The test is for x86, does this also work for aarch64 with BTI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-commits

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4080615 , @nickdesaulniers wrote: > The test is for x86, does this also work for aarch64 with BTI? IBT/BTI doesn't affect this specific optimization, it's only about KCFI. If you're referring to ibt-seal, I assu

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D140250: Define NULL in its own header

iana updated this revision to Diff 492179. iana added a comment. Revert the unnecessary changes to unspecified-var-size.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 Files: clang-tools-extra/clang-

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. > If you're referring to ibt-seal, I assume a similar optimization could be > added for BTI too. Yes, please. Does it make sense to add to this patch, or a follow up on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen added a comment. In D138337#4080628 , @nickdesaulniers wrote: >> If you're referring to ibt-seal, I assume a similar optimization could be >> added for BTI too. > > Yes, please. Does it make sense to add to this patch, or a follow up on top

[PATCH] D142560: Allow getRawCommentForDecl to find comments in macros

danakj updated this revision to Diff 492181. danakj added a comment. Add tests for enums inside a macro, other than NS_ENUM and NS_OPTIONS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142560/new/ https://reviews.llvm.org/D142560 Files: clang/li

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. ah, sorry, I think I might be conflating "kcfi-seal" with "ibt-seal?" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-c

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492182. Michael137 added a comment. - Set `IsDefaulted` when checking template arguments in `clang::Sema` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[clang] 6ec446d - [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

Author: Shafik Yaghmour Date: 2023-01-25T10:49:04-08:00 New Revision: 6ec446ddcee33777a8420c227374f7b422a7df1b URL: https://github.com/llvm/llvm-project/commit/6ec446ddcee33777a8420c227374f7b422a7df1b DIFF: https://github.com/llvm/llvm-project/commit/6ec446ddcee33777a8420c227374f7b422a7df1b.dif

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec446ddcee3: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr… (authored by shafik). Herald added a project: clang. Changed p

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492184. Michael137 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td clang/inc

[clang] cd61d2a - [clang][CodeGen][NFC] Fix `llvm-else-after-return`

Author: Michael Liao Date: 2023-01-25T13:53:35-05:00 New Revision: cd61d2abe0fdfcee52e16998f7f3fda82572cd6f URL: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f DIFF: https://github.com/llvm/llvm-project/commit/cd61d2abe0fdfcee52e16998f7f3fda82572cd6f.diff

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492187. Michael137 added a comment. - Don't need to pass flag to NewArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/Propertie

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 492189. francii added a comment. Remove cc1 option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/T

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`). The review description h

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:274 -if (Args.hasArg(options::OPT_pg)) { +if (Args.hasArg(options::OPT_p, options::OPT_pg)) { CmdArgs.push_back(Args.MakeArgString((llvm::Twine("-L") + D.SysRoot) + da

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay Could you please commit this for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list cfe-comm

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 created this revision. Herald added subscribers: kosarev, ormris, kerbowa, guansong, hiraditya, yaxunl, jvesely. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a revi

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

jhuber6 created this revision. jhuber6 added reviewers: tra, jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, asavonic, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D142565: [clang-tidy] Fix warning in portability-simd-intrinsics

ClockMan created this revision. Herald added subscribers: carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ClockMan updated this revision to Diff 492167. ClockMan added a comment. ClockMan updated this revision to Diff 492169. Eugene.Zelen

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

arsenm added a comment. Description not clear Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3912-3914 + Constant *KernelEnvironmentCasted = + ConstantExpr::getPointerBitCastOrAddrSpaceCast(KernelEnvironment, + Ke

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142570/new/ https://reviews.llvm.org/D142570 _

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:3479-3486 + /// Return the IdentTy (ident_ty) corresponding to the associated kernel. + Constant *getKernelIdent(ConstantStruct *StructC) { +GlobalVariable *KernelEnvGV = getKernelEnviro

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder updated this revision to Diff 492205. scott.linder added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driv

[clang] 759dec2 - [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

Author: Joseph Huber Date: 2023-01-25T13:58:00-06:00 New Revision: 759dec253695f38a101c74905c819ea47392e515 URL: https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515 DIFF: https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515.diff

[PATCH] D142570: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG759dec253695: [nvptx-arch] Remove `find_package(CUDA)` as it has been deprecated. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492214. isuckatcs added a comment. applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/ut

[PATCH] D135495: [clang-tidy] handle exceptions properly `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 492215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h clang-tools-extra/test/c

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

jdoerfert added a comment. Link the old review too. Pre-commit, w/o review, the file rename and include changes. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:246 + GET_KERNEL_ENVIRONMENT_MEMBER(Configuration, DL, StructC)), \ + V)) + --

[clang-tools-extra] 716469b - [clang-tidy] Fix segfault in bugprone-standalone-empty

Author: Denis Nikitin Date: 2023-01-25T20:06:41Z New Revision: 716469b6139ab5ec5c5b5dac32891300260db8eb URL: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb DIFF: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb.diff LOG:

[PATCH] D142423: [clang-tidy] Fix segfault in bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG716469b6139a: [clang-tidy] Fix segfault in bugprone-standalone-empty (authored by denik, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D140250: Define NULL in its own header

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. Please be sure to add a release note when landing the changes, btw. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140250/new/ https://reviews.llvm.org/D140250 ___ cfe-commi

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142577 Files: clang-tools-extra/clang-do

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. Wait a second... if an OS wants only `NULL`, we already have a supported way of achieving that, which is compatible with GCC and glibc and other POSIX compilers -- define `__need_NULL` before including the header. We shouldn't be providing internal headers with `__mangle

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4080990 , @rsmith wrote: > Wait a second... if an OS wants only `NULL`, we already have a supported way > of achieving that, which is compatible with GCC and glibc and other POSIX > compilers -- define `__need_NULL` befo

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with small nit to address before commit Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6287-6292 if (!TC.getTriple().isOSAIX() && !TC.getTriple().isOSOpenBS

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492234. cjdb retitled this revision from "[clang] teaches Clang the special ADL rules for functions in std::ranges" to "adds `__disable_adl` attribute". cjdb edited the summary of this revision. cjdb added a comment. - updates patch so that it meets what Aaron a

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12934-12936 +// else if (!CandidateSet.empty() && CandidateSet.begin()->FoundDecl->hasAttr()) { +// return; +// } This and below need to be deleted. Repository: rG LLVM Git

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve added a comment. https://reviews.llvm.org/D142160 Should address the incorrect handling of Mem2Reg, this is not the full picture though, as at the MIR level we handle these two differently: DEBUG_VALUE !DIExpression () indirect// this what dbg.declare gets lowered to DEB

[clang] f81d529 - [Clang] Fix compilation errors for unsupported __bf16 intrinsics

Author: Elizabeth Andrews Date: 2023-01-25T12:43:36-08:00 New Revision: f81d529f8955dbdf64d429c27dee994257b4ee99 URL: https://github.com/llvm/llvm-project/commit/f81d529f8955dbdf64d429c27dee994257b4ee99 DIFF: https://github.com/llvm/llvm-project/commit/f81d529f8955dbdf64d429c27dee994257b4ee99.d

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf81d529f8955: [Clang] Fix compilation errors for unsupported __bf16 intrinsics (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141375/new/ https://reviews.llvm.org/D141375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] 90f7db8 - Fix clang-tools-extra Sphinx build

Author: Aaron Ballman Date: 2023-01-25T15:52:49-05:00 New Revision: 90f7db87936d967998f90c8b430e5243872223b3 URL: https://github.com/llvm/llvm-project/commit/90f7db87936d967998f90c8b430e5243872223b3 DIFF: https://github.com/llvm/llvm-project/commit/90f7db87936d967998f90c8b430e5243872223b3.diff

[PATCH] D140250: Define NULL in its own header

aaron.ballman added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that, which

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4079249 , @vedgy wrote: > Now that a consensus has been reached that this revision is to be discarded, > can we please resume the discussion of which alternative should be > implemented in the replacement revisi

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

royjacobson created this revision. Herald added subscribers: s.egerton, mstorsjo, simoncook, dschuff. Herald added a project: All. royjacobson requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, sstefan1, aheejin. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081044 , @aaron.ballman wrote: > In D140250#4081009 , @iana wrote: > >> In D140250#4080990 , @rsmith wrote: >> >>> Wait a second... if a

[PATCH] D139395: Add CFI integer types normalization

samitolvanen added a reviewer: samitolvanen. samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. Thanks, LGTM. @pcc, does this version look fine to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081009 , @iana wrote: > In D140250#4080990 , @rsmith wrote: > >> Wait a second... if an OS wants only `NULL`, we already have a supported way >> of achieving that, which is com

[PATCH] D140250: Define NULL in its own header

rsmith added a comment. In D140250#4081102 , @rsmith wrote: > Our builtin header `stddef.h` shouldn't be built as a module. It > fundamentally needs to be treated as a textual header, because it consumes > macros defined by the includer. The module map

[clang] bfe4514 - [amdgpuarch] Delete stray hsa #include line

Author: Jon Chesterfield Date: 2023-01-25T21:40:35Z New Revision: bfe4514add5b7ab7e1f06248983a7162d734cffb URL: https://github.com/llvm/llvm-project/commit/bfe4514add5b7ab7e1f06248983a7162d734cffb DIFF: https://github.com/llvm/llvm-project/commit/bfe4514add5b7ab7e1f06248983a7162d734cffb.diff L

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 492246. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp cla

[PATCH] D140250: Define NULL in its own header

iana added a comment. In D140250#4081119 , @rsmith wrote: > In D140250#4081102 , @rsmith wrote: > >> Our builtin header `stddef.h` shouldn't be built as a module. It >> fundamentally needs to be treated as a text

[PATCH] D129951: adds `__disable_adl` attribute

shafik added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement wi

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrO

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan added a comment. Herald added a subscriber: thopre. Since the plan is to switch to the Canonical Style operation, may be this can wait till the `omp.canonical_loop` changes are in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[PATCH] D142578: [Clang][Doc] Edit the Clang release notes

rymiel added a comment. I don't know sphinx enough to know if the trailing underscore is needed in links, but there's about 5 links that don't have the underscore (Search for >`) ) Comment at: clang/docs/ReleaseNotes.rst:577 + potential false positives, this diagnostic wi

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

zahiraam created this revision. zahiraam added reviewers: bader, andrew.w.kaylor. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. __arithmetic_fence enforces ordering on expressi

[clang] 11656f2 - [CUDA] Fix output from `ptxas` being removes as a temporary file

Author: Joseph Huber Date: 2023-01-25T16:24:30-06:00 New Revision: 11656f204aa5fd972564e76641c00ca058ba8c0d URL: https://github.com/llvm/llvm-project/commit/11656f204aa5fd972564e76641c00ca058ba8c0d DIFF: https://github.com/llvm/llvm-project/commit/11656f204aa5fd972564e76641c00ca058ba8c0d.diff

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

bader added a comment. "[SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets." -> "[SPIR] Add support for __arithmetic_fence builtin for SPIR target." Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:16 +// Test with fast math on spir target +// RUN: %

[PATCH] D140250: Define NULL in its own header

iana planned changes to this revision. iana added a comment. In D140250#4081133 , @iana wrote: > In D140250#4081119 , @rsmith wrote: > >> In D140250#4081102 , @rsmith wrot

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

ahatanak created this revision. ahatanak added reviewers: rjmccall, ab, efriedma. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ahatanak requested review of this revision. The flag will be used for the arm64e work we plan to upstream in the

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

efriedma added a comment. I'm having a little trouble following what the meaning of an "Address" is with this patch. The `Pointer` member refers to an encoded value, and calling getPointer() emits IR to decode it? Could use a few comments to explain the API. Repository: rG LLVM Github Mon

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#4081228 , @kiranchandramohan wrote: > Since the plan is to switch to the Canonical Style operation, maybe this can > wait till the `omp.canonical_loop` changes are in? Ok..make sense Repository: rG LLVM

[PATCH] D131137: [clang][misexpect] Add support to clang for profitable annotation diagnostics

paulkirth updated this revision to Diff 492269. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131137/new/ https://reviews.llvm.org/D131137 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clan

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

ClockMan created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ClockMan published this revision for review. ClockMan added a comment. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D142564: [clang-doc] Reduce duplicate code with template

paulkirth updated this revision to Diff 492274. paulkirth added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142564/new/ https://reviews.llvm.org/D142564 Files: clang-tools-extra/clang-doc/Representation.cpp Index: cla

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492275. craig.topper edited the summary of this revision. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/tes

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492276. craig.topper added a comment. Add back the new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-featur

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valueOrOne

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 updated this revision to Diff 492278. tianshilei1992 marked 6 inline comments as done. tianshilei1992 added a comment. rebase, add more code, fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm

[PATCH] D142569: [WIP][OpenMP] Introduce kernel argument

tianshilei1992 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2544 - ~AAExecutionDomainFunction() { -delete RPOT; - } + ~AAExecutionDomainFunction() { delete RPOT; } This will be removed properly later. Repository: rG LLVM

[clang-tools-extra] 881d151 - [clang-doc] Removed unused method in the Info class

Author: Paul Kirth Date: 2023-01-25T23:55:59Z New Revision: 881d151c527c0eaae89af5842f4167f7a2439a13 URL: https://github.com/llvm/llvm-project/commit/881d151c527c0eaae89af5842f4167f7a2439a13 DIFF: https://github.com/llvm/llvm-project/commit/881d151c527c0eaae89af5842f4167f7a2439a13.diff LOG: [c

[PATCH] D142577: [clang-doc] Removed unused method in the Info class

This revision was automatically updated to reflect the committed changes. Closed by commit rG881d151c527c: [clang-doc] Removed unused method in the Info class (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142577/new/ https:/

[clang] 5e72407 - [flang] Add driver install directory to AIX toolchain program paths list.

Author: Paul Scoropan Date: 2023-01-26T00:39:51Z New Revision: 5e72407635a43b8b7f85c1658b6738f023a21f03 URL: https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03 DIFF: https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03.diff LOG:

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e72407635a4: [flang] Add driver install directory to AIX toolchain program paths list. (authored by pscoro, committed by w2yehia). Changed prior to commit: https://reviews.llvm.org/D140628?vs=485112&id

<    1   2   3   >