jdoerfert added a comment. Link the old review too. Pre-commit, w/o review, the file rename and include changes.
================ Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:246 + GET_KERNEL_ENVIRONMENT_MEMBER(Configuration, DL, StructC)), \ + V)) + ---------------- Do we need the offset parts? I think we should only work with field numbers not offsets. ================ Comment at: openmp/libomptarget/DeviceRTL/include/Configuration.h:19 +#pragma omp begin declare target device_type(nohost) + ---------------- Precommit. ================ Comment at: openmp/libomptarget/DeviceRTL/include/Configuration.h:24 +extern ConfigurationEnvironmentTy *ConfigurationEnvironment; + ---------------- Unused for now. ================ Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:26 extern uint32_t __omp_rtl_assume_no_thread_state; -extern uint32_t __omp_rtl_assume_no_nested_parallelism; ---------------- Keep it for now. Makes the transition easier. Use an `||` below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
