[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:10 // RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -fsyntax-only -verify -std=c++11 -Wno-inaccessible-base -fclang-abi-compat=16 -DCLANG_ABI_COMPAT=16 // expected-no-diagnostics

[PATCH] D142315: [clang] Add test for CWG1111

erichkeane added a comment. I didn't internalize that it was 'just a warning' (it was a -error in the test above), we should have a task for someone to remove that warning as it is no longer ambiguous. But I don't think it makes it 'partial' here anymore. Comment at: clang/t

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: clang/test/Driver/aarch64-cssc.c:11 +// RUN: %clang -S -o - -emit-llvm -target aarch64-none-none-eabi -march=armv9.4-a+cssc %s 2>&1 | FileCheck %s +// RUN: %clang -S -o - -emit-llvm -targe

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) hokein wrote: > Conceptually, this (and other `atomic_*` symbols) doesn't feel correc

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Can you add something to the release notes about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142199/new/ https://reviews.llvm

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

tbaeder added a comment. LGTM, assuming the pre-commit CI failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142338/new/ https://reviews.llvm.org/D142338 ___ cfe-commits mailing list c

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

xgupta added a comment. In D142338#4073826 , @tbaeder wrote: > LGTM, assuming the pre-commit CI failures are unrelated. Yeah, those 3 test cases should be unrelated, this is an nfc change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D142315: [clang] Add test for CWG1111

Endill added a comment. In D142315#4073782 , @erichkeane wrote: > I didn't internalize that it was 'just a warning' (it was a -error in the > test above), we should have a task for someone to remove that warning as it > is no longer ambiguous. But I d

[PATCH] D142373: [Utils] Add --full-function-signature to update_cc_test_checks.pyh to match return type as well as args

asb created this revision. asb added reviewers: arichardson, nikic, mtrofin. Herald added subscribers: wingo, pmatos, StephenFan, luismarques, sameer.abuasal, s.egerton, PkmX, simoncook. Herald added a project: All. asb requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D142315: [clang] Add test for CWG1111

Endill added inline comments. Comment at: clang/test/CXX/drs/dr11xx.cpp:31 + } +} + erichkeane wrote: > Can you also add the last example (with struct A) from the issue, and find a > way to confirm that it is calling the right version? Nice catch, thank you. Lo

[PATCH] D141765: [FPEnv] Fix complex operations in strictfp mode

sepavloff updated this revision to Diff 491397. sepavloff added a comment. Use --implicit-check-not in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141765/new/ https://reviews.llvm.org/D141765 Files: clang/lib/CodeGen/CGExprComplex.cpp c

[clang] 8246ace - [AArch64] Add command line support for v9.4-A's Instrumentation Extension

Author: Lucas Prates Date: 2023-01-23T16:39:53Z New Revision: 8246aceb90c28d27e644fe74e4ad5e2c9e9d85e1 URL: https://github.com/llvm/llvm-project/commit/8246aceb90c28d27e644fe74e4ad5e2c9e9d85e1 DIFF: https://github.com/llvm/llvm-project/commit/8246aceb90c28d27e644fe74e4ad5e2c9e9d85e1.diff LOG:

[PATCH] D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8246aceb90c2: [AArch64] Add command line support for v9.4-A's Instrumentation Extension (authored by pratlucas). Repository: rG LLVM Github Monore

[clang] 5f6813b - [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

Author: Lucas Prates Date: 2023-01-23T16:40:48Z New Revision: 5f6813beed85a0d9355c117e7638feee26e80b3d URL: https://github.com/llvm/llvm-project/commit/5f6813beed85a0d9355c117e7638feee26e80b3d DIFF: https://github.com/llvm/llvm-project/commit/5f6813beed85a0d9355c117e7638feee26e80b3d.diff LOG:

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pratlucas marked an inline comment as done. Closed by commit rG5f6813beed85: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver (authored by pra

[PATCH] D142181: [OptTable] Store llvm::cl::Option into a DenseMap instead of a StringMap

serge-sans-paille updated this revision to Diff 491400. serge-sans-paille added a comment. Do not enfore StringLiteral parameter. This is too invasive on the code base. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142181/new/ https://reviews.llvm.org/D142181 Files: clang-tools-extra

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

Michael137 added a comment. Seems like this broke the LLDB incremental build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50184/execution/node/43/log/?consoleFull We build with `LLVM_ENABLE_MODULES` by default While building module 'Clang_Basic' imported from /Users/buildslave/

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:822 classified such types as non-POD (for the purposes of Itanium ABI). Clang now - matches the gcc behavior (except on Darwin and PS4). You can switch back to + matches the gcc behavior (except on Darwi

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 491407. VitaNuo added a comment. Special case the overloads for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/C

[clang] 3759ef9 - Add support for clang-cl's option `-fexcess-precision`.

Author: Zahira Ammarguellat Date: 2023-01-23T12:08:07-05:00 New Revision: 3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118 URL: https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118 DIFF: https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

mikerice accepted this revision. mikerice added a comment. LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141375/new/ https://reviews.llvm.org/D141375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D141757: [clangd] allow extracting to variable for complete lambda expressions

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. sorry i'll need to take a look at this again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam added a subscriber: thakis. zahiraam added a comment. @thakis I think this should fix the clang-cl use with the Mac OS compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142367/new/ https://reviews.llvm.org/D142367 __

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

s-pratik created this revision. s-pratik added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a reviewer: njames93. Herald added a project: All. s-pratik requested review of this revision. Herald added a project: clang-tools-extra. There were some dead links in Suppre

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

s-pratik added a comment. replaced all dead links Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142377/new/ https://reviews.llvm.org/D142377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:100 SYMBOL(atoll, std::, ) +SYMBOL(atomic, std::, ) +SYMBOL(atomic, std::, ) kadircet wrote: > hokein wrote: > > Conceptually, this (and other `atomic_*` symbols)

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jhuber6 added a comment. Ping, is it possible to resolve this before the fork tomorrow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141717/new/ https://reviews.llvm.org/D141717 ___ cfe-commits mailing

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

steakhal added a comment. I'm very much interrested. I think you should define a mock standard variant header, that you could include from your tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142354/new/ https://reviews.llvm.org/D142354

[PATCH] D142144: [RISCV][Driver] Add -rvv-vector-bits= option similar to -sve-vector-bits=

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2150 + Args.MakeArgString("-mvscale-min=" + llvm::Twine(VScaleMin))); +} else if (!Val.equals("scalable")) { + // Handle the unsupported values passed to mrvv-vector-bits.

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1030 + } else { +if (CD->getNumParams() == 1) + PassType.PassBy = getPassMode(CD->getParamDecl(0)->getType()); This check should be `>= 1`, since the constructor co

[PATCH] D142381: [clang] Add test for CWG1960

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG1960 (currently closed as NAD) is res

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

jsjodin accepted this revision. jsjodin added a comment. This revision is now accepted and ready to land. This looks good to me. Have @jdoerfert approve as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D14

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

jdoerfert added a comment. In D141717#4056971 , @yaxunl wrote: > The intention of -emit-llvm -S is usually to get LLVM assembly for all > targets for inspection or modification. HIP emits a bundled LLVM assembly in > textual format in this case. Users c

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StdSymbolMap.inc:1053 SYMBOL(remainder, std::, ) +SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) hokein wrote: > I think `std::remove` should not be in the scope of t

[clang] 5474d7d - [AArch64] Function multi-versioning release notes added. NFC.

Author: Pavel Iliin Date: 2023-01-23T18:08:07Z New Revision: 5474d7d932710c260f03ce6c6387ec9d82bd10e2 URL: https://github.com/llvm/llvm-project/commit/5474d7d932710c260f03ce6c6387ec9d82bd10e2 DIFF: https://github.com/llvm/llvm-project/commit/5474d7d932710c260f03ce6c6387ec9d82bd10e2.diff LOG: [

[PATCH] D141606: [AArch64] Remove AES, SHA2, SHA3 and SM4 features from armv8.6-a+

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5474d7d93271: [AArch64] Function multi-versioning release notes added. NFC. (authored by ilinpv). Herald added a project: clang. Herald added a subsc

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

Endill added a comment. LGTM I checked clang-tidy docs for this kind of broken references, but found nothing else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142377/new/ https://reviews.llvm.org/D142377

[PATCH] D141606: [AArch64] Remove AES, SHA2, SHA3 and SM4 features from armv8.6-a+

ilinpv added a comment. Sorry, commit rG5474d7d93271 is not related to this, I put wrong differential revision link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141606/new/ ht

[clang] d1f313e - Mark BuiltinHeaders.def as textual

Author: Adrian Prantl Date: 2023-01-23T10:14:33-08:00 New Revision: d1f313e73a1b33d662dbab54be76720b9c875645 URL: https://github.com/llvm/llvm-project/commit/d1f313e73a1b33d662dbab54be76720b9c875645 DIFF: https://github.com/llvm/llvm-project/commit/d1f313e73a1b33d662dbab54be76720b9c875645.diff

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

aaron.ballman added a comment. I looked through the code base and I think this fix is good but benign (it doesn't look like it'll impact anything that I can see). So LGTM without tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142304/new/ htt

[clang] 94b9187 - [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

Author: Shivam Gupta Date: 2023-01-23T23:48:48+05:30 New Revision: 94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e URL: https://github.com/llvm/llvm-project/commit/94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e DIFF: https://github.com/llvm/llvm-project/commit/94b9187a7d37e4269af35f8f7ec8e0f78fd6a06e.diff

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94b9187a7d37: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h (authored by xgupta). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D142304: [Clang] Fix a Wbitfield-enum-conversion warning in DirectoryLookup.h

xgupta added a comment. In D142304#4074211 , @aaron.ballman wrote: > I looked through the code base and I think this fix is good but benign (it > doesn't look like it'll impact anything that I can see). So LGTM without > tests. Thank you for reviewing

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) Doesn't this break the monorepo (non-standalone) build? If the monorepo build still works with this, then you don't need the changes to

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142384 Files: clang/lib/AST/ExprConstant.cpp Index

[PATCH] D142377: Dead links on https://clang.llvm.org/extra/clang-tidy/ #60023

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'm happy to land this for you -- what name and email address would you like me to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:133 +each invocation. The pattern strings "%p" or "%Nm" may help to avoid +corruption due to concurrency. + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with improved wording. Comment at: clang/include/clang/Lex/PPCallbacks.h:87 + /// Callback invoked whenever an inclusion directive results in a + /// file-

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491431. nicolerabjohn added a comment. Adding run lines for AIX & z/OS, and updating comment line length. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

jansvoboda11 added a comment. Also I think we should mention this API in our docs, right where the removed original used to be. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142196/new/ https://reviews.llvm.org/D142196 ___ cfe-commits mailin

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry updated this revision to Diff 491440. v1nh1shungry added a comment. `==` to `>=` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extr

[clang] 0b92f85 - Revert "[AArch64] Function multi-versioning release notes added. NFC."

Author: Pavel Iliin Date: 2023-01-23T18:24:21Z New Revision: 0b92f852708b64084c39ac98e55de2381a40de0c URL: https://github.com/llvm/llvm-project/commit/0b92f852708b64084c39ac98e55de2381a40de0c DIFF: https://github.com/llvm/llvm-project/commit/0b92f852708b64084c39ac98e55de2381a40de0c.diff LOG: R

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 ___ cfe-commits mailing lis

[PATCH] D142381: [clang] Add test for CWG1960

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142381/new/ https://reviews.llvm.org/D142381 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 491444. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/A

[clang] c57eaf1 - [AArch64] Function multi-versioning release notes added. NFC.

Author: Pavel Iliin Date: 2023-01-23T18:31:22Z New Revision: c57eaf1c8ce37f52f19f47f61591dd7597a68226 URL: https://github.com/llvm/llvm-project/commit/c57eaf1c8ce37f52f19f47f61591dd7597a68226 DIFF: https://github.com/llvm/llvm-project/commit/c57eaf1c8ce37f52f19f47f61591dd7597a68226.diff LOG: [

[PATCH] D142265: [AArch64] Function multi-versioning release notes added. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc57eaf1c8ce3: [AArch64] Function multi-versioning release notes added. NFC. (authored by ilinpv). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1035 } else if (const auto *MTE = CastNode->ASTNode.get()) { } else { // Unknown implicit node, assume type conversion. This branch is now empty, do we

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. I tested this patch and it works, so I'll give it an LGTM. However, I think the LLVMConfig.cmake.in changes are now unnecessary since the RISCVTargetParserTableGen has been dropped from

[PATCH] D141606: [AArch64] Remove AES, SHA2, SHA3 and SM4 features from armv8.6-a+

dmgreen added a comment. In D141606#4074204 , @ilinpv wrote: > Sorry, commit rG5474d7d93271 > is not > related to this, I put wrong differential revision link Not a problem, I was ju

[clang] cc9fa50 - [AArch64] Remove AES, SHA2, SHA3 and SM4 features from armv8.6-a+

Author: David Green Date: 2023-01-23T18:39:17Z New Revision: cc9fa501ea668d197c8b55da17b76680fe79b231 URL: https://github.com/llvm/llvm-project/commit/cc9fa501ea668d197c8b55da17b76680fe79b231 DIFF: https://github.com/llvm/llvm-project/commit/cc9fa501ea668d197c8b55da17b76680fe79b231.diff LOG: [

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) tstellar wrote: > Doesn't this break the monorepo (non-standalone) build? If the monorepo > build still works with this, then you don

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1035 } else if (const auto *MTE = CastNode->ASTNode.get()) { } else { // Unknown implicit node, assume type conversion. tom-anders wrote: > This branc

[clang-tools-extra] b22963e - Silence an MSVC "not all control paths return" warning; NFC

Author: Aaron Ballman Date: 2023-01-23T13:44:37-05:00 New Revision: b22963e24aeef17e3e2535831afe643042074671 URL: https://github.com/llvm/llvm-project/commit/b22963e24aeef17e3e2535831afe643042074671 DIFF: https://github.com/llvm/llvm-project/commit/b22963e24aeef17e3e2535831afe643042074671.diff

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1035 } else if (const auto *MTE = CastNode->ASTNode.get()) { } else { // Unknown implicit node, assume type conversion. v1nh1shungry wrote: > tom-anders

[PATCH] D142388: [clang] Add builtin_nondet

ManuelJBrito created this revision. ManuelJBrito added reviewers: aaron.ballman, erichkeane, shafik. ManuelJBrito added a project: clang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a subscriber: cfe-commits. This patch adds a builtin that returns a no

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry marked an inline comment as done. v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1035 } else if (const auto *MTE = CastNode->ASTNode.get()) { } else { // Unknown implicit node, assume type conversion.

[PATCH] D142144: [RISCV][Driver] Add -rvv-vector-bits= option similar to -sve-vector-bits=

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:844 take architecture extensions from ``-march`` if both are given. +- Added -rvv-vector-bits= option to give an upper bound on vector length. Valid + values are powers of 2 between 64 and 65536. We also a

[PATCH] D142388: [clang] Add builtin_nondet

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") Not a fan of the name in general, it doesn't really explain what is happening.

[PATCH] D142392: [clang][deps] Add module files for input dependencies earlier

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I originally thought we needed to add module file inputs for modular dep

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, arsenm, tra, yaxunl, jdoerfert. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-co

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 added a comment. The libcxx test failure seems unrelated and seems to be failing on master https://buildkite.com/llvm-project/libcxx-ci/builds?branch=master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142243/new/ https://reviews.llvm.o

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552 F->addFnAttr("uniform-work-group-size", "true"); + if (IsOpenMPkernel) +F->addFnAttr("amdgpu-flat-work-group-size", Probably shouldn’t check the language, just it’s a kernel

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 491468. pmatos added a comment. Fix some tests whose diagnostics changed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clan

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552 F->addFnAttr("uniform-work-group-size", "true"); + if (IsOpenMPkernel) +F->addFnAttr("amdgpu-flat-work-group-size", arsenm wrote: > Probably shouldn’t check the language, j

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552 F->addFnAttr("uniform-work-group-size", "true"); + if (IsOpenMPkernel) +F->addFnAttr("amdgpu-flat-work-group-size", jhuber6 wrote: > arsenm wrote: > > Probably shouldn’t che

[PATCH] D142393: [OpenMP] Add 'amdgpu-flat-work-group-size' to OpenMP kernels

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9552 F->addFnAttr("uniform-work-group-size", "true"); + if (IsOpenMPkernel) +F->addFnAttr("amdgpu-flat-work-group-size", arsenm wrote: > jhuber6 wrote: > > arsenm wrote: > > > P

[PATCH] D142388: [clang] Add builtin_nondet

shafik added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > Not a fan of the name in general, it doesn't really explain wh

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

asb added inline comments. Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:101 + +struct s5 { struct empty e[1]; float f; }; + luismarques wrote: > Should we also test a case with an array size 0 like `ct s { struct empty > e[0]; float f; };`? I think t

[PATCH] D142396: [AArch64] Add the Ampere1A core

philipp.tomsich created this revision. philipp.tomsich added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. philipp.tomsich requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commi

cfe-commits@lists.llvm.org

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:851 if (CurrentToken->is(tok::r_brace)) { +// Handle unbalanced braces +if (Scopes.size() > 1) See below Comment at: clang/lib/Form

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

mstorsjo added inline comments. Comment at: lld/docs/ReleaseNotes.rst:78 + if ``-static`` has been specified. This fixes conformance to what + GNU ld dpes. (`D135651 `_) + MaskRay wrote: > `s/dpes/does/` Thanks! I'll fix this b

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks added a comment. In D141811#4070629 , @rymiel wrote: > In D141811#4068180 , > @HazardyKnusperkeks wrote: > >> I thought about `auto NAME() -> int { return 42; }`. >> >> `decltype(auto) a = (b)

[clang] c3737a6 - [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

Author: Martin Storsjö Date: 2023-01-23T22:12:32+02:00 New Revision: c3737a6522306ba4504234afe35be8b0a4b7b48d URL: https://github.com/llvm/llvm-project/commit/c3737a6522306ba4504234afe35be8b0a4b7b48d DIFF: https://github.com/llvm/llvm-project/commit/c3737a6522306ba4504234afe35be8b0a4b7b48d.diff

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

nicolerabjohn updated this revision to Diff 491477. nicolerabjohn added a comment. Opting out of clang ABI change in FieldPacked bool on AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3737a652230: [docs] Add release notes for news in 16.x done by me, or otherwise relating to… (authored by mstorsjo). Changed prior to commit: htt

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

suertreus added a comment. Andy Getzendanner please, and thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140434/new/ https://reviews.llvm.org/D140434 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the contribution! Let's give a couple days for the others to have a last look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

carlosgalvezp added a comment. In D140434#4073212 , @ymandel wrote: > In D140434#4071823 , @carlosgalvezp > wrote: > >> In D140434#4053053 , @suertreus >> wrote: >> >>>

[PATCH] D142388: [clang] Add builtin_nondet

aaron.ballman added a comment. Be sure to add documentation for this to the language extensions page and mention the new builtin in the release notes. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__built

[clang-tools-extra] 4240c91 - [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Author: Carlos Galvez Date: 2023-01-23T20:58:34Z New Revision: 4240c9146248ac0a91c45dee421c6ef07709ba74 URL: https://github.com/llvm/llvm-project/commit/4240c9146248ac0a91c45dee421c6ef07709ba74 DIFF: https://github.com/llvm/llvm-project/commit/4240c9146248ac0a91c45dee421c6ef07709ba74.diff LOG:

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

This revision was automatically updated to reflect the committed changes. Closed by commit rG4240c9146248: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D141581: [build] Fix stand-alone builds of clang.

fpetrogalli added a comment. In D141581#4074312 , @tstellar wrote: > I tested this patch and it works, so I'll give it an LGTM. However, I think > the LLVMConfig.cmake.in changes are now unnecessary since the > RISCVTargetParserTableGen has been dropp

[PATCH] D78441: Delete NaCl support

MaskRay added a comment. In D78441#4067440 , @dschuff wrote: > Sorry, no :) Is there a timeline for the removal? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78441/new/ https://reviews.llvm.org/D78441 __

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli Please go ahead and push this since it is blocking others, we can fix up any of the other issues later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[clang-tools-extra] 38a9e1d - [clang-tidy][NFC] Fix Release Notes build error

Author: Carlos Galvez Date: 2023-01-23T21:05:08Z New Revision: 38a9e1d41264b551f659a5d9215109a96e74cadd URL: https://github.com/llvm/llvm-project/commit/38a9e1d41264b551f659a5d9215109a96e74cadd DIFF: https://github.com/llvm/llvm-project/commit/38a9e1d41264b551f659a5d9215109a96e74cadd.diff LOG:

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:817 attribute is also specified on the member. Clang historically did perform such packing. Clang now matches the gcc behavior (except on Darwin and PS4). You can switch back to the old

[PATCH] D141581: [build] Fix stand-alone builds of clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52bcdac3b842: [build] Fix stand-alone builds of clang. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 52bcdac - [build] Fix stand-alone builds of clang.

Author: Francesco Petrogalli Date: 2023-01-23T22:11:47+01:00 New Revision: 52bcdac3b8425e20023151bb726b56fd6f62ec17 URL: https://github.com/llvm/llvm-project/commit/52bcdac3b8425e20023151bb726b56fd6f62ec17 DIFF: https://github.com/llvm/llvm-project/commit/52bcdac3b8425e20023151bb726b56fd6f62ec1

<    1   2   3   4   >