[clang] 38a2f08 - Revert "[NFC] [Serialization] Add static assert for the size of the decls to"

Author: Chuanqi Xu Date: 2023-01-19T10:37:48+08:00 New Revision: 38a2f089b48103922e3ff6c363032704ce52c08e URL: https://github.com/llvm/llvm-project/commit/38a2f089b48103922e3ff6c363032704ce52c08e DIFF: https://github.com/llvm/llvm-project/commit/38a2f089b48103922e3ff6c363032704ce52c08e.diff LO

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after yo

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Also fails on 64-bit windows fwiw: http://45.33.8.238/win/73344/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___ cfe-commi

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Thanks for the fast revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/Support/MathExtras.h:212 /// Only unsigned integral types are allowed. -/// -/// \param ZB the behavior on an input of 0. Only

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

thakis added a comment. This breaks oodles of tests for me: http://45.33.8.238/macm1/52994/step_7.txt Is anyone else seeing this? Also, independently of that, shouldn't this check that the _host_ os is macOS as well? Doesn't the current code try to run `xcrun` if I do `clang --target=arm64-app

[clang] f252333 - [-Wunsafe-buffer-usage][NFC] Fix Fixables filtering

Author: Jan Korous Date: 2023-01-18T18:54:48-08:00 New Revision: f252333b978c6b5a04d1cea3d92de16490969ff5 URL: https://github.com/llvm/llvm-project/commit/f252333b978c6b5a04d1cea3d92de16490969ff5 DIFF: https://github.com/llvm/llvm-project/commit/f252333b978c6b5a04d1cea3d92de16490969ff5.diff LO

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

arsenm added a comment. > If you care about compilation speed, you should build LLVM with an appropriate -march= to take advantage of lzcnt and tzcnt. I think this is bad reasoning, nobody really uses -march Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added a comment. It passes on the previous windows CI. It looks like the assertion for `sizeof(...)` is indeed not a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 _

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:225 /// /// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are /// valid arguments. A bunch of functions still have this documentation, but these are now

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. Are those failures on Linux? I only developed this change on macOS, but the automated tests passed... Admittedly I'm not sure what should happen when building for macOS from Linux (is there any use case where that works and does anything useful? I'm not sure). I

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

MaskRay added a comment. `ZB_Max` is the strange mode that should be dropped, perhaps also `ZB_Undefined`. In D141798#4064114 , @arsenm wrote: >> If you care about compilation speed, you should build LLVM with an >> appropriate -march= to take advantag

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6, yaxunl, rjmccall, tra. Herald added subscribers: mattd, gchakrabarti, asavonic, guansong. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, s

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

craig.topper added a comment. In D141798#4064142 , @MaskRay wrote: > `ZB_Max` is the strange mode that should be dropped, perhaps also > `ZB_Undefined`. > > In D141798#4064114 , @arsenm wrote: > >>> If you care a

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Seems reasonable, maybe update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142075/new/ https://reviews.llvm.org/D142075 __

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490363. kazu added a comment. I've adjusted comments for findFirstSet and findLastSet to reflect the fact that ZeroBehavior now takes only two values -- ZB_Undefined and ZB_Max. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:225 /// /// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are /// valid arguments. jrtc27 wrote: > A bunch of functi

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno created this revision. bruno added reviewers: ChuanqiXu, nridge, sammccall. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D115187

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kazu marked 2 inline comments as done. Closed by commit rG83d56fb17a4d: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC) (authored by kazu). R

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai marked an inline comment as done. vsapsai added a comment. In D71734#4061228 , @ChuanqiXu wrote: > LGTM generally. It'd better to mention this in the `Potentially Breaking > Changes` section of ReleaseNotes. Thanks for all your efforts during the

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

glandium added a comment. This broke our mac builds with errors like: ld64.lld: error: undefined symbol: CFRunLoopRun >>> referenced by tools/clang/tools/clang-stat-cache/CMakeFiles/clang-stat-cache.dir/clang-stat-cache.cpp.o:(symbol main+0x11be) (and many more symbols) Repository: rG

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. In D141451#4063582 , @nickdesaulniers wrote: > In D141451#4063519 , @dblaikie > wrote: > >> In D141451#4063504

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

tianshilei1992 updated this revision to Diff 490375. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142075/new/ https://reviews.llvm.org/D142075 Files: clang/lib/Lex/LiteralSupport.cpp clang/test/Ope

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

yonghong-song added a comment. @compnerd could you also take a look at this patch? First, some background about this patch. The reason of this patch is due to: https://lore.kernel.org/bpf/CAOFdcFPnHEc2qd-=c+hdk4ntjjfbhsf4r-g7pdjtrbat6mu...@mail.gmail.com/ Further the following link has deta

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel planned changes to this revision. rymiel added a comment. In D141811#4055485 , @HazardyKnusperkeks wrote: > What about `decltype(auto)`? Turns out this is a problem even without this patch: `decltype(auto) a = (b) -> c;` I'm sure this could som

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490383. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D141908 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/module/module.import/p6.cp

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. I suppose this means `auto a = (b) -> c;` is also technically broken, actually, and there's no easy fix for that. I did have an idea for adding an additional pass taking place somewhere in `TokenAnnotator::calculateFormattingInformation`, which would detect trailing ret

<    1   2   3