ChuanqiXu added inline comments.

================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313
 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) {
+  static_assert(sizeof(OMPDeclareMapperDecl) == 120,
+                "You need to update the serializer after you change the fields 
"
----------------
thakis wrote:
> How can this work? This includes an ArrayRef 
> (http://llvm-cs.pcc.me.uk/tools/clang/include/clang/AST/DeclOpenMP.h#221) 
> which contains a pointer and a size_t. That alone will be 16 bytes on 64-bit 
> builds and 8 bytes on 32-bit builds.
You're right that I forgot the case for 32-bit machine. I've reverted the 
patch. And I need to look for better solutions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141992/new/

https://reviews.llvm.org/D141992

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to