[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

2023-01-17 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 490028. ccotter marked an inline comment as done. ccotter added a comment. - fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clan

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2023-01-17 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
dhruvachak updated this revision to Diff 490030. dhruvachak added a comment. Herald added a subscriber: pcwang-thead. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CG

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2023-01-17 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
dhruvachak added a comment. After rebasing on top of main today and regenerating all the auto-update clang tests, here are the test results. The AST tests have to be updated manually as Johannes mentioned earlier. I haven't looked at the other clang test failures. The llvm tests need to be fixe

[clang] 5725c8d - [perf-training] Check extension in findFilesWithExtension

2023-01-17 Thread Amir Ayupov via cfe-commits
Author: Amir Ayupov Date: 2023-01-17T21:54:00-08:00 New Revision: 5725c8ddd46becff95629515b1f0a26af047aa33 URL: https://github.com/llvm/llvm-project/commit/5725c8ddd46becff95629515b1f0a26af047aa33 DIFF: https://github.com/llvm/llvm-project/commit/5725c8ddd46becff95629515b1f0a26af047aa33.diff L

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

2023-01-17 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 490036. vsapsai added a comment. Rebase and add assertion in `ODRHash::AddRecordDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files: clang/include/clang/AST/

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-17 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. In D141899#4058173 , @LuoYuanke wrote: > @zixuan-wu, changing x86_amx would break our internal code. May I know the > motivation to change the type? The background is at https://reviews.llvm.org/D135202. No more motivation, ju

[clang] a7b47fa - [NFC] Disable test on AIX due to different default output

2023-01-17 Thread Jake Egan via cfe-commits
Author: Jake Egan Date: 2023-01-18T01:14:47-05:00 New Revision: a7b47fa17c37485a1658ce44e0d87edf69e4b8be URL: https://github.com/llvm/llvm-project/commit/a7b47fa17c37485a1658ce44e0d87edf69e4b8be DIFF: https://github.com/llvm/llvm-project/commit/a7b47fa17c37485a1658ce44e0d87edf69e4b8be.diff LOG

[clang] 205b5f6 - [Serialization] Serialize the new added FunctionDeclBits: IsIneligibleOrNotSelected

2023-01-17 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-01-18T14:15:27+08:00 New Revision: 205b5f63a835bffc22dccfdaed53ee7dac504be1 URL: https://github.com/llvm/llvm-project/commit/205b5f63a835bffc22dccfdaed53ee7dac504be1 DIFF: https://github.com/llvm/llvm-project/commit/205b5f63a835bffc22dccfdaed53ee7dac504be1.diff LO

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-17 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. In D141899#4061150 , @zixuan-wu wrote: > In D141899#4058173 , @LuoYuanke > wrote: > >> @zixuan-wu, changing x86_amx would break our internal code. May I know the >> motivation to chang

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-17 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. In D141899#4061150 , @zixuan-wu wrote: > In D141899#4058173 , @LuoYuanke > wrote: > >> @zixuan-wu, changing x86_amx would break our internal code. May I know the >> motivation to chang

[clang] 346e1c4 - Revert "nullptr returned from ActOnTag() is not a valid result"

2023-01-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2023-01-17T22:35:20-08:00 New Revision: 346e1c43a11b8af5a818dac321f83f043862c1ec URL: https://github.com/llvm/llvm-project/commit/346e1c43a11b8af5a818dac321f83f043862c1ec DIFF: https://github.com/llvm/llvm-project/commit/346e1c43a11b8af5a818dac321f83f043862c1ec.diff

[clang] 39da55e - Revert "Diagnose extensions in 'offsetof'"

2023-01-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2023-01-17T22:35:21-08:00 New Revision: 39da55e8f548a11f7dadefa73ea73d809a5f1729 URL: https://github.com/llvm/llvm-project/commit/39da55e8f548a11f7dadefa73ea73d809a5f1729 DIFF: https://github.com/llvm/llvm-project/commit/39da55e8f548a11f7dadefa73ea73d809a5f1729.diff

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

2023-01-17 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. apologies for reverting this, but https://reviews.llvm.org/rGf1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee is broken and doesn't revert cleanly without this also being reverted, could you reland? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

2023-01-17 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM generally. It'd better to mention this in the `Potentially Breaking Changes` section of ReleaseNotes. Comment at: clang/lib/AST/Decl.cpp:4714 setIsRandomized(f

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-17 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. With considering https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility I think we need make consensus to choose one option from following 2 options. 1. Remove X86amx type in IR totally. (what I am doing now) 2. Without removing X86amx type in IR, just

[PATCH] D141899: [IR][X86] Remove X86AMX type in LLVM IR instead of target extension

2023-01-17 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke added a comment. In D141899#4061237 , @zixuan-wu wrote: > With considering > https://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility I think > we need make consensus to choose one option from following 2 options. > > 1. Remove X8

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

2023-01-17 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D119708#4060336 , @jansvoboda11 wrote: > In D119708#4059254 , @Hahnfeld > wrote: > >> Hello, sorry for the late heads-up, but this functionality is used by ROOT: >> https://github.c

<    1   2   3