Author: Amir Ayupov Date: 2023-01-17T21:54:00-08:00 New Revision: 5725c8ddd46becff95629515b1f0a26af047aa33
URL: https://github.com/llvm/llvm-project/commit/5725c8ddd46becff95629515b1f0a26af047aa33 DIFF: https://github.com/llvm/llvm-project/commit/5725c8ddd46becff95629515b1f0a26af047aa33.diff LOG: [perf-training] Check extension in findFilesWithExtension `findFilesWithExtension` helper checks for `endswith(extension)` instead of exactly matching the file extension. This causes it to match unrelated files, for example, `.profdata` files while matching `.fdata` files: http://157.230.108.44:8011/#/builders/56/builds/247 ``` Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/prof.fdata.1124569.fdata... Merging data from /worker/worker/bolt-x86_64-ubuntu-clang-bolt-gcc/build/tools/clang/test/Frontend/Output/optimization-remark-with-hotness-new-pm.c.tmp.profdata... ``` Reviewed By: phosek Differential Revision: https://reviews.llvm.org/D141342 Added: Modified: clang/utils/perf-training/perf-helper.py Removed: ################################################################################ diff --git a/clang/utils/perf-training/perf-helper.py b/clang/utils/perf-training/perf-helper.py index c6a815e65473..abbdc77b2372 100644 --- a/clang/utils/perf-training/perf-helper.py +++ b/clang/utils/perf-training/perf-helper.py @@ -23,7 +23,7 @@ def findFilesWithExtension(path, extension): filenames = [] for root, dirs, files in os.walk(path): for filename in files: - if filename.endswith(extension): + if filename.endswith(f".{extension}"): filenames.append(os.path.join(root, filename)) return filenames _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
