[PATCH] D141035: [clang-format] Add an option to insert a newline at EOF if missing

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #https://g

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD added a comment. Upon a second thought, with future extensions of the intrinsics, we will add rounding mode and exception intrinsics. The exposure of vxsat, vxrm, and vcsr in vread_csr and vwrite_csr will confuse user and we should remove them. Furthermore, vstart is pretty much always ke

[PATCH] D140745: WIP: generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

kadircet added a comment. In D140745#4021783 , @sammccall wrote: > worthwhile overall? > --- > > This isn't trivial: does it solve a big enough problem to be worth the > complexity? (Benefit would be improved maintenance of existing confi

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 486486. eopXD edited the summary of this revision. eopXD added a comment. Update code. Add function `vlenb` instead of extending inside the `vread_csr` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1410

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1559 __asm__ __volatile__ ("csrw\tvcsr, %z0" : : "rJ"(__value) : "memory"); break; } pcwang-thead wrote: > Should we report

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

pcwang-thead added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1565 + unsigned long __rv = 0; + __asm__ __volatile__ ("csrr\t%0, vlenb" : "=r"(__rv) : : "memory"); + return __rv; Inline assembly may not be elegant since it can't be o

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

wzssyqa added a comment. When link with ld.bfd, we get: ld/ld-new: .eh_frame_hdr entry overflow ld/ld-new: final link failed: bad value It seems due to the `initial_loc` in the object from LLVM is quite big than the gcc/gas one. initial_loc: 0x10cd0, vma: 0xe78 Repository: rG L

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet added a comment. As you point out, enhancement may be more accurate than bug fix. There are rare cases where enabling a warning for missing parentheses in `constexpr` logical expressions can be helpful, I think. For example, consider the following code: constexpr A = ...; constexp

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:4337 +// RUN: %clang -E -dM %s -o - 2>&1 \ +// RUN: -target hexagon-unknown-linux \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_HEXAGON_ATOMICS MaskRa

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

svenvh added a comment. > it may be more appropriate to make these triggered off of a hidden option > defaulted to off for now, or maybe based on whether or not opaque pointers > are enabled There isn't really a meaningful alternative representation for these opaque types when opaque pointers

[clang] d227c3b - [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Author: Brad Smith Date: 2023-01-05T04:45:07-05:00 New Revision: d227c3b68cf5c236902c9ff4fdf8b719c9a3dd26 URL: https://github.com/llvm/llvm-project/commit/d227c3b68cf5c236902c9ff4fdf8b719c9a3dd26 DIFF: https://github.com/llvm/llvm-project/commit/d227c3b68cf5c236902c9ff4fdf8b719c9a3dd26.diff LO

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGd227c3b68cf5: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros (authored by brad). Changed prior to commit: https://reviews.llvm.org/D140757?vs=485743&id=486501#toc Repository:

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999

[clang] ebd9753 - [CodeGenOpenCLCXX] Convert tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-01-05T11:03:15+01:00 New Revision: ebd97534e71aafaa637e466d700f66bbfa63d56b URL: https://github.com/llvm/llvm-project/commit/ebd97534e71aafaa637e466d700f66bbfa63d56b DIFF: https://github.com/llvm/llvm-project/commit/ebd97534e71aafaa637e466d700f66bbfa63d56b.diff

[PATCH] D141035: [clang-format] Add an option to insert a newline at EOF if missing

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think I've died an gone to heaven!! LGTM... Happy New Year! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141035/new/ https:/

[PATCH] D140843: [clang-format] fix template closer followed by >

MyDeveloperDay accepted this revision. MyDeveloperDay added a subscriber: rymiel. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for adding an annotator test, I'd like one of @owenpan, @HazardyKnusperkeks or @rymiel to comment before commit, just

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm good with that. I like small pieces of contained work and not open ended reviews that try to cover everything. If someone wants to extend this to include the old form, then that can be a completely different review. But t

[PATCH] D140950: [X86] Support -march=emeraldrapids

FreddyYe added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

acoster updated this revision to Diff 486504. acoster added a comment. Generlised the check to cover string_view and "string-like" classes Removed the option of ignoring `data()`, and generalised the check to suggest fixes if the result of `data()` or `c_str()` method of any class with a public `

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

brad updated this revision to Diff 486505. brad added a comment. Tweak test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140817/new/ https://reviews.llvm.org/D140817 Files: clang/lib/Driver/ToolChains/NetBSD.cpp clang/lib/Driver/ToolChains/N

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

acoster marked 12 inline comments as done. acoster added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/strlen-string-cstr.rst:24 + +.. option:: EnableForDataMethod + carlosgalvezp wrote: > Is there a use case for wanting this

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 486508. cor3ntin added a comment. I've convinced myself that the assertition case should be removed. Before this patch, CXXDefaultInitExpr where never visited by UsedDeclVisitor. After this patch, when doing that visitation, a variable can appear in an unev

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 486510. cor3ntin added a comment. formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h

[PATCH] D140950: [X86] Support -march=emeraldrapids

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950

[PATCH] D140950: [X86] Support -march=emeraldrapids

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140950/new/ https://reviews.llvm.org/D140950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Unless something else pops up, I'll try to land that this week end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits ma

[clang] e449e1d - [Driver] move NetBSD header search path management to the driver

Author: Brad Smith Date: 2023-01-05T06:13:40-05:00 New Revision: e449e1dff9f83e45c1a290214e9f49b2c562b343 URL: https://github.com/llvm/llvm-project/commit/e449e1dff9f83e45c1a290214e9f49b2c562b343 DIFF: https://github.com/llvm/llvm-project/commit/e449e1dff9f83e45c1a290214e9f49b2c562b343.diff LO

[PATCH] D140817: [Driver] move NetBSD header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe449e1dff9f8: [Driver] move NetBSD header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks added a comment. In D140835#4023132 , @owenpan wrote: > In D140835#4023080 , > @HazardyKnusperkeks wrote: > >> On second thought, shouldn't we test for removing the braces? > > Hmm. This patch

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

owenpan added a comment. In D140835#4028257 , @HazardyKnusperkeks wrote: > In D140835#4023132 , @owenpan wrote: > >> In D140835#4023080 , >> @HazardyKnusperkeks wrote: >

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4028147 , @MyDeveloperDay wrote: > If someone wants to extend this to include the old form, then that can be a > completely different review. Better yet, use another tool like clang-tidy to replace the old with the n

[clang] a28f074 - [clang-format] Add an option for breaking after C++11 attributes

Author: Owen Pan Date: 2023-01-05T04:08:58-08:00 New Revision: a28f0747c2f3728bd8a6f64f7c8ba80b4e0cda9f URL: https://github.com/llvm/llvm-project/commit/a28f0747c2f3728bd8a6f64f7c8ba80b4e0cda9f DIFF: https://github.com/llvm/llvm-project/commit/a28f0747c2f3728bd8a6f64f7c8ba80b4e0cda9f.diff LOG:

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28f0747c2f3: [clang-format] Add an option for breaking after C++11 attributes (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 27b8f54 - [X86] Support -march=emeraldrapids

Author: Freddy Ye Date: 2023-01-05T20:27:32+08:00 New Revision: 27b8f54f5174aa4d8ea254a7efefd7110b247c17 URL: https://github.com/llvm/llvm-project/commit/27b8f54f5174aa4d8ea254a7efefd7110b247c17 DIFF: https://github.com/llvm/llvm-project/commit/27b8f54f5174aa4d8ea254a7efefd7110b247c17.diff LOG

[PATCH] D140950: [X86] Support -march=emeraldrapids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27b8f54f5174: [X86] Support -march=emeraldrapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. Sorry for not getting back to you earlier. It mostly looks reasonable to me. what do you think @erichkeane ? Comment at: clang/lib/Sema/SemaInit.cpp:10338 +Context.getRValueReferenceType(ElementTypes[i]); + else if (isa

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1953-1959 bool isCopyDeductionCandidate() const { -return FunctionDeclBits.IsCopyDeductionCandidate; +return getDeductionCandidateKind() == DeductionCandidateKind::Copy; + } + + bool isAggr

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added a comment. LGTM! I think I prefer this solution anyways. Please commit (the entire patchstack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140387/new/ https://reviews.llvm.org/D140387 ___

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder updated this revision to Diff 486525. tbaeder marked an inline comment as done. tbaeder set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D13707

[PATCH] D140807: [clang][Interp] Skip calling simple destructors

tbaeder abandoned this revision. tbaeder added a comment. I added the `isTrivial()` checks to the new version in https://reviews.llvm.org/D137070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140807/new/ https://reviews.llvm.org/D140807

[PATCH] D140915: [clangd] Fix getQueryScopes for using-directive with inline namespace

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:674 +else if (const auto *ND = dyn_cast(Context)) { + if (ND->isInlineNamespace()) +Scopes.AccessibleScopes.push_back(printQualifiedName(*ND) + "::"); tom-ander

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added a comment. In D139168#4027637 , @ChuanqiXu wrote: > Currently, clang-scan-deps won't check for this. If we have multiple command > lines with different `-MF` value, the make-style dependency information will > be written to these diffe

[clang-tools-extra] b06b248 - [clang-tidy] Implement CppCoreGuideline CP.53

Author: Chris Cotter Date: 2023-01-05T13:57:22Z New Revision: b06b248ad9dc1b50dcf474616c3d586d47270a01 URL: https://github.com/llvm/llvm-project/commit/b06b248ad9dc1b50dcf474616c3d586d47270a01 DIFF: https://github.com/llvm/llvm-project/commit/b06b248ad9dc1b50dcf474616c3d586d47270a01.diff LOG:

[PATCH] D140793: [clang-tidy] Implement CppCoreGuideline CP.53

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06b248ad9dc: [clang-tidy] Implement CppCoreGuideline CP.53 (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: bmahjour, kadircet, arphaman. Herald added a project: All. sylvestre.ledru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald a

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D140868#4027635 , @rjmccall wrote: > In D140868#4027480 , @MaskRay wrote: > >> I am not a C

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D140835#4028274 , @owenpan wrote: > If `RemoveBracesLLVM` is false, the line is too long and will wrap. That's what I fail

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

serge-sans-paille added inline comments. Comment at: cmake/Modules/FindGRPC.cmake:85 if(NOT TARGET grpc++) +find_library(GPR_LIBRARY gpr $GRPC_OPTS REQUIRED) +add_library(gpr UNKNOWN IMPORTED GLOBAL) Shouldn't this be `${GPRC_OPTS}`?

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru updated this revision to Diff 486546. sylvestre.ledru added a comment. add the missing {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 Files: clang/cmake/modules/AddGRPC.cmake cmake

[PATCH] D141050: [standalone-build] outsource, simplify and unify repetitive CMake code

kwk created this revision. kwk added reviewers: tstellar, phosek. Herald added subscribers: bzcheeseman, rriddle. Herald added a project: All. kwk requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. Rationale = This

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a subscriber: hubert.reinterpretcast. cor3ntin added a comment. + @hubert.reinterpretcast In case i missed something conformance wise. Speaking of conformance, your implementation does not appear to gate the feature on C++20, which it should, so you should add a test that it doesn

[PATCH] D141051: [CUDA]HIP] Add support for `--offload-arch=native` to CUDA and refactor

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, MaskRay. Herald added subscribers: kosarev, mattd, carlosgalvezp, asavonic, StephenFan, kerbowa, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, s

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

ccotter added a comment. @carlosgalvezp - could you also help commit this if it looks good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140772/new/ https://reviews.llvm.org/D140772 ___ cfe-commits mail

[clang] 85d049a - Implement support for option 'fexcess-precision'.

Author: Zahira Ammarguellat Date: 2023-01-05T09:35:28-05:00 New Revision: 85d049a089d4a6a4a67145429ea5d8e155651138 URL: https://github.com/llvm/llvm-project/commit/85d049a089d4a6a4a67145429ea5d8e155651138 DIFF: https://github.com/llvm/llvm-project/commit/85d049a089d4a6a4a67145429ea5d8e155651138

[PATCH] D136176: Implement support for option 'fexcess-precision'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85d049a089d4: Implement support for option 'fexcess-precision'. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://re

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

MyDeveloperDay added a comment. In D140956#4028288 , @owenpan wrote: > In D140956#4028147 , > @MyDeveloperDay wrote: > >> If someone wants to extend this to include the old form, then that can be a >> completely

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StrlenStringCStrCheck.h:1 +//===--- StrlenStringCStrCheck.h - clang-tidy *- C++ -*-===// +// Should be 80 characters long. See other checks as example. Re

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib2.h:33-34 +private: + std::vector, std::vector>> Multilibs; + std::vector, std::vector>> RegexAttributes; +}; phosek wrote: > I think it'd really help readability and compre

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 486558. balazske added a comment. Adding test for summary case, change of comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140387/new/ https://reviews.llvm.org/D140387 Files: clang/lib/StaticAnalyzer/

[PATCH] D140959: RFC: Multilib prototype

tschuett added a comment. Did you look at Yaml I/O ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140959/new/ https://reviews.llvm.org/D140959 ___ cfe-commits mailing

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm updated this revision to Diff 486561. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-features.cl clang/test/OpenMP/amdgcn-at

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

Joe_Nash accepted this revision. Joe_Nash added a comment. This revision is now accepted and ready to land. In D138870#4020211 , @arsenm wrote: > In D138870#4020204 , @Joe_Nash > wrote: > >> The code looks fine,

[PATCH] D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests.

paulwalker-arm created this revision. Herald added subscribers: ctetreau, psnobl, arphaman, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

v1nh1shungry created this revision. v1nh1shungry added reviewers: lebedev.ri, ymandel. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Heral

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

carlosgalvezp added a comment. In D140772#4028570 , @ccotter wrote: > @carlosgalvezp - could you also help commit this if it looks good? Sure thing, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result

v1nh1shungry added a comment. Sorry, I don't know how to add tests for such fixes. Could anyone please give me some hints? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141058/new/ https://reviews.llvm.org/D141058

[PATCH] D140772: [clang-tidy] Fix minor bug in add_new_check.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG210b731c01b0: [clang-tidy] Fix minor bug in add_new_check.py (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 210b731 - [clang-tidy] Fix minor bug in add_new_check.py

Author: Chris Cotter Date: 2023-01-05T15:28:57Z New Revision: 210b731c01b020693aa8f53231c659ff5f60149e URL: https://github.com/llvm/llvm-project/commit/210b731c01b020693aa8f53231c659ff5f60149e DIFF: https://github.com/llvm/llvm-project/commit/210b731c01b020693aa8f53231c659ff5f60149e.diff LOG:

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140639/new/ https://reviews.llvm.org/D140639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139458: [clangd] Full support for #import insertions

kadircet requested changes to this revision. kadircet added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirecti

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

acoster updated this revision to Diff 486582. acoster added a comment. Fix length of comment at the top of StrlenStringCStrCheck.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140968/new/ https://reviews.llvm.org/D140968 Files: clang-tools-extr

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

erichkeane added a comment. 1 nit, and 1 trying to see what is going on. I don't have a good feeling what the purpose of this builtin is, nor whether it matches the desire/intent of this builtin, I'm hopeful one of the other reviewers has the ability to check that. Comment

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm added a comment. In D140639#4028883 , @erichkeane wrote: > 1 nit, and 1 trying to see what is going on. I don't have a good feeling > what the purpose of this builtin is, The point of every builtin is direct access to llvm intrinsics, in this c

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

erichkeane added a comment. In D140639#4028900 , @arsenm wrote: > In D140639#4028883 , @erichkeane > wrote: > >> 1 nit, and 1 trying to see what is going on. I don't have a good feeling >> what the purpose of t

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime updated this revision to Diff 486591. lime added a comment. Added release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/TreeTransform.h cla

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime added a comment. Is there a place to see the log of the powerpc64le self-built buildbot? @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 ___ c

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

erichkeane added a comment. In D137531#4028986 , @lime wrote: > Is there a place to see the log of the powerpc64le self-built buildbot? > @erichkeane It was sent via email to us: https://lab.llvm.org/buildbot#builders/121/builds/26738 Repository: r

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2660 + +ExprResult Magnitude = UsualUnaryConversions(TheCall->getArg(0)); +ExprResult Sign = UsualUnaryConversions(TheCall->getArg(1)); erichkeane wrote: > arsenm wrote: > >

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2660 + +ExprResult Magnitude = UsualUnaryConversions(TheCall->getArg(0)); +ExprResult Sign = UsualUnaryConversions(TheCall->getArg(1)); aaron.ballman wrote: > erichkeane wrote:

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:258 + hasMethod(cxxMethodDecl(hasName("begin"), isConst())), + hasMethod(cxxMethodDecl(hasName("end"), +

[PATCH] D140983: [IRBuilder] Use canonical i64 type for insertelement index used by vector splats.

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! The change seems sensible to me, although perhaps worth waiting a day or two in case anyone else has objections? I noticed that we still create inserts using 32-bit indices in a fe

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:124 +// CHECK-LABEL: omp_DistributeOp +func.func @omp_DistributeOp(%lb : index, %ub : index, %step : index, %data_var : memref, %chunk_var : i32) -> () { abidmalikwaterloo w

[PATCH] D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. I don't see the appear of this check as its a situation that I doubt ever appears in code bases. If there are open source code bases where this is a known problem can you please

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2674 + +if (MagnitudeTy.getCanonicalType() != SignTy.getCanonicalType()) { + return Diag(Sign.get()->getBeginLoc(), erichkeane wrote: > curleys not used for single-statement if-sta

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2674 + +if (MagnitudeTy.getCanonicalType() != SignTy.getCanonicalType()) { + return Diag(Sign.get()->getBeginLoc(), arsenm wrote: > erichkeane wrote: > > curleys not used for s

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

xazax.hun added a comment. I realized I did not say this explicitly in my previous comment, but feel free to commit :) Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:267 + void addFieldsReferencedInScope(llvm::DenseSet Fields); + -

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

xazax.hun added a comment. Sorry, I got a bit swamped, will try to take a look next week. In the meantime, did you have a chance to run this over some open source projects? Did you find any interesting diffs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D141000: [clang-tidy] Introduce HeaderFileExtensions option

njames93 added a comment. Can you explain the reasoning of why this approach is better than current approach where checks can use global options(`Options.getLocalOrGlobal("HeaderFileExtensions", utils::defaultHeaderFileExtensions())`) to access the same information? Some checks also have the g

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 486604. usaxena95 added a comment. Use ParsingDeclRAIIObject instead of ContextRAII. This creates a separate diagnostic pool for diagnositcs associated to the RequiresExprBodyDecl. This is important because dependent diagnostics should not leak to higher

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: MaskRay, SixWeining, gonglingqin. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Repository: rG LLVM Github

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd added a comment. I think that the current release note should be sufficient. This is handling the same scenario in a different path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/ https://reviews.llvm.org/D140507

[PATCH] D141073: [Driver] move Fuchsia header search path management to the driver

brad created this revision. brad added reviewers: MaskRay, abrachet, phosek. brad added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. brad requested review of this revision. Fuchsia already implements AddClangSystemIncludeArgs(). So it looks like we just ha

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal added a comment. In D139534#4029097 , @xazax.hun wrote: > Sorry, I got a bit swamped, will try to take a look next week. In the > meantime, did you have a chance to run this over some open source projects? > Did you find any interesting diffs?

[clang] 3b1d455 - [clang] Correct -frewrite-includes generation of line control directives with mixed EOL forms.

Author: Tom Honermann Date: 2023-01-05T13:24:01-05:00 New Revision: 3b1d45518910b529104a269d5f6712a720cc3ff7 URL: https://github.com/llvm/llvm-project/commit/3b1d45518910b529104a269d5f6712a720cc3ff7 DIFF: https://github.com/llvm/llvm-project/commit/3b1d45518910b529104a269d5f6712a720cc3ff7.diff

[PATCH] D140984: [clang] Correct -frewrite-includes generation of line control directives with mixed EOL forms.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1d45518910: [clang] Correct -frewrite-includes generation of line control directives with… (authored by tahonermann). Repository: rG LLVM Github

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

SeanP added inline comments. Comment at: clang/tools/driver/driver.cpp:251 + std::string &OptFile) { + T OptVal = ::getenv(EnvOptSet); + if (OptVal) { This change is not POSIX compliant. If T is char *, the next call to getenv() on line 25

[PATCH] D141078: [CUDA][HIP] Support '--offload-arch=native' for the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, yaxunl. Herald added subscribers: kosarev, mattd, asavonic, kerbowa, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Her

[clang] 108766f - Fix typos

Author: Luke Drummond Date: 2023-01-05T18:49:23Z New Revision: 108766fc7ef83724ff4f66235bd561b217df0ff7 URL: https://github.com/llvm/llvm-project/commit/108766fc7ef83724ff4f66235bd561b217df0ff7 DIFF: https://github.com/llvm/llvm-project/commit/108766fc7ef83724ff4f66235bd561b217df0ff7.diff LOG:

  1   2   3   >