serge-sans-paille added inline comments.
================
Comment at: cmake/Modules/FindGRPC.cmake:85
if(NOT TARGET grpc++)
+ find_library(GPR_LIBRARY gpr $GRPC_OPTS REQUIRED)
+ add_library(gpr UNKNOWN IMPORTED GLOBAL)
----------------
Shouldn't this be `${GPRC_OPTS}`?
================
Comment at: cmake/Modules/FindGRPC.cmake:95
target_include_directories(grpc++ INTERFACE ${GRPC_INCLUDE_PATHS})
+ find_library(GRPC2_LIBRARY grpc $GRPC_OPTS REQUIRED)
+ add_library(grpc UNKNOWN IMPORTED GLOBAL)
----------------
same here
================
Comment at: cmake/Modules/FindGRPC.cmake:100
+
+ find_library(ABSL_SYNCHRONIZATION_LIBRARY absl_synchronization $GRPC_OPTS
QUIET)
+ if (ABSL_SYNCHRONIZATION_LIBRARY)
----------------
and here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141047/new/
https://reviews.llvm.org/D141047
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
