[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira added a comment. Given https://reviews.llvm.org/D140363, this patch is being abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140035/new/ https://reviews.llvm.org/D140035 ___ cfe-comm

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

MaskRay added a comment. In D140363#4014131 , @joaomoreira wrote: > FWIIW, agreed on removing this until we figure out how to make it work > properly. Thanks for the patch @MaskRay. Thanks for accepting the removal:) Repository: rG LLVM Github Mono

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This crash is a combination of recovery-expr + new SemaInit.cpp code introduced by by https://reviews.llvm.org/D129531. Reposito

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide reopened this revision. davide added a comment. This revision is now accepted and ready to land. @MaskRay Roy hasn't replied. We found other spellings that break (e.g. `-Xcctests` or something). Revert this patch until we find an agreement. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012854 , @ilinpv wrote: > I don't think `std::equal` is underlying cause here. We have > featuresStrs_size() comparison before calling it: > > if (CurClones && NewClones && > (CurClones->featuresStrs_size(

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014203 , @davide wrote: > @MaskRay Roy hasn't replied. We found other spellings that break (e.g. > `-Xcctests` or something). Revert this patch until we find an agreement. D139717 (

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014230 , @MaskRay wrote: > In D140224#4014203 , @davide wrote: > >> @MaskRay Roy hasn't replied. We found other spellings that break (e.g. >> `-Xcctests` or something). Revert

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

rsundahl added a comment. > I'll reject [-\Xparser for a while as well. This is a valid amendment to > D139717 , so I don't think it needs more > approval. We have projects that are failing because of -Xlinker and I'm not too excited about walking through eve

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014234 , @davide wrote: > In D140224#4014230 , @MaskRay wrote: > >> In D140224#4014203 , @davide wrote: >> >>> @MaskRay Roy hasn't rep

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014245 , @MaskRay wrote: > In D140224#4014234 , @davide wrote: > >> In D140224#4014230 , @MaskRay >> wrote: >> >>> In D140224#4014203

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014243 , @rsundahl wrote: >> I'll reject [-\Xparser for a while as well. This is a valid amendment to >> D139717 , so I don't think it needs more >> approval. > > We have projects t

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay added a comment. In D140224#4014246 , @davide wrote: > In D140224#4014245 , @MaskRay wrote: > >> In D140224#4014234 , @davide wrote: >> >>> In D140224#4014230

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

davide added a comment. In D140224#4014256 , @MaskRay wrote: > In D140224#4014243 , @rsundahl > wrote: > >>> I'll reject [-\Xparser for a while as well. This is a valid amendment to >>> D139717

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm updated this revision to Diff 484980. arsenm added a comment. Rebase. Use _w32/_w64 suffixes since some other wave specific builtins seem to have gone with that convention CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 Files: clang/in

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expressio

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

rymiel updated this revision to Diff 484985. rymiel added a comment. Adapt description of parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140339/new/ https://reviews.llvm.org/D140339 Files: clang/lib/Format/TokenAnnotator

[clang] ba4caec - [clang-format][docs] Fix invalid CSS syntax in versionbadge

Author: Emilia Dreamer Date: 2022-12-23T02:15:48+02:00 New Revision: ba4caec64fec457b4ab20876a809b45162b048f4 URL: https://github.com/llvm/llvm-project/commit/ba4caec64fec457b4ab20876a809b45162b048f4 DIFF: https://github.com/llvm/llvm-project/commit/ba4caec64fec457b4ab20876a809b45162b048f4.diff

[PATCH] D138441: [clang-format][docs] Fix invalid CSS syntax in versionbadge

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4caec64fec: [clang-format][docs] Fix invalid CSS syntax in versionbadge (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138441/new/ ht

[clang] 0ebed86 - [clang-format] Set requires expression params as not an expression

Author: Emilia Dreamer Date: 2022-12-23T02:22:48+02:00 New Revision: 0ebed862d82134e7a8e42d8dc7944afe765445ba URL: https://github.com/llvm/llvm-project/commit/0ebed862d82134e7a8e42d8dc7944afe765445ba DIFF: https://github.com/llvm/llvm-project/commit/0ebed862d82134e7a8e42d8dc7944afe765445ba.diff

[PATCH] D140330: [clang-format] Set requires expression params as not an expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ebed862d821: [clang-format] Set requires expression params as not an expression (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. In D136554#4013463 , @rupprecht wrote: > Glad the test case made sense to you, it was convoluted to me :) > > Still seeing one more error, and it's not modules-related so I might be able > to get it reduced today. Generally, it

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan added inline comments. Comment at: clang/lib/Headers/avx512vlbwintrin.h:2997 + +static __inline__ char __DEFAULT_FN_ATTRS128 +_mm_reduce_or_epi8(__m128i __W) { Should we update here too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz updated this revision to Diff 484994. shchenz added a comment. address @dblaikie comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140544/new/ https://reviews.llvm.org/D140544 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Co

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz marked an inline comment as done. shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582 } else if (LO.C11) { -LangTag = llvm::dwarf::DW_LANG_C11; +if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5) + LangTag = llvm::dwarf::DW_LANG

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#4013217 , @aykevl wrote: > I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't > think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is > inherently specific to that particular

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

shafik added a comment. Thank you for the fix, can you explain the failure case in more detail and why checking that `RD` is defined is the correct fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140587/new/ https://reviews.llvm.org/D140587 __

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484998. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( skan wrote: > char has different meaning on different platforms. Should we use "s

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. Currently in `Sema::getDestructorName` we call `SS.getScopeRep()->getPrefix()` but `SS.getScopeRep()` can return `nullptr` because `Look

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. > Why is it necessary to add new command-line flags for this? Can't the input > and output be inherited from the specified Clang command line? Would such > command line make sense? CMake wants to query the dependency information for a single file from time to time du

[PATCH] D135171: FreeBSD: enable __float128 on x86

pkubaj requested changes to this revision. pkubaj added a comment. This revision now requires changes to proceed. Could you modify it appropriately to also enable ppc, ppc64 and ppc64le? I checked whether it works on FreeBSD 13.1-RELEASE and it builds and works fine. Repository: rG LLVM Githu

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added a comment. In D137534#4014571 , @ChuanqiXu wrote: >> Why is it necessary to add new command-line flags for this? Can't the input >> and output be inherited from the specified Clang command line? Would such >> command line make sense? >

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 485016. pengfei added a comment. Add fmul, fmin and fmax cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140467/new/ https://reviews.llvm.org/D140467 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 485018. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( skan wrote: > skan wrote: > > char has different meaning on different platfor

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu updated this revision to Diff 485022. ChuanqiXu added a comment. Address comments: fix a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 Files: clang/include/clang/Tooling/CompilationDatabase.h clang/lib/Tooling/Compilation

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. > My GCC patch names it -fdepfile-output= instead of --p1689-targeted-output, > gets --p1689-targeted-file-name from the regular command line (it looks like > a preprocessor command overall) and the --p1689-makeformat-output flag is > handled by the normal -MT and -MF

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan accepted this revision. skan added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:115 + +char test_mm_reduce_mul_epi8(__m128i __W){ +// CHECK-LABEL: @test_mm_reduce_mul_epi8( FreddyYe wrote: > skan wrote: > > skan wrote: > > >

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke marked 6 inline comments as done. Sockke added a comment. Mark comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4012996 , @sammccall wrote: > This has been discussed before, unfortunately while I *thought* it was on a > bug, it was actually in a PR: https://github.com/clangd/vscode-clangd/pull/140 > > I don't think it's a good id

[clang] 68a8880 - [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

Author: Freddy Ye Date: 2022-12-23T14:54:53+08:00 New Revision: 68a888012b12f9846131baae2533927617a58584 URL: https://github.com/llvm/llvm-project/commit/68a888012b12f9846131baae2533927617a58584 DIFF: https://github.com/llvm/llvm-project/commit/68a888012b12f9846131baae2533927617a58584.diff LOG

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68a888012b12: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

rymiel planned changes to this revision. rymiel added a comment. Going to try to make the indentation of the cases following the controlling expression not continuations, since that results in weird results such as: #define LIMIT_MAX(T) \ _Generic(

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will extend this option to support C#, Java, and JavaScript using the underscore character `_` as the separator. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest, IntegerLiteralSepar

<    1   2