[clang] dbfe446 - [Clang] Implement CWG2640 Allow more characters in an n-char sequence

Author: Corentin Jabot Date: 2022-12-13T09:02:52+01:00 New Revision: dbfe446ef3b230e8d8421a6e79793fe6f405267f URL: https://github.com/llvm/llvm-project/commit/dbfe446ef3b230e8d8421a6e79793fe6f405267f DIFF: https://github.com/llvm/llvm-project/commit/dbfe446ef3b230e8d8421a6e79793fe6f405267f.diff

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbfe446ef3b2: [Clang] Implement CWG2640 Allow more characters in an n-char sequence (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D139211: [WIP][clang-format] Properly handle the C11 _Generic keyword.

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1691 +(CurrentState.IsCSharpGenericTypeConstraint) || GenericSelection || (Style.is

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 482377. cor3ntin added a comment. remove llvm::None Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Ex

[clang] 697bfa4 - Revert "[UpdateTestChecks] Match define for labels"

Author: Nikita Popov Date: 2022-12-13T09:15:35+01:00 New Revision: 697bfa40a3f853d8b9103ead53cd80a4f7c5a7df URL: https://github.com/llvm/llvm-project/commit/697bfa40a3f853d8b9103ead53cd80a4f7c5a7df DIFF: https://github.com/llvm/llvm-project/commit/697bfa40a3f853d8b9103ead53cd80a4f7c5a7df.diff

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

MyDeveloperDay added a comment. > The reason for me to work on this feature is the fact that clang-format > doesn't work reliable for changing the location of the const. After using > clang-tidy and clang-format some consts were still one the right hand side Its true we made the decision if cla

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:4819-4831 +// When we don't have 16 bit instructions, bf16 is illegal and gets +// softened to i16 for storage, with float being used for arithmetic. +// +// After softening, so

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

qiucf updated this revision to Diff 482381. qiucf retitled this revision from "[Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes" to "[Intrinsic] Rename flt.rounds intrinsic to get.rounding". qiucf edited the summary of this revision. qiucf added a comment. Use Aut

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static constexpr llv

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

nikic added inline comments. Comment at: libcxxabi/test/test_demangle.pass.cpp:12917 {"_ZNK4llvm17X86TargetLowering15LowerTRAMPOLINEENS_7SDValueERNS_12SelectionDAGE", "llvm::X86TargetLowering::LowerTRAMPOLINE(llvm::SDValue, llvm::SelectionDAG&) const"}, - {"_ZNK4llvm1

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Pierre-vh updated this revision to Diff 482384. Pierre-vh added a comment. Put the assert back in, use alternative fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139713/new/ https://reviews.llvm.org/D139713 Files: clang/lib/AST/ExprConstant.c

[clang] f1f1b60 - Implement CWG2631

Author: Corentin Jabot Date: 2022-12-13T09:57:05+01:00 New Revision: f1f1b60c7ba607e9ffe3bc012161d43ef95ac773 URL: https://github.com/llvm/llvm-project/commit/f1f1b60c7ba607e9ffe3bc012161d43ef95ac773 DIFF: https://github.com/llvm/llvm-project/commit/f1f1b60c7ba607e9ffe3bc012161d43ef95ac773.diff

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1f1b60c7ba6: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 48e6ff9 - [clangd] Fix some header guard names, NFC

Author: Haojian Wu Date: 2022-12-13T10:00:51+01:00 New Revision: 48e6ff9ad3eb1971de6d7ba12e31754781aff675 URL: https://github.com/llvm/llvm-project/commit/48e6ff9ad3eb1971de6d7ba12e31754781aff675 DIFF: https://github.com/llvm/llvm-project/commit/48e6ff9ad3eb1971de6d7ba12e31754781aff675.diff LO

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line created this revision. addr2line added a reviewer: MaskRay. addr2line added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a reviewer: njames93. Herald added a project: All. addr2line requested review of this revision. Herald added a subscr

[PATCH] D139919: use std::optional in ClangTidyCheck

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. AFAIK it's preferred to use the LLVM types instead of the Standard types: > When both C++ and the LLVM support libraries provide similar functionality, > and there isn’

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line added a comment. Sorry, I just saw a lot of changes in the llvm repo that change llvm::Optional to std::optional, like this one . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D139919: use std::optional in ClangTidyCheck

MaskRay added a comment. In D139919#3991242 , @carlosgalvezp wrote: > AFAIK it's preferred to use the LLVM types instead of the Standard types: > >> When both C++ and the LLVM support libraries provide similar functionality, >> and there isn’t a specifi

[PATCH] D139919: use std::optional in ClangTidyCheck

carlosgalvezp added a comment. In D139919#3991247 , @addr2line wrote: > Sorry, I just saw a lot of changes in the llvm repo that change > llvm::Optional to std::optional, like this one >

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:953 if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState)) + if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode))

[PATCH] D139919: use std::optional in ClangTidyCheck

carlosgalvezp added a comment. In D139919#3991250 , @MaskRay wrote: > In D139919#3991242 , @carlosgalvezp > wrote: > >> AFAIK it's preferred to use the LLVM types instead of the Standard types: >> >>> When both C

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static cons

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

merrymeerkat updated this revision to Diff 482393. merrymeerkat added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139868/new/ https://reviews.llvm.org/D139868 Files: clang/include/clang/Analysis/FlowSensitive/

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line updated this revision to Diff 482395. addr2line added a comment. remove the change to the unrelated lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools-extra/c

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

Szelethus added a comment. IIRC we talked about it would only really make sense to evaluate this patch stack as a whole, not piece by piece, but I'm not seeing results on open source projects here either. Can you please post them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Introduce signals to rank prov

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line marked an inline comment as done. addr2line added a comment. Oops, the check on Debian failed. I'm looking into it... Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:457 - } // namespace tidy } // namespace clang MaskRay wrote: > drop wh

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line updated this revision to Diff 482404. addr2line marked an inline comment as done. addr2line added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. It also need to change the return type in YAMLParser. CHANGES SINCE LAST ACTION https://review

[PATCH] D139919: use std::optional in ClangTidyCheck

carlosgalvezp added a comment. Sounds like the change to the YAML parser can potentially affect many other components other than clang-tidy - should that be done in a separate patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 ___

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line updated this revision to Diff 482412. addr2line added a comment. Also in YAMLTraits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools-extra/clang-tidy/ClangTidyChe

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line added a comment. In D139919#3991407 , @carlosgalvezp wrote: > Sounds like the change to the YAML parser can potentially affect many other > components other than clang-tidy - should that be done in a separate patch? Only these left. ./clan

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. With this patch

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line updated this revision to Diff 482418. addr2line added a comment. finally CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.h clang

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 updated this revision to Diff 482419. Michael137 added a comment. - Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/C

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470 const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE; +#define PREFIX(NAME, VALUE) static constexpr llv

[PATCH] D128372: [Clang-Tidy] Empty Check

MyDeveloperDay added a comment. Ironically as an aside... looking back at the review because of the discource article. The whole reason why I added the [[nodiscard]] checker to clang-tidy 4 years ago was to cover exactly this use case...and many others like it where users have a function which

[clang-tools-extra] bcb457c - [clangd] Fix a semantic highlighting crash on dependent code.

Author: Haojian Wu Date: 2022-12-13T12:19:41+01:00 New Revision: bcb457c68e20120f0bdd0a59e4b4ce90b8121310 URL: https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310 DIFF: https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310.diff LO

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

hokein added a comment. This patch causes a clangd crash on dependent code (e.g. running on `ASTMatchers.h`), fixed in https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3991530 , @hokein wrote: > This patch causes a clangd crash on dependent code (e.g. running on > `ASTMatchers.h`), fixed in > https://github.com/llvm/llvm-project/commit/bcb457c68e20120f0bdd0a59e4b4ce90b8121310. Th

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:953 if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState)) + if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode))

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:953 if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState)) + if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode))

[PATCH] D139926: [clangd] Add semantic tokens for angle brackets

ckandeler updated this revision to Diff 482422. ckandeler added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp clang-tools

[PATCH] D139919: use std::optional in ClangTidyCheck

addr2line updated this revision to Diff 482424. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139919/new/ https://reviews.llvm.org/D139919 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-tools-extra/clang-tidy/ClangTidyCheck.h clang-tools-extra/clang-tidy/readability/I

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

Szelethus added a comment. In D135360#3981420 , @balazske wrote: > My current approach is that the POSIX is more strict than the C standard > (POSIX allows a subset of what C allows). I do not see (errno related) > contradiction between these standards

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, jdoerfert wrote: > jhuber6 wrote: > > tianshil

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

JonChesterfield added a comment. I am reluctant to add the dependency edge to rocm device libs to openmp's GPU runtime. We currently require that library for libm, which I'm also not thrilled about, but at least you can currently build and run openmp programs (that don't use libm, like much of

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

MoritzS added a comment. Thanks for the patch! I just tried it out and I think this enables many interesting use cases for WebAssembly when using C/C++. Currently the lowering to wasm does not work when using externrefs when compiling without optimizations. Is that intended behavior? I have th

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Mapping.cpp:19 #pragma omp begin declare target device_type(nohost) - +extern const uint16_t __oclc_ABI_version; #include "llvm/Frontend/OpenMP/OMPGridValues.h" jhuber6 wrote: >

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 482440. sdesmalen added a comment. Changed arm_new_za to be a declaration attribute instead of a type attribute (this was something that @rsandifo-arm pointed out to me recently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 2 inline comments as done. tuliom added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') qiucf wrote: > tuliom w

[clang] 82d50fe - [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

Author: Dani Ferreira Franco Moura Date: 2022-12-13T14:49:07+01:00 New Revision: 82d50fef9b7c1dfdff7f9265340fde40a34870cf URL: https://github.com/llvm/llvm-project/commit/82d50fef9b7c1dfdff7f9265340fde40a34870cf DIFF: https://github.com/llvm/llvm-project/commit/82d50fef9b7c1dfdff7f9265340fde40a

[PATCH] D139868: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice element

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82d50fef9b7c: [clang][dataflow] Change the diagnoser API to receive a correctly typed lattice… (authored by merrymeerkat, committed by gribozavr).

[PATCH] D139006: [UpdateTestChecks] Match define for labels

spatel added subscribers: arsenm, spatel. spatel added a comment. I agree with the revert - we'd need lots of commits like this: b7232dafe69eb04c14217 (cc @arsenm) Another possibility to fix this with less churn: Add a warnin

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ymandel added a comment. In D139737#3989927 , @NoQ wrote: > Ok so at the conference @ymandel suggested us to use libTooling's > Transformers API to make our lives easier > (https://clang.llvm.org/docs/ClangTransformerTutorial.html). I'm fairly > certai

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:953 if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState)) + if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode))

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:246-249 + if (!IsVMTTy) +EscapedParameters.insert(VD); + else if (!IsForCombinedParallelRegion) +return; Also, can you make it specific t

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl added a comment. In D139717#3987963 , @MaskRay wrote: >> This change is breaking internal builds. We use the -Xfoo pattern but can >> now no longer manage whether we allow an unused -Xfoo option to pass as a >> warning or promote it to an err

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

dnpetrov-sc updated this revision to Diff 482449. dnpetrov-sc marked an inline comment as done. dnpetrov-sc added a comment. - Added syntacore prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.llvm.org/D139302 Files:

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

dnpetrov-sc updated this revision to Diff 482455. dnpetrov-sc added a comment. - Fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.llvm.org/D139302 Files: clang/test/Driver/riscv-cpus.c clang/test/Misc/target-inva

[PATCH] D139458: [clangd] Full support for #import insertions

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ASTSignals.cpp:28 + // Source files: Use #import if the ObjC language flag is enabled + if (isHeaderFile(AST.tuPath(), AST.getLangOpts())) { +if (AST.getLangOpts().ObjC) { can we rewrite t

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

Backl1ght added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. with nits The lower could handle the vector case easily, but it didn't before either Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2915 +SDValue Op = N

[PATCH] D139045: [HIP] support --offload-arch=native

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGe8fd998e6194: [HIP] support --offload-arch=native (authored by yaxunl). Herald added a project: clang. Chan

[clang] e8fd998 - [HIP] support --offload-arch=native

Author: Yaxun (Sam) Liu Date: 2022-12-13T10:09:33-05:00 New Revision: e8fd998e6194d8749b83b30813e3cb74e5261770 URL: https://github.com/llvm/llvm-project/commit/e8fd998e6194d8749b83b30813e3cb74e5261770 DIFF: https://github.com/llvm/llvm-project/commit/e8fd998e6194d8749b83b30813e3cb74e5261770.dif

[PATCH] D128372: [Clang-Tidy] Empty Check

Eugene.Zelenko added a comment. Please take a loon on https://github.com/llvm/llvm-project/issues/59487. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fdbe5c573b9: [clang][PPC] Checking Unknown Values Passed to -mcpu (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 1fdbe5c - [clang][PPC] Checking Unknown Values Passed to -mcpu

Author: Qiongsi Wu Date: 2022-12-13T10:18:44-05:00 New Revision: 1fdbe5c573b920f00e5bfdbcea0e837833ae77a0 URL: https://github.com/llvm/llvm-project/commit/1fdbe5c573b920f00e5bfdbcea0e837833ae77a0 DIFF: https://github.com/llvm/llvm-project/commit/1fdbe5c573b920f00e5bfdbcea0e837833ae77a0.diff LO

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae created this revision. python3kgae added reviewers: mboehme, aaron.ballman, erichkeane. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change clang::annotate into clang::annotate_type.

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. Looking good! Some minor comments Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp:40 + + diag(Lam

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp:40 + + diag(Lambda->getBeginLoc(), "found capturing coroutine lambda"); +} carlosgalvezp wrote: > Perhaps it would be good wi

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a subscriber: STL_MSFT. compnerd added a comment. @fsb4000 is my reading correct that MSVC will look into trying to handle `static inline` even though it is a GNUism? I wonder if we should consider limiting the use of `static inline` to C mode rather than including C++. I also

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

tahonermann added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto lambda2 = [] {}; // expected-error {{def

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

ldionne created this revision. ldionne added a reviewer: arphaman. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, we would be passing down -stdlib=libc++ from the Driver to CC1 whene

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson added a comment. As this is a rather simple cleanup, I'll go ahead and merge this next week unless there is any objection until then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 _

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) && ---

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary updated this revision to Diff 482489. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/arm_acle.c clan

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added reviewers: paquette, aemerson. lenary added a comment. Adding Jessica and Amara as this affects GlobalISel for AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght added a comment. OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 _

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

kadircet added a comment. Hi! Sorry for letting these series of patches sit around without any comments. We were having some discussions internally to both understand the value proposition and its implications on the infrastructure. So it'd help a lot if you can provide some more information fo

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked an inline comment as done. tuliom added a comment. Thanks @qiucf ! I don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

steakhal added a comment. The `StaticAnalyzer` portion looks good to me AFAICT. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39 ento::CallDescription::CallDescription(CallDescriptionFlags Flags, - ArrayRef QualifiedName, +

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ben.boeckel added a comment. This worked for CMake in a previous version, so is good enough on the functionality front. I'll retry with the current state to verify. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 _

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) && ---

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

tom-anders added a comment. Thanks for the detailed feedback! Unfortunately, I’m sick right now, so I probably won’t be able to give a detailed answer until after Christmas. In D134130#3992116 , @kadircet wrote: > Happy to move the discussion to some ot

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. Some reports can be found here (if the link works and the data does not expire), the runs stored on 2022-12-09. Results appeared only projects "postgres" and "curl" (from memcached,tmux,curl,twin,vim,op

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

dblaikie added a comment. (This should be committed in two parts - the LLVM part first, then the Clang part - since they can be separated, they should be - but happy to review it altogether) Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1856 + +bool DwarfUnit::shouldE

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno added a comment. Thank you for your comments. Unfortunately I won't be able to implement these changes because of time constraints in the current project, sorry if I've wasted your time. On the bright side I feel like I've learned something so thank you for that. I hope I can make a prop

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

tahonermann added a comment. This has already been merged, but I'm commenting just to note (continued) approval of the most recent changes. Looks great, Corentin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I'm not sure if that is correct, as that doesn't fit the example (unless the example is wrong) It feels like its saying merge if its an argument of a function (sort i

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; Backl1ght

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

MyDeveloperDay added a comment. ditto my concerns with D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine as to if we should have a Leave option CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D13978

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

Backl1ght added a comment. Seems like I have misunderstood it, after some test I'm sure that it means merge if its an argument of a function. I think there are something todo to make the doc more clearly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

Backl1ght updated this revision to Diff 482530. Backl1ght retitled this revision from "[clang-format] fix typo in doc for SLS_Inline" to "[clang-format] make doc for SLS_Inline more clearly". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 File

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 updated this revision to Diff 482533. Michael137 added a comment. - Split clang and llvm changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp cla

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. **Summary** St

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 added a comment. In D139928#3992233 , @dblaikie wrote: > (This should be committed in two parts - the LLVM part first, then the Clang > part - since they can be separated, they should be - but happy to review it > altogether) Split the revie

  1   2   >