nikic added inline comments.

================
Comment at: libcxxabi/test/test_demangle.pass.cpp:12917
     
{"_ZNK4llvm17X86TargetLowering15LowerTRAMPOLINEENS_7SDValueERNS_12SelectionDAGE",
 "llvm::X86TargetLowering::LowerTRAMPOLINE(llvm::SDValue, llvm::SelectionDAG&) 
const"},
-    
{"_ZNK4llvm17X86TargetLowering16LowerFLT_ROUNDS_ENS_7SDValueERNS_12SelectionDAGE",
 "llvm::X86TargetLowering::LowerFLT_ROUNDS_(llvm::SDValue, llvm::SelectionDAG&) 
const"},
+    
{"_ZNK4llvm17X86TargetLowering16LowerGET_ROUNDINGENS_7SDValueERNS_12SelectionDAGE",
 "llvm::X86TargetLowering::LowerGET_ROUNDING(llvm::SDValue, 
llvm::SelectionDAG&) const"},
     {"_ZNK4llvm17X86TargetLowering9LowerCTLZENS_7SDValueERNS_12SelectionDAGE", 
"llvm::X86TargetLowering::LowerCTLZ(llvm::SDValue, llvm::SelectionDAG&) const"},
----------------
Demangling tests should not be updated.


================
Comment at: llvm/docs/LangRef.rst:24567
 
+For compatibility, ``llvm.flt.rounds`` has the same behavior as this intrinsic.
+
----------------
Can drop this note now.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:916
+      return true;
+    }
+    break;
----------------
This needs a test in llvm/test/Bitcode. Create a bitcode file using flt.rounds 
prior to this change, and then test llvm-dis on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139507/new/

https://reviews.llvm.org/D139507

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to