[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

2022-12-07 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Probably should copy the release note change from https://reviews.llvm.org/D138078. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 __

[clang] f9de860 - [Driver][test] Fix test by creating empty archive instead of empty file

2022-12-07 Thread Jacob Lambert via cfe-commits
Author: Jacob Lambert Date: 2022-12-07T11:50:11-08:00 New Revision: f9de860ca4c4b5827498dc096a26d9ebdf236181 URL: https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181 DIFF: https://github.com/llvm/llvm-project/commit/f9de860ca4c4b5827498dc096a26d9ebdf236181.diff

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

2022-12-07 Thread Jacob Lambert via Phabricator via cfe-commits
lamb-j added a comment. @thakis thanks for reverting that, sorry I didn't see your request sooner! I've switched the patch to use "llvm-ar" instead of "ar", which should solve the issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ h

[clang] 6cac3dc - [clang] Tweak test to tolerate clang being called "clang" instead of "clang-15"

2022-12-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-12-07T15:03:35-05:00 New Revision: 6cac3dc9db57cbf5f9f9092d97f878be3db5020d URL: https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d DIFF: https://github.com/llvm/llvm-project/commit/6cac3dc9db57cbf5f9f9092d97f878be3db5020d.diff LO

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

2022-12-07 Thread Adrian Dole via Phabricator via cfe-commits
adriandole created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. adriandole requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139570

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 481014. tianshilei1992 added a comment. Herald added a subscriber: aheejin. drop LTO and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files:

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 marked 5 inline comments as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt:24 else() llvm_map_components_to_libnames(llvm_libs Support) endif() Have to figure

[PATCH] D139395: Add CFI integer types normalization

2022-12-07 Thread Ramon de C Valle via Phabricator via cfe-commits
rcvalle updated this revision to Diff 481016. rcvalle added a comment. Updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManual.r

[libunwind] c9aff5d - Revert "[libunwind] Use .irp directives. NFC"

2022-12-07 Thread David Tenty via cfe-commits
Author: David Tenty Date: 2022-12-07T15:41:29-05:00 New Revision: c9aff5d2f9d93636009ae389824f3beacfcbc7b7 URL: https://github.com/llvm/llvm-project/commit/c9aff5d2f9d93636009ae389824f3beacfcbc7b7 DIFF: https://github.com/llvm/llvm-project/commit/c9aff5d2f9d93636009ae389824f3beacfcbc7b7.diff L

[PATCH] D139458: [clangd] Full support for #import insertions

2022-12-07 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 481022. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignals.cpp clang-tools-extra/clan

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 481023. tianshilei1992 added a comment. add build components Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/CMake

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

2022-12-07 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 481029. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

2022-12-07 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

2022-12-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Please update if it's still relevant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119621/new/ https://reviews.llvm.org/D119621 __

[PATCH] D115103: Leak Sanitizer port to Windows

2022-12-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 ___

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

2022-12-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Herald added a subscriber: Enna1. Is this still relevant? If so, I would recommend to split ItaniumCXXABI from asan changes. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115103: Leak Sanitizer port to Windows

2022-12-07 Thread Clemens Wasser via Phabricator via cfe-commits
clemenswasser updated this revision to Diff 481042. clemenswasser added a comment. @vitalybuka I've been working on this on-off for the past months and have gotten the tests in the following state: Unsupported: 41 Passed : 19 Failed : 48 There is still the bug with the tracer thre

[PATCH] D115103: Leak Sanitizer port to Windows

2022-12-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. You probably can try to finish pure lsan, and then get back to lsan+asan. So if you continue to work please send smaller and ready pieces for review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115103/new/ https://reviews.llvm.org/D115103 _

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

2022-12-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Abandon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 _

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. We should probably make a test for this. Do we currently test the nextgen plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 ___

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

2022-12-07 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. Here is a simple test case that fails the assertion in the current location. struct B { B(int, int); }; struct D : B { D() : B(0, 1) {} }; I spent a bit more time looking at the code and finally realized that `Initializer` is only assigned when `Args

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

2022-12-07 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 ___ cfe

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. All but a test and this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D139580: Run clang-tidy on clang-tidy

2022-12-07 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit created this revision. gAlfonso-bit added projects: LLVM, clang-format, clang-tools-extra. Herald added subscribers: kadircet, carlosgalvezp, arphaman, zzheng, javed.absar, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. gAlfonso-bit requested review

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2022-12-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thank you for working through this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.org/D137996

[PATCH] D137488: [clang][Interp] Array initialization via string literal

2022-12-07 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. This looks good to me now. I'm sorry for taking so long to return to review. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->

[PATCH] D139547: [NFC] Correct argument comment typo

2022-12-07 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit added a comment. @MaskRay This should be a quickie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D137826: [clang] Allow comparing pointers to string literals

2022-12-07 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); tbaeder wrote:

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

2022-12-07 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao created this revision. rZhBoYao added a reviewer: clang-language-wg. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implemented the C++23 paper P2718R0 Repository: rG LLVM Github Monorepo

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

2022-12-07 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 481078. Amir added a comment. Fix instrumentation and no-LBR modes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/caches/BOL

[PATCH] D65753: Builtins: Add some v2f16 variants

2022-12-07 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm abandoned this revision. arsenm added a comment. Herald added a project: All. Looks like __builtin_elementwise_* now exist to handle some of these operations for arbitrary vector elements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/ https://reviews.llvm.org/D65753 _

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

2022-12-07 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao added a comment. Consider: struct T { const int *begin() const; const int *end() const; T &r() [[clang::lifetimebound]]; T t(); }; const T &f1(const T &t [[clang::lifetimebound]]) { return t; } T g(); void foo() { for (auto e : f1(g())) {} for (a

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

2022-12-07 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. We can land this once we assert global instrumentation is enabled f

[clang-tools-extra] 49e75eb - [Bitcode(Reader|Writer)] Convert Optional to std::optional

2022-12-07 Thread Krzysztof Parzyszek via cfe-commits
Author: Krzysztof Parzyszek Date: 2022-12-07T15:27:38-08:00 New Revision: 49e75ebd854dee1fcf5729c264f4cfadf76e952d URL: https://github.com/llvm/llvm-project/commit/49e75ebd854dee1fcf5729c264f4cfadf76e952d DIFF: https://github.com/llvm/llvm-project/commit/49e75ebd854dee1fcf5729c264f4cfadf76e952d

[clang] 3738ce0 - Add support for a backdoor driver option that enables emitting header

2022-12-07 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-12-07T15:30:19-08:00 New Revision: 3738ce05a70cf97fc73a07b158a1726f61aed28b URL: https://github.com/llvm/llvm-project/commit/3738ce05a70cf97fc73a07b158a1726f61aed28b DIFF: https://github.com/llvm/llvm-project/commit/3738ce05a70cf97fc73a07b158a1726f61aed28b.diff

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2022-12-07 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3738ce05a70c: Add support for a backdoor driver option that enables emitting header (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2022-12-07 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/71451/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.ll

[clang] abc87ad - Remove slash in check string to fix the test that is failng on windows

2022-12-07 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-12-07T16:17:29-08:00 New Revision: abc87ad4ed6cc5e6568751f375d1c646edb502f7 URL: https://github.com/llvm/llvm-project/commit/abc87ad4ed6cc5e6568751f375d1c646edb502f7 DIFF: https://github.com/llvm/llvm-project/commit/abc87ad4ed6cc5e6568751f375d1c646edb502f7.diff

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

2022-12-07 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. abc87ad4ed6cc5e6568751f375d1c646edb502f7 should fix the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.o

[clang] 003b603 - [clang] Ensure correct metadata for relative vtables

2022-12-07 Thread Leonard Chan via cfe-commits
Author: Leonard Chan Date: 2022-12-08T00:42:48Z New Revision: 003b6033e1b254dd96ddb341f375b73ee5bed2af URL: https://github.com/llvm/llvm-project/commit/003b6033e1b254dd96ddb341f375b73ee5bed2af DIFF: https://github.com/llvm/llvm-project/commit/003b6033e1b254dd96ddb341f375b73ee5bed2af.diff LOG:

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

2022-12-07 Thread Leonard Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003b6033e1b2: [clang] Ensure correct metadata for relative vtables (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

2022-12-07 Thread Roy Sundahl via Phabricator via cfe-commits
rsundahl added a comment. In D125195#3979478 , @vitalybuka wrote: > Is this still relevant? > If so, I would recommend to split ItaniumCXXABI from asan changes. I haven't proceeded with this because this would be ABI breaking. I intend to support the (

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

2022-12-07 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729 + if (!Opts.ProfileInstrumentUsePath.empty()) { +auto FS = llvm::vfs::getRealFileSystem(); +setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags);

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

2022-12-07 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589 ___

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

2022-12-07 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5380 + } + InitExprs.push_back(ER.get()); +} So the libc++ test compile failures are due to this line. One example of a failing unit test is [range.take.while/ctor.v

[PATCH] D138489: [tsan] Add tsan support for loongarch64

2022-12-07 Thread Lu Weining via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb89b42b31c45: [tsan] Add tsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHA

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 481132. bryanpkc marked 5 inline comments as done. bryanpkc edited the summary of this revision. bryanpkc added a comment. Herald added a subscriber: mgrang. Herald added a reviewer: aaron.ballman. Updated the patch according to review comments which suggest

[clang] b89b42b - [tsan] Add tsan support for loongarch64

2022-12-07 Thread Weining Lu via cfe-commits
Author: Youling Tang Date: 2022-12-08T10:08:49+08:00 New Revision: b89b42b31c4590bb01076ed52f1c781ff787e0ef URL: https://github.com/llvm/llvm-project/commit/b89b42b31c4590bb01076ed52f1c781ff787e0ef DIFF: https://github.com/llvm/llvm-project/commit/b89b42b31c4590bb01076ed52f1c781ff787e0ef.diff

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc marked 2 inline comments as done. bryanpkc added a comment. @david-arm, I have moved all the SME definitions into a new file, arm_sme.td. I have moved the common definitions into another file, arm_sve_sme_incl.td, which will be included by both arm_sve.td and arm_sme.td. SveEmitter has

[clang] 6133942 - [OpenMP][FIX] Remove AssertingVHs that outlive their values

2022-12-07 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2022-12-07T18:27:55-08:00 New Revision: 61339427961a4399174e3e69240de7d1ad403046 URL: https://github.com/llvm/llvm-project/commit/61339427961a4399174e3e69240de7d1ad403046 DIFF: https://github.com/llvm/llvm-project/commit/61339427961a4399174e3e69240de7d1ad403046.d

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

2022-12-07 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc updated this revision to Diff 481137. bryanpkc added a comment. Removed some diffs that weren't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/Built

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

2022-12-07 Thread Amir Ayupov via Phabricator via cfe-commits
Amir updated this revision to Diff 481138. Amir added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files:

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2022-12-07 Thread Christopher Sauer via Phabricator via cfe-commits
cpsauer added a comment. Sorry for being so slow this time myself, guys. Took me a while to dig myself out of a deep inbox hole after Thanksgiving (US holiday). Really appreciate you all and your friendly responsiveness, especially as I get up to speed here. Repository: rG LLVM Github Monore

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2022-12-07 Thread Christopher Sauer via Phabricator via cfe-commits
cpsauer updated this revision to Diff 481141. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 Files: clang-tools-extra/clangd/SystemIncludeExtractor.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/c

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2022-12-07 Thread Christopher Sauer via Phabricator via cfe-commits
cpsauer added a comment. @nridge, I took a shot at amending the test. Thanks for the pointer! Please me know if that looks good to you! The host-target cross-compile situation you hypothesize is exactly what caused me to notice this. Super common with Bazel. CHANGES SINCE LAST ACTION https:/

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

2022-12-07 Thread Christopher Sauer via Phabricator via cfe-commits
cpsauer added a comment. @kadircet, you were asking about what's requiring the use of query-driver--I'll reply over in the issue (as you suggest), keeping everything in one place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546 __

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

2022-12-07 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. We probably want to enable a new test configuration to have each test run in JIT mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

2022-12-07 Thread Allen zhong via Phabricator via cfe-commits
Allen added inline comments. Herald added a project: All. Comment at: llvm/test/CodeGen/AArch64/sve2-intrinsics-fp-int-binary-logarithm.ll:31 +; CHECK-NEXT: ret + %out = call @llvm.aarch64.sve.flogb.nxv2f64( %a, +

[clang-tools-extra] aee5910 - [clang-tools-extra] Use std::nullopt instead of None in comments (NFC)

2022-12-07 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-12-07T20:22:27-08:00 New Revision: aee591003c0c1d2eb7f3e038aade820dab20d849 URL: https://github.com/llvm/llvm-project/commit/aee591003c0c1d2eb7f3e038aade820dab20d849 DIFF: https://github.com/llvm/llvm-project/commit/aee591003c0c1d2eb7f3e038aade820dab20d849.diff L

[clang] 685bbe6 - [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

2022-12-07 Thread via cfe-commits
Author: gonglingqin Date: 2022-12-08T14:11:50+08:00 New Revision: 685bbe65f5c3617e79f52a5af827cee2ee0b6f45 URL: https://github.com/llvm/llvm-project/commit/685bbe65f5c3617e79f52a5af827cee2ee0b6f45 DIFF: https://github.com/llvm/llvm-project/commit/685bbe65f5c3617e79f52a5af827cee2ee0b6f45.diff L

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

2022-12-07 Thread Gong LingQin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG685bbe65f5c3: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/n

[PATCH] D139604: [PATCH] Github Issue: Create a check that warns about using %p printf specifier #43453

2022-12-07 Thread Gianni Crivello via Phabricator via cfe-commits
giannicrivello created this revision. giannicrivello added reviewers: NoQ, tbaeder. giannicrivello added a project: clang. Herald added subscribers: steakhal, martong. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. giannicrivello requested review of this revision. Herald add

[PATCH] D139604: [PATCH] Github Issue: Create a check that warns about using %p printf specifier #43453

2022-12-07 Thread Gianni Crivello via Phabricator via cfe-commits
giannicrivello updated this revision to Diff 481154. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139604/new/ https://reviews.llvm.org/D139604 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/UnixAPIChecker.cpp Index: clang/lib/Stati

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

2022-12-07 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? In case any user outside of clang references it (although I believe no), we can deprecate it and

<    1   2