[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs. Thanks! Comment at: clang/lib/Sema/Sema.cpp:600 + // Ignore null pointers in defaulted functions, e.g. defaulted comparison + // opera

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

rymiel added a comment. Maybe the docs need somewhat of a fresh coat of paint. As a clang-format user it's odd to find the options listed as "ConfigName (`EnumName`)" but when listing the actual options it's "`EnumOption` (In configuration: `ConfigOption`)". At the very least, the order of the l

[PATCH] D138821: Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478265. VitaNuo added a comment. Add another example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478267. VitaNuo added a comment. Edit commit message, add "[include-cleaner]". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-clea

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138603/new/ https://reviews.llvm.org/D138603 __

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc);

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

sammccall updated this revision to Diff 478274. sammccall retitled this revision from "[clangd] Don't run slow clang-tidy checks" to "[clangd] Don't run slow clang-tidy checks by default". sammccall edited the summary of this revision. sammccall added a comment. Add tests of isFast Make isFast a

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

fmayer accepted this revision. fmayer added inline comments. Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); fmayer

[PATCH] D138078: [SelectionDAGISel] split critical indirect edges from callbr w/ outputs

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp:482-483 + + for (Instruction &I : instructions(F)) { +if (auto *CBR = dyn_cast(&I)) { + // If the CallBrInst has no outp

[clang] c9d38bd - Remove this type from Parser.h; NFC

Author: Aaron Ballman Date: 2022-11-28T13:12:34-05:00 New Revision: c9d38bd7132176d2b531caae2334891609db5196 URL: https://github.com/llvm/llvm-project/commit/c9d38bd7132176d2b531caae2334891609db5196 DIFF: https://github.com/llvm/llvm-project/commit/c9d38bd7132176d2b531caae2334891609db5196.diff

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sure, I'll update core issue list in a separate diff. I don't have commit rights, but I have a commit merged (just one). Does it make me eligible for that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://r

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 ___ cfe-c

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

rjmccall added a comment. To be clear, my opinion is just that the requested change is implementable, as I understand it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126818/new/ https://reviews.llvm.org/D126818 ___ cfe-commits mailing list

[clang] 9061928 - Stop accepting 'bool' in a concept declaration as an extension.

Author: Erich Keane Date: 2022-11-28T10:22:54-08:00 New Revision: 9061928ebbb1a9d002583ede2700429100305d6a URL: https://github.com/llvm/llvm-project/commit/9061928ebbb1a9d002583ede2700429100305d6a DIFF: https://github.com/llvm/llvm-project/commit/9061928ebbb1a9d002583ede2700429100305d6a.diff L

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3954137 , @rjmccall wrote: > To be clear, my opinion is just that the requested change is implementable, > as I understand it. I agree that each version of what we THINK the requested change might be is implementa

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

efriedma added a comment. It looks like AArch64ABIInfo::classifyArgumentType does a slightly more complicated check for "empty"; does that matter here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 ___

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. In D105584#3917238 , @kiranchandramohan wrote: > Patch probably needs a rebase. A few more minor things to fix. Looks mostly > ready. With which branch should I rebase? I have taken care rest of the comments. Thanks

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added reviewers: efriedma, erichkeane. aaron.ballman added a comment. In general, this looks like an improvement over the last iteration (thank you for the suggestions, @rsmith!). I think this LGTM but there's enough changes in CodeGen that I'd appreciate a second set of eyes on th

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

njames93 added a comment. I'm really not sure this is the right approach to solve the problem. If the concern here is leaking on exceptions, then the goalpost should be flagging all calls to global new and recommend a smart pointer factory instead. I think that check could even be made as a cpp

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

tra added a comment. > Builds were failing because "__bf16" wasn't allowed on the target. For CUDA/NVPTX we've solved the issue by implementing storage-only support for NVPTX: https://reviews.llvm.org/D136311 It's a bit more work, but I think it would be a better fix long-term for AMDGPU, too.

[clang] afd800f - [clang] Require parameter pack to be last argument in concepts.

Author: Luke Nihlen Date: 2022-11-28T18:40:19Z New Revision: afd800fc5679ccfe6f32b097586c658628500867 URL: https://github.com/llvm/llvm-project/commit/afd800fc5679ccfe6f32b097586c658628500867 DIFF: https://github.com/llvm/llvm-project/commit/afd800fc5679ccfe6f32b097586c658628500867.diff LOG: [

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Hmmm I might be inclined to emit 17 and 20 only under not-strict-DWARF for v5, although it makes the logic more complicated. The codes have been allocated but AFAICT the website doesn't have the new codes listed (I looked at http://wiki.dwarfstd.org/index.php/DWARF_L

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

shafik added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:556 static_assert(__is_aggregate(EmptyArMB), ""); static_assert(!__is_aggregate(void), ""); static_assert(!__is_aggregate(const volatile void), ""); Should this be `true` now or

[PATCH] D138835: [clang] Update DR status to Revision 110

erichkeane added a comment. This looks good to me, thanks! If you post your "Name " that you'd like to have this committed as, I can do so (or someone else can beat me to it!). Comment at: clang/www/make_cxx_dr_status:161 continue - if dr.issue in (1432,2565): row

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a comment. In D138822#3954104 , @Endill wrote: > Sure, I'll update core issue list in a separate diff. Thanks! > I don't have commit rights, but I have a commit merged (just one). Does it > make me eligible for that? Not quite yet

[PATCH] D138822: [clang] Add test for CWG36

erichkeane added a comment. BTW, I suspect you're close enough to ask for commit rights, and I'd prefer to not have to commit too many things for you, so please go through this procedure: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added a comment. This is looking good to me. No further non-trivial concerns on my side. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6165 + // Stop squashing the top-level stmts into a single function. + if (CurCGF && !CXXGlobalInits.back()->getName().startswith("_

[PATCH] D138835: [clang] Update DR status to Revision 110

Endill added a comment. Here it is: Vlad Serebrennikov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138835/new/ https://reviews.llvm.org/D138835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] b1a6f2a - [clang] Update DR status to Revision 110

Author: Vlad Serebrennikov Date: 2022-11-28T11:20:22-08:00 New Revision: b1a6f2aa89c3cf82ae67d28a8a20651eb68d84f1 URL: https://github.com/llvm/llvm-project/commit/b1a6f2aa89c3cf82ae67d28a8a20651eb68d84f1 DIFF: https://github.com/llvm/llvm-project/commit/b1a6f2aa89c3cf82ae67d28a8a20651eb68d84f1.

[PATCH] D138835: [clang] Update DR status to Revision 110

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a6f2aa89c3: [clang] Update DR status to Revision 110 (authored b

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:556 static_assert(__is_aggregate(EmptyArMB), ""); static_assert(!__is_aggregate(void), ""); static_assert(!__is_aggregate(const volatile void), ""); shafik wrote: > Should this be

[PATCH] D138835: [clang] Update DR status to Revision 110

erichkeane added a comment. Woops, I never marked this as approved apaprently :) I definitely intended to above for anyone keeping track. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138835/new/ https://reviews.llvm.org/D138835

[PATCH] D138838: Update wrong Unicode code point in confusable-identifiers.rst

rferrandop created this revision. rferrandop added a reviewer: aaron.ballman. Herald added a project: All. rferrandop requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In `confusable-identifiers.rst` the description refers to wron

[PATCH] D138835: [clang] Update DR status to Revision 110

Endill added a comment. Thank you for prompt review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138835/new/ https://reviews.llvm.org/D138835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478300. Endill added a comment. Incorporate D138835 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/www/cxx_dr_status.html clang/www/make_cxx_dr_status I

[PATCH] D138822: [clang] Add test for CWG36

Endill added a comment. Sorry, I messed up diff update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D138509: clang/HIP: Add another math header test

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138509/new/ https://reviews.llvm.org/D138509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478303. Endill added a comment. Incorporate D138835 (correctly this time around) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp c

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138252/new/ https://reviews.llvm.org/D138252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 699ae92 - [Index] Add various missing USR generation

Author: Ben Barham Date: 2022-11-28T11:51:08-08:00 New Revision: 699ae92f045331b555394b8b9757d7e0fbf97100 URL: https://github.com/llvm/llvm-project/commit/699ae92f045331b555394b8b9757d7e0fbf97100 DIFF: https://github.com/llvm/llvm-project/commit/699ae92f045331b555394b8b9757d7e0fbf97100.diff LO

[PATCH] D138322: [Index] Add various missing USR generation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG699ae92f0453: [Index] Add various missing USR generation (authored by bnbarham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

rjmccall added a comment. In D126818#3954139 , @erichkeane wrote: > In D126818#3954137 , @rjmccall > wrote: > >> To be clear, my opinion is just that the requested change is implementable, >> as I understand it

[PATCH] D138838: Update wrong Unicode code point in confusable-identifiers.rst

aaron.ballman added a comment. LGTM! Would you like me to commit on your behalf? If so, what name and email address would you like used for attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138838/new/ https://reviews.llvm.org/D138838 _

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478312. v.g.vassilev marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h clang/inclu

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. I think I have addressed all comments from @aaron.ballman and @rsmith. Comment at: clang/include/clang/Lex/Preprocessor.h:1782-1785 void enableIncrementalProcessing(bool value = true) { -IncrementalProcessing = value; +// FIXME: Drop thi

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478316. v.g.vassilev added a comment. rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h clang/include/clang

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implement the C++23 paper P2647R1 (adopted in Kona) Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

erichkeane added a comment. Can you add some tests that do meaningful things with the static variable? Particularly during constexpr evaluation time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138851/new/ https://reviews.llvm.org/D138851

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

cor3ntin updated this revision to Diff 478321. cor3ntin added a comment. Add an evaluation test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138851/new/ https://reviews.llvm.org/D138851 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprCo

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

akhuang updated this revision to Diff 478324. akhuang marked 3 inline comments as done. akhuang added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137872/new/ https://reviews.llvm.org/D137872 Files: clang/include/cla

[PATCH] D138852: CWG2635: Disallow constrained structured bindings.

erichkeane created this revision. erichkeane added reviewers: clang-language-wg, aaron.ballman. Herald added a project: All. erichkeane requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CWG2635 prohibits adding a constraint to a structured

[PATCH] D138852: CWG2635: Disallow constrained structured bindings.

erichkeane added a comment. I would normally not really need a review here, but I did some stuff with the fixit that I'm not sure about/not sure how to test, so I was hoping someone could take a second look CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138852/new/ https://reviews.llvm

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a comment. Adding Hubert for his C++ conformance opinion. Comment at: clang/test/CXX/drs/dr0xx.cpp:454 + +namespace dr36 { // dr36: yes +namespace example1 { It took me a while to convi

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 478328. cor3ntin added a comment. Update DR status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Exp

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

alanphipps added a comment. Thank you for the comments thus-far. I have split this patch into three stacked patches and updated them according to comments found on this review: Clang Front-end: https://reviews.llvm.org/D138849 LLVM back-end/compiler-rt: https://reviews.llvm.org/D138846 llvm-cov

[PATCH] D138838: Update wrong Unicode code point in confusable-identifiers.rst

rferrandop added a comment. In D138838#3954497 , @aaron.ballman wrote: > LGTM! Would you like me to commit on your behalf? If so, what name and email > address would you like used for attribution? Thank you Aaron. I do not have commit permissions. I wi

[PATCH] D138852: CWG2635: Disallow constrained structured bindings.

aaron.ballman added a comment. The changes look correct to me. The way to test the fix-it behavior is to model after one of the tests in https://github.com/llvm/llvm-project/tree/main/clang/test/FixIt (there is `-fdiagnostics-parseable-fixits` and friends for this purpose).

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, wenlei, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added sub

[clang-tools-extra] b24d89a - Update wrong Unicode code point in confusable-identifiers.rst

Author: Raul Ferrando Date: 2022-11-28T15:32:40-05:00 New Revision: b24d89a0428c6f5d0367ece123e566d773c4bcbb URL: https://github.com/llvm/llvm-project/commit/b24d89a0428c6f5d0367ece123e566d773c4bcbb DIFF: https://github.com/llvm/llvm-project/commit/b24d89a0428c6f5d0367ece123e566d773c4bcbb.diff

[PATCH] D138838: Update wrong Unicode code point in confusable-identifiers.rst

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb24d89a0428c: Update wrong Unicode code point in confusable-identifiers.rst (authored by rferrandop, committed by aaron.ba

[PATCH] D138838: Update wrong Unicode code point in confusable-identifiers.rst

aaron.ballman added a comment. In D138838#3954706 , @rferrandop wrote: > In D138838#3954497 , @aaron.ballman > wrote: > >> LGTM! Would you like me to commit on your behalf? If so, what name and email >> address

[PATCH] D138855: [clang][Fuchsia] Allow for setting the default build type

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. Prior to this, `CMAKE_BUILD_TYPE` would unconditionally be `Release`. This

[clang] 5607fc0 - [Clang] Permit static constexpr variables in constexpr functions

Author: Corentin Jabot Date: 2022-11-28T21:38:31+01:00 New Revision: 5607fc002dd43514a605ba1e83735e74340ec95d URL: https://github.com/llvm/llvm-project/commit/5607fc002dd43514a605ba1e83735e74340ec95d DIFF: https://github.com/llvm/llvm-project/commit/5607fc002dd43514a605ba1e83735e74340ec95d.diff

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5607fc002dd4: [Clang] Permit static constexpr variables in constexpr functions (authored by cor3ntin). Changed prior to commit: https://reviews.ll

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

mtrofin updated this revision to Diff 478339. mtrofin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixed the other 2 scripts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.llvm.o

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. Thanks! There's also the one for MCA, but this situation basically never happens for those tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.llvm.org/D138836 _

[PATCH] D138318: [-Wunsafe-buffer-usage] Improve pointer match pattern

ziqingluo-90 updated this revision to Diff 478341. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138318/new/ https://reviews.llvm.org/D138318 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp Index: clang/test/SemaCXX/warn-unsafe-buffer-

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

mtrofin updated this revision to Diff 478343. mtrofin added a comment. Herald added a subscriber: pcwang-thead. missed one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.llvm.org/D138836 Files: clang/test/utils/update

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

mtrofin added a comment. In D138836#3954782 , @lebedev.ri wrote: > Thanks! > There's also the one for MCA, but this situation basically never happens for > those tests. Yup, checked that and the mir one. The latter seems to be implementing its own "ad

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri added a comment. In D138836#3954850 , @mtrofin wrote: > In D138836#3954782 , @lebedev.ri > wrote: > >> Thanks! >> There's also the one for MCA, but this situation basically never happens for >> those

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138252/new/ https://reviews.llvm.org/D138252 __

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 478348. Febbe added a comment. Applied clang-format `QualifierAlignment: Left` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/per

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added a comment. > One test case I'd like to see is: `sizeof(p[0])` -- should code in an > unevaluated context be warned? I think they should NOT be warned. We haven't addressed the issue of unevaluated context in our patches. I'm adding a test for code in unevaluated context so

[PATCH] D138505: [clangd] Don't run slow clang-tidy checks by default

kadircet added a comment. thanks LG, i'd like to hear how we're planning to let downstream users customise the list of fast checks. otherwise they have to run with `Loose` at all times. the easiest i can think of is, generating their own `fastchecks.inc` fragment and #include that in addition t

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

mtrofin added a comment. In D138836#3954851 , @lebedev.ri wrote: > In D138836#3954850 , @mtrofin wrote: > >> In D138836#3954782 , @lebedev.ri >> wrote: >> >>> Thanks! >>

[PATCH] D138713: Fix assertion failure "PathDiagnosticSpotPiece's must have a valid location." in ReturnPtrRange checker on builtin functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM, thanks! This patch seems obvious but please upload with context next time (https://llvm.org/docs/Phabricator.html#phabricator-request-review-web). Comment at: clang/lib/Sta

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. This revision now requires changes to proceed. This looks good to me. I can commit that change for you as I know you do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138698/new/ https

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Sorry, selected the wrong option. This looks good to me. I can commit that change for you as I know you do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:10-13 +void foo(...); + +void * bar(void); +char * baz(void); steakhal wrote: > I would expect this test file to grow quite a bit. > As such, I think we should have mo

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

vsapsai created this revision. vsapsai added reviewers: aaron.ballman, ChuanqiXu, erichkeane. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In this change deliberat

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Anyways, assuming you tested that this works, LG. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138836/new/ https://reviews.l

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

erichkeane added a comment. I dont have a concern on this in general, but does it cause problems with modules built? I would think this flag needs to be written in ASTWriter/picked back up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138859/new

[PATCH] D138852: CWG2635: Disallow constrained structured bindings.

erichkeane updated this revision to Diff 478351. erichkeane marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138852/new/ https://reviews.llvm.org/D138852 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

vsapsai added a comment. This patch builds on top of D135472 and aims to show that hashing attributes with TableGen works fine and doesn't have unexpected problems. As the next step I plan to hash more attributes. Though there is one question regarding argume

[PATCH] D138532: [SPARC][clang] Enable frame pointer optimization by default

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. I still find it strange that by default clang explicitly disables an optimization that's the default for unattributed functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

vsapsai added a comment. In D138859#3954943 , @erichkeane wrote: > I dont have a concern on this in general, but does it cause problems with > modules built? I would think this flag needs to be written in > ASTWriter/picked back up. For an attribute

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

NoQ added a comment. In D138329#3938351 , @xazax.hun wrote: > Is the problem `forEachDescendant` matching statements inside blocks and > lambdas? I wonder if this behavior would surprise people, so I think it would > be better to: > > - Potentially add

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

erichkeane added a comment. The hash there isn't the problem, its that you're adding a field to Attr.td that isn't serialized in ASTWriter/ASTReader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138859/new/ https://reviews.llvm.org/D138859 _

[clang] 255e7e1 - [UpdateTestChecks] Fix `update_*_test_checks.py` to add "unused" prefixes

Author: Mircea Trofin Date: 2022-11-28T13:24:32-08:00 New Revision: 255e7e1c21eeb57b26585836a2e2d5a7f39e3cf3 URL: https://github.com/llvm/llvm-project/commit/255e7e1c21eeb57b26585836a2e2d5a7f39e3cf3 DIFF: https://github.com/llvm/llvm-project/commit/255e7e1c21eeb57b26585836a2e2d5a7f39e3cf3.diff

[PATCH] D138836: [UpdateTestChecks] Fix `update_test_checks.py` to add "unused" prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG255e7e1c21ee: [UpdateTestChecks] Fix `update_*_test_checks.py` to add "unused" prefixes (authored by mtrofin). Repository: rG LLVM Github Monorep

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 updated this revision to Diff 478356. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137379/new/ https://reviews.llvm.org/D137379 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-u

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:168-169 + static Matcher matcher() { +// FIXME: What if the index is integer literal 0? Should this be +// a safe gadget in this case? +return stmt( aaron.ballman wrote:

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138861 Files: clang/lib/Lex/Lexer.cpp clang/lib/Lex/

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:90 + /// returns an empty list if no fixes are necessary. + virtual Optional getFixits(const Strategy &) const { +return None; steakhal wrote: > steakhal wrote: > > I wonder if

[clang] eac90d1 - [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

Author: Volodymyr Sapsai Date: 2022-11-28T13:48:29-08:00 New Revision: eac90d1236cfd2935fac5cbe5634f09e2cd0981a URL: https://github.com/llvm/llvm-project/commit/eac90d1236cfd2935fac5cbe5634f09e2cd0981a DIFF: https://github.com/llvm/llvm-project/commit/eac90d1236cfd2935fac5cbe5634f09e2cd0981a.di

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeac90d1236cf: [clang][deps] During scanning don't emit warnings-as-errors that are ignored… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138252/new/ https://reviews.llvm.org/D138252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478362. cor3ntin added a comment. Update DR web page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/lib/Lex/Lexer.cpp clang/lib/Lex/LiteralSupport.

[PATCH] D138862: [Clang] Do not set offload kind in a freestanding build

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a p

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

erichkeane added a comment. I dont know the lexer well enough to do better than this review, but the code itself seems fine. Comment at: clang/www/cxx_dr_status.html:15651 Allow more characters in an n-char sequence -Unknown +Yes Shouldn't thi

<    1   2   3   >