fmayer accepted this revision. fmayer added inline comments.
================ Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622 + assert(MemtagRelocs != nullptr && + "Tagged globals are only supported on AArch64"); + Asm.registerSection(*MemtagRelocs); ---------------- fmayer wrote: > Is the story here that on non-AArch64, this function gets run, but there will > be no SymE.isMemtag()? optional: the assert message does not really convey that. Maybe something like "Unexpectedly found tagged global" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128958/new/ https://reviews.llvm.org/D128958 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
