[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. As discussed with Shafik and Aaron, I'm landing that now so there is some buffer to handle unforeseen issues as i won't be available next week and the one after. Further comments are of course welcomed. If we don't find any issues we can land https://reviews.llvm.org/D

[clang] 722a0ef - Revert "Implement CWG2631"

Author: Corentin Jabot Date: 2022-11-04T08:24:52+01:00 New Revision: 722a0efe31e16e6a98dc3742cf6101d930ba3479 URL: https://github.com/llvm/llvm-project/commit/722a0efe31e16e6a98dc3742cf6101d930ba3479 DIFF: https://github.com/llvm/llvm-project/commit/722a0efe31e16e6a98dc3742cf6101d930ba3479.diff

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. The bots are unhappy, I'll investigate later https://lab.llvm.org/buildbot/#/builders/139/builds/30564 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 __

[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + // create a Function instance but not compile the body. That + // will (maybe) happen later. if (!Fu

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

This revision was automatically updated to reflect the committed changes. Pierre-vh marked 3 inline comments as done. Closed by commit rGc05f1639f7f4: [clang][cuda/hip] Allow `__noinline__` lambdas (authored by Pierre-vh). Changed prior to commit: https://reviews.llvm.org/D137251?vs=472875&id=

[clang] c05f163 - [clang][cuda/hip] Allow `__noinline__` lambdas

Author: Pierre van Houtryve Date: 2022-11-04T07:33:31Z New Revision: c05f1639f7f4a8e81ad83bba99bae95553c6064e URL: https://github.com/llvm/llvm-project/commit/c05f1639f7f4a8e81ad83bba99bae95553c6064e DIFF: https://github.com/llvm/llvm-project/commit/c05f1639f7f4a8e81ad83bba99bae95553c6064e.diff

[clang] e787708 - [clang-format][NFC] Remove parsePPElIf()

Author: Owen Pan Date: 2022-11-04T00:38:40-07:00 New Revision: e787708bcf53e8849481f2d0267f7e8b5dbf6c8d URL: https://github.com/llvm/llvm-project/commit/e787708bcf53e8849481f2d0267f7e8b5dbf6c8d DIFF: https://github.com/llvm/llvm-project/commit/e787708bcf53e8849481f2d0267f7e8b5dbf6c8d.diff LOG:

[PATCH] D137308: [clang-format][NFC] Remove parsePPElIf()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe787708bcf53: [clang-format][NFC] Remove parsePPElIf() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136090: Handle errors in expansion of response files

uabelho added a comment. In D136090#3905845 , @sepavloff wrote: > Thank you for reporting the issue. It was fixed in fdab9f1203ee > . Thanks! Repository: rG LLVM Github Monorepo C

[PATCH] D137399: [clang][Interp] Emit negated integers directly as constants

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

nridge added a comment. Thanks for the patch! The test looks good to me. As for the fix, I wonder if it would make sense to implement it in the Sema layer rather than in clangd. For example, we could give `clang::CodeCompletionResult` a new flag

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 473156. carlosgalvezp added a comment. Move to misc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 473159. carlosgalvezp retitled this revision from "[clang-tidy] Add modernize-use-anonymous-namespace check" to "[clang-tidy] Add misc-use-anonymous-namespace check". carlosgalvezp added a comment. Update commit message Repository: rG LLVM Github M

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added a comment. Herald added a reviewer: nicolasvasilache. Herald added subscribers: Moerafaat, zero9178. Are you still working on this? Otherwise please close it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://review

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repositor

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

nridge updated this revision to Diff 473161. nridge added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137401/new/ https://reviews.llvm.org/D137401 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

nridge added a comment. Follow-up to D133757 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137401/new/ https://reviews.llvm.org/D137401 ___ cfe-commits mailing list cfe

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. In D133757#3895710 , @nridge wrote: > I will follow up with a patch to rename QueryDriverDatabase.cpp to > SystemIncludeExtractor.cpp. Posted in D137401 Repository: rG LLVM Github Monorepo

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

tomasz-kaminski-sonarsource updated this revision to Diff 473166. tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added a comment. Added assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136671/new/ http

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1244 SVal *ElementCountVal) { + assert(Region != nullptr && "Null-regions passed to prepareStateForArrayDestruction."); ---

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta updated this revision to Diff 473169. thieta added a comment. Expand and move testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta marked 2 inline comments as done. thieta added a comment. I have expanded testing and moved it to the place you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327 __

[PATCH] D135780: [IR] Switch everything to use memory attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG304f1d59ca41: [IR] Switch everything to use memory attribute (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

hokein updated this revision to Diff 473174. hokein marked 7 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137319/new/ https://reviews.llvm.

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:82 + llvm::DenseMap> + IWYUExportBy; kadircet wrote: > kadircet wrote: > > what about a smallvector, instead of a denseset here? > nit: inste

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473177. cor3ntin added a comment. I pushed a tentative fix for the bot failure, alas I'm completely unable to reproduce the issue locally, even though it does not appear to be architecture dependant afaict. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D137252: [include-cleaner] Testing helpers for ast walking

hokein added a comment. Just share my experience when reading the code, overall I have a feeling that we're regressing the code readability of the tests (left some comments on regressing samples): 1. with the sugared macros, the syntax of `TargetCode` and `ReferenceCode` are identical -- both

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Seems that everything has been taken care of. It was accidentally out of my radar (do not know why). I will go through it once again and update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https:

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein updated this revision to Diff 473185. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137320/new/ https://reviews.llvm.org/D137320 Files: clang-tools-extra/in

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:58 +Results = {{FE}}; +// FIXME: compute a closure of exporter headers. +for (const auto *Export : PI.getExporters(FE, SM.getFileManager())) kadircet wrote: >

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders added a comment. In D137040#3907497 , @nridge wrote: > Thanks for the patch! > > The test looks good to me. > > As for the fix, I wonder if it would make sense to implement it in the Sema > layer rather than in clangd. For example, we could gi

[PATCH] D137252: [include-cleaner] Testing helpers for ast walking

kadircet marked an inline comment as done. kadircet added a comment. In D137252#3907665 , @hokein wrote: > Just share my experience when reading the code, overall I have a feeling that > we're regressing the code readability of the tests (left some comme

[PATCH] D136554: Implement CWG2631

royjacobson added a comment. In D136554#3907661 , @cor3ntin wrote: > I pushed a tentative fix for the bot failure, > alas I'm completely unable to reproduce the issue locally, even > though it does not appear to be architecture dependant afaict. It seems

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3907761 , @royjacobson wrote: > In D136554#3907661 , @cor3ntin > wrote: > >> I pushed a tentative fix for the bot failure, >> alas I'm completely unable to reproduce the issu

[clang] c14df22 - [Driver] Do not run test on AIX

Author: Serge Pavlov Date: 2022-11-04T18:32:26+07:00 New Revision: c14df228ff3ca73e3c5c00c495216bba56665fd5 URL: https://github.com/llvm/llvm-project/commit/c14df228ff3ca73e3c5c00c495216bba56665fd5 DIFF: https://github.com/llvm/llvm-project/commit/c14df228ff3ca73e3c5c00c495216bba56665fd5.diff

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. In D137381#3907104 , @MaskRay wrote: > In your example, `clang++ a.cc; ./a.out` gives a libstdc++ error: > > terminate called after throwing an instance of 'int' > > libc++'s is similar. That's great, but just a symptom of m

[PATCH] D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause

animeshk-amd updated this revision to Diff 473193. animeshk-amd added a comment. The main branch dropped the use of flag `-no-opaque-pointers` in this test which generated a different IR than before. This revision gets rid of the conflicts with the main branch caused by above. Repository: rG

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473198. cor3ntin added a comment. Make sure cleanup expressions are correctly added to rewritten initializers (I'm assuming this did not manifest in C++20 mode because of copy elision) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This creates a temporary local variable for the con

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473202. cor3ntin added a comment. Cleaner fix: Only use MaybeCreateExprWithCleanups for member inits. For default arguments, this is already handled in ConvertParamDefaultArgument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:827 +BUILTIN(__nvvm_reflect, "icC*", "nc") + tra wrote: > Do we actually need this patch at all. > > `extern "C" int __nvvm_reflect(const char *);` appears to work just fine

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

stuij added a comment. As for Arm/AAch64, we're still assessing the amount of pain we'd cause with the name change, but we don't have an issue with letting go of storage-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://revie

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 473208. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 473211. carlosgalvezp added a comment. Remove some code duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files: clang-tools-extra/clang-tidy/misc/C

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder updated this revision to Diff 473212. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137415/new/ https://reviews.llvm.org/D137415 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/test/AST/Interp/switch.cpp Index: clang/test/AST/In

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473213. cor3ntin added a comment. clamg-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 473214. carlosgalvezp added a comment. Fix typo in binding names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files: clang-tools-extra/clang-tidy/misc/CMak

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

tianshilei1992 added a comment. nit: this doesn't look like NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3907974 , @stuij wrote: > As for Arm/AAch64, we're still assessing the amount of pain we'd cause with > the name change, but we don't have an issue with letting go of storage-only. Thanks @stuij. Indeed! ABI breaking

[clang] 7acfe36 - Implement CWG2631

Author: Corentin Jabot Date: 2022-11-04T14:46:38+01:00 New Revision: 7acfe3629479c8489fc2d7f629994dc200be990c URL: https://github.com/llvm/llvm-project/commit/7acfe3629479c8489fc2d7f629994dc200be990c DIFF: https://github.com/llvm/llvm-project/commit/7acfe3629479c8489fc2d7f629994dc200be990c.diff

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7acfe3629479: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); beanz wrot

[clang] 5f87a89 - [clang] Fix assert in SemaEXpr.cpp

Author: Corentin Jabot Date: 2022-11-04T15:37:37+01:00 New Revision: 5f87a892a7bed9cb0599573b9aaf387bc1df9c14 URL: https://github.com/llvm/llvm-project/commit/5f87a892a7bed9cb0599573b9aaf387bc1df9c14 DIFF: https://github.com/llvm/llvm-project/commit/5f87a892a7bed9cb0599573b9aaf387bc1df9c14.diff

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder added a comment. Oh, this doesn't work: void test_alignas_operand() { alignas(8) char dummy; static_assert(__alignof(dummy) == 8); } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 ___

[clang] 6875ac6 - [clang] Remove an incorrect assert

Author: Corentin Jabot Date: 2022-11-04T15:46:22+01:00 New Revision: 6875ac69279a3a02fab382a2c8d121558ecbfa91 URL: https://github.com/llvm/llvm-project/commit/6875ac69279a3a02fab382a2c8d121558ecbfa91 DIFF: https://github.com/llvm/llvm-project/commit/6875ac69279a3a02fab382a2c8d121558ecbfa91.diff

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Ping! Does this need any further change? Seems okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits m

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added a comment. I still see some review comments not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list cfe-commits@

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement.

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, previously, if the datafl

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added inline comments. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND FLANG_TEST_DEPENDS Bye) IIUC, `Bye` is only needed when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

jrtc27 added a comment. In D137350#3906126 , @craig.topper wrote: > Do these need their own DecoderNameSpace? I was going to come here to request that CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/CFGMatchSwitch.h:35 +public: + CFGMatchSwitch(std::unique_ptr CurrentElement, + ASTMatchSwitch StmtMS, Why do we need to keep this pointer on the heap? Repo

[PATCH] D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement

ymandel added a comment. Thanks for this patch! Unfortunately, I'm having trouble following the change. Can you expand the description to give a more detailed explantion of the motivation and the key point that are changing? Unfortunately, I don't understand the motivation for the new API an

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson edited subscribers, added: cfe-commits; removed: clang. probinson added a comment. Try again to add the commits list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/ https://reviews.llvm.org/D137437 ___ cfe-commits mailing

[Diffusion] rGfdab9f1203ee: [Clang] Check for response file existence prior to check for recursion

sepavloff added a comment. Fixed in: https://reviews.llvm.org/rGc14df228ff3c. BRANCHES main Users: sepavloff (Author) https://reviews.llvm.org/rGfdab9f1203ee ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] 6ace52e - [Driver][AIX] Change UNSUPPORTED to XFAIL system-aix

Author: Hubert Tong Date: 2022-11-04T12:26:53-04:00 New Revision: 6ace52e5e49cff6664fc301fa4985fc28c88f26f URL: https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f DIFF: https://github.com/llvm/llvm-project/commit/6ace52e5e49cff6664fc301fa4985fc28c88f26f.diff L

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tra added a comment. > The mangling should be aligned with its semantics. It's fine to use u6__bf16 > if a target doesn't want to support arithmetic operations. We (speaking for CUDA/NVPTX) do want to support math on bfloat, just didn't get to implementing it yet. NVPTX will likely start suppor

[PATCH] D136817: [RISCV] Add H extension

kito-cheng marked an inline comment as done. kito-cheng added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 ___ cfe-commits mailing list cf

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 473272. reames added a comment. Add a decoder namespace. I did one per vendor - i.e. used a Ventana table rather than a VentanaCondOps one. In theory, we could have a vendor who ships incompatible extensions (in two different pieces of hardware), but if we

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

hubert.reinterpretcast added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} Perhaps we should normalize on `-aix` while we are doing

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136930/new/ https://reviews.llvm.org/D136930 ___

[PATCH] D136894: Add clang-doc readme

brettw abandoned this revision. brettw added a comment. Ok thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136894/new/ https://reviews.llvm.org/D136894 ___ cfe-commits mailing list cfe-commits@list

[clang-tools-extra] a7fa5fe - [Test] Fix CHECK typo.

Author: Zequan Wu Date: 2022-11-04T10:18:04-07:00 New Revision: a7fa5febaa43d860cbd6a4061f239b283c4d8032 URL: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032 DIFF: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032.diff LOG

[clang] a7fa5fe - [Test] Fix CHECK typo.

Author: Zequan Wu Date: 2022-11-04T10:18:04-07:00 New Revision: a7fa5febaa43d860cbd6a4061f239b283c4d8032 URL: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032 DIFF: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032.diff LOG

[PATCH] D137287: [Test] Fix CHECK typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fa5febaa43: [Test] Fix CHECK typo. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/new/ https://reviews.llvm.org/D137287 File

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 473285. reames added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.cpp

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:827 +BUILTIN(__nvvm_reflect, "icC*", "nc") + hdelan wrote: > tra wrote: > > Do we actually need this patch at all. > > > > `extern "C" int __nvvm_reflect(const char *);` appears

[clang] 36b37a1 - [flang] Add -f[no-]approx-func

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: 36b37a1ed561404a32a4b4b6e2bd92d915894a7c URL: https://github.com/llvm/llvm-project/commit/36b37a1ed561404a32a4b4b6e2bd92d915894a7c DIFF: https://github.com/llvm/llvm-project/commit/36b37a1ed561404a32a4b4b6e2bd92d915894a7c.diff LOG: [f

[PATCH] D137325: [flang] Add -f[no-]honor-nans and -menable-no-nans

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e93e390c06: [flang] Add -f[no-]honor-nans and -menable-no-nans (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] b5e93e3 - [flang] Add -f[no-]honor-nans and -menable-no-nans

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: b5e93e390c06602cb03121ad875e2855253e2937 URL: https://github.com/llvm/llvm-project/commit/b5e93e390c06602cb03121ad875e2855253e2937 DIFF: https://github.com/llvm/llvm-project/commit/b5e93e390c06602cb03121ad875e2855253e2937.diff LOG: [f

[clang] b5b8a8c - [flang] Add -f[no-]signed-zeros

Author: Tom Eccles Date: 2022-11-04T17:22:34Z New Revision: b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273 URL: https://github.com/llvm/llvm-project/commit/b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273 DIFF: https://github.com/llvm/llvm-project/commit/b5b8a8cfbe1ee3c2d3684dd62e7f0ddeeeb73273.diff LOG: [f

[PATCH] D137326: [flang] Add -f[no-]approx-func

This revision was automatically updated to reflect the committed changes. Closed by commit rG36b37a1ed561: [flang] Add -f[no-]approx-func (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] c4dc3c0 - [flang] Add -f[no-]associative-math and -mreassociate

Author: Tom Eccles Date: 2022-11-04T17:22:35Z New Revision: c4dc3c029416a25103d631e8dc5422f65c076376 URL: https://github.com/llvm/llvm-project/commit/c4dc3c029416a25103d631e8dc5422f65c076376 DIFF: https://github.com/llvm/llvm-project/commit/c4dc3c029416a25103d631e8dc5422f65c076376.diff LOG: [f

[clang] d0d4b63 - [flang] add -f[no-]reciprocal-math

Author: Tom Eccles Date: 2022-11-04T17:22:35Z New Revision: d0d4b635786d510cd919cadbeb7e5e19983242cf URL: https://github.com/llvm/llvm-project/commit/d0d4b635786d510cd919cadbeb7e5e19983242cf DIFF: https://github.com/llvm/llvm-project/commit/d0d4b635786d510cd919cadbeb7e5e19983242cf.diff LOG: [f

[PATCH] D137328: [flang] Add -f[no-]signed-zeros

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b8a8cfbe1e: [flang] Add -f[no-]signed-zeros (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D137330: [flang] add -f[no-]reciprocal-math

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d4b635786d: [flang] add -f[no-]reciprocal-math (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137329: [flang] Add -f[no-]associative-math and -mreassociate

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4dc3c029416: [flang] Add -f[no-]associative-math and -mreassociate (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); aaron.ball

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} hubert.reinterpretcast wrote: > Perhaps we should normalize on `-aix`

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added a comment. Generally looking good to me aside from a test change that I don't quite understand yet. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(),

[PATCH] D137240: [clang][Interp] Support alignof()

aaron.ballman added a comment. In D137240#3908229 , @tbaeder wrote: > Oh, this doesn't work: > > void test_alignas_operand() { > alignas(8) char dummy; > static_assert(__alignof(dummy) == 8); > } That's interesting! Based on the code, I would

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); + return fal

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + // create a Function instance but not compile the body. That + // will (maybe) happen later. i

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp", "Sim

[PATCH] D136828: [clang][Interp] Diagnose uninitialized array record fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the request for a comment about `SourceLocation SL`, this LGTM (though we may want to improve the diagnostic behavior in the future). Comment at: cl

[PATCH] D135721: [HLSL] Added HLSL this as a reference

beanz added inline comments. Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:49-50 // CHECK-NEXT: ArraySubscriptExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type' lvalue -// CHECK-NEXT: MemberExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type *' lvalue ->h 0x{{[0-9A-Fa-f]+}} -// CHECK-NEXT: CX

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 473304. gracejennings added a comment. - Add assignment overload codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files: clang/lib/AST/ExprClassif

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. In D136664#3884796 , @phosek wrote: > In D136664#3882989 , @smeenai wrote: > >> I might be missing it, but

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen updated this revision to Diff 473306. samitolvanen added a comment. Added release notes, grouped together with `-Wcast-function-type-strict`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136790/new/ https://reviews.llvm.org/D136790 F

  1   2   >