[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 added a comment. In D136041#3862741 , @aprantl wrote: > ... Do you have any idea how much this will grow the debug info for something > like, e.g., clang? I made the measurements but I'm not sure what to make of these numbers (e.g. is it good o

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In D134337#3864288 , @mgorny wrote: > In D134337#3863744 , @tstellar > wrote: > >> In what scenarios will clang load the clang.cfg file? > > It will load it if all of the following are t

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 __

[PATCH] D135657: add time traces for AST serialization

Trass3r added a comment. Thanks, could you also commit it? I don't have the rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135657/new/ https://reviews.llvm.org/D135657 ___ cfe-commits mailing list

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

probinson added inline comments. Comment at: llvm/lib/IR/Verifier.cpp:3470 + // (Interposable functions are not inlinable as are functions w/o + // declarations). if (Call.getFunction()->getSubprogram() && Call.getCalledFunction() && (Interposable functions

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:59 explicit operator bool() const { return V; } + explicit operator double() const { return V; } Is there any reason why `operator double` exists, but `operator float` does not? =

[clang-tools-extra] 6fa0e02 - [include-cleaner] Add include-cleaner tool, with initial HTML report

Author: Sam McCall Date: 2022-10-18T18:09:41+02:00 New Revision: 6fa0e026c87e20b962137691a7852fb5e32f9611 URL: https://github.com/llvm/llvm-project/commit/6fa0e026c87e20b962137691a7852fb5e32f9611 DIFF: https://github.com/llvm/llvm-project/commit/6fa0e026c87e20b962137691a7852fb5e32f9611.diff LO

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG6fa0e026c87e: [include-cleaner] Add include-cleaner tool, with initial HTML report (authored by sammccall

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r marked 5 inline comments as done. Trass3r added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7787-7788 +/// void f() {} +/// void g(); +/// }; +/// \endcode aaron.ballman wrote: > I think it'd be interesting to show

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

steakhal marked 5 inline comments as done. steakhal added a comment. Thanks for the review @martong! I'll land this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135136/new/ https://reviews.llvm.org/D135136 __

[PATCH] D134947: [analyzer] Fix the liveness of Symbols for values in regions referred by LazyCompoundVal

steakhal added a comment. It seems like we are all aligned. I'll land this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134947/new/ https://reviews.llvm.org/D134947 ___ cfe-commits mailing lis

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 468595. Prabhuk added a comment. Introducing UEFIX86_64TargetInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic/Targets.cpp clang/lib/Ba

[clang] 4a687ef - [clang testing] Unbreak read-only source builds

Author: David Zarzycki Date: 2022-10-18T12:47:12-04:00 New Revision: 4a687efecb825f8c1c3e10ffc7949f4b2cd3c1bd URL: https://github.com/llvm/llvm-project/commit/4a687efecb825f8c1c3e10ffc7949f4b2cd3c1bd DIFF: https://github.com/llvm/llvm-project/commit/4a687efecb825f8c1c3e10ffc7949f4b2cd3c1bd.diff

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 468600. Prabhuk added a comment. Add __UEFI__ macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131594/new/ https://reviews.llvm.org/D131594 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OS

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 468602. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added a comment. In D134337#3865541 , @tstellar wrote: > I know I'm a little late here, but having a default config file that's always > loaded makes triaging issues much harder, because now every time someone > files a bug, we need to ask for th

[PATCH] D135513: [clang][Interp] Check instance pointers before calling functions on them

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Function.cpp:39 + assert(It != SrcMap.end()); + It--; // We want the offset *before* the given one. return It->second; tbaeder wrote: > While I think the comment here is correct, the decre

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

aaron.ballman added a comment. In D136036#3863519 , @Izaron wrote: >> It looks like unrelated formatting changes snuck in to this file. > > @aaron.ballman JFYI after I reverted what `git clang-format HEAD~1` did to > the code, the build has failed > >

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait for @shafik before landing, in case he has more feedback or questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136160/new/ https://reviews.llvm.org/D136160 _

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 updated this revision to Diff 468611. eddyz87 added a comment. Comment fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136041/new/ https://reviews.llvm.org/D136041 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 468617. python3kgae added a comment. Switch back to short and disable integer promote for hlsl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/lib

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3864612 , @mizvekov wrote: > Is the pre-commit CI failure here related to the patch? Seems not. It should've been fixed by 606245ad542491400a5475c796df86a99f5c8c12

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae added a comment. In D133668#3847999 , @rjmccall wrote: > If you have `char`, would you want it to promote? Because turning `char` to > `_BitInt(8)` is breaking with C on other grounds (like aliasing), for better > or worse. So if you just

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: shchenz, lkail. qiongsiwu1 added projects: clang, debug-info. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. On AIX, the default tuning option is `dbx` so it is

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In D134337#3865753 , @mgorny wrote: > In D134337#3865541 , @tstellar > wrote: > >> I know I'm a little late here, but having a default config file that's >> always loaded makes triaging

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang created this revision. akhuang added a reviewer: rnk. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update docs to reflect the fact that this flag is on by default now. Repository: rG LLVM

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:3 -namespace dr2565 { // dr252: 16 +namespace dr2565 { // dr2565: partial template erichkeane wrote: > If you could add a comment explaining this status for me, I would be grateful: > >

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

thesamesam added a comment. In D134337#3865905 , @tstellar wrote: > In D134337#3865753 , @mgorny wrote: > >> In D134337#3865541 , @tstellar >> wrote: >> >>> I know I'm a

[PATCH] D136190: [clang][Sema] remove redundant isTypeValid

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These isTypeValid calls are redundant because the isDerivedFrom call performs the same checks.

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

qiongsiwu1 updated this revision to Diff 468626. qiongsiwu1 added a comment. Adding one more test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136187/new/ https://reviews.llvm.org/D136187 Files: clang/lib/Driver/ToolChains/AIX.h clang/l

[PATCH] D136022: [clang] Add time profile for constant evaluation

aaron.ballman added a comment. Thank you for working on this, having more detailed timing information for where we're spending time in the frontend will really help us to evaluate where we need to work on frontend performance. Comment at: clang/lib/AST/ExprConstant.cpp:15257

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 __

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan accepted this revision. owenpan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > anderslanglands wro

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen updated this revision to Diff 468630. ychen added a comment. - update Release notes - remove obsolete CodeGen tests which was used to test ClangABICompat checks, similar Sema tests are already in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468631. ychen added a comment. - DR2565 is fully implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp clang/test/CXX/dr

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. SGTM with teh changes discussed above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 __

[clang] 6bca52b - [Clang] update cxx_dr_status.html by running make_cxx_dr_status

Author: Yuanfang Chen Date: 2022-10-18T11:45:40-07:00 New Revision: 6bca52be03491e796e82dd51133f29e2b7bda148 URL: https://github.com/llvm/llvm-project/commit/6bca52be03491e796e82dd51133f29e2b7bda148 DIFF: https://github.com/llvm/llvm-project/commit/6bca52be03491e796e82dd51133f29e2b7bda148.diff

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bca52be0349: [Clang] update cxx_dr_status.html by running make_cxx_dr_status (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. @mizvekov Thanks for the review and provided valuable feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing l

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG340eac01f7da: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained… (authored by ychen). Repository: rG LLVM Github Monorepo

[clang] 340eac0 - [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

Author: Yuanfang Chen Date: 2022-10-18T11:58:57-07:00 New Revision: 340eac01f7dad6c24cee35dd35f2484098dd6b1a URL: https://github.com/llvm/llvm-project/commit/340eac01f7dad6c24cee35dd35f2484098dd6b1a DIFF: https://github.com/llvm/llvm-project/commit/340eac01f7dad6c24cee35dd35f2484098dd6b1a.diff

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. In D129755#3865342 , @rupprecht wrote: > I'm seeing a fair number of breakages from this patch (not really sure how > many we truly have, I've hit ~5-10 so far in widely used libraries, but I > suspect we have far more in t

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie added a comment. (not sure whether to discuss this here or on the bug) Should we remove the documentation? Part of the principles of "cc1" flags is that their implementation details, not to be publicly used and maybe not to be publicly documented either? Repository: rG LLVM Github

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added a comment. In D134337#3865905 , @tstellar wrote: > In D134337#3865753 , @mgorny wrote: > >> In D134337#3865541 , @tstellar >> wrote: >> >>> I know I'm a litt

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > dblaikie wrote: > >

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2

[PATCH] D135192: Fix incorrect check for running out of source locations.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good (guess this is pretty impractical to have a regression test/would require very large files to test?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski added a comment. > The omission of the fast-honor-pragmas argument from the compiler driver is > deliberate. Where is it omitted? > I suspect the CI failure on windows is unrelated to my code I agree. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:165 + // Fl

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ABataev, JonChesterfield, tianshilei1992, ronlieb. Herald added subscribers: kosarev, mattd, asavonic, guansong, yaxunl, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but all of this code should move into the IR Builder... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136198/new/ https://reviews.llvm

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

benlangmuir added a subscriber: bnbarham. benlangmuir added a comment. I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line. @bnbarham any concern about overlay vs chaining behaviour here? I remember you looking at that a while

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. In D136188#3866266 , @dblaikie wrote: > (not sure whether to discuss this here or on the bug) > > Should we remove the documentation? Part of the principles of "cc1" flags is > that their implementation details, not to be publicl

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468677. akhuang edited the summary of this revision. akhuang added a comment. Remove documentation paragraph. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files:

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang added a comment. Actually, maybe I should add some of this info to the -fstandalone-debug section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 ___

[clang] 4481057 - [clang] Move variable declaration closer to use

Author: Nico Weber Date: 2022-10-18T16:40:46-04:00 New Revision: 4481057d4cbe60878d16b26085d8ab90ec5f7a43 URL: https://github.com/llvm/llvm-project/commit/4481057d4cbe60878d16b26085d8ab90ec5f7a43 DIFF: https://github.com/llvm/llvm-project/commit/4481057d4cbe60878d16b26085d8ab90ec5f7a43.diff LO

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov added a comment. In D135192#3866294 , @dblaikie wrote: > Sounds good (guess this is pretty impractical to have a regression test/would > require very large files to test?) Yea, overflowing this requires a very convoluted setup; I don't think

[PATCH] D135192: Fix incorrect check for running out of source locations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b773dcd2de0: Fix incorrect check for running out of source locations. (authored by ppluzhnikov, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 5b773dc - Fix incorrect check for running out of source locations.

Author: Paul Pluzhnikov Date: 2022-10-18T20:48:00Z New Revision: 5b773dcd2de0c4844814266a90dac14c349b8f18 URL: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18 DIFF: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18.diff LO

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote: >

[PATCH] D136154: Fix the continuation indenter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:812-814 +if (Style.BreakBeforeBinaryOperators == FormatStyle::BOS_None || ++ Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) CurrentState.LastSpace

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie added a comment. In D136188#3866385 , @akhuang wrote: > Actually, maybe I should add some of this info to the -fstandalone-debug > section. Ah, sure, if you like. At some point I think I/someone should write a full ramble about DWARF type hom

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie added a subscriber: probinson. dblaikie added a comment. (Speaking of which, might be worth pushing on the changes to remove the flags/support for opting out of ctor homing... I know @probinson had some concerns - but I really don't want to end up holding onto the tech debt of these va

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added inline comments. Comment at: clang/test/SemaCXX/array-bounds.cpp:240 -((char*)foo)[sizeof(foo)] = '\0'; // expected-warning {{array index 32768 is past the end of the array (which contains 32768 elements)}} +((char*)foo)[sizeof(foo)] = '\0'; // expected-wa

[PATCH] D136188: Update docs for -fuse-ctor-homing

akhuang updated this revision to Diff 468687. akhuang added a comment. Move ctor homing info to fstandalone-debug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136188/new/ https://reviews.llvm.org/D136188 Files: clang/docs/UsersManual.rst Ind

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein updated this revision to Diff 468688. hokein marked 4 inline comments as done. hokein added a comment. - rebase - address comments - implement shouldKeep - add unittests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://revie

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Hooks.h:38 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: sammccall wrote: > sammccall wrote: > >

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote

[PATCH] D136188: Update docs for -fuse-ctor-homing

probinson added a subscriber: jmorse. probinson added a comment. +jmorse who is closer to this topic than I am. We've had a few complaints from licensees about ctor homing, and debug-info size in general is something of a sensitive topic. But if we can come to a place where `-fstandalone-debug

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > royjacobson wrote

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1746 + if (auto TyPtr = Ty.getTypePtrOrNull()) { +if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) || vitalybuka wrote: > Taking into account potantial risks from pre-existing UB

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

bnbarham added a comment. In D135634#3866353 , @benlangmuir wrote: > I think we should deduplicate the vfs overlays if the same ivfsoverlay is > specified in both the pcm and the command-line. > > @bnbarham any concern about overlay vs chaining behaviou

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468700. python3kgae added a comment. Check sret parameter exist. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clan

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 468695. jz10 added a comment. Thanks Johannes for your comments, and I relied them below 1. format issues I ran clang-format to reformat, please check if there's any missed things; 2. replace '0' with 'nullptr' fixed 3. proper return value for helper functio

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan updated this revision to Diff 468701. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/C

[clang] 8c1449a - [OpenMP] Make kernels have protected visibility

Author: Joseph Huber Date: 2022-10-18T16:37:28-05:00 New Revision: 8c1449a84d61f6caa4b6e63f262b2c8976949548 URL: https://github.com/llvm/llvm-project/commit/8c1449a84d61f6caa4b6e63f262b2c8976949548 DIFF: https://github.com/llvm/llvm-project/commit/8c1449a84d61f6caa4b6e63f262b2c8976949548.diff

[PATCH] D136198: [OpenMP] Make kernels have protected visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c1449a84d61: [OpenMP] Make kernels have protected visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136198/new/ https://revie

[clang] 037669d - [clang-format] Do not parse certain characters in pragma directives

Author: Joseph Huber Date: 2022-10-18T16:38:19-05:00 New Revision: 037669de8bdff42fc17b72460bf8784403c8d055 URL: https://github.com/llvm/llvm-project/commit/037669de8bdff42fc17b72460bf8784403c8d055 DIFF: https://github.com/llvm/llvm-project/commit/037669de8bdff42fc17b72460bf8784403c8d055.diff

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG037669de8bdf: [clang-format] Do not parse certain characters in pragma directives (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 468706. python3kgae added a comment. More check on the ir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

beanz accepted this revision. beanz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

MaskRay added a comment. > Speedup: Linux kernel: getFileIDLocal overhead is reduced to 1.66% (~30% > saving) What's the fraction related to the whole parsing time? > The sad bit is thatit increases SourceManager memory usage, however it is a > small fraction (< 10%) of clang AST memory usage,

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 created this revision. ZhiyaoMa98 added reviewers: labrinea, rengolin. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. ZhiyaoMa98 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, LLVM. Promo

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

rjmccall added a comment. Okay, this seems fine to me. I think you accidentally removed the word "promotion" from the patch title, though. I assume HLSL also provides `uint16_t`, and you should test the behavior for it. You should also test this for whatever 8-bit types HLSL provides (`char`,

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added inline comments. Comment at: llvm/test/CodeGen/Thumb2/thumb2-execute-only-long-calls.ll:19 +; STATIC-NEXT: movt[[REG0]], :upper16:.LCP1_0 +; STATIC-NEXT: ldr [[REG1:r[0-9]+]], [[[REG0]]] +; STATIC-NEXT: blx [[REG1]] Is there some rea

[libunwind] 09dcb93 - [CMake] Fix LIBUNWIND_ENABLE_CET build after D110005

Author: jinge90 Date: 2022-10-18T15:00:09-07:00 New Revision: 09dcb933eff331749842d86b439e1a4fed76cb20 URL: https://github.com/llvm/llvm-project/commit/09dcb933eff331749842d86b439e1a4fed76cb20 DIFF: https://github.com/llvm/llvm-project/commit/09dcb933eff331749842d86b439e1a4fed76cb20.diff LOG:

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. > 6. Why do you access args_ for some parts and not for others? That said, > where does the hidden helper need access to the dependences anyway? > > there's type cast for depend objects from 'omp_depend_t' to > 'kmp_depend_info_t*', and the array of casted depend obj

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a comment. I'm not sure if it copies, will check it to confirm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

phosek added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:812-828 +case CC_X86StdCall: +case CC_X86ThisCall: +case CC_X86FastCall: + return CCCR_Ignore; +case CC_C: +case CC_X86VectorCall: +case CC_IntelOclBicc: Accordin

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote: >

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. @efriedma Thank you for your suggestion. I will remove the extra indirection. I was wondering if you could also provide some insights about the RWPI case. I believe the same optimization also applies to RWPI. However, I actually want to store the function address as

[PATCH] D136188: Update docs for -fuse-ctor-homing

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me with the addition of the forth homing strategy. In D136188#3866494 , @probinson wrote: > +jmorse who is closer to this topic than

[clang-tools-extra] 25bac38 - [include-cleaner] Add line numbers to HTML output

Author: Sam McCall Date: 2022-10-19T00:21:33+02:00 New Revision: 25bac38a02e3d43a16282d66c38084bcd553c9b5 URL: https://github.com/llvm/llvm-project/commit/25bac38a02e3d43a16282d66c38084bcd553c9b5 DIFF: https://github.com/llvm/llvm-project/commit/25bac38a02e3d43a16282d66c38084bcd553c9b5.diff LO

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2; --

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jdoerfert added a comment. > However cleanup looks scary. Msan reports maybe 20% of unique tests on our > code base. Many a of them share root cause, but still many unique root causes. On quick looks I see no false report While scary, this also is extremely encouraging to move forward with this

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 added a comment. In D135634#3866353 , @benlangmuir wrote: > I think we should deduplicate the vfs overlays if the same ivfsoverlay is > specified in both the pcm and the command-line. My understanding is that `ASTUnit` never uses command-l

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. > that I can redirect the function call at runtime, for dynamic linking purpose. Can you describe a little more what you're trying to do here? If you want to replace the implementation of an existing function at runtime, you'd be better off implementing the indirection

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

bnbarham added a comment. In D135634#3866704 , @jansvoboda11 wrote: > In D135634#3866353 , @benlangmuir > wrote: > >> I think we should deduplicate the vfs overlays if the same ivfsoverlay is >> specified in bo

<    1   2   3   >