ychen added inline comments.
================
Comment at: clang/test/CXX/drs/dr25xx.cpp:3
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
template<typename T>
----------------
erichkeane wrote:
> If you could add a comment explaining this status for me, I would be grateful:
>
> // We've implemented DR2565 as proposed (that is, a substitution failure in a
> requires parameter list causes the requires clause to evaluate as false) as
> it seems to make the most sense, and fit best into our implementation. If
> this issue gets accepted as-is, this can be marked as complete.
You said `we were in a position where we had 1/2 of it implemented`. So I put
it as partial. I must've misunderstood you. Will change it back.
================
Comment at: clang/www/make_cxx_dr_status:161
continue
- if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+ if dr.issue in (1432,2565):
+ row_style = ' class="open"'
----------------
erichkeane wrote:
> I guess this is OK, its a shame we have to custom-tag these, but I guess I'm
> 1/2 responsible here :/
Yeah, it looks hacky. If the list gets larger, we could do something like
`namespace dr1432 { // dr1432: open 16` to make it more general.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136133/new/
https://reviews.llvm.org/D136133
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
