[PATCH] D133359: [AArch64] Make ACLE intrinsics always available part1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30b67c677c6b: [AArch64] Make ACLE intrinsics always available part1 (authored by danielkiss). Herald added a project: clang. Herald added a subscribe

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added a comment. In D135690#3858541 , @aaron.ballman wrote: > In D135690#3856863 , @Trass3r wrote: > >> Didn't realize it has a big cost. Looking inside the `AST_MATCHER` and >> `REGISTER_MATCHER` macros

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135963 Files: clang/lib/CodeGen/CGCall.cpp Index:

[clang] 41ac5d2 - [clang] Fix a warning

Author: Kazu Hirata Date: 2022-10-14T08:36:59-07:00 New Revision: 41ac5d258da3045c871344400aa9e59640ce76a5 URL: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5 DIFF: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5.diff L

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- btw, feel free to land fixes to buildbot breaks without code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135963/n

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam added a comment. In D135963#3858638 , @aaron.ballman wrote: > LGTM -- btw, feel free to land fixes to buildbot breaks without code review. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski abandoned this revision. awarzynski added a comment. In D125788#3622274 , @clementval wrote: > There are open discussion so wait for other to confirm or not. I was under the impression that we did discuss this extensively in our community ca

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Defines `operator==` as an equiva

[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

isuckatcs marked an inline comment as done. isuckatcs added inline comments. Comment at: clang/test/Analysis/lambdas.cpp:226 + [uniquePtr = MakeUniquePtr()] {}(); + clang_analyzer_warnIfReached(); // expected-warning{{TRUE}} +} steakhal wrote: > It should have

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

ymandel added a comment. Reviewers: I'm inclined towards a method vs overloaded operator. Please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135964/new/ https://reviews.llvm.org/D135964 _

[clang-tools-extra] 68d714b - [clang-tidy] Use std::underlying_type_t (NFC)

Author: Kazu Hirata Date: 2022-10-14T09:10:09-07:00 New Revision: 68d714b5410209871843f6a5198db95c63da16e8 URL: https://github.com/llvm/llvm-project/commit/68d714b5410209871843f6a5198db95c63da16e8 DIFF: https://github.com/llvm/llvm-project/commit/68d714b5410209871843f6a5198db95c63da16e8.diff L

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

craig.topper created this revision. craig.topper added reviewers: RKSimon, pengfei. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. It looks like gcc's header already uses unsigned int and we should

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. For me this is good. But please wait for @MyDeveloperDay . Comment at: clang/lib/Format/WhitespaceManager.cpp:931-933 + if (Style.AlignTrailingComments.Kind == FormatStyle::TCAS_Always) { +NewLi

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3857816 , @owenpan wrote: > In D129443#3857608 , @rymiel wrote: > >> Changing the default LLVM style would change the output of all the >> requires-related test case

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. Can you mark your comments done, I think you missed removing some braces that @HazardyKnusperkeks asked you to remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org/D132131 _

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG174e954e370e: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.or

[clang] 174e954 - [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

Author: Andrzej Warzynski Date: 2022-10-14T16:20:04Z New Revision: 174e954e370e4f2ae82fea3f959e843bc05e3046 URL: https://github.com/llvm/llvm-project/commit/174e954e370e4f2ae82fea3f959e843bc05e3046 DIFF: https://github.com/llvm/llvm-project/commit/174e954e370e4f2ae82fea3f959e843bc05e3046.diff

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. I think you also need to rebase to get rid of the "ClangFormatStyleOptions.rst" (which means you need to rebase and rerun dump_format_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://review

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Value.cpp:37 + areEquivalentIndirectionValues(Val1, Val2)) && +

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rjmccall added a comment. Does Fuchsia still need this? If those experiments have stabilized, maybe we can just remove it. Also, it should probably have been a -cc1 flag in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

MyDeveloperDay added a comment. Did you test this with nested #if #endif? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 ___ cfe-commits mailing list cfe-comm

[PATCH] D135964: [clang][dataflow] Add `operator==` for `Value` type.

xazax.hun added a comment. In D135964#3858706 , @ymandel wrote: > Reviewers: I'm inclined towards a method vs overloaded operator. Please let > me know. I don't have a strong preference. But in case we come up with multiple kinds of equalities (see my

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} aaron.ballman wrote: > ChuanqiXu wrote: > > aaron

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. We can't set the flag if initialization is aborted by an exception, which is not ruled out by the use of thread-unsafe statics. So this is not a correct change. More basically,

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper added a comment. In D116735#3857705 , @zixuan-wu wrote: > In D116735#3429850 , @craig.topper > wrote: > >> I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not >> seeing large im

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

hubert.reinterpretcast added a comment. In D135919#3858808 , @rjmccall wrote: > We can't set the flag if initialization is aborted by an exception, which is > not ruled out by the use of thread-unsafe statics. So this is not a correct > change. @tahon

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. Sorry, I responded as if you were modifying the guards of static constructors, but you're actually modifying the guards of thread locals. I apologize for the confusion. However, my substantive points actually all still hold: - we have to generate code that behaves co

[PATCH] D134681: [Clang][AArch64] Add SME outer product intrinsics

rsandifo-arm added a comment. Thanks for the patch. This is going to be inconvenient, sorry, but: while implementing the specification in GCC, I noticed that the ZA functions weren't consistent about whether they had an `_m` suffix. `svwrite` (MOVA) had one, but the MOP intrinsics that you're

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467812. python3kgae added a comment. Fix clang-format missed by arc lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951 Files: clang/include/clang/Basic/HLSLRu

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467822. ymandel marked an inline comment as done. ymandel added a comment. rebase onto a recent HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files: clang/in

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previousl

[PATCH] D135973: Move HLSL builtins into hlsl namespace

beanz created this revision. beanz added reviewers: python3kgae, pow2clk, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Should have done this from the start. Since all the injected AST types are

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467829. sstwcw added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/Unwrap

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a comment. In D135740#3858782 , @MyDeveloperDay wrote: > Did you test this with nested #if #endif? No. I added the tests now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ http

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Daisy's bug ended up being more complicated than I expected... there is a lot to unpack here. In the meantime, I've captured the bug here: https://github.com/llvm/llvm-project/issues/58368 and will continue looking at it. Repository: rG LLVM Github Monorepo CHA

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 467832. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittest

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467833. sstwcw added a comment. - correct spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 -// UNSUPPORTED: default-std-cxx, ps4, ps5 -/// Test default standards when CLANG_DEFAULT_STD_CXX is unspecified. I suppose you want to remove the `lit.cfg.py` counterpart of this as

[clang] 28f7087 - [CodeGen][ObjC] Call synthesized copy constructor/assignment operator

Author: Akira Hatanaka Date: 2022-10-14T10:40:24-07:00 New Revision: 28f7087c9163f66b07e17bd47a1bfb5d9448467d URL: https://github.com/llvm/llvm-project/commit/28f7087c9163f66b07e17bd47a1bfb5d9448467d DIFF: https://github.com/llvm/llvm-project/commit/28f7087c9163f66b07e17bd47a1bfb5d9448467d.diff

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28f7087c9163: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[clang] 39b9d4f - [clang][dataflow] Add support for a Top value in boolean formulas.

Author: Yitzhak Mandelbaum Date: 2022-10-14T17:41:53Z New Revision: 39b9d4f188ca1f99515658334d57c2961db33289 URL: https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289 DIFF: https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289.diff

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39b9d4f188ca: [clang][dataflow] Add support for a Top value in boolean formulas. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { I don't really understand the purpose of th

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { mgorny wrote: > I don't really understand t

[clang] 13cd184 - [clang-dataflow][NFC] Mark test analysis classes as `final`.

Author: Yitzhak Mandelbaum Date: 2022-10-14T17:51:57Z New Revision: 13cd184ef7fa9d76deaffb1924521fa914edba5e URL: https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e DIFF: https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e.diff

[PATCH] D135923: [clang][dataflow][NFC] Mark test analysis classes as `final`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13cd184ef7fa: [clang-dataflow][NFC] Mark test analysis classes as `final`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

MaskRay updated this revision to Diff 467840. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. remove lit feature default_std_cxx I think some other CLANG_DEFAULT_* probably should go away as well, but we can start with STD_C STD_CXX

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > royjacobson wrote:

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467845. ychen added a comment. - skip non-dependent NTTP comparison because they're equivalent (match GCC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clan

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135966/new/ https://reviews.llvm.org/D135966 _

[clang] 1783253 - [Attributes] Improve writing `ExprArgument` value.

Author: Volodymyr Sapsai Date: 2022-10-14T11:20:57-07:00 New Revision: 1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 URL: https://github.com/llvm/llvm-project/commit/1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 DIFF: https://github.com/llvm/llvm-project/commit/1783253c41f1b0ac378ab7fa4b6fe5547369c6b0.di

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1783253c41f1: [Attributes] Improve writing `ExprArgument` value. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/ https://re

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/ https://reviews.llvm.org/D135931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

ymandel updated this revision to Diff 467856. ymandel added a comment. switched to function, instead of operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135964/new/ https://reviews.llvm.org/D135964 Files: clang/include/clang/Analysis/Flow

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

ymandel marked an inline comment as done. ymandel added a comment. In D135964#3858783 , @xazax.hun wrote: > In D135964#3858706 , @ymandel wrote: > >> Reviewers: I'm inclined towards a method vs overloaded operator

[clang] 6897dbc - [PowerPC] Fix parameters for __builtin_crypto_vsbox

Author: Stefan Pintilie Date: 2022-10-14T13:30:59-05:00 New Revision: 6897dbc46329cc8cc3f58b9e4809dd400218b8ae URL: https://github.com/llvm/llvm-project/commit/6897dbc46329cc8cc3f58b9e4809dd400218b8ae DIFF: https://github.com/llvm/llvm-project/commit/6897dbc46329cc8cc3f58b9e4809dd400218b8ae.dif

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

This revision was automatically updated to reflect the committed changes. Closed by commit rG6897dbc46329: [PowerPC] Fix parameters for __builtin_crypto_vsbox (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/ https://r

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#3858760 , @rjmccall wrote: > Does Fuchsia still need this? If those experiments have stabilized, maybe we > can just remove it. Also, it should probably have been a -cc1 flag in the > first place. We still use th

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Some compilers can't determine that all cases of t

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. I'd argue the warning is correct as you could store "non-enum" integer values into an enum typed variable (and people do that fairly often with bitwis

[clang] 911d2dc - [NFC] [HLSL] Move common metadata to LLVMFrontend

Author: Chris Bieneman Date: 2022-10-14T13:40:04-05:00 New Revision: 911d2dc23035454cb85422922c19259855e33bba URL: https://github.com/llvm/llvm-project/commit/911d2dc23035454cb85422922c19259855e33bba DIFF: https://github.com/llvm/llvm-project/commit/911d2dc23035454cb85422922c19259855e33bba.diff

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG911d2dc23035: [NFC] [HLSL] Move common metadata to LLVMFrontend (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 71a9b88 - [X86] Use unsigned int for return type of __get_cpuid_max.

Author: Craig Topper Date: 2022-10-14T11:45:20-07:00 New Revision: 71a9b8833231a285b4d8d5587c699ed45881624b URL: https://github.com/llvm/llvm-project/commit/71a9b8833231a285b4d8d5587c699ed45881624b DIFF: https://github.com/llvm/llvm-project/commit/71a9b8833231a285b4d8d5587c699ed45881624b.diff

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71a9b8833231: [X86] Use unsigned int for return type of __get_cpuid_max. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel added a comment. Thanks for the kind words ❤️ (I've noticed Björn already includes me in his reviewers list); and while I am humbled, and I do look at every patch, I don't *yet* trust myself to actually perform good code review, as it's not something I've really ever done before. Repos

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3859235 , @leonardchan wrote: > In D85802#3858760 , @rjmccall wrote: > >> Does Fuchsia still need this? If those experiments have stabilized, maybe >> we can just remove it. Al

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135916/new/ https://reviews.llvm.org/D135916 ___

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

beanz added inline comments. Comment at: clang/include/clang/Basic/HLSLRuntime.h:31 +// NOTE: keep sync with ResourceBase::Kinds in DirectX backend. +enum class ResourceKind : uint32_t { + Invalid = 0, If this is only used in the clangCodeGen library, we can mov

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman wro

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

ymandel added a comment. In D135978#3859272 , @xazax.hun wrote: > I'd argue the warning is correct as you could store "non-enum" integer values > into an enum typed variable (and people do that fairly often with bitwise > enums). Good point. Feels wron

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); python3kga

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

HazardyKnusperkeks added a comment. In D135707#3859357 , @rymiel wrote: > Thanks for the kind words ❤️ (I've noticed Björn already includes me in his > reviewers list); and while I am humbled, and I do look at every patch, I > don't *yet* trust myself t

[clang] 037f856 - Itanium ABI: Pack non-pod members of packed types

Author: David Blaikie Date: 2022-10-14T19:32:57Z New Revision: 037f856681268c793c660389b4d6407367e68190 URL: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190 DIFF: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190.diff LOG:

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

tahonermann added a comment. > the case from https://github.com/llvm/llvm-project/issues/57828 is not for a > block-scope variable, but the case in the patch description is... Thanks, Hubert. Yes, I found that the reported issue occurred for any case where thread safe guard variables are not re

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG037f85668126: Itanium ABI: Pack non-pod members of packed types (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D135916?vs=467599&id=467890#toc Repository: rG LLVM Github Mo

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7da087974f94: [clang][dataflow][NFC] Fix reachability warning. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135978/new/ https://revi

[clang] 7da0879 - [clang][dataflow][NFC] Fix reachability warning.

Author: Yitzhak Mandelbaum Date: 2022-10-14T19:35:11Z New Revision: 7da087974f9491855eea0087c657851a84c67b75 URL: https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75 DIFF: https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75.diff

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote: >

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

sammccall added a comment. In D54943#3854279 , @sammccall wrote: > FYI I've sent D135829 to block this check > from running in clangd, after tracking it down as the cause of a >10x > regression in reparse times in a pro

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rjmccall added a comment. If it comes down to it, we can make this a Fuchsia-specific flag, so that Fuchsia + alternative C++ ABI is essentially a sort of subtarget. That way we don't have to support the arbitrary Cartesian product of OS + ABI. With that said, while I don't know the details of

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

hubert.reinterpretcast added a comment. In D135919#3859491 , @tahonermann wrote: >> the case from https://github.com/llvm/llvm-project/issues/57828 is not for a >> block-scope variable, but the case in the patch description is... > > Thanks, Hubert. Yes

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +PS2->get

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. > Naive question, but what does it mean to target Fuschia but be > gnu-compatible? (how would that be different than using whatever gnu OS > (linux, etc) the other code was built for) (Probably poor wording on my part.) When I mention gnu-compatible here, I don't m

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467894. brettw added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-ex

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h c

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467900. ayzhao added a comment. run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/clang/AST

[PATCH] D135989: [clang][Sema] Use size of char for void types

void created this revision. void added reviewers: serge-sans-paille, kees, nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The extension that allows for pointer arithmetic on 'void' types t

[PATCH] D135989: [clang][Sema] Use size of char for void types

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contai

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8 elements

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467909. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase to use FrontendResource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8 elements

[PATCH] D135989: [clang][Sema] Use size of char for void types

void updated this revision to Diff 467912. void added a comment. Fix up testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/array-bounds-pt

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; please consider appending to the commit message something along the lines of "operations on the result of getTypeSize() are in bits, not bytes. Using 1 as the value fo

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); gracejenning

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov updated this revision to Diff 467919. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 467920. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang-tools-extra/clangd/unitte

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 467922. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h clang/include/clang/Sema/Init

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 467923. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp Index

[clang] d11b9fa - [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

Author: Daniel Rodríguez Troitiño Date: 2022-10-14T14:33:10-07:00 New Revision: d11b9fa3bfb9e2bedec142816e88b9171c8ec6b6 URL: https://github.com/llvm/llvm-project/commit/d11b9fa3bfb9e2bedec142816e88b9171c8ec6b6 DIFF: https://github.com/llvm/llvm-project/commit/d11b9fa3bfb9e2bedec142816e88b917

<    1   2   3   >