nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land.
LGTM; please consider appending to the commit message something along the lines of "operations on the result of getTypeSize() are in bits, not bytes. Using 1 as the value for void* is the correct number of bytes, but we're doing arithmetic in bits." or something to denote this is a unit-of-measure related bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
