[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d149d17f069: [clang-tidy] Fix crashes on `if consteval` in readability checks (authored by rymiel). Changed prior to commit: https://reviews.llvm.org/D133413?vs=464176&id=465291#toc Repository: rG L

[clang-tools-extra] 2d149d1 - [clang-tidy] Fix crashes on `if consteval` in readability checks

Author: Emilia Dreamer Date: 2022-10-05T09:38:05+03:00 New Revision: 2d149d17f069e671e064a000cb038590f4fc5303 URL: https://github.com/llvm/llvm-project/commit/2d149d17f069e671e064a000cb038590f4fc5303 DIFF: https://github.com/llvm/llvm-project/commit/2d149d17f069e671e064a000cb038590f4fc5303.diff

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein updated this revision to Diff 465298. hokein marked 2 inline comments as done. hokein added a comment. Remove the I variable, use GreaterIndex instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135132/new/ https://reviews.llvm.org/D13513

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:897 // actually a lower index! unsigned GreaterIndex = I; unsigned LessIndex = LoadedSLocEntryTable.size(); sammccall wrote: > is the same optimization available here? > I think

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:733 + static CXXBoolLiteralExpr *Create(const ASTContext &C, bool Val, QualType Ty, +SourceLocation Loc) { shafik wrote: > I think this makes

[PATCH] D134425: [NFC] Create a AllocLikeOpInterface and make memref::AllocOp, memref::AllocaOp and gpu::AllocOp implement it.

bondhugula added a comment. This is looking good to me. Please pull out changes unrelated to AllocLikeOpInterface into a separate revision (the ones just switching to `hasSingleEffect`). Comment at: mlir/lib/Dialect/Affine/Transforms/LoopFusion.cpp:1967 auto *op = memr

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/SourceManager.cpp:807 } // Find the FileID that contains this. "I" is an iterator that points to a Just checki

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. As pointed out in https://rev

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kadircet added a comment. sent out https://reviews.llvm.org/D135245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 ___ cfe-commits mailing list cfe-commits@li

[clang] 36a2002 - [clang][Lex] Fix a crash on malformed string literals

Author: Kadir Cetinkaya Date: 2022-10-05T09:55:50+02:00 New Revision: 36a200208facf58d454c9b7253c956c2f2a8b946 URL: https://github.com/llvm/llvm-project/commit/36a200208facf58d454c9b7253c956c2f2a8b946 DIFF: https://github.com/llvm/llvm-project/commit/36a200208facf58d454c9b7253c956c2f2a8b946.dif

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36a200208fac: [clang][Lex] Fix a crash on malformed string literals (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 465312. to268 added a comment. Added a check to not diagnose a missing type specifier in C2x mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/include

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a reviewer: martong. balazske added a comment. Herald added a subscriber: rnkovacs. This is another approach to D132017 . This eliminates redundant code from `StreamChecker` that can be done with `StdLibraryFunctionsChecker` too. Something to fix

[PATCH] D134425: [NFC] Create a AllocLikeOpInterface and make memref::AllocOp, memref::AllocaOp and gpu::AllocOp implement it.

ftynse requested changes to this revision. ftynse added a comment. This revision now requires changes to proceed. I would expect a new top-level interface (in lib/Interfaces) to go through the RFC process. I have concerns about the interface design. Specifically, it appears to be promoting deta

[clang] feea7ef - Revert "[clang][Lex] Fix a crash on malformed string literals"

Author: Kadir Cetinkaya Date: 2022-10-05T10:37:32+02:00 New Revision: feea7ef23cb1bef92d363cc613052f8f3a878fc2 URL: https://github.com/llvm/llvm-project/commit/feea7ef23cb1bef92d363cc613052f8f3a878fc2 DIFF: https://github.com/llvm/llvm-project/commit/feea7ef23cb1bef92d363cc613052f8f3a878fc2.dif

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

kadircet added a comment. this is causing some crashes in buildbots, and i can't repro. reverting until i figure this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135161/new/ https://reviews.llvm.org/D135161

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

hokein updated this revision to Diff 465321. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134942/new/ https://reviews.llvm.org/D134942 Files: clang/lib/Lex/TokenL

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

hokein added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1019 +// sourcelocation-against-bounds comparison. +FileID BeginFID = SM.getFileID(BeginLoc); +SourceLocation Limit = nickdesaulniers wrote: > sammccall wrote: > > this getFileID()

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

ilya-biryukov added a comment. Thanks! I have only various code style comments here, ptal. Overall LG. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4705 +def note_ovl_ambiguous_eqeq_reversed_self_non_const : Note< + "mark operator== as const or add a matching o

[clang] c21e571 - Fix clang baremetal test

Author: Mikhail Goncharov Date: 2022-10-05T11:32:28+02:00 New Revision: c21e57156c25734df44bb4893b9fc31dfc7de56d URL: https://github.com/llvm/llvm-project/commit/c21e57156c25734df44bb4893b9fc31dfc7de56d DIFF: https://github.com/llvm/llvm-project/commit/c21e57156c25734df44bb4893b9fc31dfc7de56d.d

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. I get a failure since this commit. `Could not load library By.so` ... `cannot open shared object file: No such file or directory`. Maybe a missing dependency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ h

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein updated this revision to Diff 465325. hokein marked an inline comment as done. hokein added a comment. add an assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135132/new/ https://reviews.llvm.org/D135132 Files: clang/lib/Basic/Sou

[PATCH] D135254: [clang][Sema] Fix crash on invalid base destructor

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LookupSpecialMember might fail, so changes the cast to cast_or_null. Inside Sema, skip

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/TokenLexer.cpp:1038 + for (Token& T : Partition) { +SourceLocation::IntTy RelativeOffset = T.getLocation().getRawEncoding() - +

[PATCH] D135245: [clang][Tooling] Move STL recognizer to its own library

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CMakeLists.txt:163 clangToolingInclusions + clangToolingInclusionsSTL clangToolingSyntax StandardLibrar

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 465332. domada added a comment. Patch rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Front

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

hans added a comment. This did turn up a problem. With this patch Clang treats the following (based on https://source.chromium.org/chromium/chromium/src/+/main:media/formats/hls/source_string.h;l=125) as invalid, and so does MSVC: template struct __declspec(dllexport) Foo { static Foo

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; dblaikie wrote: > jcranmer-intel wrote: > >

[PATCH] D135256: [clang] Add Create method for CXXBoolLiteralExpr

DavidSpickett created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett updated this revision to Diff 465341. DavidSpickett added a comment. Rebase, Create moved to parent change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135169/new/ https://reviews.llvm.org/D135169 Files: lldb/include/lldb/Symbol/

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

DavidSpickett updated this revision to Diff 465342. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135170/new/ https://reviews.llvm.org/D135170 Files: clang/lib/AST/StmtPrinter.cpp lldb/test/API/lang/cpp/c

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: r

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

kadircet added a comment. This is triggering crashes in our production setup, but I couldn't come up with a reduced test case. crash is triggered in the loop: for (const auto *S : EnclosingFunction->getBody()->children()) { if (SM.isBeforeInTranslationUnit(S->getSourceRange().getEnd()

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + jdoerfert wrote: > domada wrote: > > jdoerfert wrote: > > > domada wrote: > > > > jdoerfert wrote: > > > > > This doesn't work. Use th

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

ilya-biryukov added a comment. Having `nullptr` inside `children()` seems really weird. Should we fix those instead to never produce `nullptr`? Or is this something that is expected (I can come up with a few contracts where this would make sense, but that all looks really akward). Repository:

[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. Similar to getFileIDLocal patch, but for the versio

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135224/new/ https://reviews.llvm.org/D135224 ___

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

jdoerfert updated this revision to Diff 465350. jdoerfert added a comment. Last changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135155/new/ https://reviews.llvm.org/D135155 Files: clang/test/CodeGenOpenCL/builtins-amdgcn.cl llvm/include/

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#3834938 , @sammccall wrote: > In D134813#3834776 , @aaron.ballman > wrote: > >> Thank you for this! I applied D135191 >> over the top

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. I'm not comfortable giving the final LG but the changes here look reasonable to me. Comment at: clang/lib/CodeGen/CGStmt.cpp:829-831 + CGM.getCodeGenOpts().OptimizationLevel) { LH = Stmt::getLikelihood(S.getThen(), S.getElse()); + } --

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

aaron.ballman added reviewers: shafik, erichkeane, tbaeder. aaron.ballman added a comment. Adding a few more reviewers who have been poking around in constant expression evaluation lately. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2722-2723 InGroup, Defau

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134617/new/ https://reviews.llvm.org/D134617

[PATCH] D135254: [clang][Sema] Fix crash on invalid base destructor

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, Sema::LookupDefaultConstructor already does the similar thing as well. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5699 CXXDestructorDecl *Dtor = LookupDestr

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2640 if (UseOMPIRBuilder) { +llvm::DenseMap AlignedVars; // Emit the associated statement and get its loop representation. Where is this map populated? =

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

david-arm added a comment. Hi @sagarkulkarni19, thank you for working on the ACLE builtins for SME! I've had a look through and I have a few comments, mostly around how the code is structured. It would be good if you could try to separate SVE from SME in this implementation, in the same way tha

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

jdoerfert added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8274-8279 // Only if a local variable was declared in the function currently being // evaluated, do we expect to be able to find its value in the current // frame. (Otherwise it was likely

[PATCH] D135254: [clang][Sema] Fix crash on invalid base destructor

kadircet updated this revision to Diff 465365. kadircet marked 2 inline comments as done. kadircet added a comment. -address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135254/new/ https://reviews.llvm.org/D135254 Files: clang/lib/Sem

[PATCH] D135254: [clang][Sema] Fix crash on invalid base destructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadab08ecf2bd: [clang][Sema] Fix crash on invalid base destructor (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

hokein added a comment. In D135257#3836511 , @ilya-biryukov wrote: > Having `nullptr` inside `children()` seems really weird. Should we fix those > instead to never produce `nullptr`? Or is this something that is expected (I > can come up with a few co

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I think there is a typo somehow. It should be "Bye.so". Not sure how that happened. I'm looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___

[PATCH] D135191: [Index] USRGeneration doesn't depend on unnamed.printName() => ''. NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG20c9ac292504: [Index] USRGeneration doesn't depend on unnamed.printName() => ''. NFC (authored by sammccall). Repository:

[clang] adab08e - [clang][Sema] Fix crash on invalid base destructor

Author: Kadir Cetinkaya Date: 2022-10-05T15:23:15+02:00 New Revision: adab08ecf2bdeb84dc7d2009d4c0c13617db9c58 URL: https://github.com/llvm/llvm-project/commit/adab08ecf2bdeb84dc7d2009d4c0c13617db9c58 DIFF: https://github.com/llvm/llvm-project/commit/adab08ecf2bdeb84dc7d2009d4c0c13617db9c58.dif

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. I just landed that change to USR generation as 20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e , so there should now be no USR changes (just some changes to debug representations that happen to be in some

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added subscribers: zixuw, dexonsmith, gribozavr. aaron.ballman added a comment. In D134813#3836826 , @sammccall wrote: > I just landed that change to USR generation as > 20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e >

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. In D129156#3836768 , @tarunprabhu wrote: > I think there is a typo somehow. It should be "Bye.so". Not sure how that > happened. I'm looking into this. I probably didn't copy the error correctly .. this is the correct libs t

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in from someone on the LLVM side of things; lldb would be nice as well). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 _

[PATCH] D135258: [SourceManager] Improve getFileIDLoaded.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Just a couple of comments where we could take the opportunity to clarify the existing code. Optional. Comment at: clang/lib/Basic/SourceManager.cpp:874 +int

[clang] 20c9ac2 - [Index] USRGeneration doesn't depend on unnamed.printName() => ''. NFC

Author: Sam McCall Date: 2022-10-05T15:51:00+02:00 New Revision: 20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e URL: https://github.com/llvm/llvm-project/commit/20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e DIFF: https://github.com/llvm/llvm-project/commit/20c9ac29250493f5e0a3791dc1e5e9114ff0dc6e.diff LO

[clang-tools-extra] 0a50eaf - [clangd] Stop isSpelledInSource from printing source locations.

Author: Sam McCall Date: 2022-10-05T15:49:22+02:00 New Revision: 0a50eafd1d44fae786a673e44831dd130a21b057 URL: https://github.com/llvm/llvm-project/commit/0a50eafd1d44fae786a673e44831dd130a21b057 DIFF: https://github.com/llvm/llvm-project/commit/0a50eafd1d44fae786a673e44831dd130a21b057.diff LO

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

pengfei updated this revision to Diff 465391. pengfei added a comment. Address @rnk's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134797/new/ https://reviews.llvm.org/D134797 Files: clang/lib/CodeGen/TargetInfo.cpp clang/te

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

pengfei added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859 } -return getIndirectResult(Ty, /*ByVal=*/false, State); +bool ByVal = IsVectorCall && Ty->isFloatingType(); +return getIndirectResult(Ty, ByVal, State); } r

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3836838 , @clementval wrote: > I probably didn't copy the error correctly .. this is the correct libs that > is not found `llvm-project/build/lib/Bye.so` I need some help with this. The failing build is building

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 465393. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files: clang/d

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl created this revision. yaxunl added reviewers: tra, ronl. Herald added subscribers: kosarev, t-tye, tpr, dstuttard, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Currently there is some backend issue which causes values loa

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465395. lime added a comment. I provided a solution for the problem I mentioned above, although it may look ugly. Then, I will take a look at `friend` related stuffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl updated this revision to Diff 465403. yaxunl added a comment. fix comments in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/ https://reviews.llvm.org/D135269 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/bool-range.cu Index: clang/test/CodeGenC

[PATCH] D134618: [Syntax] Fix macro-arg handling in TokenBuffer::spelledForExpanded

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:82 + // When First and Last are part of the *same macro arg* of a macro written + // in the main file, we

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk accepted this revision. kwk added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; owenpan

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:607 + T __builtin_elementwise_cos(T x)return the ratio of the adjacent side length over thefloating point types + hypoteneuse side leng

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair created this revision. al45tair added reviewers: ahatanak, rjmccall, theraven. Herald added a project: All. al45tair requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new attribute, "?", to the property attribute string for pro

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added inline comments. Comment at: clang/include/clang/Sema/Overload.h:1024 /// candidates for operator Op. - bool shouldAddReversed(OverloadedOperatorKind Op); + bool mayAddReversed(OverloadedOperatorKind Op); ilya-biryukov wrote: >

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 465423. balazske added a comment. Fixed failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135247/new/ https://reviews.llvm.org/D135247 Files: clang/lib/StaticAnalyzer/Checkers/ErrnoChecker.cpp

[clang] 67268ee - [Syntax] Fix macro-arg handling in TokenBuffer::spelledForExpanded

Author: Sam McCall Date: 2022-10-05T18:04:39+02:00 New Revision: 67268ee11c220b1dfdf84afb10a12371c5ae6400 URL: https://github.com/llvm/llvm-project/commit/67268ee11c220b1dfdf84afb10a12371c5ae6400 DIFF: https://github.com/llvm/llvm-project/commit/67268ee11c220b1dfdf84afb10a12371c5ae6400.diff LO

[PATCH] D134618: [Syntax] Fix macro-arg handling in TokenBuffer::spelledForExpanded

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rG67268ee11c22: [Syntax] Fix macro-arg handling in TokenBuffer::spelledForExpanded (authored by sammccall).

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG15aa64301ab1: [HLSL] Support register binding attribute on global variable (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 15aa643 - [HLSL] Support register binding attribute on global variable

Author: Xiang Li Date: 2022-10-05T09:23:35-07:00 New Revision: 15aa64301ab146dec7c6ffcd0418ed834bf099e2 URL: https://github.com/llvm/llvm-project/commit/15aa64301ab146dec7c6ffcd0418ed834bf099e2 DIFF: https://github.com/llvm/llvm-project/commit/15aa64301ab146dec7c6ffcd0418ed834bf099e2.diff LOG:

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG41b51007e637: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting (authored by sammccall)

[clang] 41b5100 - Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

Author: Sam McCall Date: 2022-10-05T18:29:01+02:00 New Revision: 41b51007e6376cba72b00fb655a63b06c554d4e1 URL: https://github.com/llvm/llvm-project/commit/41b51007e6376cba72b00fb655a63b06c554d4e1 DIFF: https://github.com/llvm/llvm-project/commit/41b51007e6376cba72b00fb655a63b06c554d4e1.diff LO

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added inline comments. Comment at: clang/include/clang/Sema/SemaConcept.h:51 + // QualType of constrained template template parameter is not the same as + // its tailing version, so give it a pass here. + if (LHS.getKind() == TemplateArgument::Type && --

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

adamcz added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358 +// Returns^ +const char *findPathInURI(const char *S) { + // Skip over scheme. Is there a reason why you're doing this with manual manipulation of C-strings instea

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

ributzka added a comment. This makes sense. We shouldn't re-validate system headers when `-fmodules-validate-once-per-build-session` is passed too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135232/new/ https://reviews.llvm.org/D135232 ___

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

python3kgae updated this revision to Diff 465441. python3kgae added a comment. Update to match comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134330/new/ https://reviews.llvm.org/D134330 Files: clang/docs/HLSL/HLSLSupport.rst Index: cl

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

bnbarham accepted this revision. bnbarham added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:146-155 /// References the file which the contents were actually loaded from. /// /// Can be different from 'Entry' if we overridden the contents of one

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

shafik added a comment. Looks good but let's have Aaron check it out. Comment at: clang/lib/Sema/SemaExprCXX.cpp:24 #include "clang/AST/RecursiveASTVisitor.h" +#include "clang/AST/Type.h" #include "clang/AST/TypeLoc.h" Why also `Type.h`? Co

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465446. bob80905 added a comment. - shorten builtin description, group sin and cos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtens

[PATCH] D135285: [OpenMP] Make the exec_mode global have protected visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb, ABataev. Herald added subscribers: mattd, asavonic, guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

zixuw added a subscriber: QuietMisdreavus. zixuw added a comment. In D134813#3836836 , @aaron.ballman wrote: >> I'd guess we need some kind of change to CommentXML and ExtractAPI, but I >> don't know enough to be sure what it should be. > > Ping @dang @

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

tra added a comment. Is there more info about the issue? What does AMDGPU currently emit for the test case? AFAICT from running it on CE (https://godbolt.org/z/ccq3vnbrM) llvm optimizes it to essentially `*y = *x` and generates a 1-byte load+store for both NVPTX and AMDGPU. CHANGES SINCE LAS

[PATCH] D135284: RFC: [Driver] select alternative target containing . in executable name

dankm created this revision. Herald added subscribers: pengfei, krytarowski, arichardson, emaste. Herald added a project: All. dankm added reviewers: echristo, zarko. dankm added a comment. dankm published this revision for review. Herald added subscribers: cfe-commits, MaskRay. Herald added a proj

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. as Discussed: https://discourse.llvm.org/t/rfc-can-we-stop-the-extension-to-allow-dereferencing-void-in-c/65708 There is no good reason to a

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2630 // CUDA device code and some other targets don't support VLAs. -targetDiag(Loc, (getLangOpts().CUDA && getLangOpts().CUDAIsDevice) -? diag::err_cuda_vla -

[PATCH] D134772: [Clang] Make constraints of auto part of NTTP instead of AutoType

ychen abandoned this revision. ychen added a comment. D135088 was landed instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134772/new/ https://reviews.llvm.org/D134772 ___

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:24 #include "clang/AST/RecursiveASTVisitor.h" +#include "clang/AST/Type.h" #include "clang/AST/TypeLoc.h" shafik wrote: > Why also `Type.h`? The most likely reason is that it's come from D11

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

zixuw added inline comments. Comment at: clang/test/ExtractAPI/typedef_anonymous_record.c:74 "interfaceLanguage": "objective-c", -"precise": "c:@SA@MyStruct" +"precise": "c:@S@MyStruct" }, Why is the `A` dropped here? Isn't this US

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir updated this revision to Diff 465457. benlangmuir edited the summary of this revision. benlangmuir added a comment. - Used `OptionalFileEntryRefDegradesToFileEntryPtr` at two callsites - Attempted to fix Windows path / vs \ in test. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6938 +def ext_typecheck_indirection_through_void_pointer_cpp +: ExtWarn<"ISO C++ does not allow indirection on operand of type %0">, + // Note: This uses a different diagnostic

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:146-155 /// References the file which the contents were actually loaded from. /// /// Can be different from 'Entry' if we overridden the contents of one file /// with the contents

[PATCH] D135287: Disallow dereferencing of void* in C++.

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding the vendors group due to the potential to break existing code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.llvm.org/D135287 ___

[PATCH] D135287: Disallow dereferencing of void* in C++.

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6938 +def ext_typecheck_indirection_through_void_pointer_cpp +: ExtWarn<"ISO C++ does not allow indirection on operand of type %0">, + // Note: This uses a different diagnostics

  1   2   3   >