sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/CMakeLists.txt:163 clangToolingInclusions + clangToolingInclusionsSTL clangToolingSyntax ---------------- StandardLibrary or Stdlib? STL isn't accurate or consistent with the names in the code. ================ Comment at: clang/lib/Tooling/Inclusions/STL/CMakeLists.txt:2 +add_clang_library(clangToolingInclusionsSTL + StandardLibrary.cpp + ---------------- This means the implementation files and the header files have a different directory structure, which may be confusing to people trying to work out which library to link against based on the headers they included. On the other hand, I think the cascading effect of dependencies => libraries => directory structure => header structure is pretty unfortunate leaking of llvm's sad cmake structure. Up to you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135245/new/ https://reviews.llvm.org/D135245 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
