[PATCH] D135171: FreeBSD: enable __float128 on x86

emaste accepted this revision. emaste added a comment. OK. I think the switch will become unwieldy if additional arch-dependent things are added but could be dealt with then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://review

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

aaron.ballman added subscribers: foad, RKSimon, sepavloff, dblaikie, chandlerc. aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64>

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

jcranmer-intel added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; aaron.ballman wrote: > tbaeder wrote

[clang] 7d85f6b - [clang][driver][darwin] Ensure that the SDK version passed to -platform_version has a minor version number 0

Author: Alex Lorenz Date: 2022-10-04T10:23:38-07:00 New Revision: 7d85f6b1af26c8f749f0c217d7aae694cc3931eb URL: https://github.com/llvm/llvm-project/commit/7d85f6b1af26c8f749f0c217d7aae694cc3931eb DIFF: https://github.com/llvm/llvm-project/commit/7d85f6b1af26c8f749f0c217d7aae694cc3931eb.diff L

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille updated this revision to Diff 465071. serge-sans-paille added a comment. Removed a diff that sneaked in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp clang

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added a comment. In D134453#3828352 , @dblaikie wrote: > In D134453#3826832 , @aaron.ballman > wrote: > >> In D134453#3825902 , @dblaikie >> wrote: >>

[clang] 3d7946c - Implement DR2565: Invalid types in the parameter-declaration-clause of a

Author: Erich Keane Date: 2022-10-04T10:32:48-07:00 New Revision: 3d7946c580055dade1dcf4b632738cc54e1a25a9 URL: https://github.com/llvm/llvm-project/commit/3d7946c580055dade1dcf4b632738cc54e1a25a9 DIFF: https://github.com/llvm/llvm-project/commit/3d7946c580055dade1dcf4b632738cc54e1a25a9.diff L

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added a subscriber: cjdb. aaron.ballman added a comment. CC @cjdb for awareness that we're talking about display of diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134453/new/ https://reviews.llvm.org/D134453 __

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Assuming precommit CI comes back clean, this LGTM. Thanks for the cleanup! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 __

[PATCH] D135076: [Clang] Make offloading flags accept '-' and '--'

tra added a comment. In D135076#3831563 , @MaskRay wrote: > Another idea is to reject multiple `-o` if some are used as the `Joined` > form. Note: multiple `Separate` `-o` should be allowed. > It will not catch `-offload-*` when `-o output` is not specif

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. > There were multiple DRs implemented in this patch. > > DR692 was a fix against C++11 > DR1395 was a fix against C++17 > DR1432 is still open but was opened against C++11 > > Which DRs do we wish to implement in what language modes? There are regressions if DR1395 is not a

[clang] b0aed82 - Remove accidentially left assertion

Author: Erich Keane Date: 2022-10-04T11:07:03-07:00 New Revision: b0aed823d447c1e0d4e5bb82d7e14830d66c75d4 URL: https://github.com/llvm/llvm-project/commit/b0aed823d447c1e0d4e5bb82d7e14830d66c75d4 DIFF: https://github.com/llvm/llvm-project/commit/b0aed823d447c1e0d4e5bb82d7e14830d66c75d4.diff L

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce6776cf98: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1 (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135159/new/ https

[clang-tools-extra] 52ce677 - [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

Author: Michał Górny Date: 2022-10-04T20:08:56+02:00 New Revision: 52ce6776cf98e993c6ec04ae54b52e1354fff917 URL: https://github.com/llvm/llvm-project/commit/52ce6776cf98e993c6ec04ae54b52e1354fff917 DIFF: https://github.com/llvm/llvm-project/commit/52ce6776cf98e993c6ec04ae54b52e1354fff917.diff

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

hubert.reinterpretcast added a comment. In D128745#3834313 , @ychen wrote: > I think the consensus is some flag is needed to put it back to legacy > behavior just in case. I am not sure there is strong consensus to add a flag "just in case". Historical

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

hokein accepted this revision. hokein added a comment. Thanks! I believe it fixes a long tail crash. Comment at: clang/unittests/Lex/LexerTest.cpp:665 +TEST_F(LexerTest, BrokenStringLiteral) { + const llvm::StringLiteral Source = R"cpp("\N")cpp"; + // Make sure this isn't cra

[clang] 266ec80 - [clang][DebugInfo] Respect fmodule-file-home-is-cwd in skeleton CUs for clang modules

Author: Alex Langford Date: 2022-10-04T11:25:43-07:00 New Revision: 266ec801fb23f9f5f1d61ca9466e0805fbdb78a7 URL: https://github.com/llvm/llvm-project/commit/266ec801fb23f9f5f1d61ca9466e0805fbdb78a7 DIFF: https://github.com/llvm/llvm-project/commit/266ec801fb23f9f5f1d61ca9466e0805fbdb78a7.diff

[PATCH] D134911: [clang][DebugInfo] Respect fmodule-file-home-is-cwd in skeleton CUs for clang modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG266ec801fb23: [clang][DebugInfo] Respect fmodule-file-home-is-cwd in skeleton CUs for clang… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D135067: [lit] RUN commands without stdin.

csigg updated this revision to Diff 465096. csigg added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Fix clang tests that relied on empty input or accidentally did not provide the input in the RUN directive. Repos

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

cor3ntin added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:665 +TEST_F(LexerTest, BrokenStringLiteral) { + const llvm::StringLiteral Source = R"cpp("\N")cpp"; + // Make sure this isn't crashing. hokein wrote: > nit: I'd probably use a clang l

[PATCH] D134369: [Clang] Support constexpr builtin fmax

aaron.ballman added a comment. Regarding Annex F requirements, do we document that we conform to Annex F and do we have any actual test coverage for it? This question has come up for me quite a bit as I've worked on our C status page and I've never found a satisfactory answer of what we intend

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3834387 , @hubert.reinterpretcast wrote: > In D128745#3834313 , @ychen wrote: > >> I think the consensus is some flag is needed to put it back to legacy >> behavior just in case

[clang] 1376c73 - [clang] Add fix-it note to defaulted-function-deleted warning

Author: Nathan James Date: 2022-10-04T19:38:10+01:00 New Revision: 1376c73927dcb899db5d46f7b970692e2e95f9ac URL: https://github.com/llvm/llvm-project/commit/1376c73927dcb899db5d46f7b970692e2e95f9ac DIFF: https://github.com/llvm/llvm-project/commit/1376c73927dcb899db5d46f7b970692e2e95f9ac.diff

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG1376c73927dc: [clang] Add fix-it note to defaulted-function-deleted warning (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

tahonermann added a comment. Is it known what gcc and Microsoft maintainers are going to do with these DRs? I don't see any recent changes in gcc, but the following is interesting... For the test below, Clang has historically accepted it but now rejects it. MSVC has historically rejected it, bu

[clang] 3460a5d - [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

Author: serge-sans-paille Date: 2022-10-04T20:42:36+02:00 New Revision: 3460a5d7957237a8dbe8ce523edb3e83baa2f4c7 URL: https://github.com/llvm/llvm-project/commit/3460a5d7957237a8dbe8ce523edb3e83baa2f4c7 DIFF: https://github.com/llvm/llvm-project/commit/3460a5d7957237a8dbe8ce523edb3e83baa2f4c7.d

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG3460a5d79572: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Comment at: clang/lib/Sema/SemaDecl.cpp:7047 +NewDecl->getLocation(), +diag::err_attribute_dllimport_function_specialization_definition); +

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2817-2818 + void MaybeParseHLSLSemantics(Declarator &D, + SourceLocation *EndLoc = nullptr) { +if (Tok.is(tok::colon)) { aaron.ballman wrote:

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 465106. Izaron added a comment. Fix comment wording. Thanks to @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/ https://reviews.llvm.org/D134369 Files: clang/docs/LanguageExtensions.

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. Sorry, Monday was a holiday here... I don't think unconditionally including the filename in printQualifiedName() is great for tools, it can be unreasonably long and is generally just noise when shown in the context of that file. I'm surprised that USR generation + tha

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3834454 , @tahonermann wrote: > Is it known what gcc and Microsoft maintainers are going to do with these > DRs? I don't see any recent changes in gcc, but the following is > interesting... It's hard to tell if they d

[clang] 5d69937 - [Clang] make canonical AutoType constraints-free

Author: Yuanfang Chen Date: 2022-10-04T11:56:03-07:00 New Revision: 5d69937b9f9c8e102663c2edcbdbe5335858b215 URL: https://github.com/llvm/llvm-project/commit/5d69937b9f9c8e102663c2edcbdbe5335858b215 DIFF: https://github.com/llvm/llvm-project/commit/5d69937b9f9c8e102663c2edcbdbe5335858b215.diff

[PATCH] D135088: [Clang] make canonical AutoType constraints-free

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG5d69937b9f9c: [Clang] make canonical AutoType constraints-free (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

rjmccall added a comment. In D128745#3833393 , @royjacobson wrote: > Is there consensus that applying this DR resolution is distruptive enough > that it's actually an issue? If clang-abi-compat is not a good way to offer > backwards compatibility in th

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

sammccall added a comment. Thanks, I think this is worthwhile for the simpler code, better (non-lying) comments, avoiding arg-evaluation-order stuff. -0.05% time and -0.5% SLocEntries is interesting too! Clearly not earth-shattering but the the offset table idea gives us a lead to follow. I do

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#3834496 , @sammccall wrote: > Sorry, Monday was a holiday here... No worries, I hope you had a good holiday! > I don't think unconditionally including the filename in printQualifiedName() > is great for tools,

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 updated this revision to Diff 465112. jansvoboda11 added a comment. Squash the original macro with its `_IMPL` counterpart Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 Files: clang/lib/F

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae updated this revision to Diff 465115. python3kgae added a comment. Limit MaybeParseHLSLSemantics to HLSL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134617/new/ https://reviews.llvm.org/D134617 Files: clang/include/clang/Basic/Att

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

sammccall added a comment. Nice! Comment at: clang/lib/Basic/SourceManager.cpp:796 + // larger than SLocOffset. + const SrcMgr::SLocEntry *I = LocalSLocEntryTable.end(); + // LessIndex - This is the lower bound of the range that we're searching. hmm, while h

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. Thanks @MaskRay that's good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] e212a4f - [clangd] Don't print locations of anonymous tags

Author: Sam McCall Date: 2022-10-04T21:38:18+02:00 New Revision: e212a4f838f17e2d37b1d572d8c1b49c50d7fe17 URL: https://github.com/llvm/llvm-project/commit/e212a4f838f17e2d37b1d572d8c1b49c50d7fe17 DIFF: https://github.com/llvm/llvm-project/commit/e212a4f838f17e2d37b1d572d8c1b49c50d7fe17.diff LO

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. In D134813#3834540 , @aaron.ballman wrote: > In D134813#3834496 , @sammccall > wrote: > >> Sorry, Monday was a holiday here... > > No worries, I hope you had a good holiday! Thanks :-

[clang] b00de4d - [clang][deps] Abolish FileManager sharing

Author: Jan Svoboda Date: 2022-10-04T12:47:22-07:00 New Revision: b00de4dd4156874fd5c163e9cecd69a54e45e083 URL: https://github.com/llvm/llvm-project/commit/b00de4dd4156874fd5c163e9cecd69a54e45e083 DIFF: https://github.com/llvm/llvm-project/commit/b00de4dd4156874fd5c163e9cecd69a54e45e083.diff L

[clang] fb137ad - [clang][deps] NFC: Respect working directory on construction

Author: Jan Svoboda Date: 2022-10-04T12:47:22-07:00 New Revision: fb137adc9b3fa47989fac5cb8a346f0a3a2733bd URL: https://github.com/llvm/llvm-project/commit/fb137adc9b3fa47989fac5cb8a346f0a3a2733bd DIFF: https://github.com/llvm/llvm-project/commit/fb137adc9b3fa47989fac5cb8a346f0a3a2733bd.diff L

[PATCH] D134976: [clang][deps] Abolish FileManager sharing

This revision was automatically updated to reflect the committed changes. Closed by commit rGb00de4dd4156: [clang][deps] Abolish FileManager sharing (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134976/new/ https://review

[PATCH] D134977: [clang][deps] NFC: Respect working directory on construction

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb137adc9b3f: [clang][deps] NFC: Respect working directory on construction (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134977/n

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#3834613 , @sammccall wrote: > In D134813#3834540 , @aaron.ballman > wrote: > >> In D134813#3834496 , @sammccall >> wrote: >> >>

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added reviewers: Bigcheese, thieta. jansvoboda11 added a subscriber: thieta. jansvoboda11 added a comment. Adding @thieta as a reviewer for the MSVC flag change, since it's possible due to his D122976 and D130689 .

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. >> OK, so it sounds like the printing behavior change (not necessarily with a >> policy flag) necessary for diagnostics (make it non-ambiguous/not invalid >> code which is what is currently emitted) would be a good bug fix both for >> diagnostics and for ast-print? I

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465127. void marked 3 inline comments as done. void added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/include/clang/Basic/LangOp

[clang] 2dbfd06 - [Clang] fix -Wvoid-ptr-dereference for gnu89

Author: Nick Desaulniers Date: 2022-10-04T13:01:01-07:00 New Revision: 2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7 URL: https://github.com/llvm/llvm-project/commit/2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7 DIFF: https://github.com/llvm/llvm-project/commit/2dbfd06f2a8ba6cd7cc3f587808f1ea2c61ad2c7.di

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:369-376 +/// Any trailing array memeber is a FAM. +Default = 0, +/// Any trailing array member of undefined, 0, or 1 size is a FAM. +OneZeroOrIncomplete = 1, +/// Any trailing arra

[PATCH] D135090: [Clang] fix -Wvoid-ptr-dereference for gnu89

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbfd06f2a8b: [Clang] fix -Wvoid-ptr-dereference for gnu89 (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135090/new/ https://

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465129. void marked an inline comment as done. void added a comment. Use an already available context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/inc

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added inline comments. Comment at: clang/include/clang/Driver/Options.td:1155 + NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, + NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "Incomplete"]>, HelpText<"Enable optimizations bas

[clang] 1651289 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-10-04T20:03:36Z New Revision: 16512898956857b13e566165ba9a195be81d325f URL: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f DIFF: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f.diff LOG:

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG165128989568: [clang] fix generation of .debug_aranges with LTO (authored by azat, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. In D135011#3831452 , @craig.topper wrote: > Does these support scalable vector types from ARM SVE or RISC-V? I can't > remember what the rest of the __builtin_elementwise do. I ask because the > backends will probably crash fo

[PATCH] D135191: [Index] USRGeneration doesn't depend on unnamed.printName() => ''. NFC

sammccall created this revision. sammccall added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This prepares for printName() to print `

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ https://reviews.llvm.org/D135062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. In D134813#3834613 , @sammccall wrote: > Changing USR generation to not rely on this detail seems easier, I can take a > stab at this. Seems trivial: https://reviews.llvm.org/D135191 If there are still diffs in USR tests after

[clang-tools-extra] 77945a3 - [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

Author: Michał Górny Date: 2022-10-04T22:12:37+02:00 New Revision: 77945a344c3dee3f9735744c8d4151ef2cec6a8d URL: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d DIFF: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d.diff

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG77945a344c3d: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ h

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465134. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rs

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1019 +// sourcelocation-against-bounds comparison. +FileID BeginFID = SM.getFileID(BeginLoc); +SourceLocation Limit = sammccall wrote: > this getFileID() call is unneccesa

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1c1d6d7287: MSVC AArch64 ABI: Homogeneous aggregates (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134688/new/ https://reviews.llv

[clang] 2e1c1d6 - MSVC AArch64 ABI: Homogeneous aggregates

Author: David Blaikie Date: 2022-10-04T20:17:29Z New Revision: 2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 URL: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 DIFF: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130.diff LOG:

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Here is the code I used to test the machine code output: typedef float float4 __attribute__((ext_vector_type(4))); void test_builtin_elementwise_sin(float f1, float f2, double d1, double d2, float4 vf1, float4 vf2) { f2 = __builtin_elementwise_sin(f1);

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2817-2818 + void MaybeParseHLSLSemantics(Declarator &D, + SourceLocation *EndLoc = nullptr) { +if (Tok.is(tok::colo

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added a comment. In D20401#3833201 , @hokein wrote: >>> Meanwhile, I think besides evaluating the high level logic in in TokenLexer >>> and how it might be improved, I think there's potentially an opportunity >>> for a "AOS vs. SOA" speed

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added a comment. In D135118#3833978 , @steven_wu wrote: > LGTM. > > `RemoveDecl` does become more expensive but I don't have better solution. Luckily AFAICT this is not a "hot" function. > I am also wondering if as follow up we should add an opt

[clang] 4769976 - MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

Author: David Blaikie Date: 2022-10-04T20:19:17Z New Revision: 4769976c49be468d7629d513080e6959a25adcfe URL: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe DIFF: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe.diff LOG:

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4769976c49be: MSVC ABI: Looks like even non-aarch64 uses the MSVC/

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:1091 virtual void collectPropertiesToImplement(PropertyMap &PM, PropertyDeclOrder &PO) const {} benlangmuir wrote: > Can we use the exi

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added a comment. In D135011#3834739 , @bob80905 wrote: > Here is the code I used to test the machine code output: > > typedef float float4 __attribute__((ext_vector_type(4))); > > void test_builtin_elementwise_sin(float f1, float f2, do

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#3834710 , @sammccall wrote: > In D134813#3834613 , @sammccall > wrote: > >> Changing USR generation to not rely on this detail seems easier, I can take >> a stab at this

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The help text in ClangFormat.cpp for the `--files` option needs to be updated the same way. Note using `cl::value_desc("filename")` is what you need to change the meta-variable in the help output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/test/CodeGen/amdgcn-control-constants.c:8 + +// GFX90A: @__oclc_daz_opt = linkonce_odr hidden local_unnamed_addr addrspace(4) constant i8 0, align 1 +// GFX90A: @__oclc_wavefrontsize64 = linkonce_odr hidden local_unnamed_addr addr

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added a comment. In D134453#3834659 , @dblaikie wrote: >>> OK, so it sounds like the printing behavior change (not necessarily with a >>> policy flag) necessary for diagnostics (make it non-ambiguous/not invalid >>> code which is what is c

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465151. ychen added a comment. - make corresponding change in the commandline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst clan

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465152. craig.topper marked 2 inline comments as done. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When CurrentLoadedOffset is less than TotalSize, current code will trigger unsigned overflow and will not return an

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 465158. dblaikie added a comment. rebase and fix an AST test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.h clang

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 465159. dblaikie added a comment. Remove Microsoft return ABI test, now that the Microsoft ABI implementation no longer depends on the AST isPOD property Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/ne

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3747673 , @rnk wrote: > In D119051#3747201 , @dblaikie > wrote: > >> So... my conclusion is that Clang's AArch64 appears to be correct for x86 >> as well, and we should just

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie updated this revision to Diff 465161. dblaikie added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/cla

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465162. craig.topper added a comment. Use TT.isRISCV64() in AutoUpgrade.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISC

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2029-2036 // The align if the field is not packed. This is to check if the attribute // was unnecessary (-Wpacked). CharUnits UnpackedFieldAlign = !DefaultsToAIXPowerAlignment ? Fiel

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

beanz added inline comments. Comment at: clang/docs/HLSL/HLSLSupport.rst:98 +``HLSLExternalSemaSource`` will create new decls and use the old decls as +argument for setPreviousDecl. + We can probably generalize this to something like: ``` When precompiled headers

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. In D134813#3834776 , @aaron.ballman wrote: > Thank you for this! I applied D135191 over > the top of my changes here and ran the tests to get all the new failures with > the changes, then I

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

jdoerfert created this revision. jdoerfert added reviewers: aaron.ballman, faisalv. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. There is no reason (o

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465165. craig.topper added a comment. Add requested comment to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h l

[clang] eed92a9 - [NFC] Fix warning wiht parens in assert from 1376c7

Author: Erich Keane Date: 2022-10-04T14:33:36-07:00 New Revision: eed92a99ddfc411b7b78847b8c0ca30f624d8c7d URL: https://github.com/llvm/llvm-project/commit/eed92a99ddfc411b7b78847b8c0ca30f624d8c7d DIFF: https://github.com/llvm/llvm-project/commit/eed92a99ddfc411b7b78847b8c0ca30f624d8c7d.diff L

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. Anyone wants to take a look/stamp? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. Relatedly, if we put this POD behavior query on TargetInfo, I wonder if it makes sense to move the tail padding predicate from TargetCXXABI to TargetInfo: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/TargetCXXABI.h#L282 The switch there is basical

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4151 + QualType T = Entity.getType(); + // FIXME: Union is unsupported. + int InitKind = T->isArrayType() ? 0 : 4; Hmm...it seems like as is this patch generates the correct code

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added a reviewer: asl. beanz added a subscriber: asl. beanz added a comment. +@asl for codegen owner perspective. This LGTM too. The changes here are well isolated to HLSL, so they should have no adverse impact on other language support. @efriedma, @asl & @rjmccall any feedback? Reposit

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

dblaikie added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; jcranmer-intel wrote: > aaron.ballman wrot

<    1   2   3   >