[PATCH] D134020: [clang][Interp] Handle enums

tbaeder updated this revision to Diff 462826. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134020/new/ https://reviews.llvm.org/D134020 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/enums.cpp Index: clang/test/AST/I

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm updated this revision to Diff 462833. david-arm added a comment. - Added SVE2BITPERM to AArch64TargetParser.def and updated the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 Files: clang/docs/ReleaseNotes.rst clang/t

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

david-arm marked 3 inline comments as done. david-arm added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:239 +AARCH64_CPU_NAME("neoverse-v2", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_SVE | AArch64::AEK_SVE2 | AArch64::AEK_

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 462838. JonasToth added a comment. - remove unproductive check-fixes line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 Files: clang-tools-extra/clang-tidy/misc

[clang-tools-extra] e66345d - [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

Author: Jonas Toth Date: 2022-09-26T10:39:11+02:00 New Revision: e66345d54d5f5e803f54c1ace487d57bb11ee884 URL: https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884 DIFF: https://github.com/llvm/llvm-project/commit/e66345d54d5f5e803f54c1ace487d57bb11ee884.diff LO

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe66345d54d5f: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is… (authored by JonasToth). Repository: rG LLVM Github Mon

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 added a comment. In D134454#3812153 , @nickdesaulniers wrote: > Is it worth contacting the package maintainer for LLVM+clang for Arch-Linux > in regards to this patch? Yes, thanks for the suggestion, I will open an issue on the Arch bug tracker

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ilya-biryukov added subscribers: ChuanqiXu, ilya-biryukov. ilya-biryukov added a reviewer: ChuanqiXu. ilya-biryukov added a comment. LGTM. I believe the standard is clear here, the declaration inside `export` does not have any special treatment in terms of how it must be parsed. @ChuanqiXu could

[clang] 75e90ea - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: Simon Pilgrim Date: 2022-09-26T10:27:38+01:00 New Revision: 75e90ea7668fc5a7cc7fbae13070bf8558f884de URL: https://github.com/llvm/llvm-project/commit/75e90ea7668fc5a7cc7fbae13070bf8558f884de DIFF: https://github.com/llvm/llvm-project/commit/75e90ea7668fc5a7cc7fbae13070bf8558f884de.diff

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ff836a138b4: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 4ff836a - [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

Author: Tomasz Kamiński Date: 2022-09-26T11:39:10+02:00 New Revision: 4ff836a138b40a9fc3430bc08afc1f327e5ed281 URL: https://github.com/llvm/llvm-project/commit/4ff836a138b40a9fc3430bc08afc1f327e5ed281 DIFF: https://github.com/llvm/llvm-project/commit/4ff836a138b40a9fc3430bc08afc1f327e5ed281.dif

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 added inline comments. Comment at: clang/lib/Driver/Distro.cpp:213 + // that the Linux OS and distro are properly detected in this cases. + llvm::Triple NormTargetOrHost = llvm::Triple(Twine(TargetOrHost.normalize())); + nickdesaulniers wrote: > Twine ha

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:377-394 + if (Distro.IsArchLinux()) { +std::string Path = (InstallDir + "/../../../../" + TripleStr).str(); +if (getVFS().exists(Path)) + return Path; + } + if (!GCCInstallation.isVa

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. > Do users have some other escape hatch to tell PGO "ignore what you think you > know about this branch" so that a user who *wants* PGO to lose has some > ability to do that other than "don't use PGO"? Sounds like we need another proposal for [[always_likely]] :)

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

hans added a comment. This also fires in non-array cases: $ cat /tmp/a.cc struct T0 { char c; }; struct T2 : virtual T0 { }; T2* f() { return new T2(); } $ /work/llvm-project/build/bin/clang++ -c -target i686-pc-win32 /tmp/a.cc /tmp/a.cc:4:22: error: size of array element of typ

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle created this revision. nhaehnle added reviewers: kito-cheng, khchen, MaskRay, aaron.ballman, DavidSpickett. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

mstorsjo added a comment. Nice, +1 this looks reasonable to me. I've run into similar issues occasionally with mingw builds with dylib enabled too, where (depending on how the linker ends up pulling in objects) you can end up with duplicate definitions etc. I would expect that this also fixes t

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3814628 , @AntonBikineev wrote: >> Do users have some other escape hatch to tell PGO "ignore what you think you >> know about this branch" so that a user who *wants* PGO to lose has some >> ability to do that o

[clang] 91babd3 - Update the status of a few more C99 DRs

Author: Aaron Ballman Date: 2022-09-26T08:20:56-04:00 New Revision: 91babd351665e867c9cc4be22bc3daee8f639942 URL: https://github.com/llvm/llvm-project/commit/91babd351665e867c9cc4be22bc3daee8f639942 DIFF: https://github.com/llvm/llvm-project/commit/91babd351665e867c9cc4be22bc3daee8f639942.diff

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

sgraenitz updated this revision to Diff 462871. sgraenitz added a comment. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Follow Reid's advice from https://github.com/llvm/llvm-project/issues/56952#issuecomment-122565 and fix the instruction sequence expanded from CALL_R

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! You might want to extend the windows check lines to the other tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/ne

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin, wangleiat, gonglingqin. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subsc

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. > No, it sounds like we need a proposal for > `[[likely_unless_the_optimizer_decides_otherwise]]` -- the `[[likely]]` > attribute was intended for always-likely optimization decisions. Well, whatever the default behavior is chosen. > I agree that we should be c

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. The test cases look good to me. We should be pretty close to passing `ninja check` natively. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Herald added a project: All. In D106005#2904865 , @SaurabhJha wrote: > In D106005#2904424 , @fhahn wrote: > >> In D106005#2896080 , @SaurabhJha >>

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

erichkeane added subscribers: aaron.ballman, erichkeane. erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thanks for looking into it. I think you're right that it is a mistake that we accepted that without the 'struct' keyword after

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Thanks for looking into it. I think you're right that it is a mistake that we accepted that without the 'struct' keyword after a quick look, so I think I am OK with this. Please give @

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

erichkeane added a comment. Er... please dont' count that 'accept', let @ChuanqiXu be the approver here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134578/new/ https://reviews.llvm.org/D134578 ___ cfe

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

t.p.northover created this revision. t.p.northover added a reviewer: abrachet. Herald added a subscriber: mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. There are lots of options interacting

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

ldionne added a comment. As explained in more details here (https://reviews.llvm.org/D133249#inline-1289205), it would be nice to stop using the `DELETE.ME` idiom to kick off libc++ CI, unless you really think there's a good chance to cause failures in libc++ specifically. TLDR of the link: th

[PATCH] D134523: [clang][Interp] Fix copy constructors with record array members

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:332 + // ArrayIndex might not be set if a ArrayInitIndexExpr is being evaluated + // stand-alone, e.g. via EvaluateAsInt(). + if (!ArrayIndex) For my edification: what repro

[clang] e3d14be - [Concepts] Recover properly from a RecoveryExpr in a concept

Author: Erich Keane Date: 2022-09-26T06:33:48-07:00 New Revision: e3d14bee238b672a7a112311eefee55e142eaefc URL: https://github.com/llvm/llvm-project/commit/e3d14bee238b672a7a112311eefee55e142eaefc DIFF: https://github.com/llvm/llvm-project/commit/e3d14bee238b672a7a112311eefee55e142eaefc.diff L

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3814111 , @ahatanak wrote: > In D86049#3812412 , @plotfi wrote: > >> In D86049#3812068 , @ahatanak wrote: >> >>> In D86049#3806898

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added a subscriber: sammccall. davrec added a comment. My concerns have been addressed, except for some more nitpicking on names which I think are uncontroversial. Regarding the modules breakage found by @ChuanqiXu: > Well we touch FunctionTemplates and VariableTemplates in this patch, b

[PATCH] D134640: Unwind-tables: move back to original logic outline for kind.

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134640/new/ https://reviews.llvm.org/D134640 _

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

aaron.ballman added a comment. In D134456#3814820 , @AntonBikineev wrote: >> No, it sounds like we need a proposal for >> `[[likely_unless_the_optimizer_decides_otherwise]]` -- the `[[likely]]` >> attribute was intended for always-likely optimization d

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

sgraenitz added a comment. In D134441#3814794 , @fhahn wrote: > LGTM, thanks! You might want to extend the windows check lines to the other > tests as well. Thanks. Yes thought about that, but not all of them match the typical IR output on Windows (gxx

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3707 ToFunction->setRangeEnd(ToEndLoc); + ToFunction->setDefaultLoc(D->getDefaultLoc()); This should be imported very similarly to `EndLoc`. Repository: rG LLVM Github Monorepo CH

[clang] 192d69f - Revert "[Concepts] Recover properly from a RecoveryExpr in a concept"

Author: Erich Keane Date: 2022-09-26T06:55:25-07:00 New Revision: 192d69f7e65a625e344421841e731e39f80595f5 URL: https://github.com/llvm/llvm-project/commit/192d69f7e65a625e344421841e731e39f80595f5 DIFF: https://github.com/llvm/llvm-project/commit/192d69f7e65a625e344421841e731e39f80595f5.diff L

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. Hi @aaron.ballman, I've noticed in the linux kernel, type alignment was implemented by a tricky way using offsetof. #define TYPE_ALIGN(TYPE) offsetof(struct { char x; TYPE test; }, test) Does this always has the same semantic with C11 `_Alignof`? If this is not true,

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

davrec added a comment. > I will give an example using a Typedef for exposition, but the same > motivation applies with UsingType. > > Say we have this code: > > template struct A { using type1 = T; }; > using Int = int; > > using type2 = A::type1; > > See this example live (with that

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3780579 , @dblaikie wrote: > Yeah, that might be a way forward - splitting the warning in two - have one level that's the current even-in-system-headers behavior, then a subset that's the GCC-behavior. (probab

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz updated this revision to Diff 462898. rmaz added a comment. remove else case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 Files: clang/include/clang/AST/Type.h clang/unittests/AST/DeclTest.cpp

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

urnathan added a comment. Richard & I discussed this, and decided it was a bad idea, as it means we could have an O(N^2) initialization walk, rather than O(N). IIUC this is being motivated by NVPTX, which cannot support dynamically initialized global vars. But in that case we know all the glob

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

hans added a comment. In D134468#3812846 , @MaskRay wrote: > I am not a Windows driver user. This patch is entirely motivated by Windows > discussions in D131465 and I want to make > `/std:` default rule simple (say, c

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

martong accepted this revision. martong added a reviewer: whisperity. martong added a subscriber: whisperity. martong added a comment. This revision is now accepted and ready to land. We had a discussion about this with @dkrupp . We think that the `p = realloc(p, var)` construct in itself is an e

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

hans added a comment. Well it has to adapt to MSVC's library files, so it can't always do the same regardless of version. Given that MSVC has supported /std:c++17 for a while, it's probably safe to bump the default, but perhaps not for all versions. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains planned changes to this revision. iains added a comment. So, in light of these comments; - It seems that there is one case where I //can// elide the guard - where the init is completely empty (including of calls to imported module inits) - otherwise, I need to investigate what is needed fo

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a subscriber: nickdesaulniers. aaron.ballman added a comment. In D133574#3815105 , @inclyc wrote: > Hi @aaron.ballman, I've noticed in the linux kernel, type alignment was > implemented by a tricky way using offsetof. > > #define TY

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3279 bool IsTypeSpecifier, bool IsTemplateParamOrArg, + bool IsWithinOffsetOf, bool IsOffsetOfInMacro, SkipBodyInfo *SkipBody = nullptr);

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. This warning is quite noisy for the Linux kernel due to a couple of places where a `void *` is dereferenced as part of compile time checking. My original commentary is available on our GitHub issue track

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak added a comment. Thanks for reporting the bug. `Sema::CheckAllocatedType` can be called when the allocated type isn't an array, so `checkArrayElementAlignment` shouldn't be called in that function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

sepavloff added a comment. In D134337#3813798 , @mgorny wrote: > In D134337#3813779 , @sepavloff > wrote: > >> First clang tries to find `x86_64-pc-linux-gnu-clang.cfg`. Just tool name >> with added suffix `cfg`

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. related kernel patch https://lkml.org/lkml/2022/9/26/1484 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list c

[clang] 684a789 - Reapply "[Concepts] Recover properly from a RecoveryExpr in a concept"

Author: Erich Keane Date: 2022-09-26T08:39:10-07:00 New Revision: 684a78968bd32b0ece5b852bcaa21dbc49a4b5b0 URL: https://github.com/llvm/llvm-project/commit/684a78968bd32b0ece5b852bcaa21dbc49a4b5b0 DIFF: https://github.com/llvm/llvm-project/commit/684a78968bd32b0ece5b852bcaa21dbc49a4b5b0.diff L

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

This revision was automatically updated to reflect the committed changes. Closed by commit rG684a78968bd3: Reapply "[Concepts] Recover properly from a RecoveryExpr in a concept" (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D134542?vs

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added a comment. In D125683#3811492 , @nikic wrote: > I have some concerns about this change: > > - It makes it fundamentally impossible to link against a static > system-libcxxabi (or any other `LIBCXX_CXX_ABI` option). This is currently > alre

[PATCH] D134650: [runtimes] Remove all traces of the legacy testing configuration system

ldionne created this revision. Herald added subscribers: libcxx-commits, mstorsjo, arichardson. Herald added projects: libunwind, All. Herald added a reviewer: libunwind. ldionne requested review of this revision. Herald added projects: clang, libc++, libc++abi. Herald added a subscriber: cfe-commi

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

Matt added a comment. OK, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134352/new/ https://reviews.llvm.org/D134352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3815339 , @sepavloff wrote: > In D134337#3805368 , @mgorny wrote: > >> For target, it will try: >> >> 1. `i386.cfg` (effective triple) >> 2. `i386-pc-linux-gnu.cfg` ("fixed" pref

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3279 bool IsTypeSpecifier, bool IsTemplateParamOrArg, + bool IsWithinOffsetOf, bool IsOffsetOfInMacro, SkipBodyInfo *SkipBody = nullptr); -

[clang] 53c3664 - [xmm] Remove duplicate #define

Author: Nathan Sidwell Date: 2022-09-26T08:59:55-07:00 New Revision: 53c3664f674cc2f33c8214f493c2c17ce9b4d466 URL: https://github.com/llvm/llvm-project/commit/53c3664f674cc2f33c8214f493c2c17ce9b4d466 DIFF: https://github.com/llvm/llvm-project/commit/53c3664f674cc2f33c8214f493c2c17ce9b4d466.diff

[PATCH] D134545: [xmm] Remove duplicate #define

This revision was automatically updated to reflect the committed changes. Closed by commit rG53c3664f674c: [xmm] Remove duplicate #define (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added subscribers: EricWF, rsmith. dblaikie added a comment. In D133425#3815118 , @aaron.ballman wrote: > In D133425#3780579 , @dblaikie > wrote: > >> > > Yeah, that might be a way forward - splitting

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:307 + /// decltype(s) will be printed as "S" if enabled and as "S<{1,2}>" if disabled, + /// regardless if PrintCanonicalTypes is enabled. + unsigned AlwaysIncludeTypeForNonTypeTemplateArgumen

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a subscriber: rsmith. dblaikie added a comment. > This also tries to fix the problem I raised a year ago: > https://discourse.llvm.org/t/make-command-line-support-for-c-20-module-uniform-with-gcc/59144 I think this thread is fairly different from what this patch is proposing. @rs

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

aaron.ballman added a comment. In D134461#3815298 , @nathanchance wrote: > This warning is quite noisy for the Linux kernel due to a couple of places > where a `void *` is dereferenced as part of compile time checking. Thank you for letting us know! >

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 462940. inclyc added a comment. Address comments from @aaron.ballman Move `OffsetOfKind` to `Sema` and pass it to `Sema:ActOnTag` directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://revi

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 462942. inclyc added a comment. Fix comment nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D134652: [clang-format] Add Really Basic Carbon Support/Infrastructure

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: chandlerc, HazardyKnusperkeks, owenpan, curdeius, klimek. MyDeveloperDay added projects: clang-format, clang. Herald added a project: All. MyDeveloperDay requested review of this revision. Its great when clang-format is the ubi

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

nathanchance added a comment. In D134461#3815458 , @aaron.ballman wrote: > What do folks think of that idea? I think that all sounds reasonable to me (although I am far from an authority on these matters). As far as I understand it, the kernel cannot u

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi updated this revision to Diff 462944. plotfi added a comment. Updated based on @ahatanak's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 Files: clang/include/clang/AST/DeclObjC.h clan

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak updated this revision to Diff 462938. ahatanak added a comment. Check whether the allocated type is an array type before calling `checkArrayElementAlignment`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.

[PATCH] D134653: [clang][modules] Over-align the `Module` class

jansvoboda11 created this revision. jansvoboda11 added reviewers: srj, mgorny, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes `llvm::Point

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 462948. jhuber6 added a comment. Adding an extra check in `CodeGenAction.cpp` that forcibly internalizes these if we link in any modules in RDC mode. This is a considerable hack, but should solve the problem. It's not a great solution, so let me know if you

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Need to add Zcd command lines to compress-rv32d.s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://review

[PATCH] D134176: Add MC support of RISCV Zcf Extension

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Need to add zcf command lines to compress-rv32f.s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://review

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

nickdesaulniers added a comment. In D134461#3815458 , @aaron.ballman wrote: > In D134461#3815298 , @nathanchance > wrote: > >> This warning is quite noisy for the Linux kernel due to a couple of places >> where

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha abandoned this revision. SaurabhJha added a subscriber: Florian. SaurabhJha added a comment. > @SaurabhJha did you ever get a chance to create a patch? Hey @Florian, sorry I dropped the ball here. I don't think I would be able to spend time on this so abandoning this revision. Repos

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

aaron.ballman added a comment. In D134461#3815502 , @nathanchance wrote: > In D134461#3815458 , @aaron.ballman > wrote: > >> What do folks think of that idea? > > I think that all sounds reasonable to me (althou

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

erichkeane added a comment. FWIW, I think the idea of allowing dereference of `void*` in an unevaluated context seems somewhat sensible, if sad. I suspect the kernel is not the only place to do this foolishness and take advantage of the extensions we/gcc permit for the `void` type. So I'll sa

[clang] 1f451a8 - [clang] initialize type qualifiers for FunctionNoProtoType

Author: Richard Howell Date: 2022-09-26T09:48:54-07:00 New Revision: 1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689 URL: https://github.com/llvm/llvm-project/commit/1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689 DIFF: https://github.com/llvm/llvm-project/commit/1f451a8bd6f32465b6ff26c30ba7fb6fc7e0e689.diff

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f451a8bd6f3: [clang] initialize type qualifiers for FunctionNoProtoType (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. I've just investigated this patch deeply. I think we have wrong logic here. Assume we have `(int)(short)(int x)`. `VisitSymbolCast` will try to get the constant recursively in th

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/new/ https://reviews.llvm.org/D134441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:116 {"zca", RISCVExtensionVersion{0, 70}}, +{"zcb", RISCVExtensionVersion{0, 70}}, +{"zcmp", RISCVExtensionVersion{0, 70}}, Why is `zcb` mixed into this patch? ==

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added a comment. How did the original change pass presubmit testing -- is LLVM no longer testing on 32-bit targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134653/new/ https://reviews.llvm.org/D134653 ___

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

efriedma added a comment. Please try to avoid uploading multiple independent patches into the same revision; it's confusing for anyone who comes looking for the review of the initial patch, and only finds the followup. That said, fix looks fine, sure. Repository: rG LLVM Github Monorepo CH

[PATCH] D134652: [clang-format] Add Really Basic Carbon Support/Infrastructure

MyDeveloperDay updated this revision to Diff 462959. MyDeveloperDay added a comment. Ensure the colon stick with the variable declaraion for (var name: String in names) { Console.Print(name); } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134652/new/ https://reviews.llvm.org

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

nikic added a comment. In D125683#3815348 , @ldionne wrote: > In D125683#3811492 , @nikic wrote: > >> I have some concerns about this change: >> >> - It makes it fundamentally impossible to link against a static

[PATCH] D134653: [clang][modules] Over-align the `Module` class

jansvoboda11 added a subscriber: ms178. jansvoboda11 added a comment. Pre-commit CI only runs on x64 Debian and x64 Windows. I don't have good way to reproduce the issue, so ideally the person who reported it (@ms178?) steps up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov added a comment. In D134604#3814986 , @ldionne wrote: > As explained in more details here > (https://reviews.llvm.org/D133249#inline-1289205), it would be nice to stop > using the `DELETE.ME` idiom to kick off libc++ CI, unless you really think

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rv32zcmt-Invalid.s:5 +# CHECK-ERROR: error: immediate must be an integer in the range [0, 63] +cm.jt 64 Why no invalid test for cm.jalt? Comment at: llvm/test/MC/RISCV/rv32zcmt-

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added inline comments. Comment at: clang/include/clang/Basic/Module.h:96 /// Describes a module or submodule. -class Module { +class alignas(8) Module { public: Probably worth a comment here, it's not necessarily obvious to the reader that this is to fix a

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added a comment. In D134653#3815627 , @jansvoboda11 wrote: > Pre-commit CI only runs on x64 Debian and x64 Windows. I don't have good way > to reproduce the issue, so ideally the person who reported it (@ms178?) steps > up. I'm the one who reporte

[PATCH] D134653: [clang][modules] Over-align the `Module` class

srj added a comment. In D134653#3815627 , @jansvoboda11 wrote: > Pre-commit CI only runs on x64 Debian and x64 Windows. I don't have good way > to reproduce the issue, so ideally the person who reported it (@ms178?) steps > up. FYI, adding this patch

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

ychen created this revision. ychen added reviewers: MaskRay, probinson. Herald added subscribers: StephenFan, inglorion. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So the behavior is consistent with n

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:635 + // Setup crash diagnostics dir. + if (Args.hasArg(options::OPT_fcrash_diagnostics_dir)) { +StringRef

[PATCH] D134653: [clang][modules] Over-align the `Module` class

jansvoboda11 updated this revision to Diff 462965. jansvoboda11 added a comment. Document reason for `alignas`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134653/new/ https://reviews.llvm.org/D134653 Files: clang/include/clang/Basic/Module.h

[PATCH] D134653: [clang][modules] Over-align the `Module` class

jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. In D134653#3815672 , @srj wrote: > FYI, adding this patch to my local build does allow me to *compile* properly > now. I haven't tested for correctness. Thanks for verifying th

  1   2   3   >