erichkeane added inline comments.
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:332 + // ArrayIndex might not be set if a ArrayInitIndexExpr is being evaluated + // stand-alone, e.g. via EvaluateAsInt(). + if (!ArrayIndex) ---------------- For my edification: what reproducer causes us to do this? ================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:665 + // Narrow to our array element and recurse into visitInitializer() + if (!this->emitConstSint32(I, SubExpr)) + return false; ---------------- So why are these signed-int32? Indexes are 64 bit on 64 bit machines, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134523/new/ https://reviews.llvm.org/D134523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
