[PATCH] D111283: [clang] template / auto deduction deduces common sugar

alexfh added a comment. In D111283#3786678 , @mizvekov wrote: > @alexfh This new revision that I just pushed should be good. > > Do you want to give it a look / test, or should we go ahead and merge it? Thanks for the fix! If it fixes the test case I pro

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460587. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 460588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 460589. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index: c

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 460590. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTempl

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 460591. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 460592. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/lib/AST/ASTContext.

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 460593. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov updated this revision to Diff 460594. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 460595. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypePr

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ aaron.ballman wrote: > inclyc wrote: > > inclyc wrote: > > > aaron.ballman wrote: > >

[clang] 3eca0b3 - [lit] Set shlibpath_var on OpenBSD

Author: Brad Smith Date: 2022-09-15T21:43:54-04:00 New Revision: 3eca0b395ff07d0428f4179e33a6ae295e608f47 URL: https://github.com/llvm/llvm-project/commit/3eca0b395ff07d0428f4179e33a6ae295e608f47 DIFF: https://github.com/llvm/llvm-project/commit/3eca0b395ff07d0428f4179e33a6ae295e608f47.diff LO

[clang] d6aed77 - [InstrProfiling] No runtime hook for unused funcs

Author: Gulfem Savrun Yeniceri Date: 2022-09-16T02:05:09Z New Revision: d6aed77f0d19664be48d531552692520ae2a6f1a URL: https://github.com/llvm/llvm-project/commit/d6aed77f0d19664be48d531552692520ae2a6f1a DIFF: https://github.com/llvm/llvm-project/commit/d6aed77f0d19664be48d531552692520ae2a6f1a.d

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 9e1c1ec - [HIP][test] Avoid %T

Author: Fangrui Song Date: 2022-09-15T19:58:42-07:00 New Revision: 9e1c1ecb148eb4e530467e178973e870945e6602 URL: https://github.com/llvm/llvm-project/commit/9e1c1ecb148eb4e530467e178973e870945e6602 DIFF: https://github.com/llvm/llvm-project/commit/9e1c1ecb148eb4e530467e178973e870945e6602.diff

[PATCH] D133998: [HIP][test] Avoid %T

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e1c1ecb148e: [HIP][test] Avoid %T (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D133998?vs=460569&id=460608#toc Reposi

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

MaskRay added a comment. In the long term we should just remove the `CLANG_INSTALL_LIBDIR_BASENAME` customization. This is supposed for GCC multilib lib32 lib64 names but we don't necessarily use it for Clang + compiler-rt files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134007: [Clang][CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder.

Jimerlife created this revision. Jimerlife added reviewers: sfantao, tra, ABataev, benshi001. Jimerlife added a project: LLVM. Herald added subscribers: mattd, yaxunl. Herald added a project: All. Jimerlife requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskR

[PATCH] D133954: [clang-format] Fix template arguments in macros

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9793-9795 + verifyFormat("#define FOO(typeName, realClass) " + "\\\n" + " { #typeName, foo

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

MaskRay added a comment. Both D54214 and this look like a surprising behavior to me. Do we still have time to go back the state before D54214 and make mismatching --target & -march= an error? > clang -target=riscv32-- -march=r

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

jrtc27 added a comment. In D129824#3794221 , @MaskRay wrote: > Both D54214 and this look like a surprising > behavior to me. Do we still have time to go back the state before D54214 > a

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

MaskRay added a comment. In D129824#3794229 , @jrtc27 wrote: > In D129824#3794221 , @MaskRay wrote: > >> Both D54214 and this look like a >> surprising behavior to me. Do we stil

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. AFAIK, --target is clang-specific and transparent for compiler user in RV side. -m is also undefined or less used by RV user. It just uses -march to specify 32 or 64 mode and extensions. Is the convention specified in RV Spec? CHANGES SINCE LAST ACTION https://revi

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM. Give it a few days in case @rjmccall have comments. Comment at: clang/test/SemaCXX/coroutine-alloc-4.cpp:49 +void return_value(int) {} +void *operator new(std::si

[clang] 45b85ae - [Driver][test] Disable hip-link-bc-to-bc.hip

Author: Fangrui Song Date: 2022-09-15T21:41:18-07:00 New Revision: 45b85aebdbb08fed26cb5976401cddcf51625533 URL: https://github.com/llvm/llvm-project/commit/45b85aebdbb08fed26cb5976401cddcf51625533 DIFF: https://github.com/llvm/llvm-project/commit/45b85aebdbb08fed26cb5976401cddcf51625533.diff

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/coroutine-alloc-4.cpp:49 +void return_value(int) {} +void *operator new(std::size_t, std::align_val_t) noexcept; +void *operator new(std::size_t) noexcept; ychen wrote: > ChuanqiXu wrote:

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

dblaikie updated this revision to Diff 460637. dblaikie marked an inline comment as done. dblaikie added a comment. Add the three test cases. Verified they failed without the patch and pass with it. Testing them across all the Windows ABI variants, since they seem to apply equally. Repository:

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder added a comment. I can see that `HandleSizeOf()` uses 1 for void and function types as a gcc extension, but I can't reproduce that: https://godbolt.org/z/njG9zh6PM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 +return this->emitConst( +E, Ctx.get

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

tbaeder updated this revision to Diff 460648. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133934/new/ https://reviews.llvm.org/D133934 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Opco

[PATCH] D133991: add new function to release notes

tbaeder added a comment. In D133991#3793762 , @anderslanglands wrote: > Sorry, this was supposed to update https://reviews.llvm.org/D13392. How do I > delete this? At the bottom of the page, there's a drop-down right above the comment textview. Select

[PATCH] D133924: add clang_CXXMethod_isDeleted function

tbaeder added a comment. Looks like the new version you uploaded is //only// the changes to the last version. You need to merge that into your previous commit and upload a patch of that. (e.g. using `git rebase -i` or even just `git commit --amend`). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

dblaikie added a subscriber: majnemer. dblaikie added a comment. In D133817#3790057 , @rnk wrote: > Thanks! > >> But I had >> trouble figuring out how to exercise this functionality properly to add >> test coverage and then compare that to MSVC itself...

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

tbaeder updated this revision to Diff 460654. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 Files: clang/lib/AST/Interp/InterpStack.h Index: clang/lib/AST/Interp/InterpStack.h =

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added a comment. In D132461#3793634 , @njames93 wrote: > In D132461#3773792 , @carlosgalvezp > wrote: > >> @njames93 Friendly ping. The patch has addressed all comments and remained >> unchanged fo

[PATCH] D133941: [clang][Interp] Record item types in InterpStack

junaire added a comment. Do you think `std::is_same_v` will be even better? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133941/new/ https://reviews.llvm.org/D133941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

<    1   2   3