[PATCH] D133634: [clang] Allow vector of BitInt

craig.topper added subscribers: efriedma, craig.topper. craig.topper added a comment. I'm a little nervous about non-byte-sized non-power of 2 elements. The memory layout handling gets a little weird in the backend. @efriedma what do you think? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15881 +/// Check whether this array fits the idiom of a flexible array member, +/// depending on -fstrict-flex-array value /// depending on the value of -fstrict-flex-array value.

[PATCH] D133725: Searching for tokens including comments

aaron.ballman added a comment. Can you help me understand the expected use for these change? Comment at: clang/lib/Lex/Lexer.cpp:1278 - const char *TokenBegin = File.data() + LocInfo.second; + const char *const TokenBegin = File.data() + LocInfo.second; D

[PATCH] D133635: [clang-format] Don't insert braces for loops with a null statement

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25370 + "#if 0\n" + " if (a) {\n" + "#else\n" sstwcw wrote: > Can you confirm that there is supposed to be only one space here while there

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

probinson added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:7 +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=PLUGIN_GARANGE %s +// GARANGE: -generate-arange-section +// PLUGIN_GARA

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:362 +// allow this as an extension. +if (AllowImplicitTypename == ImplicitTypenameContext::No && +!isClassName && !IsCtorOrDtorName) Status update: This line is cur

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cor3ntin added subscribers: ChuanqiXu, cor3ntin. cor3ntin added a comment. Maybe @ChuanqiXu Can help as it seems module related Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 __

[PATCH] D133920: [X86][fastcall] Move capability check before free register update

hans added a comment. Instead of just referring to the bug in the commit message, can you add some text explaining the effects of this change, e.g. on the `__fastcall void f(unsigned long long a, int b, int c)` function in the bug and that this matches MSVC? Did you double check whether this m

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ inclyc wrote: > inclyc wrote: > > aaron.ballman wrote: > > > inclyc wrote: > >

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

Abramo-Bagnara reopened this revision. Abramo-Bagnara added a comment. These changes introduce a subtle bug in template instantiation of newly added ElaboratedType around TypedefType: bool refersInstantiatedDecl(QualType T) in SemaTemplateInstantiate.cpp does not handle this ElaboratedType corr

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3792825 , @Abramo-Bagnara wrote: > These changes introduce a subtle bug in template instantiation of newly added > ElaboratedType around TypedefType: > > bool refersInstantiatedDecl(QualType T) in SemaTemplateInstant

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin added a comment. In D133583#3792625 , @aaron.ballman wrote: > In D133583#3780460 , @yronglin > wrote: > >> Hi, follow D133202 , should I both fix >> alignment in this

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. In D133807#3792525 , @tahonermann wrote: > Structurally, these changes look like what I would expect. I didn't try to > validate any of the code point ranges. > > Are there useful tests that could be modified or added in order

[PATCH] D133956: git push Cuda Check for ignored errors after calling a CUDA kernel

barcisz created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl, mgorny. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add cuda-unchecked-kernel-call check ===

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4493 + + if (Args.hasArg(options::OPT__SLASH_Zl)) { +CmdArgs.push_back("-D_VC_NODEFAULTLIB"); mstorsjo wrote: > If I understand correctly, we still don't have any corresponding

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460456. akhuang added a comment. ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

beanz created this revision. beanz added reviewers: python3kgae, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Having the flags only pass through if you're using

[clang] fda44be - Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

Author: Amy Huang Date: 2022-09-15T17:45:41Z New Revision: fda44bedd64dbcde1b54432d99ad2f0fca0ad204 URL: https://github.com/llvm/llvm-project/commit/fda44bedd64dbcde1b54432d99ad2f0fca0ad204 DIFF: https://github.com/llvm/llvm-project/commit/fda44bedd64dbcde1b54432d99ad2f0fca0ad204.diff LOG: Add

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfda44bedd64d: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

python3kgae added inline comments. Comment at: clang/test/Driver/hlsl_no_stdinc.hlsl:2 // RUN: %clang_dxc -Tlib_6_7 -fcgl -Fo - %s -### 2>&1 | FileCheck %s --check-prefix=STDINC +// RUN: %clang target dxil-pc-shadermodel6.3-library -o - %s -### 2>&1 | FileCheck %s --check-pr

[PATCH] D133937: [mlir] Remove the unused source file.

Groverkss added a comment. Included this change in the original revision since I had to revert things because of a compilation issue with gcc8 anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133937/new/ https://reviews.llvm.org/D133937

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

Abramo-Bagnara added a comment. I have to doubly apologize: 1. my reference to refersInstantiatedDecl is completely wrong and I have been mislead by an old patch on my machine. 2. the problem despite being very real is independent by your changes If you are still interested this is the repro fo

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

owenpan added a comment. In D129926#3769542 , @curdeius wrote: > @eoanermine, please provide your name and email address for the commit > message. We can use "Danil Sidoruk " as I did in d8d331bc9710

[PATCH] D133958: [HLSL] Pass flags to cc1 based on language

beanz updated this revision to Diff 460464. beanz added a comment. Fixing test typo, thanks @python3kgae! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133958/new/ https://reviews.llvm.org/D133958 Files: clang/include/clang/Driver/Types.h clan

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge added a comment. Thanks for the feedback! Yeah I'd be wary of introducing a corner case where the user passes `--query-driver`, and there is in fact a driver available to query in `PATH`, but we end up not querying it. Even if the outcome is the same in cases we can think of, it feels li

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a subscriber: jansvoboda11. kadircet added inline comments. Comment at: clang/include/clang/Driver/Options.td:6362 -def cl_Group : OptionGroup<"">, Flags<[CLOption]>, +def cl_Group : OptionGroup<"">, Flags<[CLDXCOption]>, HelpText<"CL.EXE COMPATIBILITY OPTIONS

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

aaron.ballman added inline comments. Comment at: clang/test/Sema/builtin-redecl.cpp:5-6 +#include + // Redeclaring library builtins is OK. yronglin wrote: > aaron.ballman wrote: > > We can be tricky instead of including a header file. > Use `decltype` not wor

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang created this revision. akhuang added reviewers: mstorsjo, hans. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The /Zl flag omits default C runtime library name from obj files. This patc

[PATCH] D133924: add clang_CXXMethod_isDeleted function

aaron.ballman added a comment. Thanks for this! Can you add a release note to clang/docs/ReleaseNotes.rst and some test coverage for the change to clang/test/Index for the change? Also, it looks like precommit CI found a relevant failure that needs to be fixed: TEST 'Clan

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: I have a couple of concerns with this interface:

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

logankaser added a comment. Is there anything I can do as a random member of the public that wants this and knows C++? My organization is trying to move to clangd for the default config, and the lack of docstring parsing is common feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. yusuke-kadowaki wrote: > HazardyKnusperkeks wrote: > > yusuke-kadowaki

[PATCH] D133920: [X86][fastcall] Move capability check before free register update

rnk added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1781 + + return (Ty->isIntegralOrEnumerationType() || Ty->isPointerType() || + Ty->isReferenceType()); I think we could improve readability here with some named variable boo

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460470. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contra

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

dblaikie added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:15 +// RUN: %clang -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s -o - | llvm-dwarfdump --debug-aranges - | FileCheck -check-prefix=ARANGES %s +// ARANGES: Address Range Hea

[PATCH] D133962: [clang(d)] Include/Exclude CLDXC options properly

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This handles th

[PATCH] D133956: git push Cuda Check for ignored errors after calling a CUDA kernel

tra added a comment. > Our linter cannot easily check whether the error was reset It can not in principle. Many CUDA errors are 'sticky' and can only be cleared by resetting the GPU or exiting the application and the former is virtually never used beyond toy examples (resetting a GPU would clea

[PATCH] D133887: [Clang] Support label at end of compound statement

aaron.ballman added a comment. In D133887#3790414 , @cor3ntin wrote: > Thanks for doing that work. > > Given that this paper was touted as a C compatibility feature, I think we > should implement the C feature at the same time > https://www.open-std.org/

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat updated this revision to Diff 460475. azat added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133875/new/ https://reviews.llvm.org/D133875 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/deb

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat marked 2 inline comments as done. azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:7 +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=PLUGIN_GARANGE %s +// GARANGE: -gener

[clang] 49832b7 - Stop trying to fixup 'overloadable' prototypeless functions.

Author: Erich Keane Date: 2022-09-15T12:10:54-07:00 New Revision: 49832b7a928d4971417d8dba9aba932d62e447e3 URL: https://github.com/llvm/llvm-project/commit/49832b7a928d4971417d8dba9aba932d62e447e3 DIFF: https://github.com/llvm/llvm-project/commit/49832b7a928d4971417d8dba9aba932d62e447e3.diff L

[PATCH] D128462: [HLSL] add -I option for dxc mode.

kadircet added a comment. BTW, I am not sure when the new DXC driver mode was introduced but ATM it isn't properly handled by clang-tooling APIs, especially clangd. As the logic there wasn't updated accordingly, and it also resulted in regressions for clang-cl mode. I've sent out https://review

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please add a release note for the fix when you land the changes. Comment at: clang/test/SemaCXX/remove-nested-immediate-invocation-crash.cpp:4 + +a, class

[PATCH] D133807: Update Unicode to 15.0

tahonermann added a comment. > I considered it, and I can add a few if you insist but... I'm not sure adding > random tests tell us much except that the specific tested characters are > supported. I wouldn't expect to learn anything from doing so; it would just provide regression protection (f

[PATCH] D133968: [clangd] Enable standard library index by default.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/include/clang/Driver/Options.td: dll version.}]>; +def fms_omit_default_lib_name : Joined<["-"], "fms-omit-default-lib-name">, + Group, Flags<[NoXarchOption, CoreOption]>, Initially, I'm not entirely sure ab

[clang] 9ada3d5 - Fix error in clang /MT equivalent flag patch.

Author: Amy Huang Date: 2022-09-15T20:24:51Z New Revision: 9ada3d5a137f5edba7a599ca83e488c76681bbf9 URL: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9 DIFF: https://github.com/llvm/llvm-project/commit/9ada3d5a137f5edba7a599ca83e488c76681bbf9.diff LOG: Fix

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added a comment. I think we had no expectation that DXC-mode would be supported by the tooling APIs at this point. For context, DXC is the HLSL compiler that is based on clang-3.7. The DXC mode provides interface compatibility with it. DXC doesn't work with any of the clang tooling infra

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans added a comment. Could the new flag be marked as an Alias in the tablegen, so that we don't need to do any code changes for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D133959 __

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt added a comment. In D133853#3792518 , @aaron.ballman wrote: > I'm wondering what the goal is for these changes. ... Are you intending to > add semantics for these attributes in follow-up patches? To be honest, I wasn't planning to do any of fo

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis updated this revision to Diff 460507. Maetveis retitled this revision from "[Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs" to "[Clang] Change -ftime-trace storing path and support multiple compilation jobs". Maetveis added a comment. Remove inline e

[PATCH] D133979: [clangd] XRef functions treat visible class definitions as primary.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This means

[PATCH] D133732: [clang-doc] Support default args for functions.

paulkirth added a comment. Thanks for the patch. This is mostly LGTM modulo a few nits. My one question is regarding documentation. Do you think this needs to be described in the clang-tools-extra/doc/clang-doc.rst? And are there any changes in workflow or tool usage that we should document? I

[PATCH] D133956: git push Cuda Check for ignored errors after calling a CUDA kernel

barcisz added a comment. In D133956#3793022 , @tra wrote: > I think ultimately the checker should be generalized to flag all unchecked > CUDA runtime calls. The problem is that that is going to be exceedingly noisy > in practice as a lot of real code do

[PATCH] D133725: Searching for tokens including comments

barcisz added a comment. In D133725#3792787 , @aaron.ballman wrote: > Can you help me understand the expected use for these change? Changed the description to answer your question - it's a prerequisite to D133942 and

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:362 +// allow this as an extension. +if (AllowImplicitTypename == ImplicitTypenameContext::No && +!isClassName && !IsCtorOrDtorName) ayzhao wrote: > Status update: >

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 460514. ayzhao added a comment. hacky fix for the test CXX/module/module.interface/p2-2.cpp If anyone has a better idea on how to fix this test, feedback is **very** welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem added a comment. Thanks @kcc @vitalybuka, I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___ cfe-commits mailing list cfe-

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka updated this revision to Diff 460518. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Ba

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460519. barcisz added a comment. Dummy definition for size_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMakeLists.txt cl

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9449-9450 + !(Features & llvm::AMDGPU::FEATURE_WAVE32) || + llvm::is_contained(CGM.getTarget().getTargetOpts().FeaturesAsWritten, + "+wavefrontsize64"); +

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460520. barcisz added a comment. moved size_t definition to an stddef.h stub Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-tidy/CMa

[PATCH] D133982: [clangd] Improve inlay hints of things expanded from macros

sammccall created this revision. sammccall added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When we aim

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz updated this revision to Diff 460522. barcisz added a comment. Herald added a subscriber: mgorny. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 Files: clang-tools-extra/clang-tidy/cuda/

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

MaskRay accepted this revision. MaskRay added inline comments. Herald added a subscriber: StephenFan. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:155 +cl::desc("collect control flow for each function"), cl::Hidden, +cl::in

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka updated this revision to Diff 460525. vitalybuka added a comment. clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basi

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:155 +cl::desc("collect control flow for each function"), cl::Hidden, +cl::init(false)); + MaskRay wrote: > false can be removed

[clang] 3e52c09 - Add -fsanitizer-coverage=control-flow

Author: Navid Emamdoost Date: 2022-09-15T15:56:04-07:00 New Revision: 3e52c0926c22575d918e7ca8369522b986635cd3 URL: https://github.com/llvm/llvm-project/commit/3e52c0926c22575d918e7ca8369522b986635cd3 DIFF: https://github.com/llvm/llvm-project/commit/3e52c0926c22575d918e7ca8369522b986635cd3.dif

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e52c0926c22: Add -fsanitizer-coverage=control-flow (authored by Navidem, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

njames93 added a comment. Would I be correct in assuming you have uploaded the wrong diff here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 ___ cfe-commits

[PATCH] D133698: [clang][dataflow] SignAnalysis, edgeTransfer, branchTransfer

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:127 + // Default implementation is a Noop. + virtual void branchTransfer(bool Branch, const Stmt *S, Lattice &L, + Environment &Env) {} -

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

tra added a comment. > The intention with this check is to work a lot in tandem with the one in > D133804 , which therefore prevents most > such cases. > Thus, the check is optimized for lowering false positives during static > checking and for a practice lowe

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

njames93 added a comment. In D132461#3773792 , @carlosgalvezp wrote: > @njames93 Friendly ping. The patch has addressed all comments and remained > unchanged for 2 weeks. I would like to land it latest next week. If you are > happy with the patch, plea

[PATCH] D133634: [clang] Allow vector of BitInt

efriedma added a comment. I think the worst of the backend issues with vectors of non-byte-size integers have been resolved? Work on that has progressed slowly for a very long time. There have been a constant stream of issues. (See, for example, D129164 .)

[PATCH] D133934: [clang][Interp] Handle sizeof() expressions

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:290 +return this->emitConst( +E, Ctx.getASTContext().getTypeSizeInChars(ArgType).getQuantity()); + } aaron.ballman wrote: > erichkeane wrote: > > shafik wrote: > > > I

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 created this revision. jansvoboda11 added a reviewer: benlangmuir. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ScanInstance` is a local variable in `DependencyScanningAction::

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw updated this revision to Diff 460538. brettw marked 4 inline comments as done. brettw added a comment. There is no usage change for this. It just adds another field to the YAML. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 Files: c

[PATCH] D133705: [HIP] Fix unbundling archive

tra added a comment. In D133705#3785470 , @yaxunl wrote: >> Also, using `lib*.a` as pattern to tell device libraries from the host-ony >> one will be insufficient. There will be libraries with other extensions >> (e.g. `.lo` is fairly common) and there

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 added a comment. Another option would be to store `ScanInstance` as member of `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D133988

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 460546. python3kgae added a comment. Fix warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D133983 Files: clang/include/clang/Basic/Attr.td clang/include/clang

[PATCH] D133991: add new function to release notes

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix copy/paste error in doc comment fix failing test now deleted is su

[PATCH] D133924: add clang_CXXMethod_isDeleted function

anderslanglands updated this revision to Diff 460549. anderslanglands added a comment. Updating based on review - Add new function to release notes - Fix failing test and add a new test specifically for this function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz added a comment. In D133942#3793618 , @njames93 wrote: > Would I be correct in assuming you have uploaded the wrong diff here? Yes, sorry, got mixed up with D133956 (6 diffs ain't easy to shuffle :-/) Reposit

[PATCH] D133991: add new function to release notes

anderslanglands added a comment. Sorry, this was supposed to update https://reviews.llvm.org/D13392. How do I delete this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133991/new/ https://reviews.llvm.org/D133991

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

barcisz updated this revision to Diff 460550. barcisz added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133956/new/ https://reviews.llvm.org/D133956 Files: clang-tools-extra/clang-tidy/cuda/CMakeLists.txt clang-tools-extra/

[PATCH] D133942: Clang tidy utility to generate a fix hint for a subsequent expression to the existing one

barcisz updated this revision to Diff 460551. barcisz added a comment. Misplaced diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133942/new/ https://reviews.llvm.org/D133942 Files: clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp clang

[PATCH] D133988: [clang][deps] Make sure ScanInstance outlives collector

jansvoboda11 updated this revision to Diff 460552. jansvoboda11 added a comment. Replace `std::shared_ptr` by `Optional` stored on `DependencyScanningAction`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133988/new/ https://reviews.llvm.org/D13398

[PATCH] D133956: Cuda Check for ignored errors after calling a CUDA kernel

barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cuda/unsafe-kernel-call-macro-handler.cu:53 + } + auto err = cudaGetLastError(); + tra wrote: > barcisz wrote: > > tra wrote: > > > Just curious -- is it sufficient to just c

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After generated call for

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: sammccall wrote: > I have a couple of concerns with t

[PATCH] D131853: [clangd] Add doxygen parsing for Hover

nridge added a comment. In D131853#3792985 , @logankaser wrote: > Is there anything I can do as a random member of the public that wants this > and knows C++? Maybe apply the patch locally, use it for a bit, and provide feedback? I haven't forgotten a

[clang] 7fe4757 - Set HOME for tests that use module cache path

Author: Colin Cross Date: 2022-09-15T23:58:57Z New Revision: 7fe475756b26080fe0bb02e8e317662ccc9a01f1 URL: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1 DIFF: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1.diff LOG: S

[PATCH] D132984: Set HOME for tests that use module cache path

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fe475756b26: Set HOME for tests that use module cache path (authored by ccross, committed by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132984/n

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay created this revision. MaskRay added reviewers: tra, yaxunl. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. %T is a deprecated lit feature. It refers to th

[PATCH] D133998: [HIP][test] Avoid %T

MaskRay updated this revision to Diff 460569. MaskRay added a comment. fix all hip-* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133998/new/ https://reviews.llvm.org/D133998 Files: clang/test/Driver/hip-link-bc-to-bc.hip clang/test/Driver/hi

[PATCH] D133705: [HIP] Fix unbundling archive

MaskRay added a comment. I know very little about HIP, but I am concerned with relying on extensions as well. For example, I've seen `libc++.a.1` (we use this for the real archive while `libc++.a` is a linker script) and `.la` (libtool). A `.so` file is sometimes a linker script and it may refer

[PATCH] D133732: [clang-doc] Support default args for functions.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 ___ cfe-commits mailing list cfe-com

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3793702 , @tra wrote: > In D133705#3785470 , @yaxunl wrote: > >>> Also, using `lib*.a` as pattern to tell device libraries from the host-ony >>> one will be insufficient. There

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl added a comment. In D133705#3793931 , @MaskRay wrote: > I know very little about HIP, but I am concerned with relying on extensions > as well. For example, I've seen `libc++.a.1` (we use this for the real > archive while `libc++.a` is a linker sc

<    1   2   3   >