[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Thanks for doing this. I'm going to test it in 2-3 hours and get back to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___ cfe-co

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

kaz7 added a comment. For your information, after this patch `check-clang` fails with following errors if there is no lld is installed (lld is not enable in CMake, and lld is not installed previously). I appreciate if you run debug-options.c test with `-fuse-ld=lld` if the lld is existing. Th

[clang] 1c0a90f - [C++20] [Coroutines] Prefer sized deallocation in promise_type

Author: Chuanqi Xu Date: 2022-09-14T15:07:31+08:00 New Revision: 1c0a90fd47bded1a6d5f31091e32cd79434bf4d4 URL: https://github.com/llvm/llvm-project/commit/1c0a90fd47bded1a6d5f31091e32cd79434bf4d4 DIFF: https://github.com/llvm/llvm-project/commit/1c0a90fd47bded1a6d5f31091e32cd79434bf4d4.diff LO

[PATCH] D133834: [RISCV] Remove support for the unratified Zbt extension.

Chenbing.Zheng added a comment. I agree that we should remove support for unratified extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133834/new/ https://reviews.llvm.org/D133834 ___ cfe-commits

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented Fixes: https://reviews.llvm.org/D133092 CI: https://lab.llvm.org/buildbot/#/builders/109/builds/46592

azat created this revision. azat added a reviewer: dblaikie. Herald added a project: All. azat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133841 Files: clang/test/Driv

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. In D133092#3788734 , @kaz7 wrote: > For your information, after this patch `check-clang` fails with following > errors if there is no lld (lld is not enable in CMake, and lld is not > installed previously). I appreciate if you run

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu updated this revision to Diff 459997. ChuanqiXu marked 5 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341/new/ https://reviews.llvm.org/D133341 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D133341#3788283 , @ychen wrote: > It surprises me that Option 2 does not change > https://eel.is/c++draft/dcl.fct.def.coroutine#10. For consistency, I think it > should. And accor

[clang] a884364 - [clang][Interp] Remove struct from a testcase

Author: Timm Bäder Date: 2022-09-14T09:44:01+02:00 New Revision: a8843643cd75d0e93ebcf3f30b470d2b8e59868d URL: https://github.com/llvm/llvm-project/commit/a8843643cd75d0e93ebcf3f30b470d2b8e59868d DIFF: https://github.com/llvm/llvm-project/commit/a8843643cd75d0e93ebcf3f30b470d2b8e59868d.diff LO

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This looks good to me, I'm going to land this for you once I confirm that it fixes the test failure (we can address any post comments from dblaikie@). Repository: rG LLVM Github Monorepo C

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

kadircet added inline comments. Herald added a project: All. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1292 +for (const LocatedSymbol &Sym : *Types) + Response.push_back(Sym.PreferredDeclaration); +return Reply(std::move(Response)); ---

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

kadircet added inline comments. Herald added projects: clang-tools-extra, All. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1306 +for (const LocatedSymbol &Sym : *Overrides) + Impls.push_back(Sym.PreferredDeclaration); +return Reply(std::move(

[PATCH] D133843: [clangd] Prefer definitions for gototype and implementation

kadircet created this revision. kadircet added reviewers: sammccall, usaxena95. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44075cc34a9b: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented (authored by azat, committed by hokein). Repository:

[clang] 44075cc - [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

Author: Azat Khuzhin Date: 2022-09-14T10:17:03+02:00 New Revision: 44075cc34a9b373714b594964001ce283598eac1 URL: https://github.com/llvm/llvm-project/commit/44075cc34a9b373714b594964001ce283598eac1 DIFF: https://github.com/llvm/llvm-project/commit/44075cc34a9b373714b594964001ce283598eac1.diff

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 460010. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

MyDeveloperDay added a subscriber: aaron.ballman. MyDeveloperDay added a comment. @eoanermine ping... we need your name/email before we can commit. (@curdeius, @owenpan, @HazardyKnusperkeks ) we need to have a policy for this, that if we don't get the name for a commit we are happy to land, tha

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:428 + +bool operator==(const TrailingCommentsAlignmentStyle &R) const { + return Kind == R.Kind && OverEmptyLines == R.OverEmptyLines; yusuke-kadowaki wrote: > MyDevelo

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

sebastian-ne accepted this revision. sebastian-ne added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ cfe-commits mailing list cfe-commits

[PATCH] D133648: Clang, increase upper bound of partially initialized array sizes

OfekShochat marked an inline comment as done. OfekShochat added a comment. I created a diff for the AsmPrinter part, its at D133845 Comment at: clang/lib/Sema/SemaInit.cpp:866 ElementEntity.getKind() == InitializedEntity::EK_VectorEl

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I'm seeing test failures with this patch applied: Failed Tests (3): Clang :: CodeGen/PowerPC/builtins-ppc-p8vector.c Clang :: CodeGen/builtins-arm-msvc-compat-only.c Cla

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Hmm, I just realized that I've tested on top of 15.0.0. If commits already on top of `release/15.x` branch already fix that, I'm sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

nikic added a comment. I tested this patch as well and saw the same failures as @mgorny. Here's the additional patch I had to apply to make this pass: diff --git a/clang/test/CodeGen/PowerPC/builtins-ppc-p8vector.c b/clang/test/CodeGen/PowerPC/builtins-ppc-p8vector.c index af3d5c7d066b..3c5

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460019. barcisz added a comment. More explanation comments for the check's code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/clang-tidy/

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. @nikic, with your patch I still have `CodeGen/PowerPC/builtins-ppc-p8vector.c` failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 460021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460025. barcisz added a comment. Rebase and better comments for cuda-related decisions in the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-too

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

nikic added a comment. @mgorny Yeah, that was a testing fail on my side. I've updated it to a hopefully correct version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 __

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460027. barcisz added a comment. Better explanation of cuda-related flags in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools-extra/clang-ti

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

azat created this revision. azat added reviewers: hokein, dblaikie. Herald added a project: All. azat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now, when the filename contains lld, it does not filter correctly. Repository: rG LLVM

[PATCH] D133753: [clang][Interp] WIP: Array fillers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:54 + assert(Stk.empty()); + return true; } The additional asserts I inserted here could be in another patch. However, I added them because I ran into a peculiar problem: when creating

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460034. barcisz added a comment. Removed unnecessary cuda-related compilation flags from tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-ex

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman updated this revision to Diff 460035. aaron.ballman added a comment. Herald added subscribers: kbarton, nemanjai. Updated the failing tests caught during review (thank you!) and moved the release notes around and reworded them somewhat for clarity. CHANGES SINCE LAST ACTION http

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3788950 , @nikic wrote: > I tested this patch as well and saw the same failures as @mgorny. Thank you, I think I've got those patched up, but with one difference: > > diff --git a/clang/test/CodeGen/neon-cr

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3788983 , @nikic wrote: > @mgorny Yeah, that was a testing fail on my side. I've updated it to a > hopefully correct version. Ok, thanks. This version worked for me. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

aaron.ballman added a comment. In D129926#3788866 , @MyDeveloperDay wrote: > @eoanermine ping... we need your name/email before we can commit. > > (@curdeius, @owenpan, @HazardyKnusperkeks ) we need to have a policy for > this, that if we don't get the

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460036. mizvekov marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariab

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1023 + // which in this example would be the actual declaration of foo. + if (Candidates.size() == 2) { +if (llvm::isa(Candidates.front())) nit: you can change this to `Candidate

[PATCH] D133851: [analyzer] Initialize ShouldEmitErrorsOnInvalidConfigValue analyzer option

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D133853: [AST] Add msvc-specific C++11 attributes

RIscRIpt created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - 'msvc::no_tls_guard', first appeared in MS

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3789100 , @aaron.ballman wrote: > In D133800#3788950 , @nikic wrote: > >> I tested this patch as well and saw the same failures as @mgorny. > > Thank you, I think I've got those

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

alexgatea reopened this revision. alexgatea added a comment. This revision is now accepted and ready to land. Hi This test case is still failing for me due to the lines without -fuse-ld=ldd: // RUN: %clang -### -target x86_64-unknown-linux -flto -gdwarf-aranges %s 2>&1 | FileCheck -check-prefi

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3789188 , @mgorny wrote: > In D133800#3789100 , @aaron.ballman > wrote: > >> In D133800#3788950 , @nikic wrote: >> >>> I tested

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

azat added a comment. > Can you please fix this? It should be fixed in https://reviews.llvm.org/D133847 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://reviews.llvm.org/D133841 ___ cfe

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

azat added a comment. Can someone pick this please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman updated this revision to Diff 460051. aaron.ballman added a comment. Added the `not` back into the neon-crypto.c test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. In D133289#3788655 , @to268 wrote: > In D133289#3784042 , @aaron.ballman > wrote: > >> auto auto k = 12; // 99% this is intended to be accepted; first `auto` is >> the storage cl

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

alexgatea closed this revision. alexgatea added a comment. > It should be fixed in https://reviews.llvm.org/D133847 Ah I didn't see that. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://reviews.llvm.org/D133841 __

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. @hans just to clarify as I do not have commit access: do I still need to perform some action? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133354/new/ https://reviews.llvm.org/D133354 ___ cfe-commits mailing list cf

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1011 +const NamedDecl * +pickDeclToUse(const llvm::SmallVector &Candidates) { + if (Candidates.empty()) you can just pass in ArrayRef instead. Repository: rG LLVM Github Monorepo

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:121 +# Tests should not rely on a certain cuda device being available on the machine, +# or a certain version of it tra wrote: > The comment is incorrect.

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460055. barcisz added a comment. Update base to D133801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/

[PATCH] D133807: Update Unicode to 15.0

aaron.ballman added a comment. The changes LGTM, but I'd like to wait for @tahonermann to weigh in with the final acceptance. Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; cor3ntin wrote: > shafi

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

tom-anders updated this revision to Diff 460058. tom-anders marked 5 inline comments as done. tom-anders added a comment. Add additional test, tidy up logic in pickDeclToUse() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133664/new/ https://review

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1011 +const NamedDecl * +pickDeclToUse(const llvm::SmallVector &Candidates) { + if (Candidates.empty()) kadircet wrote: > you can just pass in ArrayRef instead. Ah of course, forgot

[PATCH] D133856: [clang][Interp] Pass initializer through when creating variables

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is of course in preparation of https://reviews

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. The newest version looks good. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___ cfe-

[PATCH] D133753: [clang][Interp] WIP: Array fillers

tbaeder updated this revision to Diff 460059. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133753/new/ https://reviews.llvm.org/D133753 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Descriptor

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460063. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/AST

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 460064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I don't like this but will concede it's quicker than changing device libs to contain IR that doesn't have to be patched on the fly. Repository: rG LLVM Github Monorepo CH

[PATCH] D133851: [analyzer] Initialize ShouldEmitErrorsOnInvalidConfigValue analyzer option

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Okay, I don't see any problem with this change. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133851/new/ https://reviews.llvm.org/D1338

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! i think you have commit access now, but let me know if I should land this for you (preferably with an email address for commit attribution) Comment at: cla

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 460070. barcisz added a comment. Herald added a subscriber: arphaman. Common documentation for cuda checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: cl

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 460073. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTempl

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github added a comment. @alvinhochun @mstorsjo Let me know if you'd like to see more changes. With the new regex, the tests pass at my end as well as in the Phabricator CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://re

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

aaron.ballman added a comment. In D133800#3787378 , @thieta wrote: > I think the easiest way to handle this is that when you have it approved here > - push it to fork on GitHub based on the release branch and create a GitHub > issue and write /branch ab

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu created this revision. VincentWu added reviewers: kito-cheng, MaskRay, craig.topper, jrtc27, HsiangKai, asb. Herald added subscribers: sunshaoce, luke957, StephenFan, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, Pkm

[clang] 194ec84 - [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

Author: Joseph Huber Date: 2022-09-14T09:42:06-05:00 New Revision: 194ec844f5c67306f505a3418038c5e75859bad8 URL: https://github.com/llvm/llvm-project/commit/194ec844f5c67306f505a3418038c5e75859bad8 DIFF: https://github.com/llvm/llvm-project/commit/194ec844f5c67306f505a3418038c5e75859bad8.diff

[PATCH] D133726: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU

This revision was automatically updated to reflect the committed changes. Closed by commit rG194ec844f5c6: [OpenMP][AMDGPU] Link bitcode ROCm device libraries per-TU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133726/new/ ht

[clang] b8e1da0 - [analyzer] Initialize ShouldEmitErrorsOnInvalidConfigValue analyzer option

Author: Balazs Benics Date: 2022-09-14T16:45:44+02:00 New Revision: b8e1da050673470f20a75d4ecca2c0a00d1a8691 URL: https://github.com/llvm/llvm-project/commit/b8e1da050673470f20a75d4ecca2c0a00d1a8691 DIFF: https://github.com/llvm/llvm-project/commit/b8e1da050673470f20a75d4ecca2c0a00d1a8691.diff

[PATCH] D133851: [analyzer] Initialize ShouldEmitErrorsOnInvalidConfigValue analyzer option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e1da050673: [analyzer] Initialize ShouldEmitErrorsOnInvalidConfigValue analyzer option (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassChe

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 460099. Ericson2314 added a comment. Fix typo in compiler-rt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: bolt/CMakeLists.txt clang/CMakeLists.txt

[clang] bae1a2c - [OpenMP] Remove unused function after removing simplified interface

Author: Joseph Huber Date: 2022-09-14T10:14:43-05:00 New Revision: bae1a2cf3cce529b0d03df8bac962d13b407e117 URL: https://github.com/llvm/llvm-project/commit/bae1a2cf3cce529b0d03df8bac962d13b407e117 DIFF: https://github.com/llvm/llvm-project/commit/bae1a2cf3cce529b0d03df8bac962d13b407e117.diff

[clang] f6e759b - Remove some unused static functions in CGOpenMPRuntimeGPU.cpp, NFC

Author: Haojian Wu Date: 2022-09-14T17:20:02+02:00 New Revision: f6e759bd26b24e046573ac46d3ee3be6eebd5526 URL: https://github.com/llvm/llvm-project/commit/f6e759bd26b24e046573ac46d3ee3be6eebd5526 DIFF: https://github.com/llvm/llvm-project/commit/f6e759bd26b24e046573ac46d3ee3be6eebd5526.diff LO

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

vitalybuka added a comment. the test crashes with sanitizers https://lab.llvm.org/buildbot/#/builders/5/builds/27437 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://reviews.llvm.org/D133841 __

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

azat added a comment. > the test crashes with sanitizers > https://lab.llvm.org/buildbot/#/builders/5/builds/27437 yep, this should be fixed in https://reviews.llvm.org/D133847 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://rev

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1276 + if (Error E = MemProfResult.takeError()) { +handleAllErrors(std::move(E), [&](co

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 460127. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/lib/AST/ASTContext.

[PATCH] D133773: [clang] fix linker executable path in test

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773 ___

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

kaz7 added a comment. In D133092#3788749 , @azat wrote: > In D133092#3788734 , @kaz7 wrote: > >> For your information, after this patch `check-clang` fails with following >> errors if there is no lld (lld is not

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

thakis added a comment. As far as I can tell, this broke check-clang everywhere. (See e.g.: https://lab.llvm.org/buildbot/#/builders/139/builds/28039 and many of the bots on https://lab.llvm.org/buildbot/#/console Before landing changes, please: - run tests locally - wait for the presubmit bot

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

thakis added a comment. Reverted in db6a53450facdfead8b0c8d20cfa361a785945fd for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://reviews.llvm.org/D133841 ___ cfe-commits mailing li

[clang] db6a534 - Revert "[test][clang] run test for lld emitting dwarf-aranages only if lld is presented"

Author: Nico Weber Date: 2022-09-14T12:17:41-04:00 New Revision: db6a53450facdfead8b0c8d20cfa361a785945fd URL: https://github.com/llvm/llvm-project/commit/db6a53450facdfead8b0c8d20cfa361a785945fd DIFF: https://github.com/llvm/llvm-project/commit/db6a53450facdfead8b0c8d20cfa361a785945fd.diff LO

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov updated this revision to Diff 460133. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133468/new/ https://reviews.llvm.org/D133468 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

azat added a comment. @thakis Thanks for taking a look! Actually initially the problem had been introduced in https://reviews.llvm.org/D133092 I've run tests locally, however I did have lld in a system, so I did not noticed the problem. And CI did not find the problem either, since I guess it a

[PATCH] D133773: [clang] fix linker executable path in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1848b0a0ed7: [clang] fix linker executable path in test (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm

[clang] f1848b0 - [clang] fix linker executable path in test

Author: Ashay Rane Date: 2022-09-14T11:35:37-05:00 New Revision: f1848b0a0ed70fc91eff50f6c47561ca24362a37 URL: https://github.com/llvm/llvm-project/commit/f1848b0a0ed70fc91eff50f6c47561ca24362a37 DIFF: https://github.com/llvm/llvm-project/commit/f1848b0a0ed70fc91eff50f6c47561ca24362a37.diff LO

[clang] 5631d20 - Revert "[clang] fix generation of .debug_aranges with LTO"

Author: Nico Weber Date: 2022-09-14T12:43:24-04:00 New Revision: 5631d20bfc9f77d15435badf6ce34e1a56c27e1c URL: https://github.com/llvm/llvm-project/commit/5631d20bfc9f77d15435badf6ce34e1a56c27e1c DIFF: https://github.com/llvm/llvm-project/commit/5631d20bfc9f77d15435badf6ce34e1a56c27e1c.diff LO

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

thakis added a comment. Reverted this in 5631d20bfc9f77d15435badf6ce34e1a56c27e1c since the fix for the test failures this change here caused got reverted due to breaking other tests. Let's regroup and make a new patch that

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

dblaikie added a comment. Presumably this would break if someone's build uses a tool suffix (so lld becomes lld-tot or something like that)? Perhaps `lld[^"]*"` would be better? Are there other test cases that test something similar that we could look at to see how they work/more likely get some

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

azat added a comment. > Presumably this would break if someone's build uses a tool suffix (so lld > becomes lld-tot or something like that)? Perhaps lld[^"]*" would be better? I thought about this too, but I found this in another test, so likely it should work... > Are there other test cases t

[PATCH] D133711: [Sema] Reject array element types whose alignments are larger than their sizes

rnk added a comment. I agree, there's no reason to change the i686 MSVC record layout algorithm. It was written, tested, done, it's fragile. We used to have some decent continuous integration testing for ABI issues like this, but as usual these things require care and feeding and it did not sur

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2311 case DeclSpecContext::DSC_association: +case DeclSpecContext::DSC_offsetof: return true; Is this correct? I don't think we can deduce the type from `offsetof`

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat created this revision. Herald added a subscriber: inglorion. Herald added a project: All. azat requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Right now in case of LTO the section is not emited: $ cat test.c void __attribu

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

azat added a comment. > Perhaps lld[^"]*" would be better? But yeah, this looks better anyway. Applied your suggestion. New revision - https://reviews.llvm.org/D133875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2311 case DeclSpecContext::DSC_association: +case DeclSpecContext::DSC_offsetof: return true; aaron.ballman wrote: > Is this correct? I don't think we can deduce the type

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:50 +if (S.LookupQualifiedName(Result, HLSLNamespace)) { + NamedDecl *Found = Result.getFoundDecl(); + if (auto *TD = dyn_cast(Found)) { 99.9% sure this is saf

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

rnk added a comment. Thanks! > But I had > trouble figuring out how to exercise this functionality properly to add > test coverage and then compare that to MSVC itself... - I got very > confused/turned around trying to test this, so I've given up enough to > send what I have out for review, but h

  1   2   3   >