aaron.ballman added a comment. In D129926#3788866 <https://reviews.llvm.org/D129926#3788866>, @MyDeveloperDay wrote:
> @eoanermine ping... we need your name/email before we can commit. > > (@curdeius, @owenpan, @HazardyKnusperkeks ) we need to have a policy for > this, that if we don't get the name for a commit we are happy to land, that > we'll do it the old way, and just mention them, Its frustrating for us to > waste our time doing reviews only to fall at the last hurdle. (@aaron.ballman > any thoughts) Good idea on starting a policy for this. I think that policy should be discussed by the community via an RFC because we should be consistent across the project in how we handle this sort of situation, IMO (at least within the `clang` part of the repo; it'd be weird for the static analyzer to have a different policy from Clang which is different from clang-format). Personally, I think if there's been no response for a month, we're probably fine to commandeer the patch. That should be sufficient time for folks who have gone on vacation to have come back and responded, hopefully. I think the only situation where we might want a more tight timeframe is when the patch is critical (blocking a release kind of thing), but hopefully that situation is so rare as to not require making a policy for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
