[PATCH] D133289: [C2X] N3007 Type inference for object definitions

cor3ntin added a comment. In D133289#3773708 , @to268 wrote: > Also @aaron.ballman said me that he was thinking about maybe adding an > extension to add support for `auto` in a function return or in a parameter > list. I think extensions are best left

[PATCH] D132918: [clang] Fix a crash in constant evaluation

kadircet added a comment. > This is helpful information but I am not sure this convinces me that > EvaluateVarDecl is the correct place to check. Why not in EvaluateDecl or > EvaluateStmt? Both locations we could also check. I have done the check inside `EvaluateVarDecl` because the invalid eva

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

sammccall added a comment. Thanks for doing this, clangd change LGTM. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:726 EXPECT_EQ("CXXConstructExpr", nodeKind(Str->Parent->Parent)); EXPECT_EQ(Str, &Str->Parent->Parent->ignoreImplicit()) << "Didn

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro created this revision. ro added reviewers: glaubitz, MaskRay. Herald added subscribers: StephenFan, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've been using this hack to wor

[PATCH] D132918: [clang] Fix a crash in constant evaluation

ilya-biryukov accepted this revision as: ilya-biryukov. ilya-biryukov added a comment. In D132918#3773237 , @shafik wrote: > This is helpful information but I am not sure this convinces me that > `EvaluateVarDecl` is the correct place to check. Why not i

[PATCH] D133407: [Driver] Support non-canonical triples with new runtime lib layout

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: StephenFan, abidh, jrtc27, fedor.sergeev, kristof.beyls, jyknight. Herald added a project: All. ro requested review of this revision. This is the companion patch to D133406

[PATCH] D133405: [Linux] Hack around Linux/sparc

glaubitz added a comment. Thanks, this is definitely very useful. I have pinged glibc upstream and asked them about the progress about this change. Let' see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D13340

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

alvinhochun updated this revision to Diff 458392. alvinhochun added a comment. Fixed `--target=` option for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llvm.org/D132810 Files: clang/docs/ReleaseNotes.rst clan

[clang] 98a3a34 - [ConstantExpr] Don't create fneg expressions

Author: Nikita Popov Date: 2022-09-07T11:27:25+02:00 New Revision: 98a3a340c3612c06c51d7bb36bfc5857ab06a951 URL: https://github.com/llvm/llvm-project/commit/98a3a340c3612c06c51d7bb36bfc5857ab06a951 DIFF: https://github.com/llvm/llvm-project/commit/98a3a340c3612c06c51d7bb36bfc5857ab06a951.diff

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

tmatheson added inline comments. Comment at: clang/lib/Headers/arm_acle.h:219 __revsh(int16_t __t) { - return __builtin_bswap16(__t); + return (int16_t)__builtin_bswap16((int16_t)__t); } Should the second cast be (uint16_t)__t? Repository: rG LLVM Github

[PATCH] D132797: [clangd] Support renaming virtual methods

ilya-biryukov added a comment. A few more NITs from me, but please wait for @sammccall for another round of reviews. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:550 +// method. +void recursivelyInsertOverrides(SymbolID Base, llvm::DenseSet &IDs, +

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 458403. yronglin retitled this revision from "[Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type" to "[Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type". Repository: rG LLVM Github Monorepo CHAN

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn updated this revision to Diff 458407. fhahn added a comment. Rebase and ping :) The potential benefit of having -m flags is also mentioned in this recent bug report: https://github.com/llvm/llvm-project/issues/57588 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. FWIW, I'm not sure this will usually be a simplification of the code. Splitting the condition and using early return is quite a frequent recommendation in code reviews, and I would e

[PATCH] D132797: [clangd] Support renaming virtual methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG IIRC Tom doesn't have commit access, so I'll apply the last trivial changes and commit to avoid another round trip. (Please LMK if i'm wrong about this!) Comment a

[clang-tools-extra] 8019b46 - [clangd] Support renaming virtual methods

Author: Tom Praschan Date: 2022-09-07T13:15:50+02:00 New Revision: 8019b46bc70b15cf5551ffcf494c6df17d1e7437 URL: https://github.com/llvm/llvm-project/commit/8019b46bc70b15cf5551ffcf494c6df17d1e7437 DIFF: https://github.com/llvm/llvm-project/commit/8019b46bc70b15cf5551ffcf494c6df17d1e7437.diff

[PATCH] D132797: [clangd] Support renaming virtual methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8019b46bc70b: [clangd] Support renaming virtual methods (authored by tom-anders, committed by sammccall). Changed prior to commit: https://reviews

[PATCH] D133102: [clang-tidy] Extend simplify-boolean-expr check

alexfh added a comment. For example, LLVM coding standards recommends using early exits: https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133102/new/ https://rev

[PATCH] D132797: [clangd] Support renaming virtual methods

tom-anders added a comment. In D132797#3774138 , @sammccall wrote: > LG > > IIRC Tom doesn't have commit access, so I'll apply the last trivial changes > and commit to avoid another round trip. > (Please LMK if i'm wrong about this!) I actually have com

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel created this revision. rymiel added reviewers: njames93, LegalizeAdulthood, aaron.ballman, gribozavr2. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

jyknight added a comment. >> Also, do you know if having posted this patch is agreement for licensing >> this code? Or do we need to get explicit agreement from the original author >> before committing a version of this? > > I've never seen that be an issue before, and I don't see enough in > h

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Note for reviewing: - The C++ standard, from what I could tell, seems to imply the the else clause of a consteval if clause could be written without braces, however it seems that both GCC and Clang don't allow for this, so both clauses of constexpr if statements should

[PATCH] D133415: [clangd] Fix non-idempotent cases of canonicalRenameDecl()

sammccall created this revision. sammccall added reviewers: ilya-biryukov, tom-anders. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D131465#3772803 , @MaskRay wrote: > Update clang-tools-extra/clangd/unittests/SelectionTests.cpp @sammccall This one looks to still b

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

aaron.ballman added a comment. So the basic idea here is that the default can be specified by a configuration file and thus we don't need any configure-time variable for it? But then why do we need other configuration macros like default stdlib or default linker? Mostly trying to understand wha

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

uweigand added a comment. I think it is correct to implement this in Clang. Note that on SystemZ (another big-endian platform), we also implement this in `EmitVAArg`. Of course the details are different since we're not using `emitVoidPtrVAArg` on that platform. However, I'm not sure if the

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked 3 inline comments as done. yusuke-kadowaki added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. MyDeveloperDay wrote: >

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

scanon added a comment. Wearing my compiler user hat, I would much rather use additive -mfeature than have to specify these as -march+feature, even when using a build system that nominally handles this stuff, because I frequently want to be able to compile one specific file with "whatever the p

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added a comment. Thanks for the update, this is heading in a good direction! I think there's still a lot of test coverage missing. Consider: namespace Name { cbuffer a { int x; } } struct S { cbuffer what { int y; } }; void func() { tbuffer

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, this wasn't quite what I had in mind, but I can see how my suggestion was going to be far too tricky to try to implement as a lit test. Thanks for adding the unit test coverage! CHANGES SINCE LAST ACTION https://revie

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 458440. dongjunduo added a comment. fix windows path-check error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/test/

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. @fhahn @aaron.ballman would you mind taking time for a review for this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list cfe-commi

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

SjoerdMeijer added a comment. In D113779#3496589 , @fhahn wrote: > In D113779#3207936 , @SjoerdMeijer > wrote: > >>> If anybody has contacts to GCC that would be very helpful. Unfortunately I >>> don't think I w

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover added a comment. > I don't think this is quite correct though? It'll turn off unwind tables for > AArch64 entirely, whereas we want to keep sync unwind tables. You're right, sorry about that. Hopefully this refactoring with MaskRay's suggestion gets it right. C

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 458443. Herald added subscribers: abrachet, mstorsjo, emaste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131153/new/ https://reviews.llvm.org/D131153 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/li

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 458444. t.p.northover added a comment. Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, mgester, arpith-ja

[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. 17 vs 14 h

[PATCH] D129683: [Sema] Move Diags.isIgnored() checks off hot paths, it's not free. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG897f3ddc6154: [Sema] Move Diags.isIgnored() checks off hot paths, it's not free. NFC (authored by sammccall). Changed prior to commit: https://rev

[clang] 897f3dd - [Sema] Move Diags.isIgnored() checks off hot paths, it's not free. NFC

Author: Sam McCall Date: 2022-09-07T16:18:31+02:00 New Revision: 897f3ddc6154fee9bc072f800ceab8202b236b0a URL: https://github.com/llvm/llvm-project/commit/897f3ddc6154fee9bc072f800ceab8202b236b0a DIFF: https://github.com/llvm/llvm-project/commit/897f3ddc6154fee9bc072f800ceab8202b236b0a.diff LO

[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. can you wait for premerge checks to finish (especially for windows)? Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:729-730 EXPECT_EQ("CXXConstructE

[clang-tools-extra] 8af74da - [clangd] Improve Selection testcase, pin to C++17

Author: Sam McCall Date: 2022-09-07T16:32:04+02:00 New Revision: 8af74da5bdbdccf13de84a4610ef75cd3dbac09e URL: https://github.com/llvm/llvm-project/commit/8af74da5bdbdccf13de84a4610ef75cd3dbac09e DIFF: https://github.com/llvm/llvm-project/commit/8af74da5bdbdccf13de84a4610ef75cd3dbac09e.diff LO

[PATCH] D133423: [clangd] Improve Selection testcase, pin to C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rG8af74da5bdbd: [clangd] Improve Selection testcase, pin to C++17 (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D133423?vs=458445&id=458450#toc Repository: rG LLVM Github M

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

sammccall added a comment. In D131465#3774276 , @aaron.ballman wrote: > In D131465#3772803 , @MaskRay wrote: > >> Update clang-tools-extra/clangd/unittests/SelectionTests.cpp @sammccall > > This one looks to stil

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman created this revision. aaron.ballman added reviewers: dblaikie, ldionne, clang-language-wg, libc++. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, this diagnostic fires on system header code that the user has no

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. You forgot to remove the ` \param PrintMarkerForTokensBeforeEOF ...` from the doc comment. Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ReleaseNotes.rst:87-88 `Issue 57387 `_. +- Fix clang not properly handling configur

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:10303 // Warn if CTAD was used on a type that does not have any user-defined - // deduction guides. - if (!HasAnyDedu

[clang-tools-extra] 72142fb - [clangd] Fix hover crashing on integral or enumeral casts

Author: Georg Kotheimer Date: 2022-09-07T16:43:22+02:00 New Revision: 72142fbac496a66769e16c80b076216d7c449ab2 URL: https://github.com/llvm/llvm-project/commit/72142fbac496a66769e16c80b076216d7c449ab2 DIFF: https://github.com/llvm/llvm-project/commit/72142fbac496a66769e16c80b076216d7c449ab2.dif

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

mtrofin added a comment. In D132991#3764877 , @aidengrossman wrote: > @xur I've modified the patch slightly (mainly fixing tests and changing the > error message printing in `CodeGenModule` to an assert as we should be > capturing everything in `Compil

[PATCH] D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

aaron.ballman added a reviewer: jcranmer-intel. aaron.ballman added a comment. I made some suggested documentation changes, but would love to hear more from folks heavily into floating-point options. Comment at: clang/docs/UsersManual.rst:1409-1410 + Disable fast-math mode.

[clang-tools-extra] 44bbf20 - [clangd] Add Macro Expansion to Hover

Author: Qingyuan Zheng Date: 2022-09-07T17:49:45+02:00 New Revision: 44bbf20965d2c1e00bb805343ad80dbb7758bf3d URL: https://github.com/llvm/llvm-project/commit/44bbf20965d2c1e00bb805343ad80dbb7758bf3d DIFF: https://github.com/llvm/llvm-project/commit/44bbf20965d2c1e00bb805343ad80dbb7758bf3d.diff

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44bbf20965d2: [clangd] Add Macro Expansion to Hover (authored by daiyousei-qz, committed by sammccall). Changed prior to

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > ChuanqiXu

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llvm.org/D132810 ___ cfe-c

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458472. hctim marked 3 inline comments as done. hctim added a comment. Update from Florian's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files: clang/te

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:60 + // gadgets. + if (G.getName().startswith("llvm.") || G.isThreadLocal() || G.isConstant()) { +Meta.Memtag = false; fmayer wrote: > not necessarily in this CL: do

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:93 + + uint64_t NewSize = alignTo(SizeInBytes, 16); + if (SizeInBytes != NewSize) { If the `16` is the size of the granule, then it deserves to be named constant. R

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

steven_wu accepted this revision. steven_wu added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 ___ cfe-commits mailing list cfe-commits@lis

[clang] a4a2943 - [RISCV][MC] Add minimal support for Ztso extension

Author: Philip Reames Date: 2022-09-07T09:30:57-07:00 New Revision: a4a29438f451370ed241dde30bfcaab0fdf2ab71 URL: https://github.com/llvm/llvm-project/commit/a4a29438f451370ed241dde30bfcaab0fdf2ab71 DIFF: https://github.com/llvm/llvm-project/commit/a4a29438f451370ed241dde30bfcaab0fdf2ab71.diff

[PATCH] D133239: [RISCV][MC] Add minimal support for Ztso extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a29438f451: [RISCV][MC] Add minimal support for Ztso extension (authored by reames). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 6ed21fc - Avoid __builtin_assume_aligned crash when the 1st arg is array type

Author: yronglin Date: 2022-09-07T12:46:20-04:00 New Revision: 6ed21fc515230ac2ea459d8aa90566e9a467bbb0 URL: https://github.com/llvm/llvm-project/commit/6ed21fc515230ac2ea459d8aa90566e9a467bbb0 DIFF: https://github.com/llvm/llvm-project/commit/6ed21fc515230ac2ea459d8aa90566e9a467bbb0.diff LOG:

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed21fc51523: Avoid __builtin_assume_aligned crash when the 1st arg is array type (authored by yronglin, committed by aaron.ballman). Repository:

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

aaron.ballman added a comment. I've pushed the changes up for you, thanks! In D133202#3774801 , @yronglin wrote: > ping~ Something to keep in mind for the future: we typically only "ping" a review after about a week of no activity on it (just because f

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458487. hctim marked an inline comment as done. hctim added a comment. Update inlined constants to use named constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 F

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. In D133202#3774905 , @aaron.ballman wrote: > I've pushed the changes up for you, thanks! > > In D133202#3774801 , @yronglin > wrote: > >> ping~ > > Something to keep in mind for the fut

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz created this revision. Herald added subscribers: mattd, carlosgalvezp, yaxunl, mgorny. Herald added a project: All. barcisz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Signed-off-by: bcieslar Repository: rG LLVM

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

tschuett added inline comments. Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp:25 + +// Register the GoogleTidyModule using this statically initialized variable. +static ClangTidyModuleRegistry::Add Is Google a copy and paste error? ==

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

akyrtzi updated this revision to Diff 458499. akyrtzi added a comment. Remove leftover doc-comment parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133357/new/ https://reviews.llvm.org/D133357 Files: clang/include/clang/Lex/DependencyDir

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

ivanmurashko added inline comments. Comment at: clang-tools-extra/test/lit.cfg.py:19 # suffixes: A list of file extensions to treat as test files. -config.suffixes = ['.c', '.cpp', '.hpp', '.m', '.mm', '.cu', '.ll', '.cl', '.s', +config.suffixes = ['.c', '.cpp', '.cu', '.hpp',

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 458502. barcisz added a comment. Fixed a copy-paste error with Google->Cuda in CudaTidyModule.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-tools

[clang] aa484c9 - [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

Author: Argyrios Kyrtzidis Date: 2022-09-07T10:31:29-07:00 New Revision: aa484c90cf5902042cec0f6a4f3bf2a460eea307 URL: https://github.com/llvm/llvm-project/commit/aa484c90cf5902042cec0f6a4f3bf2a460eea307 DIFF: https://github.com/llvm/llvm-project/commit/aa484c90cf5902042cec0f6a4f3bf2a460eea307.

[PATCH] D133357: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between the last scanned directive and EOF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa484c90cf59: [Lex/DependencyDirectivesScanner] Keep track of the presence of tokens between… (authored by akyrtzi). Repository: rG LLVM Github Mo

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz updated this revision to Diff 458504. barcisz added a comment. removed duplication of '.cu' in the lit config for clang-tidy tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133436/new/ https://reviews.llvm.org/D133436 Files: clang-to

[clang] 9ea7e4f - [RISCV] Remove unnecessary word from error message.

Author: Craig Topper Date: 2022-09-07T10:31:48-07:00 New Revision: 9ea7e4f7c14267ada92aa6e04d7f460d2562bf19 URL: https://github.com/llvm/llvm-project/commit/9ea7e4f7c14267ada92aa6e04d7f460d2562bf19 DIFF: https://github.com/llvm/llvm-project/commit/9ea7e4f7c14267ada92aa6e04d7f460d2562bf19.diff

[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

barcisz added inline comments. Comment at: clang-tools-extra/clang-tidy/cuda/CudaTidyModule.cpp:25 + +// Register the GoogleTidyModule using this statically initialized variable. +static ClangTidyModuleRegistry::Add tschuett wrote: > Is Google a copy and paste er

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 458506. zahiraam marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contra

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. Thanks @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D133438: change SM target to 6.2, that's when fnative-half-type was introduced

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133438 Files: clang/test/CodeGenHLSL/builtins/sqrt.hls

[PATCH] D132918: [clang] Fix a crash in constant evaluation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132918/new/ https://reviews.llvm.org/D132918

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 458513. bob80905 added a comment. Shader Model target update Change the shader model target to 6.2, because that is when fnative-half-type was introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/n

[PATCH] D132918: [clang] Fix a crash in constant evaluation

shafik accepted this revision. shafik added a comment. LGTM, I spent some time debugging this and I don't see an obvious alternative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132918/new/ https://reviews.llvm.org/D132918 __

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D133440: [clangd] Allow programmatically disabling rename of virtual method hierarchies.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This featu

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

fmayer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25 + +using namespace llvm; + why don't we put this into the llvm namespace rather than using? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

aaron.ballman added a comment. In D132997#3763367 , @tbaeder wrote: > In D132997#3763094 , @shafik wrote: > >> I think like @aaron.ballman was saying in another PR you should aim for as >> complete set of tests a

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:29 + +namespace { + I believe you are going too far with the anonymous namespace. There is no need for static functions in anonymous namespaces. https://llvm.org/docs/

[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options

sammccall added a comment. I like the change to initialize() a lot. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:64 + +/// Options used for diagnostics. +ClangdDiagnosticOptions DiagOpts; I don't really like making these options part of this s

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. `CodeGenModule` doesn't get invoked when compiling IR. The error would trip when compiling other languages (eg c), but when passing IR to clang, the function doing error checking would never get called so no error was ever thrown. Repository: rG LLVM Github Mo

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:947-949 +Option `--search-config-dirs` changes the search algorith if the included +file is specified without a directory separator. In this case the file is looked +for in the same directories as config

[clang] cc14e19 - [RISCV] Remove space before colon in error message.

Author: Craig Topper Date: 2022-09-07T11:34:33-07:00 New Revision: cc14e195e79d0c1eca2190acffbddd53d0898317 URL: https://github.com/llvm/llvm-project/commit/cc14e195e79d0c1eca2190acffbddd53d0898317 DIFF: https://github.com/llvm/llvm-project/commit/cc14e195e79d0c1eca2190acffbddd53d0898317.diff

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

bd1976llvm added a comment. This approach doesn't account for the implementation of -fvisibility-global-new-delete-hidden. The following case now fails after this change: > type new_del.cpp namespace std { typedef __typeof__(sizeof(int)) size_t; struct nothrow_t {}; struct align_val_t {

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames created this revision. reames added reviewers: palmer-dabbelt, sunshaoce, craig.topper, kito-cheng, jrtc27, frasercrmck, asb, luismarques. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, Pkm

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, This doesn't really belong here, but a separate RISCVInstrInfo

[PATCH] D133444: [RISCV] Update error message to not call 'RV32' and 'RV64' an extension.

craig.topper created this revision. craig.topper added reviewers: reames, luismarques, asb, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinM

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, jrtc27 wrote: > This doesn't really belong here, but a separat

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 ___ cfe-commits mailing lis

[clang] c4842bb - [Clang] Introduce -fexperimental-sanitize-metadata=

Author: Marco Elver Date: 2022-09-07T21:25:40+02:00 New Revision: c4842bb2e98e2f1ee23bb3bc753752816927b7b3 URL: https://github.com/llvm/llvm-project/commit/c4842bb2e98e2f1ee23bb3bc753752816927b7b3 DIFF: https://github.com/llvm/llvm-project/commit/c4842bb2e98e2f1ee23bb3bc753752816927b7b3.diff L

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4842bb2e98e: [Clang] Introduce -fexperimental-sanitize-metadata= (authored by melver). Changed prior to commit: https://reviews.llvm.org/D130888?

  1   2   >