[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added a comment. Another thing we need consider here is this case: #pragma pack(push, 1) struct b64 { char a[64]; }; #pragma pack(pop) typedef b64 (fptrtype)(int a); b64 f(void* p, int a) { return ((fptrtype*)p)(a); } For now we

[PATCH] D132742: [X86][BF16] Add type mangling for Windows

FreddyYe accepted this revision. FreddyYe added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llvm.org/D132742 __

[clang] 279ba53 - [Fuchsia][CMake] Disable LLVM plugin support

Author: Petr Hosek Date: 2022-08-29T07:26:01Z New Revision: 279ba539a1dad609c8293b39a641d33814a2e2be URL: https://github.com/llvm/llvm-project/commit/279ba539a1dad609c8293b39a641d33814a2e2be DIFF: https://github.com/llvm/llvm-project/commit/279ba539a1dad609c8293b39a641d33814a2e2be.diff LOG: [F

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource updated this revision to Diff 456268. tomasz-kaminski-sonarsource added a comment. - Pass BldrCtx to handleConstructionContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 F

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:753 -SVal V = computeObjectUnderConstruction(E, State, LCtx, CC, CallOpts, Idx);

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-pointer-as-values.cpp:27-30 + for (const int *p_local1 : p_local0) { + // CHECK-MESSAGES: [[@LINE-1]]:8: warning: variable 'p_local1' of type 'const int *' can be de

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I don't have a test case handy for them since I'm n

[clang] a845d8f - [X86][BF16] Add type mangling for Windows

Author: Phoebe Wang Date: 2022-08-29T16:12:26+08:00 New Revision: a845d8fc57b6b09198bcb104f060925298034636 URL: https://github.com/llvm/llvm-project/commit/a845d8fc57b6b09198bcb104f060925298034636 DIFF: https://github.com/llvm/llvm-project/commit/a845d8fc57b6b09198bcb104f060925298034636.diff L

[PATCH] D132742: [X86][BF16] Add type mangling for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGa845d8fc57b6: [X86][BF16] Add type mangling for Windows (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llv

[PATCH] D132742: [X86][BF16] Add type mangling for Windows

pengfei added a comment. Thanks @FreddyYe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132742/new/ https://reviews.llvm.org/D132742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D132830: [clangd] Avoid crash when printing call to string literal operator template in hover

nridge created this revision. nridge added reviewers: hokein, kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-ext

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann. Herald added a subscriber: kristof.beyls. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is illegal in a constexpr context. We can alre

[PATCH] D132833: [clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Currently

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder updated this revision to Diff 456281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132832/new/ https://reviews.llvm.org/D132832 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 456282. dongjunduo marked 2 inline comments as done. dongjunduo added a comment. Restyle variables' name and comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D13146

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto &J : C.getJobs()) { Whitney wrote: > Do you mean Add or replace the modified `-ftime-trace=` to a

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG00d648bdb5a8: [clang] Make guard(nocf) attribute available only for Windows (authored by alvinhochun, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D132661?vs=455820&id=45628

[clang] 00d648b - [clang] Make guard(nocf) attribute available only for Windows

Author: Alvin Wong Date: 2022-08-29T11:30:44+03:00 New Revision: 00d648bdb5a8b71785269b4851b651c883de2cd9 URL: https://github.com/llvm/llvm-project/commit/00d648bdb5a8b71785269b4851b651c883de2cd9 DIFF: https://github.com/llvm/llvm-project/commit/00d648bdb5a8b71785269b4851b651c883de2cd9.diff LO

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

mstorsjo added a comment. Looks reasonable to me, but I'd appreciate input from people more familiar with adding new options to the GCC style driver about option naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llv

[clang] c04eab8 - [Flang] Use find_program() to find clang-tblgen

Author: Nikita Popov Date: 2022-08-29T11:09:25+02:00 New Revision: c04eab8c78e517210c7641551ec008b09bfe20d0 URL: https://github.com/llvm/llvm-project/commit/c04eab8c78e517210c7641551ec008b09bfe20d0 DIFF: https://github.com/llvm/llvm-project/commit/c04eab8c78e517210c7641551ec008b09bfe20d0.diff

[PATCH] D131475: [Flang] Use find_program() to find clang-tblgen

This revision was automatically updated to reflect the committed changes. Closed by commit rGc04eab8c78e5: [Flang] Use find_program() to find clang-tblgen (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] b5b7503 - [docs] improve documentation for misc-const-correctness

Author: Jonas Toth Date: 2022-08-29T11:20:47+02:00 New Revision: b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4 URL: https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4 DIFF: https://github.com/llvm/llvm-project/commit/b5b750346346bfe95c7c6b1cceacc6cfccc8f4f4.diff LO

[PATCH] D132244: [docs] improve documentation for misc-const-correctness

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b750346346: [docs] improve documentation for misc-const-correctness (authored by JonasToth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132244/new/ htt

[PATCH] D132830: [clangd] Avoid crash when printing call to string literal operator template in hover

kadircet added a comment. can you move the test into `llvm/llvm-project/clang/unittests/AST/StmtPrinterTest.cpp` ? while there, also a test on pack-extended user defined literals would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132830/

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal accepted this revision. aaronmondal added a comment. Thanks for addressing my comment. I think I overlooked the part about `-fmodules-embed-all-files` 😅 I'm fine with this revision 😊 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388

[clang] efc76a1 - [analyzer] Silence GCC warnings about unused variables. NFC.

Author: Martin Storsjö Date: 2022-08-29T13:26:13+03:00 New Revision: efc76a1ac5f910776091a48947ca1e90e9068845 URL: https://github.com/llvm/llvm-project/commit/efc76a1ac5f910776091a48947ca1e90e9068845 DIFF: https://github.com/llvm/llvm-project/commit/efc76a1ac5f910776091a48947ca1e90e9068845.diff

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

lewis-revill added a comment. Herald added subscribers: sunshaoce, pcwang-thead, VincentWu, luke957, StephenFan, arichardson. Herald added a project: All. I believe this patch is still relevant/necessary when using LTO for RISCV, so can I ask if @khchen is able to update it to rebase/address the

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

lewis-revill created this revision. lewis-revill added reviewers: efriedma, lenary, jrtc27, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, ormris, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, simoncook, s.egerton, Jim, benna, psnobl, jocewei, PkmX, t

[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

nikic added a comment. In D129833#3727881 , @ChuanqiXu wrote: > And I am working on adding Align properties. But I meet problems since the > alignment of threadlocal_address intrinsic depends on its argument so we > can't set the alignment for its decla

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:202 FR.endLine = End.line; +FR.startCharacter = Start.character; FR.endCharacter = End.character; can you put it back to its previous location (i.e. right aft

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 456305. wyt marked 5 inline comments as done. wyt added a comment. Address comments: add const qualifiers where applicable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 456307. wyt marked an inline comment as done. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files: clang/unit

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:88 +/// Arguments for building the dataflow analysis. +template struct AnalysisInputs { + /// Input code that is analyzed. sgatev wrote: > Why move this? It makes it

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt updated this revision to Diff 456308. wyt marked 6 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132763/new/ https://reviews.llvm.org/D132763 Files: clang/unittests/Analysis/Flo

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:363-365 +std::sort(AnnotationStatesAsVector.begin(), + AnnotationStatesAsVector.end(), + [](auto a, auto b) { return a.first < b.first; }); ---

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

wyt updated this revision to Diff 456311. wyt marked an inline comment as done. wyt added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132745/new/ https://reviews.llvm.org/D132745 Files: clang/lib/Basic/SanitizerSpec

[PATCH] D131475: [Flang] Use find_program() to find clang-tblgen

awarzynski added a comment. Thanks for the quick fix, makes sense! 👍🏻 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131475/new/ https://reviews.llvm.org/D131475 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the new attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://re

[clang] 123062e - Expose QualType::getUnqualifiedType in libclang

Author: Luca Di Sera Date: 2022-08-29T08:16:18-04:00 New Revision: 123062ec2f3e45bb1614a63bcb79c22527d9b914 URL: https://github.com/llvm/llvm-project/commit/123062ec2f3e45bb1614a63bcb79c22527d9b914 DIFF: https://github.com/llvm/llvm-project/commit/123062ec2f3e45bb1614a63bcb79c22527d9b914.diff

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG123062ec2f3e: Expose QualType::getUnqualifiedType in libclang (authored by diseraluca, committed by aaron.ballman). Repository: rG LLVM Github Mon

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

wyt updated this revision to Diff 456317. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132756/new/ https://reviews.llvm.org/D132756 Files: clang/unittests/Analysis/Flo

[PATCH] D132791: Fix formatting in release notes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I did not test building the docs, but the changes all look correct based on my experience with RST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/ https://review

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:302 +AnnotationStates.insert({It->second, StateT{*Lattice, State.Env}}); +assert(InsertSuccess); }; Please add

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a comment. In D131479#3753586 , @Mordante wrote: > In D131479#3753533 , @aaron.ballman > wrote: > >> In D131479#3753462 , @Mordante >> wrote: >> >>>

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

mstorsjo created this revision. mstorsjo added a reviewer: aaron.ballman. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. We shouldn't just check the clang options, we also should check `Triple::hasDefaultEmulatedTLS()`. This doesn't make an

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456321. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tool

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt updated this revision to Diff 456323. wyt marked an inline comment as done. wyt added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132763/new/ https://reviews.llvm.org/D132763 Files: clang/unittests/Analysis/Flow

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +} -

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

erichkeane added a comment. just a pair of minor changes I'd like to see, otherwise this LGTM. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getPa

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:254 +// Remove the ending sentinal "*/" from the block comment range. +if (Code.substr(EndOffset(*LastComment) - 2, 2) == "*/") { + End.character -= 2; this is

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

uabelho added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. pin~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131979/new/ https://reviews.llvm.org/D131979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I assume we're going to see more patches in the future in this space as you discover examples/tests for this, but in order to unblock other tests, this is good enough for now. Reposi

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

nikic added a comment. Okay, this is a bit tricky because we have three different things: 1. The noread_thread_id attribute, the lack of which was causing issues with intrinsics in the previous version 2. The meaning of the readnone (etc) attributes, which for pragmatic reasons has to exclude t

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245 + +if (!Init) + return false; Would be nice to test this before the work to allocate Offset? Comment at: clang/lib/AST/Interp/Function.h:163 +

[clang] b345be1 - Make this test slightly less fragile; NFC

Author: Aaron Ballman Date: 2022-08-29T09:41:23-04:00 New Revision: b345be177d03166add391f090fd0288a23413934 URL: https://github.com/llvm/llvm-project/commit/b345be177d03166add391f090fd0288a23413934 DIFF: https://github.com/llvm/llvm-project/commit/b345be177d03166add391f090fd0288a23413934.diff

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

JonasToth added a comment. just my 2 cents Comment at: clang-tools-extra/clang-tidy/readability/UseEarlyExitsCheck.cpp:66 + if (needsParensAfterUnaryNegation(Condition)) { +Diag << FixItHint::CreateInsertion(Condition->getBeginLoc(), "!(") + << FixItHint::CreateIns

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","resu

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:245 + +if (!Init) + return false; erichkeane wrote: > Would be nice to test this before the work to allocate Offset? Ah, sure. Good catch. CHANGES SINCE LAST ACTION h

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

tbaeder updated this revision to Diff 456328. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132832/new/ https://reviews.llvm.org/D132832 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

dodohand added a comment. IMO you have just introduced a bug, not fixed one. A lambda expression in an if statement condition clause is exactly the kind of thing that this checker was designed to flag. The BARR group coding guideline, with which this is intended to comply in spirit, makes no exc

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. I feel like Phabricator is not sending notifications for this patch like it usually does (I'm not getting any emails). I'll create a new, identical patch tomorrow if there's still no activity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

Eugene.Zelenko added a comment. I got notification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman created this revision. aaron.ballman added reviewers: ShawnZhong, thakis, clang-language-wg, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. https://reviews.llvm.org/D131255 (82afc9b169a67e8b8a1862fb9c41a2cd974

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. In D131255#3729304 , @aaron.ballman wrote: > After some more thought and some offline discussions, I think I have a > reasonable way forward: let's add `-Wsingle-bit-bitfield-constant-conversion` > as a new warning group

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. In D131939#3755399 , @Eugene.Zelenko wrote: > I got notification. Thank you. I got an email for this message but not my own updates, which usually also CC me 🤷. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456335. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-to

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane added a comment. LGTM, questioning whether we want to do some macro introspection in C mode (as the CORRECT way to use these 1 bit-bitfields is as a bool), but at least this gives the person the ability to disable this warning. Comment at: clang/test/Sema/constant-

[PATCH] D123630: [WIP] Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 456337. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c clang/test/Driver/fp-contract

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/test/Parser/cxx-concept-declaration.cpp:3 // Support parsing of concepts // Disabled for now. I guess we can drop these two lines now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456343. aaron.ballman added a comment. Added a test case for `true` in C++, and added similar logic for C to reduce the chance for false positives. If the user uses `true` (the macro from stdbool.h), they're signaling an intent that the field is used i

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

serge-sans-paille created this revision. serge-sans-paille added reviewers: sberg, kees. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D132786: [clang-tidy] Fix a false positive in bugprone-assignment-in-if-condition

njames93 added a comment. In D132786#3755390 , @dodohand wrote: > IMO you have just introduced a bug, not fixed one. > A lambda expression in an if statement condition clause is exactly the kind > of thing that this checker was designed to flag. > The BA

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I like the direction this is going; I ran into some questions on the tests about whether we should use a range or not and other small things, but I think this is getting close. Comment at: clang/test/CXX/temp/temp.res/temp.local/p3.cpp:2 +// RUN

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 __

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added a comment. Precommit CI found a relevant failure: FAIL: Clang :: AST/Interp/arrays.cpp (67 of 15858) TEST 'Clang :: AST/Interp/arrays.cpp' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w5\llvm-project\premerge-checks\build\

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

aaron.ballman added a comment. > I don't have a test case handy for them since I'm not sure how to trigger > them reliably, but they are easy enough to implement and I ran into them > while working on array fillers. I think we should have test coverage for this if possible. https://godbolt.org

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< Is "concept templ

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto &J : C.getJobs()) { dongjunduo wrote: > Whitney wrote: > > Do you mean Add or replace the modified `

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

tbaeder added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:779 + "|refers to a variable template||refers to a concept|" + "refers to a concept template}1">; def err_id_after_template_in_nested_name_spec : Error< cjdb wrote: >

[clang] d346eb7 - [clang] Fix ambiguous use of `report_fatal_error`.

Author: Wei Yi Tee Date: 2022-08-29T15:32:49Z New Revision: d346eb7bf08c7780bb80426eabc6b5f81490e9ae URL: https://github.com/llvm/llvm-project/commit/d346eb7bf08c7780bb80426eabc6b5f81490e9ae DIFF: https://github.com/llvm/llvm-project/commit/d346eb7bf08c7780bb80426eabc6b5f81490e9ae.diff LOG: [c

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd346eb7bf08c: [clang] Fix ambiguous use of `report_fatal_error`. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132745/new/ https://review

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits, otherwise LGTM. Comment at: clang/lib/Sema/SemaChecking.cpp:13080 - S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) -<< PrettyValue <<

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132831/new/ https://reviews.llvm.org/D132831 _

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132832/new/ https://reviews.llvm.org/D132832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske added a reviewer: martong. balazske added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:537 + errno_modeling::getNoteTagForStdSuccess( + C, cast(Call.getDecl())-

[PATCH] D127973: [analyzer] Eval construction of non POD type arrays.

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:493 + if (auto DS = dyn_cast_or_null(Item.getStmtOrNull())) { +if (auto VD = dyn_cast_or_null(DS->getSingleDecl())) + E = dyn_cast(VD->getInit()); Hmm, when we are

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} Is there nothing special that has to happen when these are reference parameter

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

ivanrodriguez3753 added a comment. In D131639#3749633 , @jhuber6 wrote: > I think it's perfectly reasonable to include system files as part of a > toolchain. I think it comes down to a matter of inconveniencing the user versus the developer. We usually

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456366. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132851/new/ https://reviews.llvm.org/D132851 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGrou

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3753290 , @tbaeder wrote: > In D132136#3751702 , @erichkeane > wrote: > >> Would be great if we had a better test here... is there anything we can do >> to validate this

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

erichkeane accepted this revision. erichkeane added a comment. Still LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132851/new/ https://reviews.llvm.org/D132851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} erichkeane wrote: > Is there nothing special that has to happen when these are ref

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman added a comment. Please be sure to add a release note for the fix as well. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:776-779 "identifier followed by '<' indicates a class template specialization but " "%0 %select{does not refer to a templ

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder updated this revision to Diff 456376. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

tbaeder added a comment. In D132727#3755571 , @aaron.ballman wrote: > Precommit CI found a relevant failure: That needs the lvalue-to-rvalue conversion patch first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llv

  1   2   3   >