wyt added inline comments.
================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:88
+/// Arguments for building the dataflow analysis.
+template <typename AnalysisT> struct AnalysisInputs {
+ /// Input code that is analyzed.
----------------
sgatev wrote:
> Why move this? It makes it hard to tell if there are other changes. If there
> are other changes, let's keep it where it is to have a clean diff and move it
> in a separate commit.
It was moved as the new parameter declared uses `AnalysisOutputs`, hence
`AnalysisOutputs` needs to come before `AnalysisInputs`. The move is now fixed
by reordering these two struct declarations in the parent patch where they were
first introduced.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132377/new/
https://reviews.llvm.org/D132377
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
