[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. I'm a little worried about the shift to emit an unconditional error on `volatile`. Can we at least separate that into its own patch and just fix the bug in this one? And please try to reach out whoever originally added this feature to see if that restriction is okay

[clang] 21dfe48 - [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

Author: Shafik Yaghmour Date: 2022-08-26T09:40:43-07:00 New Revision: 21dfe482e13e3b64801372f8b3db75eeb85b3135 URL: https://github.com/llvm/llvm-project/commit/21dfe482e13e3b64801372f8b3db75eeb85b3135 DIFF: https://github.com/llvm/llvm-project/commit/21dfe482e13e3b64801372f8b3db75eeb85b3135.dif

[PATCH] D132712: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an unconditional cast to TagType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21dfe482e13e: [Clang] Fix assert in Sema::LookupTemplateName so that it does not attempt an… (authored by shafik). Herald added a project: clang. Re

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3751471 , @joanahalili wrote: > We have some compilation failures on our end because of function template > parameter deduction when passing the function template to a function pointer. > > typedef void (*f)(const int

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

paulkirth added a comment. In D132186#3751985 , @tejohnson wrote: > I have seen a few cases where noinline was used for performance, in addition > to other cases like avoiding too much stack growth. Well, I stand corrected. I'm curious about what these

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

yihanaa added a comment. In D131979#3752131 , @rjmccall wrote: > I'm a little worried about the shift to emit an unconditional error on > `volatile`. Can we at least separate that into its own patch and just fix > the bug in this one? And please try t

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The method is now wrapped by `clang_g

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:753 -SVal V = computeObjectUnderConstruction(E, State, LCtx, CC, CallOpts, Idx); +SVal V = computeObjectUnderConstruction(E, State, currBldrCtx, LCtx, CC, +

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. From the test case, it looks like the builtin just ignores pointer to volatile, which should be preserved by the conversions you're now doing in Sema. That is, you should be able to just check `Ptr->getType()->castAs()->isVolatile()`. Repository: rG LLVM Github Mo

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

NoQ added a comment. > So, what you are suggesting here is an alternative solution to the one you > already proposed in your last comment? I was just expanding the initial suggestion but also symbol reaper is too complicated for me to make such suggestions confidently. So I'm just sharing some

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca added a comment. I recently encountered a few cases, at work, as an employee of The Qt Company, where we would have liked to have access to `getUnqualifiedType` in libclang. I found a precedence on the old mailing list, from 2018 (https://lists.llvm.org/pipermail/cfe-dev/2018-Februar

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 455954. python3kgae added a comment. Fix build error and merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRuntime.

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455955. abrahamcd marked 10 inline comments as done. abrahamcd added a comment. Resolved pending comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files:

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:58 + + if (Loc.isValid()) +Result = addLocationToResult(Result, Loc, PLoc, Ranges, *Diag); denik wrote: > abrahamcd wrote: > > denik wrote: > > > I think we should add a test

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

steakhal planned changes to this revision. steakhal added a comment. In D132236#3752209 , @NoQ wrote: >> So, what you are suggesting here is an alternative solution to the one you >> already proposed in your last comment? > > I was just expanding the ini

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

rnk accepted this revision. rnk added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132661/new/ https://reviews.llvm.org/D132661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455964. abrahamcd added a comment. Deleted copy and move for Printer and added asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rG93e5cf6b9c08: [clang] Do not instrument relative vtables under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ h

[clang] 93e5cf6 - [clang] Do not instrument relative vtables under hwasan

Author: Leonard Chan Date: 2022-08-26T18:21:40Z New Revision: 93e5cf6b9c08d99cf7cefc0adda346bd7ba56049 URL: https://github.com/llvm/llvm-project/commit/93e5cf6b9c08d99cf7cefc0adda346bd7ba56049 DIFF: https://github.com/llvm/llvm-project/commit/93e5cf6b9c08d99cf7cefc0adda346bd7ba56049.diff LOG:

[clang] cdb30f7 - [clang] Do not instrument the rtti_proxies under hwasan

Author: Leonard Chan Date: 2022-08-26T18:22:17Z New Revision: cdb30f7a26354b000310ebe30a6874f7737675ed URL: https://github.com/llvm/llvm-project/commit/cdb30f7a26354b000310ebe30a6874f7737675ed DIFF: https://github.com/llvm/llvm-project/commit/cdb30f7a26354b000310ebe30a6874f7737675ed.diff LOG:

[PATCH] D132691: [clang] Do not instrument the rtti_proxies under hwasan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdb30f7a2635: [clang] Do not instrument the rtti_proxies under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455968. abrahamcd added a comment. Reset SARIFDiag during EndSourceFile(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SAR

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

modimo added a comment. Thanks for taking a look! In D132186#3752150 , @paulkirth wrote: > In D132186#3751985 , @tejohnson > wrote: > >> I have seen a few cases where noinline was used for performance, in additi

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82e893c47c77: [clang] Enable output of SARIF diagnostics (authored by abrahamcd, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES

[clang] 82e893c - [clang] Enable output of SARIF diagnostics

Author: Abraham Corea Diaz Date: 2022-08-26T18:49:29Z New Revision: 82e893c47c77430ca59f92d7a814a336e3873a35 URL: https://github.com/llvm/llvm-project/commit/82e893c47c77430ca59f92d7a814a336e3873a35 DIFF: https://github.com/llvm/llvm-project/commit/82e893c47c77430ca59f92d7a814a336e3873a35.diff

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D132749#3752233 , @diseraluca wrote: > I found a precedence on the old mailing list, from 2018 > (https://lists.llvm.org/pipermail/c

[PATCH] D132672: [Docs] [HLSL] Documenting HLSL Entry Functions

beanz updated this revision to Diff 455985. beanz added a comment. Updating based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132672/new/ https://reviews.llvm.org/D132672 Files: clang/docs/HLSL/EntryFunctions.rst clang/docs/HLSL

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 455975. jpenix-quic added a comment. Fixed up/simplified environment-default-list.h for C/C++ compatibility. Also cleaned up a declaration and a few autos in the lowering component. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/n

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. This caused: In file included from ../../clang/lib/Driver/ToolChains/Cuda.cpp:9: ../../clang/lib/Driver/ToolChains/Cuda.h:193:29: warning: private field 'OK' is not used [-Wunused-private-field] const Action::OffloadKind OK; ^ Repos

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

jhuber6 added a comment. In D130020#3752458 , @thakis wrote: > This caused: > > In file included from ../../clang/lib/Driver/ToolChains/Cuda.cpp:9: > ../../clang/lib/Driver/ToolChains/Cuda.h:193:29: warning: private field > 'OK' is not used [-Wunused

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. ps: Thank you to everyone who's been working on having fewer offload wrapper binaries! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. Glad to see that refactoring the sanitizer metadata made someone's life easier ;) (now allowing for disabling hwasanificiation of globals) Patch looks reasonable to me. Can you please add the negative test (that vtables under the vanilla ABI still have hwasan)? I wans't

[clang] a5e354e - [analyzer] Fixing a bug raising false positives of stack block object

Author: ziqingluo-90 Date: 2022-08-26T12:19:32-07:00 New Revision: a5e354ec4da14cfc02b9847be314524e8deb93c6 URL: https://github.com/llvm/llvm-project/commit/a5e354ec4da14cfc02b9847be314524e8deb93c6 DIFF: https://github.com/llvm/llvm-project/commit/a5e354ec4da14cfc02b9847be314524e8deb93c6.diff

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e354ec4da1: [analyzer] Fixing a bug raising false positives of stack block object (authored by ziqingluo-90). Changed prior to commit: https://reviews.llvm.org/D131009?vs=453144&id=455992#toc Reposit

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: kristof.beyls. Herald added a project: All. thakis requested review of this revision. Xcode 13's clang has them. For the included testcase, Xcode's clang behaves like the implementation in this patch. Availabi

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis added a comment. Another patch to make open-source clang more like Xcode's clang, needed to parse system headers. https://github.com/nico/hack/blob/main/notes/catalyst.md has some background information on catalyst triples and zippered code. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added inline comments. Comment at: flang/runtime/environment-default-list.h:1 +//===-- Runtime/environment-default-list.h ===// +// klausler wrote: > If you want this header to be maximally portable C and C++, please o

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1713 // FIXME: This is inconsistent; we usually suggest detecting // builtin macros via #ifdef. Don't add more cases here. .Case("__is_target_arch", true) ---

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132756 Files: clan

[PATCH] D132398: Allow constant static members to be used with 'this'

aaron.ballman added reviewers: aaron.ballman, clang-language-wg. aaron.ballman added a comment. Thanks for this! Can you add some more details to the patch description so it's more clear from there why the patch is necessary? Also, can you add a release note for the fix? I'm pretty sure the cha

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

thakis added a comment. This adds warnings: [498/568] CXX obj/clang/lib/Frontend/Frontend.SARIFDiagnostic.o ../../clang/lib/Frontend/SARIFDiagnostic.cpp:74:25: warning: unused variable 'Filename' [-Wunused-variable] llvm::StringRef Filename = ^ In file i

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3751702 , @erichkeane wrote: > Would be great if we had a better test here... is there anything we can do to > validate this is happening other than checking for that one note? +1 to this request, but the chang

[PATCH] D132398: Allow constant static members to be used with 'this'

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8458 + Info.AccessingStaticConstantDataMember); + if(Info.InConstantContext) +Info.AccessingStaticConstantDataMember = true; When not in a constant-context, what sh

[clang] 5eab94f - Eliminate unused-variable warning.

Author: Sterling Augustine Date: 2022-08-26T12:40:55-07:00 New Revision: 5eab94f7eb20c2f5d3123e7401892a1a6a133e38 URL: https://github.com/llvm/llvm-project/commit/5eab94f7eb20c2f5d3123e7401892a1a6a133e38 DIFF: https://github.com/llvm/llvm-project/commit/5eab94f7eb20c2f5d3123e7401892a1a6a133e38.

[clang] f886f7e - Remove unused private variable.

Author: Sterling Augustine Date: 2022-08-26T12:43:05-07:00 New Revision: f886f7e8ef7aa4f54298db792a656373af90440c URL: https://github.com/llvm/llvm-project/commit/f886f7e8ef7aa4f54298db792a656373af90440c DIFF: https://github.com/llvm/llvm-project/commit/f886f7e8ef7aa4f54298db792a656373af90440c.

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132754/new/ https://reviews.llvm.org/D132754 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9343ec861a2e: [clang-tidy] Adding the missing handling of "noreturn" attributes for Obj-C… (authored by ziqingluo-90). Re

[clang-tools-extra] 9343ec8 - [clang-tidy] Adding the missing handling of "noreturn" attributes for Obj-C nodes in `InfiniteLoopChecker`

Author: ziqingluo-90 Date: 2022-08-26T12:44:59-07:00 New Revision: 9343ec861a2e47f05b3b4339f45f6e755b1c5f96 URL: https://github.com/llvm/llvm-project/commit/9343ec861a2e47f05b3b4339f45f6e755b1c5f96 DIFF: https://github.com/llvm/llvm-project/commit/9343ec861a2e47f05b3b4339f45f6e755b1c5f96.diff

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132739/new/ https://reviews.llvm.org/D132739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3752148 , @ychen wrote: > In D128745#3751471 , @joanahalili > wrote: > >> We have some compilation failures on our end because of function template >> parameter deduction when p

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3752593 , @ychen wrote: > In D128745#3752148 , @ychen wrote: > >> In D128745#3751471 , @joanahalili >> wrote: >> >>> We have some compil

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[clang] 937aaea - [CUDA] Fix arguments after removing unused private variable

Author: Joseph Huber Date: 2022-08-26T15:28:34-05:00 New Revision: 937aaead87f055caa4d91d7ba637d442a94a24a6 URL: https://github.com/llvm/llvm-project/commit/937aaead87f055caa4d91d7ba637d442a94a24a6 DIFF: https://github.com/llvm/llvm-project/commit/937aaead87f055caa4d91d7ba637d442a94a24a6.diff

[clang] 0e5813b - [clang][NFC] silences warnings

Author: Abraham Corea Diaz Date: 2022-08-26T21:09:39Z New Revision: 0e5813b88e50576940070003e093d696390a6959 URL: https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959 DIFF: https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959.diff

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. reduced: define void @a() { entry: %call = call float @strtof(ptr noundef null, ptr noundef null) ret void } define internal float @strtof(ptr noundef %0, ptr noundef %1) nounwind { entry: ret float 0.0 } `./build/rel/bin/opt -passes='inline,a

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes `throw` more similar to `return`. Ho

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 456029. wyt marked 4 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147 Files: clang/unittests/Analysis/Flo

[PATCH] D132377: [clang][dataflow] Add `SetupTest` parameter for `AnalysisInputs`.

wyt updated this revision to Diff 456030. wyt added a comment. Propagate change from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132377/new/ https://reviews.llvm.org/D132377 Files: clang/unittests/Analysis/FlowSensitive/TestingSu

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

wyt created this revision. Herald added subscribers: martong, mgrang, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D132377 Repository: rG LLVM

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

wyt updated this revision to Diff 456032. wyt added a comment. Fix typo and indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132147/new/ https://reviews.llvm.org/D132147 Files: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. sent out https://reviews.llvm.org/D132764 to fix the CGSCC crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://reviews.llvm.org/D128830 ___ cfe-commits maili

[PATCH] D132711: [HLSL] add sqrt library function

pow2clk added a comment. A very minor suggestion. This looks pretty straightforward. Comment at: clang/test/CodeGenHLSL/builtins/sqrt.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -o - | FileCheck %s --check-prefix=NO_HALF + --

[clang] 396f40a - [clang] Add __is_target_variant_{os, environment} builtins

Author: Nico Weber Date: 2022-08-26T18:20:06-04:00 New Revision: 396f40a79fc98184fb40967db788896263b3b2fa URL: https://github.com/llvm/llvm-project/commit/396f40a79fc98184fb40967db788896263b3b2fa DIFF: https://github.com/llvm/llvm-project/commit/396f40a79fc98184fb40967db788896263b3b2fa.diff LO

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG396f40a79fc9: [clang] Add __is_target_variant_{os,environment} builtins (authored by thakis). Herald added a project: clang. Repository: rG LLVM G

[clang] 4b815eb - [clang][dataflow] Extend transfer functions for other `CFGElement`s

Author: Wei Yi Tee Date: 2022-08-26T22:21:29Z New Revision: 4b815eb4fde0202434c6395973578349767b3f15 URL: https://github.com/llvm/llvm-project/commit/4b815eb4fde0202434c6395973578349767b3f15 DIFF: https://github.com/llvm/llvm-project/commit/4b815eb4fde0202434c6395973578349767b3f15.diff LOG: [c

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b815eb4fde0: [clang][dataflow] Extend transfer functions for other `CFGElement`s (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131614/new

[PATCH] D132745: [clang] Fix ambiguous use of `report_fatal_error`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/SanitizerSpecialCaseList.cpp:36 return SSCL; - llvm::report_fatal_error(Error); + llvm::report_fatal_error(llvm::StringRef(Erro

[clang] e877b42 - [clang] Better warning-fix follow-up to D131632

Author: Nico Weber Date: 2022-08-26T18:29:20-04:00 New Revision: e877b42e2c70813352c1963ea33e992f481d5cba URL: https://github.com/llvm/llvm-project/commit/e877b42e2c70813352c1963ea33e992f481d5cba DIFF: https://github.com/llvm/llvm-project/commit/e877b42e2c70813352c1963ea33e992f481d5cba.diff LO

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

thakis added a comment. I don't know how you commited this, but the commit message is missing all the (great!) details that are here on the review. See here: https://github.com/llvm/llvm-project/commit/4b815eb4fde0202434c6 or here: https://reviews.llvm.org/rG4b815eb4fde0202434c63 Please update

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt added a comment. @thakis Thanks for pointing that out, will revert and recommit - since it also ran into some build failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131614/new/ https://reviews.llvm.org/D131614

[clang] fb9c1b8 - Revert "[clang][dataflow] Extend transfer functions for other `CFGElement`s"

Author: Wei Yi Tee Date: 2022-08-26T22:41:20Z New Revision: fb9c1b8938fdc37705aa2e71688c4a061cfb2cd5 URL: https://github.com/llvm/llvm-project/commit/fb9c1b8938fdc37705aa2e71688c4a061cfb2cd5 DIFF: https://github.com/llvm/llvm-project/commit/fb9c1b8938fdc37705aa2e71688c4a061cfb2cd5.diff LOG: Re

[PATCH] D132147: [clang][dataflow] Refactor `TestingSupport.h`

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:117 +llvm::DenseMap +getAnnotationLinesAndContent(AnalysisOutputs &AO); + (if possible) Comment at: clang/unittests/Analysis/FlowSensitive/Tes

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 456046. python3kgae added a comment. Fix build error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h

[PATCH] D132763: [clang][dataflow] Use `StringMap` for storing analysis states at annotated points instead of `vector>`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.cpp:124 + } + Result[Stmt] = Annotation; + Commen

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

wyt updated this revision to Diff 456049. wyt added a comment. Mark override for virtual transfer function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131614/new/ https://reviews.llvm.org/D131614 Files: clang/include/clang/Analysis/FlowSensit

[clang] dc32ed8 - [Clang][Driver] Refine/refactor DriverKit support

Author: Julian Lettner Date: 2022-08-26T16:06:24-07:00 New Revision: dc32ed8a8e226db3677abb19eda62cfe80572aed URL: https://github.com/llvm/llvm-project/commit/dc32ed8a8e226db3677abb19eda62cfe80572aed DIFF: https://github.com/llvm/llvm-project/commit/dc32ed8a8e226db3677abb19eda62cfe80572aed.diff

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

paulkirth added a comment. In D132186#3752403 , @modimo wrote: > Same. The instances I've seen is an older codebase where compiler > optimizations were not as powerful and/or purposefully written by engineers > that didn't trust the compiler to do the r

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:68 +const Environment &getEnvironmentAtAnnotation( +llvm::StringMap> &AnnotationStates, +

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3752468 , @hctim wrote: > Glad to see that refactoring the sanitizer metadata made someone's life > easier ;) (now allowing for disabling hwasanificiation of globals) > > Patch looks reasonable to me. Can you pleas

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

shafik added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:90 + template static Boolean from(T Value) { +if constexpr (std::is_integral::value) + return Boolean(Value != 0); This should work for `floating_point` as well. ===

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

hctim added a comment. In D132425#3753065 , @leonardchan wrote: > We have a generic long term solution for hwasan+RV which I think might also > be applicable for MTE+RV. For hwasan, since it's mainly the IR pass that > converts usages of the vtable (wi

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 456069. ychen added a comment. - change from `FunctionLike` to `Function` - add a Sema test - update doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files: clang/

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen added a comment. In D132592#3751561 , @aaron.ballman wrote: > In D132592#3749567 , @ychen wrote: > >> Thanks for taking a look! >> >> In D132592#3749261 , >> @aaro

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3751477 , @mizvekov wrote: > In D128113#3747946 , @alexfh wrote: > >> For now we've added a workaround for the most problematic use case and got >> us unblocked. Thus there is n

[clang] 5284cf0 - [Clang][Driver] Temporarily disable failing DriverKit test

Author: Julian Lettner Date: 2022-08-26T18:32:51-07:00 New Revision: 5284cf0098c150137983d9e6326fc1ac014428a6 URL: https://github.com/llvm/llvm-project/commit/5284cf0098c150137983d9e6326fc1ac014428a6 DIFF: https://github.com/llvm/llvm-project/commit/5284cf0098c150137983d9e6326fc1ac014428a6.diff

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith created this revision. rsmith added reviewers: Bigcheese, aaron.ballman. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the documentation, these restrictions were intended to apply to textual

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 456077. rsmith added a comment. Add release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Lan

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. $ cat fconvert_option_main_2.f90 ! ! Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. ! See https://llvm.org/LICENSE.txt for license information. ! SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception ! ! checking for I/O: tes

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

NoQ added a comment. > For FPs I dont know how to automate this process. :/ Given that our initial hypothesis was that there should be zero new false positives, it could probably work with a creduce predicate //"this code has a warning after the patch but not before the patch"//. The initial hy

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Boolean.h:90 + template static Boolean from(T Value) { +if constexpr (std::is_integral::value) + return Boolean(Value != 0); shafik wrote: > This

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. In D132136#3751702 , @erichkeane wrote: > Would be great if we had a better test here... is there anything we can do to > validate this is happening other than checking for that one note? `EvaluateAsRValue` is called from `Expr

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

dyung added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

dyung added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":[{"

<    1   2